norma43_parser 1.0.1 → 2.0.0

data/lib/norma43/utils/typecaster.rb

@@ -1,19 +1,23 @@
+# frozen_string_literal: true
+
 require "time"
 
 module Norma43
-  module Typecaster
-    def self.cast value, type
-      casters.fetch(type).call(value) unless value == ""
-    end
+  module Utils
+    module Typecaster
+      def self.cast(value, type)
+        casters.fetch(type).call(value) unless value == ""
+      end
 
-    def self.casters
-      {
-        integer: ->(value) { value.to_i },
-        time: ->(value) { Time.strptime(value, "%Y%m%d%H%M%S%N") },
-        date: ->(value) { Date.strptime(value, "%y%m%d") },
-        string: ->(value) { value unless value.match(/\A0+\Z/) },
-        raw: ->(value) { value }
-      }
+      def self.casters
+        {
+          integer: ->(value) { value.to_i },
+          time: ->(value) { Time.strptime(value, "%Y%m%d%H%M%S%N") },
+          date: ->(value) { Date.strptime(value, "%y%m%d") },
+          string: ->(value) { value unless value.match?(/\A0+\Z/) },
+          raw: ->(value) { value }
+        }
+      end
     end
   end
 end

data/lib/norma43/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Norma43
-  VERSION = "1.0.1"
+  VERSION = "2.0.0"
 end

data/norma43_parser.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "norma43/version"
 
@@ -8,20 +9,21 @@ Gem::Specification.new do |spec|
   spec.version       = Norma43::VERSION
   spec.authors       = ["Sequra engineering"]
   spec.email         = ["dev@sequra.es"]
-  spec.summary       = %q{Parses banks transactions files specified in rule 43}
+  spec.summary       = "Parses banks transactions files specified in rule 43"
   spec.homepage      = "https://github.com/sequra/norma43_parser"
   spec.license       = "MIT"
 
-  spec.required_ruby_version = "~> 2.0"
+  spec.required_ruby_version = "~> 2.4"
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "byebug"
-  spec.add_development_dependency "rspec"
-  spec.add_runtime_dependency "virtus"
+  spec.add_runtime_dependency "virtus",   "~> 1.0"
+  spec.add_runtime_dependency "zeitwerk", "~> 2.0"
+
+  spec.add_development_dependency "bundler", "~> 1.0"
+  spec.add_development_dependency "rake",    "~> 10.0"
+  spec.add_development_dependency "rspec",   "~> 3.0"
 end

data/spec/example1_parse_spec.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 require "norma43"
 
 RSpec.describe Norma43 do
   describe "parse" do
-
     let(:document) do
-      file = File.open( File.join(__dir__, "fixtures/example1.n43"),
+      file = File.open(File.join(__dir__, "fixtures/example1.n43"),
                         encoding: "iso-8859-1")
       Norma43.parse file
     end
@@ -17,7 +18,7 @@ RSpec.describe Norma43 do
       let(:account) { document.accounts.first }
 
       it "stores expected attributes from AccountStart parser" do
-        expect(account).to have_attributes({
+        expect(account).to have_attributes(
           "bank_code"             => 9999,
           "branch_code"           => 1111,
           "account_number"        => 123456789,
@@ -26,18 +27,18 @@ RSpec.describe Norma43 do
           "currency_code"         => 1,
           "information_mode_code" => 3,
           "abbreviated_name"      => "MY ACCOUNT"
-        })
+        )
       end
 
       it "stores expected attributes from AccountEnd parser" do
-        expect(account).to have_attributes({
+        expect(account).to have_attributes(
           "balance_code"   => 2,
           "balance_amount" => 78889999999999,
           "debit_entries"  => 4,
           "debit_amount"   => 4936,
           "credit_entries" => 2,
           "credit_amount"  => 999999,
-        })
+        )
       end
 
       describe "transactions" do
@@ -48,7 +49,7 @@ RSpec.describe Norma43 do
         describe "first transaction" do
           let(:transaction) { account.transactions[0] }
           it "stores expected attributes" do
-            expect(transaction).to have_attributes({
+            expect(transaction).to have_attributes(
               "origin_branch_code" => 6700,
               "transaction_date"   => Date.parse("2004-04-08"),
               "value_date"         => Date.parse("2004-04-08"),
@@ -59,7 +60,7 @@ RSpec.describe Norma43 do
               "document_number"    => 0,
               "reference_1"        => 0,
               "reference_2"        => nil,
-            })
+            )
           end
         end
 
@@ -70,13 +71,13 @@ RSpec.describe Norma43 do
         end
 
         describe "first additional item" do
-          let(:additional_item) { account.transactions[0].additional_items[0]}
+          let(:additional_item) { account.transactions[0].additional_items[0] }
           it "stores expected attributes" do
-            expect(additional_item).to have_attributes({
+            expect(additional_item).to have_attributes(
               "data_code" => 1,
               "item_1"    => "XXXXXXXXX",
               "item_2"    => nil
-            })
+            )
           end
         end
 

data/spec/norma43/line_parsers/account_end_spec.rb

@@ -1,4 +1,4 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers

data/spec/norma43/line_parsers/account_start_spec.rb

@@ -1,4 +1,4 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers
@@ -49,7 +49,6 @@ module Norma43
       it "parses the abbreviated name" do
         expect(account_start.abbreviated_name).to eq "MY ACCOUNT"
       end
-
     end
   end
 end

data/spec/norma43/line_parsers/additional_currency_spec.rb

@@ -1,4 +1,4 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers

data/spec/norma43/line_parsers/additional_items_spec.rb

@@ -1,4 +1,4 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers

data/spec/norma43/line_parsers/document_end_spec.rb

@@ -1,4 +1,4 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers
@@ -10,7 +10,6 @@ module Norma43
       it "parses the record number" do
         expect(document_end.record_number).to eq 48
       end
-
     end
   end
 end

data/spec/norma43/line_parsers/document_start_spec.rb

@@ -1,4 +1,4 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers

data/spec/norma43/line_parsers/transaction_spec.rb

@@ -1,10 +1,9 @@
-require "norma43/line_parsers/line_parsers"
+# frozen_string_literal: true
 
 module Norma43
   module LineParsers
     RSpec.describe Transaction do
       let :transaction do
-
         Transaction.new "2256781127040805040805020092000000000012340000000000000000000000           REF 2"
       end
 
@@ -52,4 +51,3 @@ module Norma43
     end
   end
 end
-

data/spec/norma43/line_processors/account_end_spec.rb

@@ -1,19 +1,18 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
-    RSpec.describe "AccountEnd" do
+    RSpec.describe AccountEnd do
       let :line do
         double "Line", attributes: {}
       end
 
-      let(:account){ Models::Account.new }
-      let(:contexts){ Contexts.new(
+      let(:account) { Norma43::Models::Account.new }
+      let(:contexts) { Norma43::Utils::Contexts.new(
         [
-          Models::Document.new,
+          Norma43::Models::Document.new,
           account,
-          Models::Transaction.new
+          Norma43::Models::Transaction.new
         ])
       }
 
@@ -31,4 +30,3 @@ module Norma43
     end
   end
 end
-

data/spec/norma43/line_processors/account_start_spec.rb

@@ -1,29 +1,28 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
     RSpec.describe "AccountStart" do
-      let(:line){ double "Line", attributes: {} }
-      let(:document) { Models::Document.new }
-      let(:contexts){ Contexts.new}
+      let(:line) { double "Line", attributes: {} }
+      let(:document) { Norma43::Models::Document.new }
+      let(:contexts) { Norma43::Utils::Contexts.new }
 
       before do
         contexts.add document
       end
 
       it "instantiates a new account with the line attributes" do
-        allow(Models::Account).to receive :new
+        allow(Norma43::Models::Account).to receive :new
 
         AccountStart.call line, contexts
 
-        expect(Models::Account).to have_received(:new).with line.attributes
+        expect(Norma43::Models::Account).to have_received(:new).with line.attributes
       end
 
       context "when AccountStart is called" do
-        let(:fake_account) { double "Models::Account" }
+        let(:fake_account) { double "Norma43::Models::Account" }
         before do
-          allow(Models::Account).to receive(:new) { fake_account }
+          allow(Norma43::Models::Account).to receive(:new) { fake_account }
         end
         let!(:subject) { AccountStart.call line, contexts }
 

data/spec/norma43/line_processors/additional_currency_spec.rb

@@ -1,15 +1,14 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
     RSpec.describe "AdditionalCurrency" do
-      let(:line){ double "Line", attributes: {} }
-      let(:transaction){ Models::Transaction.new }
-      let(:contexts){ Contexts.new(
+      let(:line) { double "Line", attributes: {} }
+      let(:transaction) { Norma43::Models::Transaction.new }
+      let(:contexts) { Norma43::Utils::Contexts.new(
         [
-          Models::Document.new ,
-          Models::Account.new ,
+          Norma43::Models::Document.new,
+          Norma43::Models::Account.new,
           transaction
         ])
       }

data/spec/norma43/line_processors/additional_items_spec.rb

@@ -1,15 +1,14 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
     RSpec.describe "AdditionalItems" do
-      let(:line){ double "Line", attributes: {} }
-      let(:transaction){ Models::Transaction.new }
-      let(:contexts){ Contexts.new(
+      let(:line) { double "Line", attributes: {} }
+      let(:transaction) { Norma43::Models::Transaction.new }
+      let(:contexts) { Norma43::Utils::Contexts.new(
         [
-          Models::Document.new ,
-          Models::Account.new ,
+          Norma43::Models::Document.new,
+          Norma43::Models::Account.new,
           transaction
         ])
       }

data/spec/norma43/line_processors/document_end_spec.rb

@@ -1,5 +1,4 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
@@ -10,8 +9,8 @@ module Norma43
       let(:line) { double "Line", record_number: 35 }
 
       it "moves to the nearest document context" do
-        document = Models::Document.new
-        contexts = Contexts.new [Thing.new, document, Thing.new, Thing.new]
+        document = Norma43::Models::Document.new
+        contexts = Norma43::Utils::Contexts.new [Thing.new, document, Thing.new, Thing.new]
 
         DocumentEnd.call line, contexts
 
@@ -19,9 +18,9 @@ module Norma43
       end
 
       it "sets the number of lines on the document" do
-        document = Models::Document.new
+        document = Norma43::Models::Document.new
 
-        DocumentEnd.call line, Contexts.new(document)
+        DocumentEnd.call line, Norma43::Utils::Contexts.new(document)
 
         expect(document.number_of_lines).to eq 35
       end

data/spec/norma43/line_processors/document_start_spec.rb

@@ -1,5 +1,4 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
@@ -9,7 +8,7 @@ module Norma43
       it "instantiates a new document with the line attributes" do
         allow(Models::Document).to receive :new
 
-        DocumentStart.call line, Contexts.new
+        DocumentStart.call line, Norma43::Utils::Contexts.new
 
         expect(Models::Document).to have_received(:new).with line.attributes
       end
@@ -18,7 +17,7 @@ module Norma43
         fake_document = double "Models::Document"
         allow(Models::Document).to receive(:new) { fake_document }
 
-        contexts = DocumentStart.call line, Contexts.new
+        contexts = DocumentStart.call line, Norma43::Utils::Contexts.new
 
         expect(contexts.current).to be fake_document
       end

data/spec/norma43/line_processors/transaction_spec.rb

@@ -1,16 +1,15 @@
-require "norma43/utils/contexts"
-require "norma43/line_processors"
+# frozen_string_literal: true
 
 module Norma43
   module LineProcessors
     RSpec.describe "Transaction" do
-      let(:line){ double "Line", attributes: {} }
-      let(:account){ Models::Account.new }
-      let(:contexts){ Contexts.new(
+      let(:line) { double "Line", attributes: {} }
+      let(:account) { Norma43::Models::Account.new }
+      let(:contexts) { Norma43::Utils::Contexts.new(
         [
-          Models::Document.new ,
+          Norma43::Models::Document.new,
           account,
-          Models::Transaction.new
+          Norma43::Models::Transaction.new
         ])
       }
 

data/spec/norma43/parser_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "norma43/parser"
 
 module Norma43
@@ -5,18 +7,17 @@ module Norma43
     describe "ensuring the file is valid" do
       it "accepts a valid file starting with document" do
         valid_file = "00TI222222    2011102504133012345601TL1Norma43                                  "
-        expect{ Parser.new(valid_file) }.to_not raise_error
+        expect { Parser.new(valid_file) }.to_not raise_error
       end
 
       it "accepts a valid file starting with an account" do
-        
         valid_file = "119999111101234567890408040409052000000001234569783MY ACCOUNT                   "
-        expect{ Parser.new(valid_file) }.to_not raise_error
+        expect { Parser.new(valid_file) }.to_not raise_error
       end
 
       it "should start with 00 or 11" do
         invalid_file = "99TI222222    2011102504133012345601TL1Norma43                                  "
-        expect{ Parser.new(invalid_file) }.to raise_error{ Norma43::InvalidFileFormatError }
+        expect { Parser.new(invalid_file) }.to raise_error { Norma43::InvalidFileFormatError }
       end
     end
   end