nori 2.9.0 → 2.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2ffd841cec28588977a4cf413ade2a33ceba13466046a1299e27016231db0ef
-  data.tar.gz: 51edbdf4ab6413ca7583bb02e05a88ad13fac97741797cf5dde6135edd99d5f8
+  metadata.gz: ad5bbd690d533a62edcdedfe9a4f3d96f117e6cb744a64b9e268676189be1f92
+  data.tar.gz: f8d68043348d270b1e7eeb93b1ae9dfd7abbb18b52181a655b0001d34900d492
 SHA512:
-  metadata.gz: 1700483ec9b91f559ab0fa138c5760fe237f7bf92f5b927bbde60dc437175af5e8c8cc12998195bd875ea9272f62d25727e3fe85a5954918cc0ea31aa5a413a3
-  data.tar.gz: 8713852dfe40adfe96ae00debff569d58f6d8c394fd48fe8df7ad34a767e886605df4163d15cd8573922926ad7abb9f3af1135ddd7180301172dfef5b6b718c6
+  metadata.gz: 81a096bff5c1d667ba3f51d8474c6b9732cf3c128ccb0b17ccf73af780fb83e0b2f60883f4ed26b9a426465e4f4b89d77aaa2ff090d1b174ab138a779280fd0e
+  data.tar.gz: ae0f9173142a7e0f544c0a70a6de05877d96d884d03a87d8154052efb587ba6a5ca93898f2bd4127193e1742d7db1eaf500277797e561cbf6590d7ab6d50ca8d

data/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.9.1] - 2026-07-05
+
+### Fixed
+
+* Under `:serializable`, a typecast value no longer drops the node's attributes. A text node whose content gets converted to a non-String (by `:advanced_typecasting` or a bare `type=` cast) now takes the same hash shape as string values: `<status source="ldap">true</status>` becomes `{"#text" => true, "@source" => "ldap"}` instead of a bare `true` that silently lost `@source`. This closes a data-dependent hole in the profile's no-silent-loss promise, where the same element kept or dropped its attributes depending on what its text happened to look like. The value at `#text` is whatever the typecasting produced. Combined with `standards: true` no typecasting happens and `#text` is always a string.
+
+* The `#text` key of the `:serializable` hash shape now goes through `:convert_tags_to` like every other key. Previously a key-converting formula (for example one that symbolizes keys) produced converted element and attribute keys next to a raw `"#text"` string key in the same hash. Nori's contract is that a `:convert_tags_to` formula sees every key it emits, which also means a caller who prefers a plain `text` key over the XML JSON convention can now map `"#text"` in their formula.
+
 ## [2.9.0] - 2026-07-05
 
 ### Changed
@@ -265,5 +273,6 @@ Please make sure to read the updated README for how to use the new version.
 ## 0.1.0 2009-03-28
 * Initial release.
 
+[2.9.1]: https://github.com/savonrb/nori/compare/v2.9.0...v2.9.1
 [2.9.0]: https://github.com/savonrb/nori/compare/v2.8.0...v2.9.0
 [2.8.0]: https://github.com/savonrb/nori/compare/v2.7.1...v2.8.0

data/README.md

@@ -219,7 +219,11 @@ Members of the profile:
   with the `@`-prefixed attributes) instead of a `Nori::StringWithAttributes`.
   This is the same `@`-keyed shape element nodes already use, so the attributes
   survive `to_json`, `to_yaml`, and `Marshal`. A text node without attributes
-  stays a plain `String`.
+  stays a plain `String`. Typecast values keep their attributes the same way
+  (`{"#text" => true, "@source" => "ldap"}`) – attributes are never silently
+  dropped under the profile. The `#text` key goes through `convert_tags_to`
+  like every other key, so a key-converting formula can reshape it (or drop
+  the `#` entirely).
 
   ```ruby
   Nori.new(:serializable => true).parse('<foo bar="baz">Content</foo>')

data/lib/nori/version.rb

@@ -1,3 +1,3 @@
 class Nori
-  VERSION = '2.9.0'
+  VERSION = '2.9.1'
 end

data/lib/nori/xml_utility_node.rb

@@ -255,10 +255,16 @@ class Nori
     end
 
     # Typecasts the text content of the node. String results are wrapped
-    # so the node's attributes stay accessible on the value.
+    # so the node's attributes stay accessible on the value. Typecast
+    # non-String results can only carry the attributes under the
+    # +:serializable+ profile, where every value with attributes takes the
+    # hash shape. Without the profile they are returned bare and the
+    # attributes are dropped, because a {StringWithAttributes} cannot wrap
+    # them.
     def text_value
       value = typecast_value(inner_html)
       value = advanced_typecasting(value) if value.is_a?(String) && @options[:advanced_typecasting]
+      return serializable_value(value) if @options[:serializable]
       value.is_a?(String) ? string_with_attributes(value) : value
     end
 
@@ -331,19 +337,22 @@ class Nori
       string
     end
 
-    # The +:serializable+ representation of a string +value+ and the node's
+    # The +:serializable+ representation of a +value+ and the node's
     # attributes. A node with attributes maps to the XML JSON convention
     # (+{"#text" => value}+ merged with the "@"-prefixed attributes) and a
-    # node without attributes maps to the plain String. The attribute keys go
-    # through the same prefixing and tag conversion as element-node attributes
-    # ({#prefixed_attributes}), so every node kind shares one convention.
+    # node without attributes maps to the plain value. This holds for
+    # typecast non-String values too, so attributes are never silently
+    # dropped under the profile. The +#text+ key and the attribute keys go
+    # through the same tag conversion as every other key
+    # ({#prefixed_attribute_name}), so a +:convert_tags_to+ formula sees
+    # each key Nori emits.
     #
-    # @param value [String] the typecast text content of the node
-    # @return [Hash{String => String}, String] the hash shape when the node
+    # @param value [Object] the typecast text content of the node
+    # @return [Hash{String => Object}, Object] the hash shape when the node
     #   has attributes, otherwise the plain +value+
     def serializable_value(value)
       return value if attributes.empty?
-      { "#text" => value }.merge(prefixed_attributes)
+      { prefixed_attribute_name("#text") => value }.merge(prefixed_attributes)
     end
 
     def try_to_convert(value, &block)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nori
 version: !ruby/object:Gem::Version
-  version: 2.9.0
+  version: 2.9.1
 platform: ruby
 authors:
 - Daniel Harrington