noresponse 2.1.8 → 2.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23eb30fbb62a49330cd9e5db69140d6ccfeb408d7a44937d594f54e4b8482761
-  data.tar.gz: 7d11e9e140129264da5d4a897096a10e15a01c68d6bd991a0645357cac0b6058
+  metadata.gz: 7295cfba1804dbd242c6e281b99ab6ade40e297c7377e0686a81a1e916bc460c
+  data.tar.gz: 18c1ffd8eb31d511e3d91cb36358eeaeaf0b801cbf55e714a1ad7ee66cac2768
 SHA512:
-  metadata.gz: 30f786d6011a91db0826d647bd31a7a987c46a4ccc4bef38f0b08c537a29aac412ecde15e3a53241135ae9508a727489cc9071460f04a47f0ea2bf3575f79595
-  data.tar.gz: a0150b0114a84e97d0ccb31aeb56bfe1500f9664e6e139912c9eb258bda05b9df1500facc100b5a0734aeaa7fa817f04d6b292b84c4476604a119a5379f329bf
+  metadata.gz: 24ae1d8d916a9113c3e94bb4e77fa61c2ce7c878a6c08ba631df4a75bb3575c9a4769ce44bf74020e223b5fc15e0b4d8721d41b450720234195a3c9ff47d50b5
+  data.tar.gz: 87bc61f9f9e3abdb7bfa757a60654ced341dd1a09ffdb5311f5a16f9489cead2823961a535f26691571f3446fff582c6293d25730fbb96b14b0278303cedb4d0

data/lib/no_response/sdkconfiguration.rb

@@ -95,9 +95,9 @@ module NoResponse
 
       @language = "ruby"
       @openapi_doc_version = "1"
-      @sdk_version = "2.1.8"
+      @sdk_version = "2.1.9"
       @gen_version = "internal"
-      @user_agent = "noresponse-sdk/ruby 2.1.8 internal 1 noresponse"
+      @user_agent = "noresponse-sdk/ruby 2.1.9 internal 1 noresponse"
     end
 
     sig { returns([String, T::Hash[Symbol, String]]) }

data/lib/no_response/wait.rb

@@ -1,7 +1,7 @@
 # typed: true
 # frozen_string_literal: true
 
-# Wait for a pending assessment. Hand-written beside the generated client.
+# Wait for an assessment to complete. Hand-written beside the generated client.
 
 module NoResponse
   # The assessment was still pending when the wait ran out. last is the
@@ -22,9 +22,12 @@ module NoResponse
 
     class << self
 
-      # Poll client.assessments.get until the assessment is no longer pending,
+      # Poll client.assessments.get until the assessment's status is complete,
       # sleeping for the Retry-After the API sends (at least 1 s) between
-      # polls. Raises WaitTimeoutError once timeout seconds have passed.
+      # polls. Once timeout seconds have passed it returns a partial answer as
+      # it stands, its status still PARTIAL, and raises WaitTimeoutError if the
+      # assessment is still pending. A poll cut off by the deadline also
+      # returns the last partial answer instead of losing it.
       def wait(client, assessment_id, **options)
         poll(client.assessments, assessment_id, **options)
       end
@@ -34,13 +37,29 @@ module NoResponse
         raise ArgumentError, 'timeout must be positive' unless timeout.positive?
 
         deadline = clock.call + timeout
+        last = T.let(nil, T.untyped)
         loop do
           remaining_ms = [((deadline - clock.call) * 1000).ceil, 1].max
-          response = assessments.get(assessment_id: assessment_id, timeout_ms: remaining_ms)
-          return response.result unless response.result.status == Models::Shared::Status::PENDING
+          begin
+            response = assessments.get(assessment_id: assessment_id, timeout_ms: remaining_ms)
+          rescue Faraday::TimeoutError
+            # Each poll is bounded by the time left, so a request timeout here
+            # is the wait running out: a partial answer from an earlier poll
+            # stands. Anything else, or a timeout before the deadline, raises.
+            raise unless clock.call >= deadline && last&.status == Models::Shared::Status::PARTIAL
+
+            return last
+          end
+          last = response.result
+          status = response.result.status
+          return response.result if status == Models::Shared::Status::COMPLETE
 
           delay = retry_after(response.headers)
-          raise WaitTimeoutError.new(assessment_id, response.result) if clock.call + delay > deadline
+          if clock.call + delay > deadline
+            return response.result if status == Models::Shared::Status::PARTIAL
+
+            raise WaitTimeoutError.new(assessment_id, response.result)
+          end
 
           sleeper.call(delay)
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noresponse
 version: !ruby/object:Gem::Version
-  version: 2.1.8
+  version: 2.1.9
 platform: ruby
 authors:
 - NoResponse