nonnative 2.19.1 → 2.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '08e1e5b760ed902c52e55ef0694bddeb1e36580891ab9a778767a04ea02b1d9c'
-  data.tar.gz: d632a3b8047ebada176e3db071caada192b87d8c255d6beb0e14a1010874103f
+  metadata.gz: 50e3259a9203deec0efaadd273f5dbb0af97707e7226399147e081c57c19e1a9
+  data.tar.gz: 3986e9250edbf08bd3b570610849cc6f6a998dc1773ef14eee7cb9da45771db6
 SHA512:
-  metadata.gz: bfeba487e42d817e967c0a1cfe0814e5fc75c4d360399dcbd0caaf6ddef83c11efb8a4aff8ffe58ee6566be138b3b85e146e5ffe44dc431e734cf22544956019
-  data.tar.gz: 268c3d360f3d23b18a69317cbe656b06d24b8f94799c245108e94e5e269ac852c000d74d3427168fd2ad5b2c56ea24a3bb21e1507c77d9e4cce713fac4b57a3b
+  metadata.gz: b7d31913722e55932103ab8855d3a01b4fccc358dfec987e16ebc6978cc39f6a34eed25f46d788084a3fa665fe5af9165da4091f8d512064ef550e12aa26c817
+  data.tar.gz: 8f3aa8a30785c105735916ba45275ee3f72d1f1d76edec4399124a262995664e7866901ca18cb7d9b85a7108196b46bf8c76d2376e6505d628f15854c821de9a

data/AGENTS.md

@@ -29,7 +29,8 @@ of dependencies.
 
 Public entry point: `lib/nonnative.rb`.
 
-Main API: `configure`, `start`, `stop`, `clear`, `reset`, `pool`.
+Main API: `configure`, `start`, `stop`, `clear`, `reset`, `pool`,
+`go_argv`, `go_command`.
 
 Configuration is `Nonnative::Configuration`, built with
 `config.process`, `config.server`, `config.service`, or
@@ -81,7 +82,8 @@ Config rules:
 
 - YAML config is loaded as data only via `Nonnative::ConfigurationFile`; ERB is not evaluated and arbitrary Ruby object tags are rejected
 - Runner `host` and nested `proxy.host` default to `127.0.0.1`; use explicit `0.0.0.0` only when external access is intended
-- Process `command` can be a legacy shell string or an argv array; prefer argv arrays for new config, and `go:` config builds argv internally
+- Process `command` can be a legacy shell string or an argv array; prefer argv arrays for new config, and `go:` config builds argv internally with `Nonnative.go_argv`
+- Use `Nonnative.go_argv` for no-shell Go executable argv entries and `Nonnative.go_command` only when a caller needs Ruby shell-style command string spawning
 - YAML services belong under `services:`, not `processes:`
 - There is no top-level `config.wait`; `wait` is per runner
 - Programmatic service config uses `config.service do |s| ... end`, so use `s.host` / `s.port`
@@ -108,6 +110,7 @@ Limitations:
 - Lifecycle: `lib/nonnative.rb`, `lib/nonnative/pool.rb`
 - Readiness/timeouts: `lib/nonnative/port.rb`, `lib/nonnative/timeout.rb`
 - Process lifecycle: `lib/nonnative/process.rb`
+- Go executable command/argv building: `lib/nonnative/go_executable.rb`
 - Proxies: `lib/nonnative/fault_injection_proxy.rb`, `lib/nonnative/socket_pair_factory.rb`
 - Cucumber: `lib/nonnative/cucumber.rb`, `lib/nonnative/startup.rb`, `features/support/env.rb`
 - Config loading: `lib/nonnative/configuration.rb`, `lib/nonnative/configuration_file.rb`, `lib/nonnative/configuration_runner.rb`, `lib/nonnative/configuration_proxy.rb`

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nonnative (2.19.1)
+    nonnative (2.21.0)
       concurrent-ruby (>= 1, < 2)
       config (>= 5, < 6)
       cucumber (>= 7, < 12)

data/README.md

@@ -781,12 +781,14 @@ Programmatic Go binaries can be configured as normal argv process commands:
 Nonnative.configure do |config|
   config.process do |p|
     p.name = 'go'
-    p.command = -> { ['your_binary', 'sub_command', '--config', 'config.yaml'] }
+    p.command = -> { Nonnative.go_argv(%w[cover], 'reports', 'your_binary', 'sub_command', '-i file:.config/server.yml') }
     p.port = 12_345
   end
 end
 ```
 
+Use `Nonnative.go_argv(...)` when a process should execute without shell interpretation, and `Nonnative.go_command(...)` when a caller needs a command string for Ruby's shell-style `spawn` behavior.
+
 YAML `go:` configuration is for Go test binaries compiled with `go test -c`. It builds argv entries in this order: executable, optional `-test.*` profiling/trace/coverage flags, command, then parameters. Parameter strings are parsed into argv words with shell-style quoting, but the argv entries are executed without shell interpretation.
 
 To get this to work you will need to create a `main_test.go` file with these contents:

data/lib/nonnative/configuration.rb

@@ -141,7 +141,7 @@ module Nonnative
         params = go.parameters || []
         tools = go.tools || []
 
-        -> { Nonnative.go_executable_args(tools, go.output, go.executable, go.command, *params) }
+        -> { Nonnative.go_argv(tools, go.output, go.executable, go.command, *params) }
       else
         -> { process.command }
       end

data/lib/nonnative/cucumber.rb

@@ -88,7 +88,7 @@ module Nonnative
     end
 
     module LifecycleSteps
-      SERVICE_UNAVAILABLE = 'Service Unavailable'
+      SERVICE_UNAVAILABLE = 'service unavailable'
 
       def install_state_steps
         install_start_step
@@ -126,11 +126,12 @@ module Nonnative
         opts = observability_options
 
         Then('I should see {string} as unhealthy') do |service|
+          service = service.downcase
           wait_for { Nonnative.observability.health(opts).code }.to eq(503)
           wait_for { Nonnative.observability.health(opts).body }.to satisfy do |body|
-            body = body.to_s.strip
+            body = body.to_s.strip.downcase
 
-            body == SERVICE_UNAVAILABLE || body.include?(service)
+            body.include?(SERVICE_UNAVAILABLE) || body.include?(service)
           end
         end
       end
@@ -139,11 +140,12 @@ module Nonnative
         opts = observability_options
 
         Then('I should see {string} as healthy') do |service|
+          service = service.downcase
           wait_for { Nonnative.observability.health(opts).code }.to eq(200)
           wait_for { Nonnative.observability.health(opts).body }.to satisfy do |body|
-            body = body.to_s.strip
+            body = body.to_s.strip.downcase
 
-            body != SERVICE_UNAVAILABLE && !body.include?(service)
+            !body.include?(SERVICE_UNAVAILABLE) && !body.include?(service)
           end
         end
       end

data/lib/nonnative/{go_command.rb → go_executable.rb}

@@ -19,15 +19,16 @@ module Nonnative
   #
   # If `tools` is `nil` or empty, all tools (`prof`, `trace`, `cover`) are enabled.
   #
-  # Parameter strings are parsed into argv words using shell-style quoting, then executed without a shell.
+  # Parameter strings are parsed into argv words using shell-style quoting.
   #
   # @example
-  #   cmd = Nonnative::GoCommand.new(%w[prof cover], './svc.test', 'reports')
-  #   cmd.executable_args('serve', '--config', 'config.yaml')
+  #   executable = Nonnative::GoExecutable.new(%w[prof cover], './svc.test', 'reports')
+  #   executable.argv('serve', '--config', 'config.yaml')
   #   # => ["./svc.test", "-test.cpuprofile=...", "-test.coverprofile=...", "serve", "--config", "config.yaml"]
   #
-  # @see Nonnative.go_executable_args
-  class GoCommand
+  # @see Nonnative.go_command
+  # @see Nonnative.go_argv
+  class GoExecutable
     # @param tools [Array<String>, nil] tool names to enable (see class docs)
     # @param exec [String] path to the compiled Go test binary
     # @param output [String] output directory for generated files
@@ -44,10 +45,19 @@ module Nonnative
     # @param cmd [String] command/sub-command argument passed to the Go test binary
     # @param params [Array<String>] additional parameter strings passed after `cmd`
     # @return [Array<String>] argv entries to execute
-    def executable_args(cmd, *params)
+    def argv(cmd, *params)
       [exec, *flags(cmd), cmd, *parameter_args(params)]
     end
 
+    # Returns an executable command string including enabled `-test.*` flags.
+    #
+    # @param cmd [String] command/sub-command argument passed to the Go test binary
+    # @param params [Array<String>] additional parameter strings passed after `cmd`
+    # @return [String] the full command to execute
+    def command(cmd, *params)
+      Shellwords.join(argv(cmd, *params))
+    end
+
     private
 
     attr_reader :tools, :exec, :output

data/lib/nonnative/version.rb

@@ -4,5 +4,5 @@ module Nonnative
   # The current gem version.
   #
   # @return [String]
-  VERSION = '2.19.1'
+  VERSION = '2.21.0'
 end

data/lib/nonnative.rb

@@ -94,7 +94,7 @@ require 'nonnative/close_all_socket_pair'
 require 'nonnative/delay_socket_pair'
 require 'nonnative/invalid_data_socket_pair'
 require 'nonnative/socket_pair_factory'
-require 'nonnative/go_command'
+require 'nonnative/go_executable'
 require 'nonnative/cucumber'
 require 'nonnative/header'
 
@@ -154,9 +154,23 @@ module Nonnative
       File.readlines(path).select { |l| predicate.call(l) }
     end
 
+    # Builds a Go test executable command string with optional profiling/trace/coverage flags.
+    #
+    # Use this when passing a command string directly to `spawn`.
+    #
+    # @param tools [Array<String>] enabled tool names (e.g. `["prof", "trace", "cover"]`)
+    # @param output [String] directory where outputs should be written
+    # @param exec [String] the test binary (or wrapper) to execute
+    # @param cmd [String] the command argument passed to the test binary
+    # @param params [Array<String>] extra parameter strings for the command
+    # @return [String] executable command string
+    def go_command(tools, output, exec, cmd, *params)
+      Nonnative::GoExecutable.new(tools, exec, output).command(cmd, *params)
+    end
+
     # Builds a Go test executable argv array with optional profiling/trace/coverage flags.
     #
-    # This is used when process configuration specifies a `go` section.
+    # Use this when passing argv entries directly to `spawn`.
     #
     # @param tools [Array<String>] enabled tool names (e.g. `["prof", "trace", "cover"]`)
     # @param output [String] directory where outputs should be written
@@ -164,8 +178,8 @@ module Nonnative
     # @param cmd [String] the command argument passed to the test binary
     # @param params [Array<String>] extra parameter strings for the command
     # @return [Array<String>] executable argv entries
-    def go_executable_args(tools, output, exec, cmd, *params)
-      Nonnative::GoCommand.new(tools, exec, output).executable_args(cmd, *params)
+    def go_argv(tools, output, exec, cmd, *params)
+      Nonnative::GoExecutable.new(tools, exec, output).argv(cmd, *params)
     end
 
     # Returns an HTTP client for common health/readiness endpoints.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nonnative
 version: !ruby/object:Gem::Version
-  version: 2.19.1
+  version: 2.21.0
 platform: ruby
 authors:
 - Alejandro Falkowski
@@ -298,7 +298,7 @@ files:
 - lib/nonnative/delay_socket_pair.rb
 - lib/nonnative/error.rb
 - lib/nonnative/fault_injection_proxy.rb
-- lib/nonnative/go_command.rb
+- lib/nonnative/go_executable.rb
 - lib/nonnative/grpc_server.rb
 - lib/nonnative/header.rb
 - lib/nonnative/http_client.rb