nonnative 2.0 → 2.8.0

data/lib/nonnative.rb

@@ -53,7 +53,6 @@ require 'rest-client'
 require 'retriable'
 require 'concurrent'
 require 'config'
-require 'cucumber'
 require 'get_process_mem'
 require 'rspec-benchmark'
 require 'rspec/expectations'
@@ -109,10 +108,10 @@ require 'nonnative/header'
 # @see Nonnative::Pool for lifecycle orchestration once started
 module Nonnative
   class << self
-    # Returns the current runner pool (created on {Nonnative.start}).
+    # Returns or overrides the current runner pool (created on {Nonnative.start}).
     #
     # @return [Nonnative::Pool, nil] the pool instance, or `nil` if not started yet
-    attr_reader :pool
+    attr_accessor :pool
 
     # Loads one or more configuration files using the `config` gem.
     #
@@ -210,13 +209,19 @@ module Nonnative
     def start
       @pool ||= Nonnative::Pool.new(configuration)
       errors = []
-
-      @pool.start do |name, values, result|
+      errors.concat(@pool.start do |name, values, result|
         id, started = values
-        errors << "Started #{name} with id #{id}, though did respond in time" if !started || !result
-      end
+        errors << "Started #{name} with id #{id}, though did not respond in time" if !started || !result
+      end)
+      nil
+    rescue StandardError => e
+      errors << unexpected_lifecycle_error(:start, e)
+    ensure
+      if errors.any?
+        errors.concat(rollback_start)
 
-      raise Nonnative::StartError, errors.join("\n") unless errors.empty?
+        raise Nonnative::StartError, errors.join("\n")
+      end
     end
 
     # Stops all configured processes and servers, then services, and waits for shutdown.
@@ -224,14 +229,16 @@ module Nonnative
     # @return [void]
     # @raise [Nonnative::StopError] if one or more runners fail to stop in time
     def stop
-      return if @pool.nil?
-
       errors = []
+      return if @pool.nil?
 
-      @pool.stop do |name, id, result|
-        errors << "Stopped #{name} with id #{id}, though did respond in time" unless result
-      end
-
+      errors.concat(@pool.stop do |name, id, result|
+        errors << "Stopped #{name} with id #{id}, though did not respond in time" unless result
+      end)
+      nil
+    rescue StandardError => e
+      errors << unexpected_lifecycle_error(:stop, e)
+    ensure
       raise Nonnative::StopError, errors.join("\n") unless errors.empty?
     end
 
@@ -242,6 +249,22 @@ module Nonnative
       @configuration = nil
     end
 
+    # Closes and clears the memoized logger instance.
+    #
+    # @return [void]
+    def clear_logger
+      @logger&.close
+    ensure
+      @logger = nil
+    end
+
+    # Clears the memoized observability client.
+    #
+    # @return [void]
+    def clear_observability
+      @observability = nil
+    end
+
     # Clears the memoized pool instance.
     #
     # @return [void]
@@ -249,10 +272,12 @@ module Nonnative
       @pool = nil
     end
 
-    # Clears memoized configuration and pool.
+    # Clears memoized configuration, logger, observability client, and pool.
     #
     # @return [void]
     def clear
+      clear_logger
+      clear_observability
       clear_configuration
       clear_pool
     end
@@ -264,5 +289,24 @@ module Nonnative
     def reset
       Nonnative.pool.reset
     end
+
+    private
+
+    def rollback_start
+      errors = []
+      return errors if @pool.nil?
+
+      errors.concat(@pool.rollback do |name, id, result|
+        errors << "Rollback failed for #{name} with id #{id}, because it did not stop in time" unless result
+      end)
+    rescue StandardError => e
+      errors << unexpected_lifecycle_error(:rollback, e)
+    ensure
+      clear_pool if errors.empty?
+    end
+
+    def unexpected_lifecycle_error(action, error)
+      "#{action.to_s.capitalize} failed with #{error.class}: #{error.message}"
+    end
   end
 end

data/nonnative.gemspec

@@ -27,6 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'concurrent-ruby', '>= 1', '< 2'
   spec.add_dependency 'config', '>= 5', '< 6'
   spec.add_dependency 'cucumber', '>= 7', '< 11'
+  spec.add_dependency 'cucumber-cucumber-expressions', '< 19'
   spec.add_dependency 'get_process_mem', '>= 1', '< 2'
   spec.add_dependency 'grpc', '>= 1', '< 2'
   spec.add_dependency 'puma', '>= 7', '< 8'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nonnative
 version: !ruby/object:Gem::Version
-  version: '2.0'
+  version: 2.8.0
 platform: ruby
 authors:
 - Alejandro Falkowski
@@ -69,6 +69,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '11'
+- !ruby/object:Gem::Dependency
+  name: cucumber-cucumber-expressions
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '19'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '19'
 - !ruby/object:Gem::Dependency
   name: get_process_mem
   requirement: !ruby/object:Gem::Requirement