nonnative 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '06810bfb7f808b9a8d29a48a83f3b6d65d62d7319708961176ac4d12ec8b7f1e'
-  data.tar.gz: 4822cdaa7d9fc73ed9bdd56721eed722d782dc0656dcdd83503b6bb9eb626d72
+  metadata.gz: 8cb45efde1cca2e96f9720adc6142b538be0fc5d3d3b416c1d65d3130d40582f
+  data.tar.gz: 6b3b131ba76dba8bad6c7b56d3e93d228fa7695e001b5018f48a8a7e665aa331
 SHA512:
-  metadata.gz: 6f78bb13f595d29a1156635e56673e8cb37c2a6c32160d7ed92bc846d80203bd4249da3a37dfeebb0f5c3fbc60cbd4d87b952bc3c02df1f59dd3efa8351ec4a4
-  data.tar.gz: f3f42321dbc3b520ef40965a043fdb55c8a4cd7116eeeb7199319138efea9008481607c41c47809b785ed688d091a1b55277fd84bfec3876327c6d32fb4e2930
+  metadata.gz: d393842c0a687f9ff4a7d6ae336c431a4ef2e5cbf174c63f44a24e5c14acf419c4b5f9807353d4ae4319d74695ab8d5a75520bec2c7307bf2657adb5bda70aa3
+  data.tar.gz: 17864c1f200bc596d09ba25918d9a722f9566ba8f7fe844ddfacc452eb04076d1800dd53f2a0db879fc64fa532442250a16ad2c0ab66055998b12f94372c4c99

data/.gitignore

@@ -7,3 +7,4 @@
 /spec/reports/
 /tmp/
 vendor
+coverage

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nonnative (0.3.0)
+    nonnative (0.4.0)
       cucumber
       rspec-expectations
       semantic_logger
@@ -31,9 +31,11 @@ GEM
     cucumber-tag_expressions (1.1.1)
     cucumber-wire (0.0.1)
     diff-lcs (1.3)
+    docile (1.3.2)
     gherkin (5.1.0)
     htmlentities (4.3.4)
     jaro_winkler (1.5.3)
+    json (2.2.0)
     kramdown (1.17.0)
     mini_portile2 (2.4.0)
     multi_json (1.13.1)
@@ -61,6 +63,11 @@ GEM
     ruby-progressbar (1.10.1)
     semantic_logger (4.5.0)
       concurrent-ruby (~> 1.0)
+    simplecov (0.17.0)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
     solargraph (0.35.1)
       backport (~> 1.1)
       bundler (>= 1.17.2)
@@ -86,6 +93,7 @@ DEPENDENCIES
   nonnative!
   rake
   rubocop
+  simplecov
   solargraph
 
 BUNDLED WITH

data/lib/nonnative/process.rb

@@ -2,28 +2,23 @@
 
 module Nonnative
   class Process
-    def initialize(configuration, logger)
+    def initialize(configuration)
       @configuration = configuration
-      @logger = logger
     end
 
     def start
-      @child_pid = spawn(configuration.process)
-      return if port_open?
-
-      logger.error('Process has started though did respond in time', pid: child_pid)
+      @pid = spawn(configuration.process)
+      [port_open?, pid]
     end
 
     def stop
-      ::Process.kill('SIGHUP', child_pid)
-      return if port_closed?
-
-      logger.error('Process has stopped though did respond in time', pid: child_pid)
+      ::Process.kill('SIGHUP', pid)
+      [port_closed?, pid]
     end
 
     private
 
-    attr_reader :configuration, :logger, :child_pid
+    attr_reader :configuration, :pid
 
     def port_open?
       timeout do

data/lib/nonnative/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nonnative
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/lib/nonnative.rb

@@ -27,12 +27,18 @@ module Nonnative
     end
 
     def start
-      @process ||= Nonnative::Process.new(configuration, logger)
-      @process.start
+      @process ||= Nonnative::Process.new(configuration)
+      result, pid = @process.start
+      return if result
+
+      logger.error('Process has started though did respond in time', pid: pid)
     end
 
     def stop
-      @process.stop
+      result, pid = @process.stop
+      return if result
+
+      logger.error('Process has started though did respond in time', pid: pid)
     end
   end
 end

data/nonnative.gemspec

@@ -31,5 +31,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'solargraph'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nonnative
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Alex Falkowski
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: solargraph
   requirement: !ruby/object:Gem::Requirement