nondisposable 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b423ab4d910c50439d17398fcb84d95013ecd20be9c281f540c7b4540f79cb22
-  data.tar.gz: b09ff53a1ac0cf5d47f4b597e89f30e6522836d6fbdcd0bd3de4ed564edfa69f
+  metadata.gz: 6d6da844eae687a1d72201694a880a5ec5f16dcbd5e498de792a19d421027e6b
+  data.tar.gz: ea77c8f6ea5ddf4726f95b3438fadb7c7f0dedaed83bf7b674fdba78f95cbbed
 SHA512:
-  metadata.gz: 6506a82600a139b2ac20b2abb8e84e2215f08af55eacbb43fac4d4524b7feb3b338dfd4cc73e7808957bbc9243f9d72c90fa3c28bc4b248ece56ea6f7d240ba2
-  data.tar.gz: d840467aa4befe4c934883cc18bfc33ba847889d4808dd94e633f84ef6a5c690b5c9b93e5d1fbc0a5e45daa5d1524f3534fce9db52aea3939a9ef01a490c18ef
+  metadata.gz: af761f9347d7e630239973256600cb52996f166f8479908c2ee8d379cae8b46d2035455c4bc2dc3c305941d7fe393dcac634e8d6b287e95eeee4b8bf9271db64
+  data.tar.gz: f58d7598f288515f684aaffc55a9399e01398fc9644b5744fd8e136510e4e51d358db12b4b33f99a58c7d06b5a05bd06a5313ff8e5f9f35e2d8ce95166791d38

data/.simplecov

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# SimpleCov configuration file (auto-loaded before test suite)
+# This keeps test_helper.rb clean and follows best practices
+
+SimpleCov.start do
+  # Use SimpleFormatter for terminal-only output (no HTML generation)
+  formatter SimpleCov::Formatter::SimpleFormatter
+
+  # Track coverage for the lib directory (gem source code)
+  add_filter "/test/"
+
+  # Track the lib and app directories
+  track_files "{lib,app}/**/*.rb"
+
+  # Enable branch coverage for more detailed metrics
+  enable_coverage :branch
+
+  # Set minimum coverage threshold to prevent coverage regression
+  minimum_coverage line: 90, branch: 90
+
+  # Disambiguate parallel test runs
+  command_name "Job #{ENV['TEST_ENV_NUMBER']}" if ENV['TEST_ENV_NUMBER']
+end
+
+# Print coverage summary to terminal after tests complete
+SimpleCov.at_exit do
+  SimpleCov.result.format!
+  puts "\n" + "=" * 60
+  puts "COVERAGE SUMMARY"
+  puts "=" * 60
+  puts "Line Coverage:   #{SimpleCov.result.covered_percent.round(2)}%"
+  puts "Branch Coverage: #{SimpleCov.result.coverage_statistics[:branch]&.percent&.round(2) || 'N/A'}%"
+  puts "=" * 60
+end

data/AGENTS.md

@@ -0,0 +1,5 @@
+# AGENTS.md
+
+This file provides guidance to AI Agents (like OpenAI's Codex, Cursor Agent, Claude Code, etc) when working with code in this repository.
+
+Please go ahead and read the full context for this project at `.cursor/rules/0-overview.mdc` and `.cursor/rules/1-quality.mdc` now. Also read the README for a good overview of the project.

data/Appraisals

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# Note: Rails < 7.2 is not compatible with Ruby 3.4
+# (Logger became a bundled gem in Ruby 3.4, and only Rails 7.2+ handles this)
+# See: https://stdgems.org/logger/
+
+# Test against Rails 7.2 (minimum version compatible with Ruby 3.4)
+appraise "rails-7.2" do
+  gem "rails", "~> 7.2.0"
+end
+
+# Test against Rails 8.0
+appraise "rails-8.0" do
+  gem "rails", "~> 8.0.0"
+end
+
+# Test against Rails 8.1 (latest)
+appraise "rails-8.1" do
+  gem "rails", "~> 8.1.2"
+end

data/CHANGELOG.md

@@ -1,4 +1,13 @@
-## [Unreleased]
+## [0.2.1] - 2026-01-17
+
+- Add `[nondisposable]` prefix to all logger calls for better log identification
+
+## [0.2.0] - 2026-01-16
+
+- Fixed `NoMethodError` when email is `"@"` or malformed (empty domain after split)
+- Removed non-existent asset references from engine (`nondisposable/application.css` and `.js`)
+- Removed buggy `railtie.rb` file that attempted to include a class instead of a module
+- Added comprehensive Minitest 6 test suite with 256 tests and 90%+ line / branch coverage
 
 ## [0.1.0] - 2024-09-25
 

data/CLAUDE.md

@@ -0,0 +1,5 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+Please go ahead and read the full context for this project at `.cursor/rules/0-overview.mdc` and `.cursor/rules/1-quality.mdc` now. Also read the README for a good overview of the project.

data/README.md

@@ -1,5 +1,10 @@
 # 🗑️ `nondisposable` - Block disposable email addresses from signing up to your Rails app
 
+[![Gem Version](https://badge.fury.io/rb/nondisposable.svg)](https://badge.fury.io/rb/nondisposable) [![Build Status](https://github.com/rameerez/nondisposable/workflows/Tests/badge.svg)](https://github.com/rameerez/nondisposable/actions)
+
+> [!TIP]
+> **🚀 Ship your next Rails app 10x faster!** I've built **[RailsFast](https://railsfast.com/?ref=nondisposable)**, a production-ready Rails boilerplate template that comes with everything you need to launch a software business in days, not weeks. Go [check it out](https://railsfast.com/?ref=nondisposable)!
+
 `nondisposable` is a Ruby gem that prevents users from signing up to your Rails app with disposable email addresses.
 
 Simply add to your User model:
@@ -122,6 +127,38 @@ production:
     schedule: every day at 3am US/Pacific
 ```
 
+## Troubleshooting
+
+### SSL certificate verify failed (unable to get certificate CRL)
+
+If you see this error when running `Nondisposable::DomainListUpdater.update`:
+
+```
+SSL_connect returned=1 errno=0 peeraddr=[::1]:10011 state=error: certificate verify failed (unable to get certificate CRL) (OpenSSL::SSL::SSLError)
+```
+
+This is **not** a bug in `nondisposable`. It's a known incompatibility between OpenSSL 3.6.0 and older versions of Ruby's `openssl` gem (3.3.0 and earlier).
+
+The fix is to update the `openssl` gem to version 3.3.1 or later **in your Rails project**.
+
+Add this to your Rails' project `Gemfile`:
+
+```ruby
+gem "openssl", "~> 3.3.2"
+```
+
+Then run:
+
+```bash
+bundle install
+```
+
+This issue is unlikely to occur in production, it's mostly a development-only issue. It's likely that the exact same codebase fails in development but works fine in production. It only occurs when you have OpenSSL 3.6.0 system-wide AND something intercepting HTTPS traffic (like Cursor's proxy). Users in production or using a regular terminal won't experience it.
+
+This issue is more likely to occur if you're running your Rails console from within certain IDEs (like Cursor) that intercept HTTPS traffic through a local proxy. The updated `openssl` gem properly handles certificate verification in these environments.
+
+For more details, see the [Ruby openssl gem issue](https://github.com/ruby/openssl/issues/949).
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/Rakefile

@@ -1,4 +1,13 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-task default: %i[]
+require "rake/testtask"
+
+Rake::TestTask.new(:test) do |t|
+  t.libs << "lib"
+  t.libs << "test"
+  t.test_files = FileList['test/**/*_test.rb']
+  t.warning = false
+end
+
+task default: %i[test]

data/gemfiles/rails_7.2.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 7.2.0"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end
+
+gemspec path: "../"

data/gemfiles/rails_8.0.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 8.0.0"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end
+
+gemspec path: "../"

data/gemfiles/rails_8.1.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 8.1.2"
+
+group :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "minitest-reporters", "~> 1.6"
+  gem "webmock", "~> 3.19"
+  gem "sqlite3", "~> 2.1"
+  gem "simplecov", require: false
+end
+
+gemspec path: "../"

data/lib/nondisposable/domain_list_updater.rb

@@ -7,7 +7,7 @@ module Nondisposable
   class DomainListUpdater
 
     def self.update
-      Rails.logger.info "Refreshing list of disposable domains..."
+      Rails.logger.info "[nondisposable] Refreshing list of disposable domains..."
 
       url = 'https://raw.githubusercontent.com/disposable-email-domains/disposable-email-domains/master/disposable_email_blocklist.conf'
 
@@ -19,29 +19,29 @@ module Nondisposable
           downloaded_domains = response.body.split("\n")
           raise "The list is empty. This might indicate a problem with the format." if downloaded_domains.empty?
 
-          Rails.logger.info "Downloaded list of disposable domains..."
+          Rails.logger.info "[nondisposable] Downloaded list of disposable domains..."
 
           domains = (downloaded_domains + Nondisposable.configuration.additional_domains).uniq
           domains -= Nondisposable.configuration.excluded_domains
 
           ActiveRecord::Base.transaction do
-            Rails.logger.info "Updating disposable domains..."
+            Rails.logger.info "[nondisposable] Updating disposable domains..."
             Nondisposable::DisposableDomain.delete_all
 
             domains.each { |domain| Nondisposable::DisposableDomain.create(name: domain.downcase) }
           end
 
-          Rails.logger.info "Finished updating disposable domains. Total domains: #{domains.count}"
+          Rails.logger.info "[nondisposable] Finished updating disposable domains. Total domains: #{domains.count}"
           true
         else
-          Rails.logger.error "Failed to download the list. HTTP Status: #{response.code}"
+          Rails.logger.error "[nondisposable] Failed to download the list. HTTP Status: #{response.code}"
           false
         end
       rescue SocketError => e
-        Rails.logger.error "Network error occurred: #{e.message}"
+        Rails.logger.error "[nondisposable] Network error occurred: #{e.message}"
         false
       rescue StandardError => e
-        Rails.logger.error "An error occurred when trying to update the list of disposable domains: #{e.message}"
+        Rails.logger.error "[nondisposable] An error occurred when trying to update the list of disposable domains: #{e.message}"
         false
       end
     end

data/lib/nondisposable/email_validator.rb

@@ -14,7 +14,7 @@ module ActiveModel
             record.errors.add(attribute, options[:message] || Nondisposable.configuration.error_message)
           end
         rescue StandardError => e
-          Rails.logger.error "Nondisposable validation error: #{e.message}"
+          Rails.logger.error "[nondisposable] Nondisposable validation error: #{e.message}"
           record.errors.add(attribute, "is an invalid email address, cannot check if it's disposable")
         end
       end

data/lib/nondisposable/engine.rb

@@ -4,10 +4,6 @@ module Nondisposable
   class Engine < ::Rails::Engine
     isolate_namespace Nondisposable
 
-    initializer "nondisposable.assets.precompile" do |app|
-      app.config.assets.precompile += %w( nondisposable/application.css nondisposable/application.js )
-    end
-
     config.generators do |g|
       g.test_framework :rspec
       g.fixture_replacement :factory_bot

data/lib/nondisposable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nondisposable
-  VERSION = "0.1.0"
+  VERSION = "0.2.1"
 end

data/lib/nondisposable.rb

@@ -4,6 +4,7 @@ require_relative "nondisposable/version"
 require_relative "nondisposable/engine"
 require_relative "nondisposable/email_validator"
 require_relative "nondisposable/domain_list_updater"
+
 module Nondisposable
   class Error < StandardError; end
 
@@ -18,8 +19,9 @@ module Nondisposable
 
   def self.disposable?(email)
     return false if email.nil? || !email.include?('@')
-    domain = email.to_s.split('@').last.downcase
-    DisposableDomain.disposable?(domain)
+    domain = email.to_s.split('@').last
+    return false if domain.nil? || domain.empty?
+    DisposableDomain.disposable?(domain.downcase)
   end
 
   class Configuration

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: nondisposable
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - rameerez
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-31 00:00:00.000000000 Z
+date: 2026-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -33,11 +32,18 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".simplecov"
+- AGENTS.md
+- Appraisals
 - CHANGELOG.md
+- CLAUDE.md
 - LICENSE.txt
 - README.md
 - Rakefile
 - app/models/nondisposable/disposable_domain.rb
+- gemfiles/rails_7.2.gemfile
+- gemfiles/rails_8.0.gemfile
+- gemfiles/rails_8.1.gemfile
 - lib/generators/nondisposable/install_generator.rb
 - lib/generators/nondisposable/templates/create_nondisposable_disposable_domains.rb.erb
 - lib/generators/nondisposable/templates/disposable_email_domain_list_update_job.rb
@@ -46,7 +52,6 @@ files:
 - lib/nondisposable/domain_list_updater.rb
 - lib/nondisposable/email_validator.rb
 - lib/nondisposable/engine.rb
-- lib/nondisposable/railtie.rb
 - lib/nondisposable/version.rb
 - sig/nondisposable.rbs
 homepage: https://github.com/rameerez/nondisposable
@@ -57,7 +62,6 @@ metadata:
   homepage_uri: https://github.com/rameerez/nondisposable
   source_code_uri: https://github.com/rameerez/nondisposable
   changelog_uri: https://github.com/rameerez/nondisposable/blob/main/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -72,8 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Block disposable emails from signing up to your Rails app
 test_files: []

data/lib/nondisposable/railtie.rb

@@ -1,9 +0,0 @@
-module Nondisposable
-  class Railtie < Rails::Railtie
-    initializer 'nondisposable.add_validator' do
-      ActiveSupport.on_load(:active_record) do
-        include ActiveModel::Validations::NondisposableValidator
-      end
-    end
-  end
-end