nom-xml 0.5.4 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb52919534624c32a6a015dec49c1b7070d0c933
-  data.tar.gz: b64cc4bba00bee3b5afef3f67ca877fab87a9b44
+  metadata.gz: 014aacabf359763825e7eed07089ed3e080df7f7
+  data.tar.gz: 3196afd25586b81fda37a98535c2e55f4b1e0f9b
 SHA512:
-  metadata.gz: 76735f5e2789f473ad4354778775a2cf3292b83c4f25caf1d5fab17e984cb7ab478acd78c775b32dcb9106dc9a8a708640de9cf6f909cd6f70bf61035a89934b
-  data.tar.gz: c5fe6162f42f5e05ee41d8069ce1bcf9ba42912dc4467b55a7820604244b4bfdb5d0ef2e8a495e4e7ac0db4f16fe724d30c0a4365a04cf789f63a5c6b3498013
+  metadata.gz: ba98c65fe282f957254e7fdd803a62bdc6692ed17d928b3c8666802c069259cb18f0e115c4ba9235c92ca75477cb0e978fc6e1a4d18a084b7343eb46014caeaf
+  data.tar.gz: d2f3b9757f83d81ac615ee5c6b2b317611324c75fc7265c2cbf9b42df2e1da5736a095673f7d154083df9bf3d3327a3a87e9c85ba23ed14e3471ec59ad213f96

data/lib/nom/xml/decorators/terminology.rb

@@ -1,19 +1,4 @@
 module Nom::XML::Decorators::Terminology
-
-  def self.extended node
-    node.add_terminology_method_overrides!
-  end
-
-  def add_terminology_method_overrides!
-    self.term_accessors.each do |k, term|
-      if self.respond_to_without_terms? k and not term.options[:override]
-        raise "Trying to redefine method #{k} on #{self.to_s}"
-      end
-    end.select { |k, term| term.options[:override] }.each do |method, term|
-       define_term_method(method, self.term_accessors[method.to_sym])
-    end
-  end
-
   def method_missing method, *args, &block
     if self.term_accessors[method.to_sym]
       define_term_method(method, self.term_accessors[method.to_sym])

data/lib/nom/xml/term.rb

@@ -16,6 +16,10 @@ module Nom::XML
     # @attr [Hash] options
     # @yield 
     def initialize parent, name, options = {}, *args, &block
+      if Nokogiri::XML::Node.instance_methods.include?(name.to_sym)
+        raise "Unable to redefine method #{name} on Nokogiri::XML::Node"
+      end
+
       @name = name
       @terms = {}
       @parent = parent

data/lib/nom/xml/version.rb

@@ -1,5 +1,5 @@
 module Nom
   module XML
-    VERSION = '0.5.4'
+    VERSION = '0.6.0'
   end
 end

data/spec/examples/mods_example_spec.rb

@@ -13,7 +13,7 @@ describe "Namespaces example" do
 
       t.author :path => '//mods:name' do |n|
         n.authorityURI :path => '@authorityURI', :accessor => lambda { |e| e.text }
-        n.description :path => 'mods:description', :override => true
+        n.mods_description :path => 'mods:description'
         n.valueURI :path => '@valueURI'
         n.namePart :path => 'mods:namePart', :single => true, :index_as => [:type_1]
       end
@@ -39,10 +39,6 @@ describe "Namespaces example" do
      xml
   }
 
-  it "should work with existing reserved method names when override is present" do
-    expect(subject.author.first.description.text).to include('asdf')
-  end
-
   it "should return nodesets by default" do
     expect(subject.personal_authors).to be_a_kind_of(Nokogiri::XML::NodeSet)
   end

data/spec/lib/terminology_decorator_spec.rb

@@ -32,23 +32,6 @@ describe "Nutrition" do
      xml
   }
 
-  describe "#add_terminology_method_overrides!" do
-
-    it "should warn you if you try to override already existing methods" do
-      pending if defined? JRUBY_VERSION
-      mock_term = {:text => double(:options => {})}
-      allow(document.a.first).to receive(:term_accessors).and_return mock_term
-      expect { document.a.first.add_terminology_method_overrides! }.to raise_error /Trying to redefine/
-    end
-  
-    it "should let you override the warning" do
-      pending if defined? JRUBY_VERSION
-      mock_term = {:text => double(:options => { :override => true } )}
-      allow(document.a.first).to receive(:term_accessors).and_return mock_term
-      expect { document.a.first.add_terminology_method_overrides! }.to_not raise_error
-    end
-  end
-
   describe "#terms" do
 
     context "root element" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nom-xml
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.6.0
 platform: ruby
 authors:
 - Chris Beer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A library to help you tame sprawling XML schemas.
@@ -191,4 +191,3 @@ test_files:
 - spec/lib/terminology_spec.rb
 - spec/spec_helper.rb
 - spec/test_spec.rb
-has_rdoc: