nokolexbor 0.3.4 → 0.3.6

data/ext/nokolexbor/nl_node.c

@@ -51,8 +51,11 @@ nl_rb_node_create(lxb_dom_node_t *node, VALUE rb_document)
   case LXB_DOM_NODE_TYPE_COMMENT:
     rb_class = cNokolexborComment;
     break;
-  // case LXB_DOM_NODE_TYPE_DOCUMENT:
-  //   break;
+  case LXB_DOM_NODE_TYPE_DOCUMENT:
+    if (nl_rb_node_unwrap(rb_document) != node) {
+      rb_raise(rb_eRuntimeError, "Unexpected node type: Document");
+    }
+    return rb_document;
   // case LXB_DOM_NODE_TYPE_DOCUMENT_TYPE:
   //   break;
   case LXB_DOM_NODE_TYPE_DOCUMENT_FRAGMENT:
@@ -81,6 +84,23 @@ nl_rb_node_unwrap(VALUE rb_node)
   return node;
 }
 
+/**
+ * call-seq:
+ *   new(name, document) { |Node| ... } -> Node
+ *
+ * Create a new node with +name+ that belongs to +document+.
+ *
+ * If you intend to add a node to a document tree, it's likely that you will prefer one of the
+ * {Node} methods like {#add_child}, {#add_next_sibling}, {#replace}, etc. which will
+ * both create an element (or subtree) and place it in the document tree.
+ *
+ * Another alternative, if you are concerned about performance, is
+ * {Document#create_element} which accepts additional arguments for contents or
+ * attributes but (like this method) avoids parsing markup.
+ *
+ * @param name [String]
+ * @param document [Document] The document to which the the returned node will belong.
+ */
 static VALUE
 nl_node_new(int argc, VALUE *argv, VALUE klass)
 {
@@ -113,6 +133,11 @@ nl_node_new(int argc, VALUE *argv, VALUE klass)
   return rb_node;
 }
 
+/**
+ * call-seq: attribute(name) → Attribute
+ *
+ * @return [Attribute] The attribute belonging to this node with name +name+.
+ */
 static VALUE
 nl_node_attribute(VALUE self, VALUE rb_name)
 {
@@ -130,11 +155,14 @@ nl_node_attribute(VALUE self, VALUE rb_name)
     return Qnil;
   }
   if (attr->owner == NULL) {
-    attr->owner = node;
+    attr->owner = lxb_dom_interface_element(node);
   }
   return nl_rb_node_create(attr, nl_rb_document_get(self));
 }
 
+/**
+ * @return [Array<Attribute>] An array of {Attribute} belonging to this node.
+ */
 static VALUE
 nl_node_attribute_nodes(VALUE self)
 {
@@ -153,7 +181,7 @@ nl_node_attribute_nodes(VALUE self)
   VALUE rb_doc = nl_rb_document_get(self);
   while (attr != NULL) {
     if (attr->owner == NULL) {
-      attr->owner = node;
+      attr->owner = lxb_dom_interface_element(node);
     }
     rb_ary_push(ary, nl_rb_node_create(attr, rb_doc));
     attr = attr->next;
@@ -162,6 +190,11 @@ nl_node_attribute_nodes(VALUE self)
   return ary;
 }
 
+/**
+ * @return [String]
+ *   Contents of all the text nodes in this node's subtree, concatenated together into a single
+ *   String.
+ */
 static VALUE
 nl_node_content(VALUE self)
 {
@@ -178,6 +211,12 @@ nl_node_content(VALUE self)
   return rb_str;
 }
 
+/**
+ * Set the Node's content to a Text node containing +content+. The string gets XML escaped, not
+ * interpreted as markup.
+ *
+ * @return [String] +content+
+ */
 static VALUE
 nl_node_content_set(VALUE self, VALUE content)
 {
@@ -192,6 +231,15 @@ nl_node_content_set(VALUE self, VALUE content)
   return content;
 }
 
+/**
+ * call-seq: [](name) -> String,nil
+ *
+ * Fetch an attribute from this node.
+ *
+ * @param name The name of the attribute.
+ *
+ * @return (String, nil) The value of the attribute +name+, or +nil+ if no matching attribute exists.
+ */
 static VALUE
 nl_node_get_attr(VALUE self, VALUE rb_attr)
 {
@@ -217,6 +265,16 @@ nl_node_get_attr(VALUE self, VALUE rb_attr)
   return rb_utf8_str_new((const char *)attr_value, attr_value_len);
 }
 
+/**
+ * call-seq: []=(name, value) -> String,nil
+ *
+ * Update the attribute +name+ to +value+, or create the attribute if it does not exist.
+ *
+ * @param name The name of the attribute.
+ * @param value The value of the attribute.
+ *
+ * @return [String] +value+
+ */
 static VALUE
 nl_node_set_attr(VALUE self, VALUE rb_attr, VALUE rb_value)
 {
@@ -241,13 +299,22 @@ nl_node_set_attr(VALUE self, VALUE rb_attr, VALUE rb_value)
   return rb_value;
 }
 
+/**
+ * call-seq: remove_attr(name) -> Boolean
+ *
+ * Remove the attribute named +name+.
+ *
+ * @param name [String]
+ *
+ * @return [Boolean] +true+ if removal success, +false+ if node is not an {Element}.
+ */
 static VALUE
 nl_node_remove_attr(VALUE self, VALUE rb_attr)
 {
   lxb_dom_node_t *node = nl_rb_node_unwrap(self);
 
   if (node->type != LXB_DOM_NODE_TYPE_ELEMENT) {
-    return Qnil;
+    return Qfalse;
   }
 
   VALUE rb_attr_s = rb_String(rb_attr);
@@ -257,7 +324,12 @@ nl_node_remove_attr(VALUE self, VALUE rb_attr)
 
   lxb_dom_element_t *element = lxb_dom_interface_element(node);
 
-  return lxb_dom_element_remove_attribute(element, (const lxb_char_t *)attr_c, attr_len) == LXB_STATUS_OK ? Qtrue : Qfalse;
+  lxb_status_t status = lxb_dom_element_remove_attribute(element, (const lxb_char_t *)attr_c, attr_len);
+  if (status != LXB_STATUS_OK) {
+    nl_raise_lexbor_error(status);
+  }
+
+  return Qtrue;
 }
 
 lxb_status_t
@@ -311,7 +383,6 @@ nl_node_find(VALUE self, VALUE selector, lxb_selectors_cb_f cb, void *ctx)
   }
 
   /* Parse and get the log. */
-  // TODO: Cache the list for reuse, improves performance
   list = lxb_css_selectors_parse_relative_list(parser, (const lxb_char_t *)selector_c, selector_len);
   if (parser->status != LXB_STATUS_OK) {
     status = parser->status;
@@ -384,6 +455,11 @@ void nl_sort_nodes_if_necessary(VALUE selector, lxb_dom_document_t *doc, lexbor_
   }
 }
 
+/**
+ * Internal implementation of {#at_css}
+ *
+ * @see #at_css
+ */
 static VALUE
 nl_node_at_css(VALUE self, VALUE selector)
 {
@@ -411,6 +487,11 @@ nl_node_at_css(VALUE self, VALUE selector)
   return ret;
 }
 
+/**
+ * Internal implementation of {#css}
+ *
+ * @see #css
+ */
 static VALUE
 nl_node_css(VALUE self, VALUE selector)
 {
@@ -428,6 +509,11 @@ nl_node_css(VALUE self, VALUE selector)
   return nl_rb_node_set_create_with_data(array, nl_rb_document_get(self));
 }
 
+/**
+ * Get the inner_html of this Node.
+ *
+ * @return [String]
+ */
 static VALUE
 nl_node_inner_html(int argc, VALUE *argv, VALUE self)
 {
@@ -465,6 +551,11 @@ nl_node_inner_html(int argc, VALUE *argv, VALUE self)
   return Qnil;
 }
 
+/**
+ * Serialize this Node to HTML, also known as outer_html.
+ *
+ * @return [String]
+ */
 static VALUE
 nl_node_outer_html(int argc, VALUE *argv, VALUE self)
 {
@@ -502,6 +593,11 @@ nl_node_outer_html(int argc, VALUE *argv, VALUE self)
   return Qnil;
 }
 
+/**
+ * call-seq: key?(name) -> Boolean
+ *
+ * @return true if +name+ is set.
+ */
 static VALUE
 nl_node_has_key(VALUE self, VALUE rb_attr)
 {
@@ -520,6 +616,11 @@ nl_node_has_key(VALUE self, VALUE rb_attr)
   return lxb_dom_element_has_attribute(element, (const lxb_char_t *)attr_c, attr_len) ? Qtrue : Qfalse;
 }
 
+/**
+ * Get the attribute names of this Node.
+ *
+ * @return [Array<String>] An array of attribute names.
+ */
 static VALUE
 nl_node_keys(VALUE self)
 {
@@ -543,6 +644,11 @@ nl_node_keys(VALUE self)
   return ary_keys;
 }
 
+/**
+ * Get the attribute values of this Node.
+ *
+ * @return [Array<String>] An array of attribute values.
+ */
 static VALUE
 nl_node_values(VALUE self)
 {
@@ -570,6 +676,11 @@ nl_node_values(VALUE self)
   return ary_values;
 }
 
+/**
+ * Get a hash of attribute names and values of this Node.
+ *
+ * @return [Hash{String => String}] A hash whose keys are attribute names and values are attribute values.
+ */
 static VALUE
 nl_node_attrs(VALUE self)
 {
@@ -598,6 +709,11 @@ nl_node_attrs(VALUE self)
   return rb_hash;
 }
 
+/**
+ * Get the parent node.
+ *
+ * @return [Node,nil] The parent node
+ */
 static VALUE
 nl_node_parent(VALUE self)
 {
@@ -605,6 +721,11 @@ nl_node_parent(VALUE self)
   return node->parent ? nl_rb_node_create(node->parent, nl_rb_document_get(self)) : Qnil;
 }
 
+/**
+ * Get the previous sibling node.
+ *
+ * @return [Node,nil] The previous sibling node
+ */
 static VALUE
 nl_node_previous(VALUE self)
 {
@@ -612,6 +733,11 @@ nl_node_previous(VALUE self)
   return node->prev ? nl_rb_node_create(node->prev, nl_rb_document_get(self)) : Qnil;
 }
 
+/**
+ * Get the previous sibling element.
+ *
+ * @return [Element,nil] The previous sibling element
+ */
 static VALUE
 nl_node_previous_element(VALUE self)
 {
@@ -625,6 +751,11 @@ nl_node_previous_element(VALUE self)
   return Qnil;
 }
 
+/**
+ * Get the next sibling node.
+ *
+ * @return [Node,nil] The previous sibling node
+ */
 static VALUE
 nl_node_next(VALUE self)
 {
@@ -632,6 +763,11 @@ nl_node_next(VALUE self)
   return node->next ? nl_rb_node_create(node->next, nl_rb_document_get(self)) : Qnil;
 }
 
+/**
+ * Get the next sibling element.
+ *
+ * @return [Element,nil] The previous sibling element
+ */
 static VALUE
 nl_node_next_element(VALUE self)
 {
@@ -645,6 +781,11 @@ nl_node_next_element(VALUE self)
   return Qnil;
 }
 
+/**
+ * Get the children of this node.
+ *
+ * @return [NodeSet] The set of this node's children.
+ */
 static VALUE
 nl_node_children(VALUE self)
 {
@@ -660,6 +801,11 @@ nl_node_children(VALUE self)
   return nl_rb_node_set_create_with_data(array, nl_rb_document_get(self));
 }
 
+/**
+ * Get the first child of this node.
+ *
+ * @return [Node,nil] The first child.
+ */
 static VALUE
 nl_node_child(VALUE self)
 {
@@ -668,14 +814,26 @@ nl_node_child(VALUE self)
   return child ? nl_rb_node_create(child, nl_rb_document_get(self)) : Qnil;
 }
 
+/**
+ * Remove this node from its current context.
+ *
+ * @return [Node] +self+, to support chaining of calls.
+ */
 static VALUE
 nl_node_remove(VALUE self)
 {
   lxb_dom_node_t *node = nl_rb_node_unwrap(self);
   lxb_dom_node_remove(node);
-  return Qnil;
+  return self;
 }
 
+/**
+ * Remove this node from its current context and free its allocated memory.
+ *
+ * @return [nil]
+ *
+ * @see #remove
+ */
 static VALUE
 nl_node_destroy(VALUE self)
 {
@@ -684,6 +842,9 @@ nl_node_destroy(VALUE self)
   return Qnil;
 }
 
+/**
+ * @return [Boolean] true if this Node is equal to +other+.
+ */
 static VALUE
 nl_node_equals(VALUE self, VALUE other)
 {
@@ -702,6 +863,11 @@ lxb_dom_node_name_qualified(lxb_dom_node_t *node, size_t *len)
   return lxb_dom_node_name(node, len);
 }
 
+/**
+ * Get the name of this Node
+ *
+ * @return [String] The name of this Node
+ */
 static VALUE
 nl_node_name(VALUE self)
 {
@@ -733,6 +899,13 @@ nl_node_parse_fragment(lxb_dom_document_t *doc, lxb_dom_element_t *element, lxb_
   return frag_root;
 }
 
+/**
+ * Parse +html+ as a document fragment within the context of
+ * *this* node.
+ *
+ * @param html [String] The fragment to be parsed.
+ * @return [NodeSet] The {NodeSet} containing the parsed nodes.
+ */
 static VALUE
 nl_node_parse(VALUE self, VALUE html)
 {
@@ -752,38 +925,48 @@ nl_node_parse(VALUE self, VALUE html)
   return nl_rb_node_set_create_with_data(array, nl_rb_document_get(self));
 }
 
+typedef void (*lxb_dom_node_add_nodes_to_f)(lxb_dom_node_t *, lxb_dom_node_t *);
+
 static VALUE
-nl_node_add_sibling(VALUE self, VALUE next_or_previous, VALUE new)
+nl_node_add_nodes(VALUE self, VALUE new, lxb_dom_node_add_nodes_to_f add_to, bool operate_on_new_node)
 {
   lxb_dom_node_t *node = nl_rb_node_unwrap(self);
   lxb_dom_document_t *doc = node->owner_document;
 
-  int insert_after;
-  if (rb_eql(rb_String(next_or_previous), rb_str_new_literal("next"))) {
-    insert_after = 1;
-  } else if (rb_eql(rb_String(next_or_previous), rb_str_new_literal("previous"))) {
-    insert_after = 0;
-  } else {
-    rb_raise(rb_eArgError, "Unsupported inserting position");
-  }
-
-  if (TYPE(new) == T_STRING) {
-    lxb_dom_node_t *frag_root = nl_node_parse_fragment(doc, NULL, (lxb_char_t *)RSTRING_PTR(new), RSTRING_LEN(new));
+  if (TYPE(new) == T_STRING || rb_obj_is_kind_of(new, cNokolexborDocumentFragment)) {
+    lxb_dom_node_t *frag_root = (TYPE(new) == T_STRING) ? nl_node_parse_fragment(doc, NULL, (lxb_char_t *)RSTRING_PTR(new), RSTRING_LEN(new))
+                                                        : nl_rb_node_unwrap(new);
     lexbor_array_t *array = lexbor_array_create();
 
+    lxb_dom_node_t *last_node = node;
     while (frag_root->first_child != NULL) {
       lxb_dom_node_t *child = frag_root->first_child;
       lxb_dom_node_remove(child);
-      insert_after ? lxb_dom_node_insert_after(node, child) : lxb_dom_node_insert_before(node, child);
+      operate_on_new_node ? add_to(last_node, child) : add_to(node, child);
+      last_node = child;
       lexbor_array_push(array, child);
     }
-    lxb_dom_node_destroy(frag_root);
+    if (TYPE(new) == T_STRING) {
+      lxb_dom_node_destroy(frag_root);
+    }
     return nl_rb_node_set_create_with_data(array, nl_rb_document_get(self));
 
+  } else if (rb_obj_is_kind_of(new, cNokolexborNodeSet)) {
+    lexbor_array_t *node_array = nl_rb_node_set_unwrap(new);
+
+    lxb_dom_node_t *last_node = node;
+    for (size_t i = 0; i < node_array->length; i++) {
+      lxb_dom_node_t *child = (lxb_dom_node_t *)node_array->list[i];
+      lxb_dom_node_remove(child);
+      operate_on_new_node ? add_to(last_node, child) : add_to(node, child);
+      last_node = child;
+    }
+    return new;
+
   } else if (rb_obj_is_kind_of(new, cNokolexborNode)) {
     lxb_dom_node_t *node_new = nl_rb_node_unwrap(new);
     lxb_dom_node_remove(node_new);
-    insert_after ? lxb_dom_node_insert_after(node, node_new) : lxb_dom_node_insert_before(node, node_new);
+    add_to(node, node_new);
     return new;
 
   } else {
@@ -792,43 +975,57 @@ nl_node_add_sibling(VALUE self, VALUE next_or_previous, VALUE new)
   return Qnil;
 }
 
+/**
+ * Insert +node_or_tags+ before or after this Node (as a sibling).
+ *
+ * @see #add_previous_sibling
+ * @see #add_next_sibling
+ *
+ * @return [Node,NodeSet] The reparented {Node} (if +node_or_tags+ is a {Node}), or {NodeSet} (if +node_or_tags+ is a {DocumentFragment}, {NodeSet}, or {String}).
+ */
 static VALUE
-nl_node_add_child(VALUE self, VALUE new)
+nl_node_add_sibling(VALUE self, VALUE next_or_previous, VALUE new)
 {
-  lxb_dom_node_t *node = nl_rb_node_unwrap(self);
-  lxb_dom_document_t *doc = node->owner_document;
-
-  if (TYPE(new) == T_STRING) {
-    lxb_dom_node_t *frag_root = nl_node_parse_fragment(doc, NULL, (lxb_char_t *)RSTRING_PTR(new), RSTRING_LEN(new));
-    lexbor_array_t *array = lexbor_array_create();
-
-    while (frag_root->first_child != NULL) {
-      lxb_dom_node_t *child = frag_root->first_child;
-      lxb_dom_node_remove(child);
-      lxb_dom_node_insert_child(node, child);
-      lexbor_array_push(array, child);
-    }
-    lxb_dom_node_destroy(frag_root);
-    return nl_rb_node_set_create_with_data(array, nl_rb_document_get(self));
-
-  } else if (rb_obj_is_kind_of(new, cNokolexborNode)) {
-    lxb_dom_node_t *node_new = nl_rb_node_unwrap(new);
-    lxb_dom_node_remove(node_new);
-    lxb_dom_node_insert_child(node, node_new);
-    return new;
-
+  bool insert_after;
+  if (rb_eql(rb_String(next_or_previous), rb_str_new_literal("next"))) {
+    insert_after = true;
+  } else if (rb_eql(rb_String(next_or_previous), rb_str_new_literal("previous"))) {
+    insert_after = false;
   } else {
-    rb_raise(rb_eArgError, "Unsupported node type");
+    rb_raise(rb_eArgError, "Unsupported inserting position");
   }
-  return Qnil;
+
+  return insert_after ? nl_node_add_nodes(self, new, lxb_dom_node_insert_after, true)
+                      : nl_node_add_nodes(self, new, lxb_dom_node_insert_before, false);
+}
+
+/**
+ * Add +new+ as a child of this Node.
+ *
+ * @param new [Node, DocumentFragment, NodeSet, String] The node to be added.
+ *
+ * @return [Node,NodeSet] The reparented {Node} (if +new+ is a {Node}), or {NodeSet} (if +new+ is a {DocumentFragment}, {NodeSet}, or {String}).
+ */
+static VALUE
+nl_node_add_child(VALUE self, VALUE new)
+{
+  return nl_node_add_nodes(self, new, lxb_dom_node_insert_child, false);
 }
 
+/**
+ * Get the type of this Node
+ *
+ * @return {Integer}
+ */
 static VALUE
 nl_node_get_type(VALUE self)
 {
   return INT2NUM(nl_rb_node_unwrap(self)->type);
 }
 
+/**
+ * @return [Element] The first child Node that is an element.
+ */
 static VALUE
 nl_node_first_element_child(VALUE self)
 {
@@ -856,6 +1053,9 @@ nl_node_first_element_child(VALUE self)
   return Qnil;
 }
 
+/**
+ * @return [Element] The last child Node that is an element.
+ */
 static VALUE
 nl_node_last_element_child(VALUE self)
 {
@@ -883,6 +1083,11 @@ nl_node_last_element_child(VALUE self)
   return Qnil;
 }
 
+/**
+ * Copy this node.
+ *
+ * @return [Node] The new {Node}.
+ */
 static VALUE
 nl_node_clone(VALUE self)
 {
@@ -891,9 +1096,9 @@ nl_node_clone(VALUE self)
 
   switch (node->type) {
   case LXB_DOM_NODE_TYPE_ATTRIBUTE:
-    clone = lxb_dom_attr_interface_clone(node->owner_document, lxb_dom_interface_attr(node));
+    clone = (lxb_dom_node_t *)lxb_dom_attr_interface_clone(node->owner_document, lxb_dom_interface_attr(node));
   case LXB_DOM_NODE_TYPE_CDATA_SECTION:
-    clone = lxb_dom_cdata_section_interface_clone(node->owner_document, lxb_dom_interface_cdata_section(node));
+    clone = (lxb_dom_node_t *)lxb_dom_cdata_section_interface_clone(node->owner_document, lxb_dom_interface_cdata_section(node));
   default:
     clone = lxb_dom_node_clone(node, true);
     break;

data/ext/nokolexbor/nl_node_set.c

@@ -63,12 +63,27 @@ nl_rb_node_set_create_with_data(lexbor_array_t *array, VALUE rb_document)
   return ret;
 }
 
+/**
+ * Get the length of this NodeSet.
+ *
+ * @return [Integer]
+ */
 static VALUE
 nl_node_set_length(VALUE self)
 {
   return INT2NUM(nl_rb_node_set_unwrap(self)->length);
 }
 
+/**
+ * call-seq:
+ *   push(node)
+ *
+ * Append +node+ to the NodeSet.
+ *
+ * @param node [Node]
+ *
+ * @return [NodeSet] +self+, to support chaining of calls.
+ */
 static VALUE
 nl_node_set_push(VALUE self, VALUE rb_node)
 {
@@ -83,6 +98,16 @@ nl_node_set_push(VALUE self, VALUE rb_node)
   return self;
 }
 
+/**
+ *  call-seq:
+ *    delete(node)
+ *
+ * Delete +node+ from the NodeSet.
+ *
+ * @param node [Node]
+ *
+ * @return [Node,nil] The deleted node if found, otherwise returns nil.
+ */
 static VALUE
 nl_node_set_delete(VALUE self, VALUE rb_node)
 {
@@ -103,6 +128,12 @@ nl_node_set_delete(VALUE self, VALUE rb_node)
   return rb_node;
 }
 
+/**
+ * call-seq:
+ *   include?(node)
+ *
+ * @return true if any member of this NodeSet equals +node+.
+ */
 static VALUE
 nl_node_set_is_include(VALUE self, VALUE rb_node)
 {
@@ -166,6 +197,18 @@ nl_node_set_subseq(VALUE self, long beg, long len)
   return nl_rb_node_set_create_with_data(new_array, nl_rb_document_get(self));
 }
 
+/**
+ * call-seq:
+ *   [](index) -> Node,nil
+ *   [](start, length) -> NodeSet,nil
+ *   [](range) -> NodeSet,nil
+ *
+ * @return [Node,NodeSet,nil] the {Node} at +index+, or returns a {NodeSet}
+ *   containing nodes starting at +start+ and continuing for +length+ elements, or
+ *   returns a {NodeSet} containing nodes specified by +range+. Negative +indices+
+ *   count backward from the end of the +node_set+ (-1 is the last node). Returns
+ *   nil if the +index+ (or +start+) are out of range.
+ */
 static VALUE
 nl_node_set_slice(int argc, VALUE *argv, VALUE self)
 {
@@ -205,6 +248,9 @@ nl_node_set_slice(int argc, VALUE *argv, VALUE self)
   return nl_node_set_index_at(self, NUM2LONG(arg));
 }
 
+/**
+ * @return [Array<Node>] This list as an Array
+ */
 static VALUE
 nl_node_set_to_array(VALUE self)
 {
@@ -221,6 +267,9 @@ nl_node_set_to_array(VALUE self)
   return list;
 }
 
+/**
+ * @return [NodeSet] A new set built by merging the +other+ set, excluding duplicates.
+ */
 static VALUE
 nl_node_set_union(VALUE self, VALUE other)
 {
@@ -301,6 +350,9 @@ nl_node_set_find(VALUE self, VALUE selector, lxb_selectors_cb_f cb, void *ctx)
   return status;
 }
 
+/**
+ * (see Node#at_css)
+ */
 static VALUE
 nl_node_set_at_css(VALUE self, VALUE selector)
 {
@@ -328,6 +380,9 @@ nl_node_set_at_css(VALUE self, VALUE selector)
   return ret;
 }
 
+/**
+ * (see Node#css)
+ */
 static VALUE
 nl_node_set_css(VALUE self, VALUE selector)
 {
@@ -353,7 +408,6 @@ void Init_nl_node_set(void)
 
   rb_define_method(cNokolexborNodeSet, "length", nl_node_set_length, 0);
   rb_define_method(cNokolexborNodeSet, "[]", nl_node_set_slice, -1);
-  rb_define_method(cNokolexborNodeSet, "slice", nl_node_set_slice, -1);
   rb_define_method(cNokolexborNodeSet, "push", nl_node_set_push, 1);
   rb_define_method(cNokolexborNodeSet, "|", nl_node_set_union, 1);
   rb_define_method(cNokolexborNodeSet, "to_a", nl_node_set_to_array, 0);
@@ -362,6 +416,7 @@ void Init_nl_node_set(void)
   rb_define_method(cNokolexborNodeSet, "at_css", nl_node_set_at_css, 1);
   rb_define_method(cNokolexborNodeSet, "css", nl_node_set_css, 1);
 
+  rb_define_alias(cNokolexborNodeSet, "slice", "[]");
   rb_define_alias(cNokolexborNodeSet, "<<", "push");
   rb_define_alias(cNokolexborNodeSet, "size", "length");
   rb_define_alias(cNokolexborNodeSet, "+", "|");