nokolexbor 0.2.6 → 0.3.2

data/ext/nokolexbor/nl_node_set.c

@@ -55,8 +55,7 @@ nl_node_set_allocate(VALUE klass)
 VALUE
 nl_rb_node_set_create_with_data(lexbor_array_t *array, VALUE rb_document)
 {
-  if (array == NULL)
-  {
+  if (array == NULL) {
     array = lexbor_array_create();
   }
   VALUE ret = TypedData_Wrap_Struct(cNokolexborNodeSet, &nl_node_set_type, array);
@@ -77,8 +76,7 @@ nl_node_set_push(VALUE self, VALUE rb_node)
   lxb_dom_node_t *node = nl_rb_node_unwrap(rb_node);
 
   lxb_status_t status = lexbor_array_push_unique(array, node);
-  if (status != LXB_STATUS_OK && status != LXB_STATUS_STOPPED)
-  {
+  if (status != LXB_STATUS_OK && status != LXB_STATUS_STOPPED) {
     nl_raise_lexbor_error(status);
   }
 
@@ -93,13 +91,11 @@ nl_node_set_delete(VALUE self, VALUE rb_node)
 
   size_t i;
   for (i = 0; i < array->length; i++)
-    if (array->list[i] == node)
-    {
+    if (array->list[i] == node) {
       break;
     }
 
-  if (i >= array->length)
-  {
+  if (i >= array->length) {
     // not found
     return Qnil;
   }
@@ -114,8 +110,7 @@ nl_node_set_is_include(VALUE self, VALUE rb_node)
   lxb_dom_node_t *node = nl_rb_node_unwrap(rb_node);
 
   for (size_t i = 0; i < array->length; i++)
-    if (array->list[i] == node)
-    {
+    if (array->list[i] == node) {
       return Qtrue;
     }
 
@@ -126,13 +121,11 @@ static VALUE
 nl_node_set_index_at(VALUE self, long offset)
 {
   lexbor_array_t *array = nl_rb_node_set_unwrap(self);
-  if (offset >= (long)array->length || abs((int)offset) > (long)array->length)
-  {
+  if (offset >= (long)array->length || abs((int)offset) > (long)array->length) {
     return Qnil;
   }
 
-  if (offset < 0)
-  {
+  if (offset < 0) {
     offset += array->length;
   }
 
@@ -145,35 +138,28 @@ nl_node_set_subseq(VALUE self, long beg, long len)
 {
   lexbor_array_t *old_array = nl_rb_node_set_unwrap(self);
 
-  if (beg > (long)old_array->length)
-  {
+  if (beg > (long)old_array->length) {
     return Qnil;
   }
-  if (beg < 0 || len < 0)
-  {
+  if (beg < 0 || len < 0) {
     return Qnil;
   }
 
-  if ((beg + len) > (long)old_array->length)
-  {
+  if ((beg + len) > (long)old_array->length) {
     len = old_array->length - beg;
   }
 
   lexbor_array_t *new_array = lexbor_array_create();
-  if (len > 0)
-  {
+  if (len > 0) {
     lxb_status_t status = lexbor_array_init(new_array, len);
-    if (status != LXB_STATUS_OK)
-    {
+    if (status != LXB_STATUS_OK) {
       nl_raise_lexbor_error(status);
     }
   }
 
-  for (long j = beg; j < beg + len; ++j)
-  {
+  for (long j = beg; j < beg + len; ++j) {
     lxb_status_t status = lexbor_array_push(new_array, old_array->list[j]);
-    if (status != LXB_STATUS_OK)
-    {
+    if (status != LXB_STATUS_OK) {
       nl_raise_lexbor_error(status);
     }
   }
@@ -188,31 +174,26 @@ nl_node_set_slice(int argc, VALUE *argv, VALUE self)
 
   lexbor_array_t *array = nl_rb_node_set_unwrap(self);
 
-  if (argc == 2)
-  {
+  if (argc == 2) {
     beg = NUM2LONG(argv[0]);
     len = NUM2LONG(argv[1]);
-    if (beg < 0)
-    {
+    if (beg < 0) {
       beg += array->length;
     }
     return nl_node_set_subseq(self, beg, len);
   }
 
-  if (argc != 1)
-  {
+  if (argc != 1) {
     rb_scan_args(argc, argv, "11", NULL, NULL);
   }
   arg = argv[0];
 
-  if (FIXNUM_P(arg))
-  {
+  if (FIXNUM_P(arg)) {
     return nl_node_set_index_at(self, FIX2LONG(arg));
   }
 
   /* if arg is Range */
-  switch (rb_range_beg_len(arg, &beg, &len, array->length, 0))
-  {
+  switch (rb_range_beg_len(arg, &beg, &len, array->length, 0)) {
   case Qfalse:
     break;
   case Qnil:
@@ -231,8 +212,7 @@ nl_node_set_to_array(VALUE self)
 
   VALUE list = rb_ary_new2(array->length);
   VALUE doc = nl_rb_document_get(self);
-  for (size_t i = 0; i < array->length; i++)
-  {
+  for (size_t i = 0; i < array->length; i++) {
     lxb_dom_node_t *node = (lxb_dom_node_t *)array->list[i];
     VALUE rb_node = nl_rb_node_create(node, doc);
     rb_ary_push(list, rb_node);
@@ -244,31 +224,27 @@ nl_node_set_to_array(VALUE self)
 static VALUE
 nl_node_set_union(VALUE self, VALUE other)
 {
-  if (!rb_obj_is_kind_of(other, cNokolexborNodeSet))
-  {
+  if (!rb_obj_is_kind_of(other, cNokolexborNodeSet)) {
     rb_raise(rb_eArgError, "Parameter must be a Nokolexbor::NodeSet");
   }
 
   lexbor_array_t *self_array = nl_rb_node_set_unwrap(self);
   lexbor_array_t *other_array = nl_rb_node_set_unwrap(other);
 
-  if (self_array->length + other_array->length == 0)
-  {
+  if (self_array->length + other_array->length == 0) {
     return nl_rb_node_set_create_with_data(NULL, nl_rb_document_get(self));
   }
 
   lexbor_array_t *new_array = lexbor_array_create();
   lxb_status_t status = lexbor_array_init(new_array, self_array->length + other_array->length);
-  if (status != LXB_STATUS_OK)
-  {
+  if (status != LXB_STATUS_OK) {
     nl_raise_lexbor_error(status);
   }
 
   memcpy(new_array->list, self_array->list, sizeof(lxb_dom_node_t *) * self_array->length);
   new_array->length = self_array->length;
 
-  for (size_t i = 0; i < other_array->length; i++)
-  {
+  for (size_t i = 0; i < other_array->length; i++) {
     lexbor_array_push_unique(new_array, other_array->list[i]);
   }
 
@@ -279,40 +255,33 @@ static lxb_status_t
 nl_node_set_find(VALUE self, VALUE selector, lxb_selectors_cb_f cb, void *ctx)
 {
   lxb_dom_document_t *doc = nl_rb_document_unwrap(nl_rb_document_get(self));
-  if (doc == NULL)
-  {
+  if (doc == NULL) {
     rb_raise(rb_eRuntimeError, "Error getting document");
   }
   // Wrap direct children with a temporary fragment so that they can be searched
   lxb_dom_document_fragment_t *frag = lxb_dom_document_fragment_interface_create(doc);
-  if (frag == NULL)
-  {
+  if (frag == NULL) {
     rb_raise(rb_eRuntimeError, "Error creating document fragment");
   }
   lexbor_array_t *array = nl_rb_node_set_unwrap(self);
 
   lexbor_array_t *backup_array = lexbor_array_create();
-  if (array->length > 0)
-  {
+  if (array->length > 0) {
     lxb_status_t status = lexbor_array_init(backup_array, array->length);
-    if (status != LXB_STATUS_OK)
-    {
+    if (status != LXB_STATUS_OK) {
       nl_raise_lexbor_error(status);
     }
   }
   // Backup original node data and re-group them into a fragment
-  for (size_t i = 0; i < array->length; i++)
-  {
+  for (size_t i = 0; i < array->length; i++) {
     lxb_dom_node_t *node = (lxb_dom_node_t *)array->list[i];
     lxb_dom_node_t *backup_node = malloc(sizeof(lxb_dom_node_t));
-    if (backup_node == NULL)
-    {
+    if (backup_node == NULL) {
       nl_raise_lexbor_error(LXB_STATUS_ERROR_MEMORY_ALLOCATION);
     }
     memcpy(backup_node, node, sizeof(lxb_dom_node_t));
     lxb_status_t status = lexbor_array_push(backup_array, backup_node);
-    if (status != LXB_STATUS_OK)
-    {
+    if (status != LXB_STATUS_OK) {
       nl_raise_lexbor_error(LXB_STATUS_ERROR_MEMORY_ALLOCATION);
     }
     lxb_dom_node_insert_child(&frag->node, node);
@@ -323,8 +292,7 @@ nl_node_set_find(VALUE self, VALUE selector, lxb_selectors_cb_f cb, void *ctx)
 
   lxb_dom_document_fragment_interface_destroy(frag);
   // Restore original node data
-  for (size_t i = 0; i < array->length; i++)
-  {
+  for (size_t i = 0; i < array->length; i++) {
     memcpy(array->list[i], backup_array->list[i], sizeof(lxb_dom_node_t));
     free(backup_array->list[i]);
   }
@@ -341,14 +309,12 @@ nl_node_set_at_css(VALUE self, VALUE selector)
 
   lxb_status_t status = nl_node_set_find(self, selector, nl_node_at_css_callback, array);
 
-  if (status != LXB_STATUS_OK)
-  {
+  if (status != LXB_STATUS_OK) {
     lexbor_array_destroy(array, true);
     nl_raise_lexbor_error(status);
   }
 
-  if (array->length == 0)
-  {
+  if (array->length == 0) {
     lexbor_array_destroy(array, true);
     return Qnil;
   }
@@ -369,8 +335,7 @@ nl_node_set_css(VALUE self, VALUE selector)
   lxb_dom_document_t *doc = nl_rb_document_unwrap(nl_rb_document_get(self));
 
   lxb_status_t status = nl_node_set_find(self, selector, nl_node_css_callback, array);
-  if (status != LXB_STATUS_OK)
-  {
+  if (status != LXB_STATUS_OK) {
     lexbor_array_destroy(array, true);
     nl_raise_lexbor_error(status);
   }

data/ext/nokolexbor/nl_text.c

@@ -0,0 +1,44 @@
+#include "nokolexbor.h"
+
+VALUE cNokolexborText;
+extern VALUE cNokolexborCharacterData;
+extern VALUE mNokolexbor;
+
+static VALUE
+nl_text_new(int argc, VALUE *argv, VALUE klass)
+{
+  lxb_dom_document_t *document;
+  VALUE rb_text;
+  VALUE rb_document;
+  VALUE rest;
+
+  rb_scan_args(argc, argv, "2*", &rb_text, &rb_document, &rest);
+
+  if (!rb_obj_is_kind_of(rb_document, cNokolexborDocument)) {
+    rb_raise(rb_eArgError, "Document must be a Nokolexbor::Document");
+  }
+
+  document = nl_rb_document_unwrap(rb_document);
+
+  const char* c_text = StringValuePtr(rb_text);
+  size_t text_len = RSTRING_LEN(rb_text);
+  lxb_dom_text_t *element = lxb_dom_document_create_text_node(document, (const lxb_char_t *)c_text, text_len);
+  if (element == NULL) {
+    rb_raise(rb_eRuntimeError, "Error creating text node");
+  }
+
+  VALUE rb_node = nl_rb_node_create(&element->char_data.node, rb_document);
+
+  if (rb_block_given_p()) {
+    rb_yield(rb_node);
+  }
+
+  return rb_node;
+}
+
+void Init_nl_text(void)
+{
+  cNokolexborText = rb_define_class_under(mNokolexbor, "Text", cNokolexborCharacterData);
+
+  rb_define_singleton_method(cNokolexborText, "new", nl_text_new, -1);
+}

data/ext/nokolexbor/nl_xpath_context.c

@@ -1,11 +1,11 @@
-#include <ruby.h>
-#include <ruby/util.h>
-#include "nokolexbor.h"
 #include "libxml.h"
 #include "libxml/globals.h"
+#include "libxml/parserInternals.h"
 #include "libxml/xpath.h"
 #include "libxml/xpathInternals.h"
-#include "libxml/parserInternals.h"
+#include "nokolexbor.h"
+#include <ruby.h>
+#include <ruby/util.h>
 
 #define RBSTR_OR_QNIL(_str) (_str ? rb_utf8_str_new_cstr(_str) : Qnil)
 
@@ -15,12 +15,110 @@ VALUE cNokolexborXpathContext;
 VALUE mNokolexborXpath;
 VALUE cNokolexborXpathSyntaxError;
 
+static const xmlChar *NOKOGIRI_PREFIX = (const xmlChar *)"nokogiri";
+static const xmlChar *NOKOGIRI_URI = (const xmlChar *)"http://www.nokogiri.org/default_ns/ruby/extensions_functions";
+static const xmlChar *NOKOGIRI_BUILTIN_PREFIX = (const xmlChar *)"nokogiri-builtin";
+static const xmlChar *NOKOGIRI_BUILTIN_URI = (const xmlChar *)"https://www.nokogiri.org/default_ns/ruby/builtins";
+
 static void
 free_xml_xpath_context(xmlXPathContextPtr ctx)
 {
   nl_xmlXPathFreeContext(ctx);
 }
 
+/* find a CSS class in an HTML element's `class` attribute */
+static const xmlChar *
+builtin_css_class(const xmlChar *str, const xmlChar *val)
+{
+  int val_len;
+
+  if (str == NULL) {
+    return (NULL);
+  }
+  if (val == NULL) {
+    return (NULL);
+  }
+
+  val_len = nl_xmlStrlen(val);
+  if (val_len == 0) {
+    return (str);
+  }
+
+  while (*str != 0) {
+    if ((*str == *val) && !nl_xmlStrncmp(str, val, val_len)) {
+      const xmlChar *next_byte = str + val_len;
+
+      /* only match if the next byte is whitespace or end of string */
+      if ((*next_byte == 0) || (IS_BLANK_CH(*next_byte))) {
+        return ((const xmlChar *)str);
+      }
+    }
+
+    /* advance str to whitespace */
+    while ((*str != 0) && !IS_BLANK_CH(*str)) {
+      str++;
+    }
+
+    /* advance str to start of next word or end of string */
+    while ((*str != 0) && IS_BLANK_CH(*str)) {
+      str++;
+    }
+  }
+
+  return (NULL);
+}
+
+/* xmlXPathFunction to wrap builtin_css_class() */
+static void
+xpath_builtin_css_class(xmlXPathParserContextPtr ctxt, int nargs)
+{
+  xmlXPathObjectPtr hay, needle;
+
+  CHECK_ARITY(2);
+
+  CAST_TO_STRING;
+  needle = nl_xmlXPathValuePop(ctxt);
+  if ((needle == NULL) || (needle->type != XPATH_STRING)) {
+    nl_xmlXPathFreeObject(needle);
+    XP_ERROR(XPATH_INVALID_TYPE);
+  }
+
+  CAST_TO_STRING;
+  hay = nl_xmlXPathValuePop(ctxt);
+  if ((hay == NULL) || (hay->type != XPATH_STRING)) {
+    nl_xmlXPathFreeObject(hay);
+    nl_xmlXPathFreeObject(needle);
+    XP_ERROR(XPATH_INVALID_TYPE);
+  }
+
+  if (builtin_css_class(hay->stringval, needle->stringval)) {
+    nl_xmlXPathValuePush(ctxt, nl_xmlXPathNewBoolean(1));
+  } else {
+    nl_xmlXPathValuePush(ctxt, nl_xmlXPathNewBoolean(0));
+  }
+
+  nl_xmlXPathFreeObject(hay);
+  nl_xmlXPathFreeObject(needle);
+}
+
+/* xmlXPathFunction to select nodes whose local name matches, for HTML5 CSS queries that should ignore namespaces */
+static void
+xpath_builtin_local_name_is(xmlXPathParserContextPtr ctxt, int nargs)
+{
+  xmlXPathObjectPtr element_name;
+  size_t tmp_len;
+
+  CHECK_ARITY(1);
+  CAST_TO_STRING;
+  CHECK_TYPE(XPATH_STRING);
+  element_name = nl_xmlXPathValuePop(ctxt);
+
+  const lxb_char_t *node_name = lxb_dom_node_name_qualified(ctxt->context->node, &tmp_len);
+  nl_xmlXPathValuePush(ctxt, nl_xmlXPathNewBoolean(nl_xmlStrEqual((xmlChar *)node_name, element_name->stringval)));
+
+  nl_xmlXPathFreeObject(element_name);
+}
+
 /*
  * call-seq:
  *  register_ns(prefix, uri)
@@ -34,8 +132,8 @@ nl_xpath_context_register_ns(VALUE self, VALUE prefix, VALUE uri)
   Data_Get_Struct(self, xmlXPathContext, ctx);
 
   nl_xmlXPathRegisterNs(ctx,
-                     (const xmlChar *)StringValueCStr(prefix),
-                     (const xmlChar *)StringValueCStr(uri));
+                        (const xmlChar *)StringValueCStr(prefix),
+                        (const xmlChar *)StringValueCStr(uri));
   return self;
 }
 
@@ -55,8 +153,8 @@ nl_xpath_context_register_variable(VALUE self, VALUE name, VALUE value)
   xmlValue = nl_xmlXPathNewCString(StringValueCStr(value));
 
   nl_xmlXPathRegisterVariable(ctx,
-                           (const xmlChar *)StringValueCStr(name),
-                           xmlValue);
+                              (const xmlChar *)StringValueCStr(name),
+                              xmlValue);
 
   return self;
 }
@@ -70,28 +168,23 @@ xpath2ruby(xmlXPathObjectPtr c_xpath_object, xmlXPathContextPtr ctx, VALUE rb_do
 {
   VALUE rb_retval;
 
-  switch (c_xpath_object->type)
-  {
+  switch (c_xpath_object->type) {
   case XPATH_STRING:
     rb_retval = rb_utf8_str_new_cstr((const char *)c_xpath_object->stringval);
     nl_xmlFree(c_xpath_object->stringval);
     return rb_retval;
 
-  case XPATH_NODESET:
-  {
-    if (c_xpath_object->nodesetval == NULL)
-    {
+  case XPATH_NODESET: {
+    if (c_xpath_object->nodesetval == NULL) {
       return nl_rb_node_set_create_with_data(NULL, rb_document);
     }
-    if (c_xpath_object->nodesetval->nodeNr == 0)
-    {
+    if (c_xpath_object->nodesetval->nodeNr == 0) {
       return nl_rb_node_set_create_with_data(NULL, rb_document);
     }
 
     lexbor_array_t *array = lexbor_array_create();
     lxb_status_t status = lexbor_array_init(array, c_xpath_object->nodesetval->nodeNr);
-    if (status != LXB_STATUS_OK)
-    {
+    if (status != LXB_STATUS_OK) {
       nl_raise_lexbor_error(status);
     }
     memcpy(array->list, c_xpath_object->nodesetval->nodeTab, sizeof(lxb_dom_node_t *) * c_xpath_object->nodesetval->nodeNr);
@@ -122,8 +215,7 @@ nl_xpath_wrap_syntax_error(xmlErrorPtr error)
       &msg,
       cNokolexborXpathSyntaxError);
 
-  if (error)
-  {
+  if (error) {
     rb_iv_set(e, "@domain", INT2NUM(error->domain));
     rb_iv_set(e, "@code", INT2NUM(error->code));
     rb_iv_set(e, "@level", INT2NUM((short)error->level));
@@ -182,8 +274,7 @@ nl_xpath_context_evaluate(int argc, VALUE *argv, VALUE self)
 
   Data_Get_Struct(self, xmlXPathContext, ctx);
 
-  if (rb_scan_args(argc, argv, "11", &search_path, &xpath_handler) == 1)
-  {
+  if (rb_scan_args(argc, argv, "11", &search_path, &xpath_handler) == 1) {
     xpath_handler = Qnil;
   }
 
@@ -203,15 +294,13 @@ nl_xpath_context_evaluate(int argc, VALUE *argv, VALUE self)
   nl_xmlSetStructuredErrorFunc(NULL, NULL);
   nl_xmlSetGenericErrorFunc(NULL, NULL);
 
-  if (xpath == NULL)
-  {
+  if (xpath == NULL) {
     nl_xmlXPathFreeObject(xpath);
     rb_exc_raise(rb_ary_entry(errors, 0));
   }
 
   retval = xpath2ruby(xpath, ctx, nl_rb_document_get(self));
-  if (retval == Qundef)
-  {
+  if (retval == Qundef) {
     retval = rb_funcall(cNokolexborNodeSet, rb_intern("new"), 1, rb_ary_new());
   }
 
@@ -237,6 +326,13 @@ nl_xpath_context_new(VALUE klass, VALUE rb_node)
   ctx = nl_xmlXPathNewContext(node->owner_document);
   ctx->node = node;
 
+  nl_xmlXPathRegisterNs(ctx, NOKOGIRI_PREFIX, NOKOGIRI_URI);
+  nl_xmlXPathRegisterNs(ctx, NOKOGIRI_BUILTIN_PREFIX, NOKOGIRI_BUILTIN_URI);
+  nl_xmlXPathRegisterFuncNS(ctx, (const xmlChar *)"css-class", NOKOGIRI_BUILTIN_URI,
+                         xpath_builtin_css_class);
+  nl_xmlXPathRegisterFuncNS(ctx, (const xmlChar *)"local-name-is", NOKOGIRI_BUILTIN_URI,
+                         xpath_builtin_local_name_is);
+
   self = Data_Wrap_Struct(klass, 0, free_xml_xpath_context, ctx);
   rb_iv_set(self, "@document", nl_rb_document_get(rb_node));
 

data/ext/nokolexbor/nokolexbor.c

@@ -2,11 +2,11 @@
 
 VALUE mNokolexbor;
 VALUE eLexborError;
+VALUE eLexborSyntaxError;
 
 void nl_raise_lexbor_error(lxb_status_t error)
 {
-  switch (error)
-  {
+  switch (error) {
   case LXB_STATUS_ERROR:
     rb_raise(eLexborError, "LXB_STATUS_ERROR");
   case LXB_STATUS_ERROR_MEMORY_ALLOCATION:
@@ -30,7 +30,7 @@ void nl_raise_lexbor_error(lxb_status_t error)
   case LXB_STATUS_ERROR_UNEXPECTED_RESULT:
     rb_raise(eLexborError, "LXB_STATUS_ERROR_UNEXPECTED_RESULT");
   case LXB_STATUS_ERROR_UNEXPECTED_DATA:
-    rb_raise(eLexborError, "LXB_STATUS_ERROR_UNEXPECTED_DATA");
+    rb_raise(eLexborSyntaxError, "LXB_STATUS_ERROR_UNEXPECTED_DATA");
   case LXB_STATUS_ERROR_OVERFLOW:
     rb_raise(eLexborError, "LXB_STATUS_ERROR_OVERFLOW");
   case LXB_STATUS_CONTINUE:
@@ -54,10 +54,17 @@ void nl_raise_lexbor_error(lxb_status_t error)
 
 void Init_nokolexbor(void)
 {
+#ifndef NOKOLEXBOR_ASAN
+  lexbor_memory_setup(ruby_xmalloc, ruby_xrealloc, ruby_xcalloc, ruby_xfree);
+#endif
   mNokolexbor = rb_define_module("Nokolexbor");
   eLexborError = rb_define_class_under(mNokolexbor, "LexborError", rb_eStandardError);
+  eLexborSyntaxError = rb_define_class_under(mNokolexbor, "LexborSyntaxError", eLexborError);
   Init_nl_node();
   Init_nl_document();
+  Init_nl_text();
+  Init_nl_comment();
+  Init_nl_cdata();
   Init_nl_node_set();
   Init_nl_xpath_context();
 }

data/ext/nokolexbor/nokolexbor.h

@@ -3,8 +3,8 @@
 
 #include <ruby.h>
 
-#include <lexbor/html/html.h>
 #include <lexbor/css/css.h>
+#include <lexbor/html/html.h>
 #include <lexbor/selectors/selectors.h>
 
 extern VALUE cNokolexborDocument;
@@ -12,6 +12,9 @@ extern VALUE cNokolexborDocument;
 void Init_nl_document(void);
 void Init_nl_node(void);
 void Init_nl_node_set(void);
+void Init_nl_text(void);
+void Init_nl_comment(void);
+void Init_nl_cdata(void);
 void Init_nl_xpath_context(void);
 
 void nl_raise_lexbor_error(lxb_status_t error);
@@ -21,14 +24,13 @@ VALUE nl_rb_node_set_create_with_data(lexbor_array_t *array, VALUE rb_document);
 
 lxb_inline VALUE nl_rb_document_get(VALUE rb_node_or_doc)
 {
-    if (rb_obj_class(rb_node_or_doc) == cNokolexborDocument)
-    {
-        return rb_node_or_doc;
-    }
-    return rb_iv_get(rb_node_or_doc, "@document");
+  if (rb_obj_is_kind_of(rb_node_or_doc, cNokolexborDocument)) {
+    return rb_node_or_doc;
+  }
+  return rb_iv_get(rb_node_or_doc, "@document");
 }
 
-lxb_dom_document_t * nl_rb_document_unwrap(VALUE rb_doc);
+lxb_dom_document_t *nl_rb_document_unwrap(VALUE rb_doc);
 
 const lxb_char_t *
 lxb_dom_node_name_qualified(lxb_dom_node_t *node, size_t *len);

data/ext/nokolexbor/xml_xpath.c

@@ -2897,6 +2897,10 @@ valuePop(xmlXPathParserContextPtr ctxt)
     ctxt->valueTab[ctxt->valueNr] = NULL;
     return (ret);
 }
+
+xmlXPathObjectPtr
+nl_xmlXPathValuePop(xmlXPathParserContextPtr ctxt) { return valuePop(ctxt); }
+
 /**
  * valuePush:
  * @ctxt:  an XPath evaluation context
@@ -2941,6 +2945,9 @@ valuePush(xmlXPathParserContextPtr ctxt, xmlXPathObjectPtr value)
     return (ctxt->valueNr++);
 }
 
+int
+nl_xmlXPathValuePush(xmlXPathParserContextPtr ctxt, xmlXPathObjectPtr value) { return valuePush(ctxt, value); }
+
 /**
  * nl_xmlXPathPopBoolean:
  * @ctxt:  an XPath parser context