nokogiri 1.8.2 → 1.8.3

data/test/xml/test_node_set.rb

@@ -51,6 +51,12 @@ module Nokogiri
         @list.each { |x| assert_nil x['class'] }
       end
 
+      def test_remove_attribute
+        @list.each { |x| x['class'] = 'blah' }
+        assert_equal @list, @list.remove_attribute('class')
+        @list.each { |x| assert_nil x['class'] }
+      end
+
       def test_add_class
         assert_equal @list, @list.add_class('bar')
         @list.each { |x| assert_equal 'bar', x['class'] }
@@ -62,6 +68,17 @@ module Nokogiri
         @list.each { |x| assert_equal 'bar baz', x['class'] }
       end
 
+      def test_append_class
+        assert_equal @list, @list.append_class('bar')
+        @list.each { |x| assert_equal 'bar', x['class'] }
+
+        @list.append_class('bar')
+        @list.each { |x| assert_equal 'bar bar', x['class'] }
+
+        @list.append_class('baz')
+        @list.each { |x| assert_equal 'bar bar baz', x['class'] }
+      end
+
       def test_remove_class_with_no_class
         assert_equal @list, @list.remove_class('bar')
         @list.each { |e| assert_nil e['class'] }
@@ -408,7 +425,7 @@ module Nokogiri
       def test_delete_on_empty_set
         empty_set = Nokogiri::XML::NodeSet.new @xml, []
         employee  = @xml.at_xpath("//employee")
-        assert_equal nil, empty_set.delete(employee)
+        assert_nil empty_set.delete(employee)
       end
 
       def test_unlink
@@ -563,6 +580,8 @@ module Nokogiri
 
         assert_equal 3, employees.index(employees[3])
         assert_nil employees.index(other)
+        assert_equal 3, employees.index {|employee| employee.search("employeeId/text()").to_s == "EMP0004" }
+        assert_nil employees.index {|employee| employee.search("employeeId/text()").to_s == "EMP0000" }
       end
 
       def test_slice_too_far
@@ -573,9 +592,9 @@ module Nokogiri
 
       def test_slice_on_empty_node_set
         empty_set = Nokogiri::XML::NodeSet.new @xml, []
-        assert_equal nil, empty_set[99]
-        assert_equal nil, empty_set[99..101]
-        assert_equal nil, empty_set[99,2]
+        assert_nil empty_set[99]
+        assert_nil empty_set[99..101]
+        assert_nil empty_set[99,2]
       end
 
       def test_slice_waaaaaay_off_the_end
@@ -653,6 +672,14 @@ module Nokogiri
         assert ! empty_set.include?(employee)
       end
 
+      def test_each
+        employees = @xml.search("//employee")
+        enum = employees.each
+        assert_instance_of Enumerator, enum
+        assert_equal enum.next, employees[0]
+        assert_equal enum.next, employees[1]
+      end
+
       def test_children
         employees = @xml.search("//employee")
         count = 0

data/test/xml/test_reader.rb

@@ -4,6 +4,18 @@ require "helper"
 module Nokogiri
   module XML
     class TestReader < Nokogiri::TestCase
+      class NonStringIO
+        def read(size)
+          :invalid_object
+        end
+      end
+
+      def test_io_non_string
+        io = NonStringIO.new
+        reader = Nokogiri::XML::Reader(io)
+        assert_equal io, reader.source
+      end
+
       def test_from_io_sets_io_as_source
         io = File.open SNUGGLES_FILE
         reader = Nokogiri::XML::Reader.from_io(io)
@@ -601,7 +613,7 @@ module Nokogiri
         reader = Nokogiri::XML::Reader("<root xmlns='bob'><el attr='fred' /></root>")
         reader.read # root
         reader.read # el
-        assert_equal nil, reader.attribute('other')
+        assert_nil reader.attribute('other')
       end
     end
   end

data/test/xml/test_syntax_error.rb

@@ -27,9 +27,9 @@ module Nokogiri
         error = bad_doc.errors.first
 
         assert_equal "The element type \"root\" must be terminated by the matching end-tag \"</root>\".", error.message
-        assert_equal nil, error.line
-        assert_equal nil, error.column
-        assert_equal nil, error.level
+        assert_nil error.line
+        assert_nil error.column
+        assert_nil error.level
       end
     end
   end

data/test/xml/test_xpath.rb

@@ -108,6 +108,14 @@ module Nokogiri
         assert_equal 3, node.search('.//div', 'p.blah').length
       end
 
+      def test_css_search_with_ambiguous_integer_or_string_attributes
+        # https://github.com/sparklemotion/nokogiri/issues/711
+        html = "<body><div><img width=200>"
+        doc = Nokogiri::HTML(html)
+        assert_not_nil doc.at_css("img[width='200']")
+        assert_not_nil doc.at_css("img[width=200]")
+      end
+
       def test_css_search_uses_custom_selectors_with_arguments
         set = @xml.css('employee > address:my_filter("domestic", "Yes")', @handler)
         assert set.length > 0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nokogiri
 version: !ruby/object:Gem::Version
-  version: 1.8.2
+  version: 1.8.3
 platform: ruby
 authors:
 - Aaron Patterson
@@ -9,10 +9,12 @@ authors:
 - Yoko Harada
 - Tim Elliott
 - Akinori MUSHA
+- John Shahid
+- Lars Kanis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-29 00:00:00.000000000 Z
+date: 2018-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mini_portile2
@@ -214,12 +216,27 @@ description: |-
   Nokogiri (鋸) is an HTML, XML, SAX, and Reader parser.  Among
   Nokogiri's many features is the ability to search documents via XPath
   or CSS3 selectors.
+
+  * http://nokogiri.org
+  * [Installation Help](http://nokogiri.org/tutorials/installing_nokogiri.html)
+  * [Tutorials](http://nokogiri.org)
+  * [GitHub](https://github.com/sparklemotion/nokogiri)
+  * [Mailing List](https://groups.google.com/group/nokogiri-talk)
+  * [Bug Reports](https://github.com/sparklemotion/nokogiri/issues)
+  * [Chat/Gitter](https://gitter.im/sparklemotion/nokogiri)
+
+  [![Concourse CI](https://ci.nokogiri.org/api/v1/teams/nokogiri-core/pipelines/nokogiri/jobs/ruby-2.4-system/badge)](https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri?groups=master)
+  [![Code Climate](https://codeclimate.com/github/sparklemotion/nokogiri.svg)](https://codeclimate.com/github/sparklemotion/nokogiri)
+  [![Version Eye](https://www.versioneye.com/ruby/nokogiri/badge.png)](https://www.versioneye.com/ruby/nokogiri)
+  [![Join the chat at https://gitter.im/sparklemotion/nokogiri](https://badges.gitter.im/sparklemotion/nokogiri.svg)](https://gitter.im/sparklemotion/nokogiri?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 email:
 - aaronp@rubyforge.org
 - mike.dalessio@gmail.com
 - yokolet@gmail.com
 - tle@holymonkey.com
 - knu@idaemons.org
+- jvshahid@gmail.com
+- lars@greiz-reinsdorf.de
 executables:
 - nokogiri
 extensions:
@@ -233,6 +250,7 @@ extra_rdoc_files:
 - Manifest.txt
 - README.md
 - ROADMAP.md
+- SECURITY.md
 - STANDARD_RESPONSES.md
 - Y_U_NO_GEMSPEC.md
 - suppressions/README.txt
@@ -287,6 +305,7 @@ files:
 - README.md
 - ROADMAP.md
 - Rakefile
+- SECURITY.md
 - STANDARD_RESPONSES.md
 - Y_U_NO_GEMSPEC.md
 - appveyor.yml
@@ -426,8 +445,9 @@ files:
 - lib/nokogiri/xslt.rb
 - lib/nokogiri/xslt/stylesheet.rb
 - lib/xsd/xmlparser/nokogiri.rb
+- patches/libxml2/0001-Revert-Do-not-URI-escape-in-server-side-includes.patch
 - patches/sort-patches-by-date
-- ports/archives/libxml2-2.9.7.tar.gz
+- ports/archives/libxml2-2.9.8.tar.gz
 - ports/archives/libxslt-1.1.32.tar.gz
 - suppressions/README.txt
 - suppressions/nokogiri_ruby-2.supp
@@ -479,6 +499,7 @@ files:
 - test/html/sax/test_parser_context.rb
 - test/html/sax/test_parser_text.rb
 - test/html/sax/test_push_parser.rb
+- test/html/test_attributes.rb
 - test/html/test_builder.rb
 - test/html/test_document.rb
 - test/html/test_document_encoding.rb
@@ -542,7 +563,7 @@ files:
 - test/xml/test_xpath.rb
 - test/xslt/test_custom_functions.rb
 - test/xslt/test_exception_handling.rb
-homepage: http://nokogiri.org
+homepage: 
 licenses:
 - MIT
 metadata: {}