nokogiri 1.5.3.rc3-java → 1.5.3.rc4-java

data/CHANGELOG.ja.rdoc

@@ -1,5 +1,9 @@
 == 1.5.3 / unreleased
 
+* Features
+
+  * Support for "prefixless" CSS selectors ~, > and + like jQuery supports. #621, #623. (Thanks, David Lee!)
+
 * Bugfixes
 
   * Custom xpath functions with empty nodeset arguments cause a segfault. #634.
@@ -8,6 +12,11 @@
     namespace.
   * Fixed marshalling bugs around how arguments are passed to (and
     returned from) XSLT custom xpath functions. #640.
+  * Nokogiri::XML::Reader#outer_xml がJRubyで正しく動作しない #617
+  * Nokogiri::XML::Attribute が JRuby 上で　nil namespace を返す　#647
+  * Nokogiri::XML::Node#namespace= メソッドが JRuby　上で prefix　が無い namespace を設定できない #648
+  * JRuby 1.9 モードで rake を実行するとデッドロックを引き起こす #571
+  * HTML::Document#meta_encoding does not raise exception on docs with malformed content-type. #655
 
 
 == 1.5.2 / 2012-03-09

data/CHANGELOG.rdoc

@@ -1,5 +1,9 @@
 == 1.5.3 / unreleased
 
+* Features
+
+  * Support for "prefixless" CSS selectors ~, > and + like jQuery supports. #621, #623. (Thanks, David Lee!)
+
 * Bugfixes
 
   * Custom xpath functions with empty nodeset arguments cause a segfault. #634.
@@ -8,6 +12,11 @@
     namespace.
   * Fixed marshalling bugs around how arguments are passed to (and
     returned from) XSLT custom xpath functions. #640.
+  * Nokogiri::XML::Reader#outer_xml is broken in JRuby #617
+  * Nokogiri::XML::Attribute on JRuby returns a nil namespace #647
+  * Nokogiri::XML::Node#namespace= cannot set a namespace without a prefix on JRuby #648
+  * JRuby 1.9 mode causes dead lock while running rake #571
+  * HTML::Document#meta_encoding does not raise exception on docs with malformed content-type. #655
 
 
 == 1.5.2 / 2012-03-09
@@ -439,7 +448,7 @@ Repackaging of 1.5.1 with a gemspec that is compatible with older Rubies. #631,
   * Nokogiri::HTML.fragment will properly handle text only nodes (LH #43)
   * Nokogiri::XML::Node#before will prepend text nodes (LH #44)
   * Nokogiri::XML::Node#after will append text nodes
-  * Nokogiri::XML::Node#search automatically registers root namepsaces (LH #42)
+  * Nokogiri::XML::Node#search automatically registers root namespaces (LH #42)
   * Nokogiri::XML::NodeSet#search automatically registers namespaces
   * Nokogiri::HTML::NamedCharacters delegates to libxml2
   * Nokogiri::XML::Node#[] can take a symbol (LH #48)
@@ -559,7 +568,7 @@ Repackaging of 1.5.1 with a gemspec that is compatible with older Rubies. #631,
 
 * Bugfixes
 
-  * Changed memory mangement from weak refs to document refs
+  * Changed memory management from weak refs to document refs
   * Plugged some memory leaks
   * Builder blocks can call methods from surrounding contexts
 

data/Manifest.txt

@@ -58,7 +58,6 @@ ext/java/nokogiri/internals/NokogiriXPathFunctionResolver.java
 ext/java/nokogiri/internals/NokogiriXPathVariableResolver.java
 ext/java/nokogiri/internals/NokogiriXsltErrorListener.java
 ext/java/nokogiri/internals/ParserContext.java
-ext/java/nokogiri/internals/PushInputStream.java
 ext/java/nokogiri/internals/ReaderNode.java
 ext/java/nokogiri/internals/SaveContextVisitor.java
 ext/java/nokogiri/internals/SchemaErrorHandler.java

data/ROADMAP.md

@@ -26,6 +26,7 @@
   * https://github.com/tenderlove/nokogiri/issues/621
   * https://github.com/tenderlove/nokogiri/issues/342
   * https://github.com/tenderlove/nokogiri/issues/628
+  * https://github.com/tenderlove/nokogiri/issues/652
 
 * https://github.com/tenderlove/nokogiri/issues/394
   nth-of-type is wrong, and possibly other selectors as well
@@ -52,12 +53,22 @@
 * https://github.com/tenderlove/nokogiri/pull/464
 
 
+## Better Syntax around Node#xpath and NodeSet#xpath
+
+* look at those methods, and use of Node#extract_params in Node#{css,search}
+  * we should standardize on a hash of options for these and other calls
+* what should NodeSet#xpath return?
+  * https://github.com/tenderlove/nokogiri/issues/656
+
 ## Encoding
 
 We have a lot of issues open around encoding. Is this really an issue?
 Somebody who knows something about encoding, and cares, should point
 this one.
 
+* Extract EncodingReader as a real object that can be injected
+  https://groups.google.com/forum/#!msg/nokogiri-talk/arJeAtMqvkg/tGihB-iBRSAJ
+
 
 ## Reader
 

data/STANDARD_RESPONSES.md

@@ -33,8 +33,8 @@ Thank you so much!
 
 Hello!
 
-Thanks for asking this question! Your request for help will not go
-unanswered!
+Thanks for asking this question! Your request for assistance using
+Nokogiri will not go unanswered!
 
 However, Nokogiri's Github Issues is reserved for reporting bugs or
 submitting patches. If you ask your question on the mailing list, Team

data/ext/java/nokogiri/XmlAttr.java

@@ -1,7 +1,7 @@
 /**
  * (The MIT License)
  *
- * Copyright (c) 2008 - 2011:
+ * Copyright (c) 2008 - 2012:
  *
  * * {Aaron Patterson}[http://tenderlovemaking.com]
  * * {Mike Dalessio}[http://mike.daless.io]
@@ -96,6 +96,16 @@ public class XmlAttr extends XmlNode{
         Node attr = xmlDoc.getDocument().createAttribute(str);
         setNode(context, attr);
     }
+    
+    
+    // this method is called from XmlNode.setNode()
+    // if the node is attribute, and its name has prefix "xml"
+    // the default namespace should be registered for this attribute
+    void setNamespaceIfNecessary(Ruby runtime) {
+        if ("xml".equals(node.getPrefix())) {
+           XmlNamespace.createDefaultNamespace(runtime, node); 
+        }
+    }
 
     private boolean isHtmlBooleanAttr() {
         String name = node.getNodeName().toLowerCase();

data/ext/java/nokogiri/XmlNamespace.java

@@ -36,6 +36,7 @@ import static nokogiri.internals.NokogiriHelpers.CACHED_NODE;
 import static nokogiri.internals.NokogiriHelpers.getCachedNodeOrCreate;
 import static nokogiri.internals.NokogiriHelpers.getLocalNameForNamespace;
 import static nokogiri.internals.NokogiriHelpers.getNokogiriClass;
+import static nokogiri.internals.NokogiriHelpers.stringOrNil;
 import nokogiri.internals.NokogiriHelpers;
 import nokogiri.internals.SaveContextVisitor;
 
@@ -155,6 +156,30 @@ public class XmlNamespace extends RubyObject {
         return namespace;
     }
     
+    // owner should be an Attr node
+    public static XmlNamespace createDefaultNamespace(Ruby runtime, Node owner) {
+        String prefixValue = owner.getPrefix();
+        String hrefValue = owner.getNamespaceURI();
+        Document document = owner.getOwnerDocument();
+        // check namespace cache
+        XmlDocument xmlDocument = (XmlDocument)getCachedNodeOrCreate(runtime, document);
+        XmlNamespace xmlNamespace = xmlDocument.getNamespaceCache().get(prefixValue, hrefValue);
+        if (xmlNamespace != null) return xmlNamespace;
+
+        // creating XmlNamespace instance
+        XmlNamespace namespace =
+            (XmlNamespace) NokogiriService.XML_NAMESPACE_ALLOCATOR.allocate(runtime, getNokogiriClass(runtime, "Nokogiri::XML::Namespace"));
+
+        IRubyObject prefix = stringOrNil(runtime, prefixValue);
+        IRubyObject href = stringOrNil(runtime, hrefValue);
+        // initialize XmlNamespace object
+        namespace.init((Attr)owner, prefix, href, prefixValue, hrefValue, xmlDocument);
+        
+        // updating namespace cache
+        xmlDocument.getNamespaceCache().put(namespace, owner);
+        return namespace;
+    }
+    
     /**
      * Create and return a copy of this object.
      *

data/ext/java/nokogiri/XmlNode.java

@@ -479,6 +479,10 @@ public class XmlNode extends RubyObject {
                 doc = document(context);
             }
         }
+
+        if (this instanceof XmlAttr) {
+            ((XmlAttr)this).setNamespaceIfNecessary(context.getRuntime());
+        }
     }
 
     public void updateNodeNamespaceIfNecessary(ThreadContext context, XmlNamespace ns) {
@@ -1342,7 +1346,7 @@ public class XmlNode extends RubyObject {
          */
         if (parent.getNodeType() == Node.DOCUMENT_NODE &&
             otherNode.getNodeType() == Node.TEXT_NODE) {
-            Element e = ((Document)parent).createElement("text");
+            Element e = ((Document)parent).createElement("nokogiri_text_wrapper");
             e.appendChild(otherNode);
             otherNode = e;
         }

data/ext/java/nokogiri/XmlReader.java

@@ -1,7 +1,7 @@
 /**
  * (The MIT License)
  *
- * Copyright (c) 2008 - 2011:
+ * Copyright (c) 2008 - 2012:
  *
  * * {Aaron Patterson}[http://tenderlovemaking.com]
  * * {Mike Dalessio}[http://mike.daless.io]
@@ -228,8 +228,15 @@ public class XmlReader extends RubyObject {
         if (!current.hasChildren) return null;
         StringBuffer sb = new StringBuffer();
         int currentDepth = (Integer)current.depth;
+        int inner = 0;
         for (ReaderNode node : nodeQueue) {
-            if (((Integer)node.depth) > currentDepth) sb.append(node.getString());
+            if (((Integer)node.depth) == currentDepth && node.getName().equals(current.getName())) {
+                inner++;
+            }
+            if (((Integer)node.depth) > currentDepth) {
+                sb.append(node.getString());
+            }
+            if (inner == 2) break;
         }
         return new String(sb);
     }
@@ -242,9 +249,17 @@ public class XmlReader extends RubyObject {
     private String getOuterXml(ArrayDeque<ReaderNode> nodeQueue, ReaderNode current) {
         if (current.depth < 0) return null;
         StringBuffer sb = new StringBuffer();
-        int initialDepth = (Integer)current.depth - 1;
+        int initialDepth = (Integer)current.depth;
+        int inner = 0;
         for (ReaderNode node : nodeQueue) {
-            if (((Integer)node.depth) > initialDepth) sb.append(node.getString());
+            if (((Integer)node.depth) >= initialDepth) {
+                if (((Integer)node.depth) == initialDepth && node.getName().equals(current.getName())) {
+                    inner++;
+                }
+
+                sb.append(node.getString());
+            }
+            if (inner == 2) break;
         }
         return new String(sb);
     }

data/ext/java/nokogiri/XmlSaxPushParser.java

@@ -1,7 +1,7 @@
 /**
  * (The MIT License)
  *
- * Copyright (c) 2008 - 2011:
+ * Copyright (c) 2008 - 2012:
  *
  * * {Aaron Patterson}[http://tenderlovemaking.com]
  * * {Mike Dalessio}[http://mike.daless.io]
@@ -37,10 +37,15 @@ import static org.jruby.javasupport.util.RuntimeHelpers.invoke;
 
 import java.io.IOException;
 import java.io.InputStream;
-import java.nio.channels.ClosedChannelException;
+import java.io.OutputStream;
+import java.nio.channels.Channels;
+import java.nio.channels.Pipe;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.FutureTask;
 
 import nokogiri.internals.ParserContext;
-import nokogiri.internals.PushInputStream;
 
 import org.jruby.Ruby;
 import org.jruby.RubyClass;
@@ -63,9 +68,12 @@ import org.jruby.runtime.builtin.IRubyObject;
 public class XmlSaxPushParser extends RubyObject {
     ParserContext.Options options;
     IRubyObject optionsRuby;
-    PushInputStream stream;
-    Thread reader;
-    Runner runner;
+    IRubyObject saxParser;
+    OutputStream ostream = null;
+    InputStream istream = null;
+    ParserTask parserTask = null;
+    FutureTask<XmlSaxParserContext> futureTask = null;
+    ExecutorService executor = null;
 
     public XmlSaxPushParser(Ruby ruby, RubyClass rubyClass) {
         super(ruby, rubyClass);
@@ -73,18 +81,12 @@ public class XmlSaxPushParser extends RubyObject {
 
     @JRubyMethod
     public IRubyObject initialize_native(final ThreadContext context,
-                                         IRubyObject _saxParser,
+                                         IRubyObject saxParser,
                                          IRubyObject fileName) {
-        optionsRuby = invoke(context,
-                             context.getRuntime().getClassFromPath("Nokogiri::XML::ParseOptions"),
-                             "new");
+        optionsRuby
+            = invoke(context, context.getRuntime().getClassFromPath("Nokogiri::XML::ParseOptions"), "new");
         options = new ParserContext.Options(0);
-        stream = new PushInputStream();
-
-        runner = new Runner(context, this, stream);
-        reader = new Thread(runner);
-        reader.start();
-
+        this.saxParser = saxParser;
         return this;
     }
 
@@ -110,74 +112,103 @@ public class XmlSaxPushParser extends RubyObject {
     @JRubyMethod
     public IRubyObject native_write(ThreadContext context, IRubyObject chunk,
                                     IRubyObject isLast) {
+        try {
+            initialize_task(context);
+        } catch (IOException e) {
+            throw context.getRuntime().newRuntimeError(e.getMessage());
+        }
         byte[] data = null;
         if (chunk instanceof RubyString || chunk.respondsTo("to_str")) {
             data = chunk.convertToString().getBytes();
-        } else {
-            XmlSyntaxError xmlSyntaxError = (XmlSyntaxError) NokogiriService.XML_SYNTAXERROR_ALLOCATOR.allocate(context.getRuntime(), getNokogiriClass(context.getRuntime(), "Nokogiri::XML::SyntaxError"));
+        } else { 
+            try {
+                terminateTask();
+            } catch (IOException e) {
+                throw context.getRuntime().newRuntimeError(e.getMessage());
+            }
+            XmlSyntaxError xmlSyntaxError = 
+                (XmlSyntaxError) NokogiriService.XML_SYNTAXERROR_ALLOCATOR.allocate(context.getRuntime(), getNokogiriClass(context.getRuntime(), "Nokogiri::XML::SyntaxError"));
             throw new RaiseException(xmlSyntaxError);
         }
 
-        int errorCount0 = runner.getErrorCount();
-
+        int errorCount0 = parserTask.getErrorCount();;
+        
         try {
-            stream.writeAndWaitForRead(data);
-        } catch (ClosedChannelException e) {
-            // ignore
+            if (isLast.isTrue()) {
+                IRubyObject document = invoke(context, this, "document");
+                invoke(context, document, "end_document");
+                terminateTask();
+            } else {
+                ostream.write(data);
+                Thread.currentThread().sleep(10);   // gives a reader a chance to work
+            }
         } catch (IOException e) {
-            throw context.getRuntime().newRuntimeError(e.toString());
+            throw context.getRuntime().newRuntimeError(e.getMessage());
+        } catch (InterruptedException e) {
+            throw context.getRuntime().newRuntimeError(e.getMessage());
         }
 
-        if (isLast.isTrue()) {
+        if (!options.recover && parserTask.getErrorCount() > errorCount0) {
             try {
-                stream.close();
+                terminateTask();
             } catch (IOException e) {
-                // ignore
-            }
-
-            for (;;) {
-                try {
-                    reader.join();
-                    break;
-                } catch (InterruptedException e) {
-                    // continue loop
-                }
+                throw context.getRuntime().newRuntimeError(e.getMessage());
             }
-        }
-
-        if (!options.recover && runner.getErrorCount() > errorCount0) {
-            throw new RaiseException(runner.getLastError(), true);
+            throw new RaiseException(parserTask.getLastError(), true);
         }
 
         return this;
     }
-
-    protected static class Runner implements Runnable {
-        protected ThreadContext context;
-        protected IRubyObject handler;
-        protected XmlSaxParserContext parser;
-
-        public Runner(ThreadContext context,
-                      IRubyObject handler,
-                      InputStream stream) {
+    
+    private void initialize_task(ThreadContext context) throws IOException {
+        if (futureTask == null || ostream == null || istream == null) {
+            Pipe pipe = Pipe.open();
+            Pipe.SinkChannel sink = pipe.sink();
+            ostream = Channels.newOutputStream(sink);
+            Pipe.SourceChannel source = pipe.source();
+            istream = Channels.newInputStream(source);
+
+            parserTask = new ParserTask(context, saxParser);
+            futureTask = new FutureTask<XmlSaxParserContext>(parserTask);
+            executor = Executors.newSingleThreadExecutor();
+            executor.submit(futureTask);
+        }
+    }
+    
+    private synchronized void terminateTask() throws IOException {
+        futureTask.cancel(true);
+        executor.shutdown();
+        ostream.close();
+        istream.close();
+        ostream = null;
+        istream = null;
+    }
+    
+    private class ParserTask implements Callable<XmlSaxParserContext> {
+        private ThreadContext context;
+        private IRubyObject handler;
+        private XmlSaxParserContext parser;
+        
+        private ParserTask(ThreadContext context, IRubyObject handler) {
             RubyClass klazz = getNokogiriClass(context.getRuntime(), "Nokogiri::XML::SAX::ParserContext");
-
             this.context = context;
             this.handler = handler;
-            this.parser = (XmlSaxParserContext) XmlSaxParserContext.parse_stream(context, klazz, stream);
+            this.parser = (XmlSaxParserContext) XmlSaxParserContext.parse_stream(context, klazz, istream);
         }
 
-        public void run() {
+        @Override
+        public XmlSaxParserContext call() throws Exception {
             parser.parse_with(context, handler);
+            return parser;
         }
-
-        public int getErrorCount() {
-            // check for null because thread may nto have started yet
+        
+        private synchronized int getErrorCount() {
+            // check for null because thread may not have started yet
             if (parser.getNokogiriHandler() == null) return 0;
             else return parser.getNokogiriHandler().getErrorCount();
         }
-
-        public RubyException getLastError() {
+        
+        private synchronized RubyException getLastError() {
             return (RubyException) parser.getNokogiriHandler().getLastError();
         }
     }