nokogiri 1.5.0.beta.2 → 1.5.0.beta.3

data/ext/java/nokogiri/XmlText.java

@@ -1,6 +1,39 @@
+/**
+ * (The MIT License)
+ *
+ * Copyright (c) 2008 - 2010:
+ *
+ * * {Aaron Patterson}[http://tenderlovemaking.com]
+ * * {Mike Dalessio}[http://mike.daless.io]
+ * * {Charles Nutter}[http://blog.headius.com]
+ * * {Sergio Arbeo}[http://www.serabe.com]
+ * * {Patrick Mahoney}[http://polycrystal.org]
+ * * {Yoko Harada}[http://yokolet.blogspot.com]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * 'Software'), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 package nokogiri;
 
 import static nokogiri.internals.NokogiriHelpers.isXmlEscaped;
+import static nokogiri.internals.NokogiriHelpers.rubyStringToString;
 import static nokogiri.internals.NokogiriHelpers.stringOrNil;
 import nokogiri.internals.NokogiriHelpers;
 import nokogiri.internals.SaveContext;
@@ -15,10 +48,15 @@ import org.jruby.runtime.builtin.IRubyObject;
 import org.w3c.dom.Document;
 import org.w3c.dom.Node;
 
+/**
+ * Class for Nokogiri::XML::Text
+ *
+ */
 @JRubyClass(name="Nokogiri::XML::Text", parent="Nokogiri::XML::CharacterData")
 public class XmlText extends XmlNode {
-    public XmlText(Ruby ruby, RubyClass rubyClass, Node node) {
-        super(ruby, rubyClass, node);
+
+    public XmlText(Ruby runtime, RubyClass rubyClass, Node node) {
+        super(runtime, rubyClass, node);
     }
 
     public XmlText(Ruby runtime, RubyClass klass) {
@@ -40,13 +78,14 @@ public class XmlText extends XmlNode {
         Document document = xmlDoc.getDocument();
         // text node content should not be encoded when it is created by Text node.
         // while content should be encoded when it is created by Element node.
-        Node node = document.createTextNode((String)content.toJava(String.class));
-        setNode(node);
+        Node node = document.createTextNode(rubyStringToString(content));
+        setNode(context, node);
     }
     
     @Override
     protected IRubyObject getNodeName(ThreadContext context) {
-        return JavaUtil.convertJavaToUsableRubyObject(context.getRuntime(), "text");
+        if (name == null) name = context.getRuntime().newString("text");
+        return name;
     }
     
     @Override
@@ -78,7 +117,7 @@ public class XmlText extends XmlNode {
         XmlDocument xmlDocument = (XmlDocument)document(context);
         IRubyObject ruby_encoding = xmlDocument.encoding(context);
         if (!ruby_encoding.isNil()) {
-            encoding = (String)ruby_encoding.toJava(String.class);
+            encoding = rubyStringToString(ruby_encoding);
         }
         return encoding;
     }

data/ext/java/nokogiri/XmlXpathContext.java

@@ -1,3 +1,35 @@
+/**
+ * (The MIT License)
+ *
+ * Copyright (c) 2008 - 2010:
+ *
+ * * {Aaron Patterson}[http://tenderlovemaking.com]
+ * * {Mike Dalessio}[http://mike.daless.io]
+ * * {Charles Nutter}[http://blog.headius.com]
+ * * {Sergio Arbeo}[http://www.serabe.com]
+ * * {Patrick Mahoney}[http://polycrystal.org]
+ * * {Yoko Harada}[http://yokolet.blogspot.com]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * 'Software'), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 package nokogiri;
 
 import java.util.Set;
@@ -12,6 +44,7 @@ import javax.xml.xpath.XPathFactory;
 
 import nokogiri.internals.NokogiriNamespaceContext;
 import nokogiri.internals.NokogiriXPathFunctionResolver;
+import nokogiri.internals.NokogiriXPathVariableResolver;
 
 import org.jruby.Ruby;
 import org.jruby.RubyBoolean;
@@ -27,6 +60,10 @@ import org.jruby.runtime.ThreadContext;
 import org.jruby.runtime.builtin.IRubyObject;
 import org.w3c.dom.NodeList;
 
+/**
+ * Class for Nokogiri::XML::XpathContext
+ *
+ */
 @JRubyClass(name="Nokogiri::XML::XPathContext")
 public class XmlXpathContext extends RubyObject {
     private XmlNode context;
@@ -37,6 +74,7 @@ public class XmlXpathContext extends RubyObject {
         this.context = context;
         this.xpath = XPathFactory.newInstance().newXPath();
         this.xpath.setNamespaceContext(new NokogiriNamespaceContext());
+        this.xpath.setXPathVariableResolver(new NokogiriXPathVariableResolver());
     }
 
     @JRubyMethod(name = "new", meta = true)
@@ -127,4 +165,11 @@ public class XmlXpathContext extends RubyObject {
         ((NokogiriNamespaceContext) this.xpath.getNamespaceContext()).registerNamespace(prefix.convertToString().asJavaString(), uri.convertToString().asJavaString());
         return this;
     }
+
+    @JRubyMethod
+    public IRubyObject register_variable(ThreadContext context, IRubyObject name, IRubyObject value) {
+        ((NokogiriXPathVariableResolver) this.xpath.getXPathVariableResolver()).
+            registerVariable(name.convertToString().asJavaString(), value.convertToString().asJavaString());
+        return this;
+    }
 }

data/ext/java/nokogiri/XsltStylesheet.java

@@ -1,7 +1,41 @@
+/**
+ * (The MIT License)
+ *
+ * Copyright (c) 2008 - 2010:
+ *
+ * * {Aaron Patterson}[http://tenderlovemaking.com]
+ * * {Mike Dalessio}[http://mike.daless.io]
+ * * {Charles Nutter}[http://blog.headius.com]
+ * * {Sergio Arbeo}[http://www.serabe.com]
+ * * {Patrick Mahoney}[http://polycrystal.org]
+ * * {Yoko Harada}[http://yokolet.blogspot.com]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * 'Software'), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 package nokogiri;
 
 import static nokogiri.internals.NokogiriHelpers.getNokogiriClass;
 
+import java.util.HashMap;
+import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -24,11 +58,20 @@ import org.jruby.runtime.ThreadContext;
 import org.jruby.runtime.builtin.IRubyObject;
 import org.w3c.dom.Document;
 
+/**
+ * Class for Nokogiri::XSLT::Stylesheet
+ *
+ */
 @JRubyClass(name="Nokogiri::XSLT::Stylesheet")
 public class XsltStylesheet extends RubyObject {
-
+    private static Map<String, Object> registry = new HashMap<String, Object>();
+    private static TransformerFactory factory = null;
     private Templates sheet;
 
+    public static Map<String, Object> getRegistry() {
+        return registry;
+    }
+
     public XsltStylesheet(Ruby ruby, RubyClass rubyClass) {
         super(ruby, rubyClass);
     }
@@ -77,8 +120,10 @@ public class XsltStylesheet extends RubyObject {
         Document doc = ((XmlDocument) xmlDoc.dup_implementation(context, true)).getDocument();
 
         XsltStylesheet xslt = new XsltStylesheet(ruby, (RubyClass) cls);
+
         try {
-            xslt.sheet = TransformerFactory.newInstance().newTemplates(new DOMSource(doc));
+            if (factory == null) factory = TransformerFactory.newInstance();
+            xslt.sheet = factory.newTemplates(new DOMSource(doc));
         } catch (TransformerConfigurationException ex) {
             ruby.newRuntimeError("could not parse xslt stylesheet");
         }
@@ -88,7 +133,6 @@ public class XsltStylesheet extends RubyObject {
 
     @JRubyMethod
     public IRubyObject serialize(ThreadContext context, IRubyObject doc) {
-        System.out.println("Serialize called in stylesheet");
         return RuntimeHelpers.invoke(context,
                 RuntimeHelpers.invoke(context, doc, "root"),
                 "to_s");
@@ -123,4 +167,15 @@ public class XsltStylesheet extends RubyObject {
                     (Document) result.getNode());
         }
     }
+    
+    @JRubyMethod(name = {"registr", "register"}, meta = true)
+    public static IRubyObject register(ThreadContext context, IRubyObject cls, IRubyObject uri, IRubyObject receiver) {
+        throw context.getRuntime().newNotImplementedError("Nokogiri::XSLT.register method is not implemented");
+        /* When API conflict is solved, this method should be below:
+        // ThreadContext is used while executing xslt extension function
+        registry.put("context", context);
+        registry.put("receiver", receiver);
+        return context.getRuntime().getNil();
+        */
+    }
 }

data/ext/java/nokogiri/internals/HtmlDomParserContext.java

@@ -1,3 +1,35 @@
+/**
+ * (The MIT License)
+ *
+ * Copyright (c) 2008 - 2010:
+ *
+ * * {Aaron Patterson}[http://tenderlovemaking.com]
+ * * {Mike Dalessio}[http://mike.daless.io]
+ * * {Charles Nutter}[http://blog.headius.com]
+ * * {Sergio Arbeo}[http://www.serabe.com]
+ * * {Patrick Mahoney}[http://polycrystal.org]
+ * * {Yoko Harada}[http://yokolet.blogspot.com]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * 'Software'), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 package nokogiri.internals;
 
 import static nokogiri.internals.NokogiriHelpers.getNokogiriClass;
@@ -21,20 +53,11 @@ import org.jruby.runtime.builtin.IRubyObject;
 import org.w3c.dom.Document;
 
 /**
- *
+ * Parser for HtmlDocument. This class actually parses HtmlDocument using NekoHtml.
+ * 
  * @author sergio
  */
 public class HtmlDomParserContext extends XmlDomParserContext {
-    protected static final String PROPERTY_FILTERS =
-        "http://cyberneko.org/html/properties/filters";
-    protected static final String PROPERTY_ELEM_NAMES =
-        "http://cyberneko.org/html/properties/names/elems";
-    protected static final String PROPERTY_ATTRS_NAMES =
-        "http://cyberneko.org/html/properties/names/attrs";
-    protected static final String FEATURE_DOCUMENT_FRAGMENT =
-        "http://cyberneko.org/html/features/balance-tags/document-fragment";
-    protected static final String FEATURE_REPORT_ERRORS =
-        "http://cyberneko.org/html/features/report-errors";
 
     public HtmlDomParserContext(Ruby runtime, IRubyObject options) {
         super(runtime, options);
@@ -46,12 +69,10 @@ public class HtmlDomParserContext extends XmlDomParserContext {
 
     @Override
     protected void initErrorHandler() {
-        if (continuesOnError()) {
-            errorHandler = new NokogiriNonStrictErrorHandler4NekoHtml();
-        } else if (options.noError) {
-            errorHandler = new NokogiriNonStrictErrorHandler4NekoHtml(options.noError);
+        if (options.strict) {
+            errorHandler = new NokogiriStrictErrorHandler(options.noError, options.noWarning);
         } else {
-            errorHandler = new NokogiriStrictErrorHandler();
+            errorHandler = new NokogiriNonStrictErrorHandler4NekoHtml(options.noError, options.noWarning);
         }
     }
 
@@ -60,33 +81,35 @@ public class HtmlDomParserContext extends XmlDomParserContext {
         XMLParserConfiguration config = new HTMLConfiguration();
         XMLDocumentFilter removeNSAttrsFilter = new RemoveNSAttrsFilter();
         XMLDocumentFilter elementValidityCheckFilter = new ElementValidityCheckFilter(errorHandler);
-        //XMLDocumentFilter[] filters = { removeNSAttrsFilter};
         XMLDocumentFilter[] filters = { removeNSAttrsFilter,  elementValidityCheckFilter};
 
         config.setErrorHandler(this.errorHandler);
         parser = new DOMParser(config);
 
+        // see http://nekohtml.sourceforge.net/settings.html for details
         setProperty("http://cyberneko.org/html/properties/default-encoding", java_encoding);
-        setProperty(PROPERTY_ELEM_NAMES, "lower");
-        setProperty(PROPERTY_ATTRS_NAMES, "lower");
-        setFeature(FEATURE_REPORT_ERRORS, true);
+        setProperty("http://cyberneko.org/html/properties/names/elems", "lower");
+        setProperty("http://cyberneko.org/html/properties/names/attrs", "lower");
+        setFeature("http://cyberneko.org/html/features/report-errors", true);
         setFeature("http://xml.org/sax/features/namespaces", false);
-        setProperty(PROPERTY_FILTERS, filters);
+        setProperty("http://cyberneko.org/html/properties/filters", filters);
+        setFeature("http://cyberneko.org/html/features/insert-doctype", true);
     }
 
     /**
-     * Enable NekoHTML feature for balancing tags in a document
-     * fragment.
+     * Enable NekoHTML feature for balancing tags in a document fragment.
+     * 
+     * This method is used in XmlNode#in_context method.
      */
     public void enableDocumentFragment() {
-        setFeature(FEATURE_DOCUMENT_FRAGMENT, true);
+        setFeature("http://cyberneko.org/html/features/balance-tags/document-fragment", true);
     }
 
     @Override
     protected XmlDocument getNewEmptyDocument(ThreadContext context) {
         IRubyObject[] args = new IRubyObject[0];
         return (XmlDocument) XmlDocument.rbNew(context,
-                    getNokogiriClass(context.getRuntime(), "Nokogiri::XML::Document"),
+                    getNokogiriClass(context.getRuntime(), "Nokogiri::HTML::Document"),
                     args);
     }
 
@@ -162,6 +185,7 @@ public class HtmlDomParserContext extends XmlDomParserContext {
         private boolean isValid(String testee) {
             char[] c = testee.toCharArray();
             int index = new Integer(c[0]) - 97;
+            if (index > 25) return false;
             for (int i=0; i<element_names[index].length; i++) {
                 if (testee.equals(element_names[index][i])) {
                     return true;
@@ -173,7 +197,7 @@ public class HtmlDomParserContext extends XmlDomParserContext {
         @Override
         public void startElement(QName name, XMLAttributes attrs, Augmentations augs) throws XNIException {
             if (!isValid(name.rawname)) {
-                errorHandler.addError(new Exception("Tag " + name.rawname + " invalid"));
+                errorHandler.getErrors().add(new Exception("Tag " + name.rawname + " invalid"));
             }
             super.startElement(name, attrs, augs);
         }

data/ext/java/nokogiri/internals/NokogiriDocumentCache.java

@@ -1,3 +1,35 @@
+/**
+ * (The MIT License)
+ *
+ * Copyright (c) 2008 - 2010:
+ *
+ * * {Aaron Patterson}[http://tenderlovemaking.com]
+ * * {Mike Dalessio}[http://mike.daless.io]
+ * * {Charles Nutter}[http://blog.headius.com]
+ * * {Sergio Arbeo}[http://www.serabe.com]
+ * * {Patrick Mahoney}[http://polycrystal.org]
+ * * {Yoko Harada}[http://yokolet.blogspot.com]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * 'Software'), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 package nokogiri.internals;
 
 import java.util.Hashtable;
@@ -5,7 +37,9 @@ import nokogiri.XmlDocument;
 import org.w3c.dom.Document;
 
 /**
- *
+ * Currently, this class is not used anywhere.
+ * I'm not sure what for this class was written.(Yoko)
+ * 
  * @author sergio
  */
 public class NokogiriDocumentCache {

data/ext/java/nokogiri/internals/NokogiriErrorHandler.java

@@ -1,3 +1,35 @@
+/**
+ * (The MIT License)
+ *
+ * Copyright (c) 2008 - 2010:
+ *
+ * * {Aaron Patterson}[http://tenderlovemaking.com]
+ * * {Mike Dalessio}[http://mike.daless.io]
+ * * {Charles Nutter}[http://blog.headius.com]
+ * * {Sergio Arbeo}[http://www.serabe.com]
+ * * {Patrick Mahoney}[http://polycrystal.org]
+ * * {Yoko Harada}[http://yokolet.blogspot.com]
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * 'Software'), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 package nokogiri.internals;
 
 import java.util.ArrayList;
@@ -12,31 +44,37 @@ import org.jruby.runtime.builtin.IRubyObject;
 import org.xml.sax.ErrorHandler;
 
 /**
- *
+ * Super class of error handlers.
+ * 
+ * XMLErrorHandler is used by nokogiri.internals.HtmlDomParserContext since NekoHtml
+ * uses this type of the error handler.
+ * 
  * @author sergio
  */
-public abstract class NokogiriErrorHandler
-    implements ErrorHandler, XMLErrorHandler {
-
+public abstract class NokogiriErrorHandler implements ErrorHandler, XMLErrorHandler {
     protected List<Exception> errors;
+    protected boolean noerror;
+    protected boolean nowarning;
 
-    public NokogiriErrorHandler() {
-        this.errors = new ArrayList<Exception>();
+    public NokogiriErrorHandler(boolean noerror, boolean nowarning) {
+        errors = new ArrayList<Exception>();
+        this.noerror = noerror;
+        this.nowarning = nowarning;
     }
 
-    void addError(Exception e) {
-        errors.add(e);
-    }
-
-    public List<Exception> getErrors() { return this.errors; }
+    public List<Exception> getErrors() { return errors; }
 
     public List<IRubyObject> getErrorsReadyForRuby(ThreadContext context){
         Ruby ruby = context.getRuntime();
         List<IRubyObject> res = new ArrayList<IRubyObject>();
-        for(int i = 0; i < this.errors.size(); i++) {
-            res.add(new XmlSyntaxError(ruby, this.errors.get(i)));
+        for(int i = 0; i < errors.size(); i++) {
+            res.add(new XmlSyntaxError(ruby, errors.get(i)));
         }
         return res;
     }
 
+    protected boolean usesNekoHtml(String domain) {
+        if ("http://cyberneko.org/html".equals(domain)) return true;
+        else return false;
+    }
 }