nokogiri 1.2.3 → 1.3.0

data/test/xml/test_document_fragment.rb

@@ -3,22 +3,74 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', "helper"))
 module Nokogiri
   module XML
     class TestDocumentFragment < Nokogiri::TestCase
-      def test_new
+      def setup
+        super
         @xml = Nokogiri::XML.parse(File.read(XML_FILE), XML_FILE)
+      end
+
+      def test_new
         fragment = Nokogiri::XML::DocumentFragment.new(@xml)
       end
 
       def test_fragment_should_have_document
-        @xml = Nokogiri::XML.parse(File.read(XML_FILE), XML_FILE)
         fragment = Nokogiri::XML::DocumentFragment.new(@xml)
         assert_equal @xml, fragment.document
       end
 
       def test_name
-        @xml = Nokogiri::XML.parse(File.read(XML_FILE), XML_FILE)
         fragment = Nokogiri::XML::DocumentFragment.new(@xml)
         assert_equal '#document-fragment', fragment.name
       end
+
+      def test_static_method
+        fragment = Nokogiri::XML::DocumentFragment.parse("<div>a</div>")
+        assert_instance_of Nokogiri::XML::DocumentFragment, fragment
+      end
+
+      def test_many_fragments
+        100.times { Nokogiri::XML::DocumentFragment.new(@xml) }
+      end
+
+      def test_subclass
+        klass = Class.new(Nokogiri::XML::DocumentFragment)
+        fragment = klass.new(@xml, "<div>a</div>")
+        assert_instance_of klass, fragment
+      end
+
+      def test_xml_fragment
+        fragment = Nokogiri::XML.fragment("<div>a</div>")
+        assert_equal "<div>a</div>", fragment.to_s
+      end
+
+      def test_xml_fragment_has_multiple_toplevel_children
+        # TODO: this is lame. xml fragment() should support multiple top-level children
+        doc = "<div>b</div><div>e</div>"
+        fragment = Nokogiri::XML::Document.new.fragment(doc)
+        assert_equal "<div>b</div>", fragment.to_s
+      end
+
+      def test_xml_fragment_has_outer_text
+        # this test is descriptive, not prescriptive.
+        doc = "a<div>b</div>"
+        fragment = Nokogiri::XML::Document.new.fragment(doc)
+        assert_equal "", fragment.to_s
+
+        doc = "<div>b</div>c"
+        fragment = Nokogiri::XML::Document.new.fragment(doc)
+        assert_equal "<div>b</div>", fragment.to_s
+      end
+
+      def test_xml_fragment_case_sensitivity
+        doc = "<crazyDiv>b</crazyDiv>"
+        fragment = Nokogiri::XML::Document.new.fragment(doc)
+        assert_equal "<crazyDiv>b</crazyDiv>", fragment.to_s
+      end
+
+      def test_xml_fragment_with_leading_whitespace
+        doc = "     <div>b</div>  "
+        fragment = Nokogiri::XML::Document.new.fragment(doc)
+        assert_equal "<div>b</div>", fragment.to_s
+      end
     end
   end
 end

data/test/xml/test_entity_reference.rb

@@ -12,6 +12,10 @@ module Nokogiri
         assert ref = EntityReference.new(@xml, 'ent4')
         assert_instance_of EntityReference, ref
       end
+
+      def test_many_references
+        100.times { EntityReference.new(@xml, 'foo') }
+      end
     end
   end
 end

data/test/xml/test_namespace.rb

@@ -0,0 +1,43 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', "helper"))
+
+module Nokogiri
+  module XML
+    class TestNamespace < Nokogiri::TestCase
+      def setup
+        @xml = Nokogiri::XML <<-eoxml
+          <root xmlns="http://tenderlovemaking.com/" xmlns:foo="bar">
+            <awesome/>
+          </root>
+        eoxml
+      end
+
+      def test_namespace_node_prefix
+        namespaces = @xml.root.namespace_definitions
+        assert_equal [nil, 'foo'], namespaces.map { |x| x.prefix }
+      end
+
+      def test_namespace_node_href
+        namespaces = @xml.root.namespace_definitions
+        assert_equal [
+          'http://tenderlovemaking.com/',
+          'bar'
+        ], namespaces.map { |x| x.href }
+      end
+
+      def test_equality
+        namespaces = @xml.root.namespace_definitions
+        assert_equal namespaces, @xml.root.namespace_definitions
+      end
+
+      def test_add_definition
+        @xml.root.add_namespace_definition('baz', 'bar')
+        assert_equal 3, @xml.root.namespace_definitions.length
+      end
+
+      def test_add_definition_return
+        ns = @xml.root.add_namespace_definition('baz', 'bar')
+        assert_equal 'baz', ns.prefix
+      end
+    end
+  end
+end

data/test/xml/test_node.rb

@@ -7,7 +7,89 @@ module Nokogiri
     class TestNode < Nokogiri::TestCase
       def setup
         super
-        @xml = Nokogiri::XML.parse(File.read(XML_FILE), XML_FILE)
+        @xml = Nokogiri::XML(File.read(XML_FILE), XML_FILE)
+      end
+
+      def test_namespace_nodes
+        xml = Nokogiri::XML <<-eoxml
+          <root xmlns="http://tenderlovemaking.com/" xmlns:foo="bar">
+            <awesome/>
+          </root>
+        eoxml
+        awesome = xml.root
+        namespaces = awesome.namespace_definitions
+        assert_equal 2, namespaces.length
+      end
+
+      def test_no_definitions
+        xml = Nokogiri::XML <<-eoxml
+          <root xmlns="http://tenderlovemaking.com/" xmlns:foo="bar">
+            <awesome/>
+          </root>
+        eoxml
+        awesome = xml.at('//xmlns:awesome')
+        namespaces = awesome.namespace_definitions
+        assert_equal 0, namespaces.length
+      end
+
+      def test_subclass_dup
+        subclass = Class.new(Nokogiri::XML::Node)
+        node = subclass.new('foo', @xml).dup
+        assert_instance_of subclass, node
+      end
+
+      def test_namespace_goes_to_children
+        fruits = Nokogiri::XML(<<-eoxml)
+        <Fruit xmlns='www.fruits.org'>
+        </Fruit>
+        eoxml
+        apple = Nokogiri::XML::Node.new('Apple', fruits)
+        orange = Nokogiri::XML::Node.new('Orange', fruits)
+        apple << orange
+        fruits.root << apple
+        assert fruits.at('//fruit:Orange',{'fruit'=>'www.fruits.org'})
+        assert fruits.at('//fruit:Apple',{'fruit'=>'www.fruits.org'})
+      end
+
+      def test_description
+        assert_nil @xml.at('employee').description
+      end
+
+      def test_add_namespace_add_child
+        doc   = Nokogiri::XML::Document.new
+        item  = Nokogiri::XML::Element.new('item', doc)
+        doc.root = item
+
+        entry = Nokogiri::XML::Element.new('entry', doc)
+        entry.add_namespace('tlm', 'http://tenderlovemaking.com')
+        assert_equal 'http://tenderlovemaking.com', entry.namespaces['xmlns:tlm']
+        item.add_child(entry)
+        assert_equal 'http://tenderlovemaking.com', entry.namespaces['xmlns:tlm']
+      end
+
+      def test_spaceship
+        nodes = @xml.xpath('//employee')
+        assert_equal(-1, (nodes.first <=> nodes.last))
+        list = [nodes.first, nodes.last].sort
+        assert_equal nodes.first, list.first
+        assert_equal nodes.last, list.last
+      end
+
+      def test_incorrect_spaceship
+        nodes = @xml.xpath('//employee')
+        assert_nil(nodes.first <=> 'asdf')
+      end
+
+      def test_document_compare
+        nodes = @xml.xpath('//employee')
+        assert_equal(-1, (nodes.first <=> @xml))
+      end
+
+      def test_different_document_compare
+        nodes = @xml.xpath('//employee')
+        doc = Nokogiri::XML('<a><b/></a>')
+        b = doc.at('b')
+        assert_nil(nodes.first <=> b)
       end
 
       def test_duplicate_node_removes_namespace
@@ -22,7 +104,16 @@ module Nokogiri
         assert_equal 2, fruits.xpath('//xmlns:Apple').length
         assert_equal 1, fruits.to_xml.scan('www.fruits.org').length
       end
-      
+
+      [:clone, :dup].each do |symbol|
+        define_method "test_#{symbol}" do
+          node = @xml.at('//employee')
+          other = node.send(symbol)
+          assert_equal "employee", other.name
+          assert_nil other.parent
+        end
+      end
+
       def test_node_added_to_root_should_get_namespace
         fruits = Nokogiri::XML(<<-eoxml)
           <Fruit xmlns='http://www.fruits.org'>
@@ -40,6 +131,12 @@ module Nokogiri
         assert_equal '/root/item', item.path
       end
 
+      def test_new_node_can_have_ancestors
+        xml = Nokogiri::XML('<root>text</root>')
+        item = Nokogiri::XML::Element.new('item', xml)
+        assert_equal 0, item.ancestors.length
+      end
+
       def test_children
         doc = Nokogiri::XML(<<-eoxml)
           <root>#{'<a/>' * 9 }</root>
@@ -60,6 +157,114 @@ module Nokogiri
         assert_equal 'http://tenderlovemaking.com', node.namespaces['xmlns:foo']
       end
 
+      def test_add_default_ns
+        node = @xml.at('address')
+        node.add_namespace(nil, 'http://tenderlovemaking.com')
+        assert_equal 'http://tenderlovemaking.com', node.namespaces['xmlns']
+      end
+
+      def test_add_multiple_namespaces
+        node = @xml.at('address')
+
+        node.add_namespace(nil, 'http://tenderlovemaking.com')
+        assert_equal 'http://tenderlovemaking.com', node.namespaces['xmlns']
+
+        node.add_namespace('foo', 'http://tenderlovemaking.com')
+        assert_equal 'http://tenderlovemaking.com', node.namespaces['xmlns:foo']
+      end
+
+      def test_default_namespace=
+        node = @xml.at('address')
+        node.default_namespace = 'http://tenderlovemaking.com'
+        assert_equal 'http://tenderlovemaking.com', node.namespaces['xmlns']
+      end
+
+      def test_namespace=
+        node = @xml.at('address')
+        assert_nil node.namespace
+        definition = node.add_namespace_definition 'bar', 'http://tlm.com/'
+
+        node.namespace = definition
+
+        assert_equal definition, node.namespace
+
+        assert_equal node, @xml.at('//foo:address', {
+          'foo' => 'http://tlm.com/'
+        })
+      end
+
+      def test_add_namespace_with_nil_associates_node
+        node = @xml.at('address')
+        assert_nil node.namespace
+        definition = node.add_namespace_definition nil, 'http://tlm.com/'
+        assert_equal definition, node.namespace
+      end
+
+      def test_add_namespace_does_not_associate_node
+        node = @xml.at('address')
+        assert_nil node.namespace
+        definition = node.add_namespace_definition 'foo', 'http://tlm.com/'
+        assert_nil node.namespace
+      end
+
+      def test_set_namespace_from_different_doc
+        node = @xml.at('address')
+        doc = Nokogiri::XML(File.read(XML_FILE), XML_FILE)
+        decl = doc.root.add_namespace_definition 'foo', 'bar'
+
+        assert_raises(ArgumentError) do
+          node.namespace = decl
+        end
+      end
+
+      def test_set_namespace_must_only_take_a_namespace
+        node = @xml.at('address')
+        assert_raises(TypeError) do
+          node.namespace = node
+        end
+      end
+
+      def test_at
+        node = @xml.at('address')
+        assert_equal node, @xml.xpath('//address').first
+      end
+
+      def test_percent
+        node = @xml % ('address')
+        assert_equal node, @xml.xpath('//address').first
+      end
+
+      def test_accept
+        visitor = Class.new {
+          attr_accessor :visited
+          def accept target
+            target.accept(self)
+          end
+
+          def visit node
+            node.children.each { |c| c.accept(self) }
+            @visited = true
+          end
+        }.new
+        visitor.accept(@xml.root)
+        assert visitor.visited
+      end
+
+      def test_replace_with_default_namespaces
+        fruits = Nokogiri::XML(<<-eoxml)
+          <fruit xmlns="http://fruits.org">
+            <apple />
+          </fruit>
+        eoxml
+
+        apple = fruits.css('apple').first
+
+        orange = Nokogiri::XML::Node.new('orange', fruits)
+        apple.replace(orange)
+
+        assert_equal orange, fruits.css('orange').first
+      end
+
       def test_add_child_should_inherit_namespace
         doc = Nokogiri::XML(<<-eoxml)
           <root xmlns="http://tenderlovemaking.com/">
@@ -152,6 +357,7 @@ module Nokogiri
       def test_new
         assert node = Nokogiri::XML::Node.new('input', @xml)
         assert_equal 1, node.node_type
+        assert_instance_of Nokogiri::XML::Node, node
       end
 
       def test_to_str
@@ -452,12 +658,12 @@ module Nokogiri
       def test_node_equality
         doc1 = Nokogiri::XML.parse(File.read(XML_FILE), XML_FILE)
         doc2 = Nokogiri::XML.parse(File.read(XML_FILE), XML_FILE)
-        
+
         address1_1 = doc1.xpath('//address').first
         address1_2 = doc1.xpath('//address').first
-        
+
         address2 = doc2.xpath('//address').first
-        
+
         assert_not_equal address1_1, address2 # two references to very, very similar nodes
         assert_equal address1_1, address1_2 # two references to the exact same node
       end
@@ -536,12 +742,25 @@ EOF
 </x>
 EOF
         set = xml.search("//y/*")
-        assert_equal "a", set[0].namespace
-        assert_equal "b", set[1].namespace
-        assert_equal "c", set[2].namespace
+        assert_equal "a", set[0].namespace.prefix
+        assert_equal "b", set[1].namespace.prefix
+        assert_equal "c", set[2].namespace.prefix
         assert_equal nil, set[3].namespace
       end
 
+      def test_namespace_without_an_href_on_html_node
+        # because microsoft word's HTML formatting does this. ick.
+        xml = Nokogiri::HTML.parse <<-EOF
+<div><o:p>foo</o:p></div>
+        EOF
+
+        assert_not_nil(node = xml.at('p'))
+
+        assert_equal 1, node.namespaces.keys.size
+        assert       node.namespaces.has_key?('xmlns:o')
+        assert_equal nil, node.namespaces['xmlns:o']
+      end
+
       def test_line
         xml = Nokogiri::XML(<<-eoxml)
         <root>
@@ -556,6 +775,34 @@ EOF
         assert_equal 2, node.line
       end
 
+      def test_unlink_then_reparent
+        # see http://github.com/tenderlove/nokogiri/issues#issue/22
+        10.times do
+          STDOUT.putc "."
+          STDOUT.flush
+          begin
+            doc = Nokogiri::XML <<-EOHTML
+              <root>
+                <a>
+                  <b/>
+                  <c/>
+                </a>
+              </root>
+            EOHTML
+
+            root = doc.at("root")
+            a = root.at("a")
+            b = a.at("b")
+            c = a.at("c")
+            a.add_next_sibling(b.unlink)
+            c.unlink
+          end
+
+          GC.start
+        end
+
+      end
+
     end
   end
 end