nokogiri 1.12.5 → 1.14.3

data/lib/nokogiri/xml/pp/character_data.rb

@@ -1,17 +1,19 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
+    # :nodoc: all
     module PP
       module CharacterData
-        def pretty_print pp # :nodoc:
-          nice_name = self.class.name.split('::').last
-          pp.group(2, "#(#{nice_name} ", ')') do
-            pp.pp text
+        def pretty_print(pp)
+          nice_name = self.class.name.split("::").last
+          pp.group(2, "#(#{nice_name} ", ")") do
+            pp.pp(text)
           end
         end
 
-        def inspect # :nodoc:
-          "#<#{self.class.name}:#{sprintf("0x%x",object_id)} #{text.inspect}>"
+        def inspect
+          "#<#{self.class.name}:#{format("0x%x", object_id)} #{text.inspect}>"
         end
       end
     end

data/lib/nokogiri/xml/pp/node.rb

@@ -1,54 +1,54 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
+    # :nodoc: all
     module PP
       module Node
-        def inspect # :nodoc:
-          attributes = inspect_attributes.reject { |x|
-            begin
-              attribute = send x
-              !attribute || (attribute.respond_to?(:empty?) && attribute.empty?)
-            rescue NoMethodError
-              true
-            end
-          }.map { |attribute|
-            "#{attribute.to_s.sub(/_\w+/, 's')}=#{send(attribute).inspect}"
-          }.join ' '
-          "#<#{self.class.name}:#{sprintf("0x%x", object_id)} #{attributes}>"
-        end
+        COLLECTIONS = [:attribute_nodes, :children]
 
-        def pretty_print pp # :nodoc:
-          nice_name = self.class.name.split('::').last
-          pp.group(2, "#(#{nice_name}:#{sprintf("0x%x", object_id)} {", '})') do
+        def inspect
+          attributes = inspect_attributes.reject do |x|
+            attribute = send(x)
+            !attribute || (attribute.respond_to?(:empty?) && attribute.empty?)
+          rescue NoMethodError
+            true
+          end.map do |attribute|
+            "#{attribute.to_s.sub(/_\w+/, "s")}=#{send(attribute).inspect}"
+          end.join(" ")
+          "#<#{self.class.name}:#{format("0x%x", object_id)} #{attributes}>"
+        end
 
+        def pretty_print(pp)
+          nice_name = self.class.name.split("::").last
+          pp.group(2, "#(#{nice_name}:#{format("0x%x", object_id)} {", "})") do
             pp.breakable
-            attrs = inspect_attributes.map { |t|
+            attrs = inspect_attributes.filter_map do |t|
               [t, send(t)] if respond_to?(t)
-            }.compact.find_all { |x|
+            end.find_all do |x|
               if x.last
-                if [:attribute_nodes, :children].include? x.first
+                if COLLECTIONS.include?(x.first)
                   !x.last.empty?
                 else
                   true
                 end
               end
-            }
+            end
 
             pp.seplist(attrs) do |v|
-              if [:attribute_nodes, :children].include? v.first
-                pp.group(2, "#{v.first.to_s.sub(/_\w+$/, 's')} = [", "]") do
+              if COLLECTIONS.include?(v.first)
+                pp.group(2, "#{v.first.to_s.sub(/_\w+$/, "s")} = [", "]") do
                   pp.breakable
                   pp.seplist(v.last) do |item|
-                    pp.pp item
+                    pp.pp(item)
                   end
                 end
               else
-                pp.text "#{v.first} = "
-                pp.pp v.last
+                pp.text("#{v.first} = ")
+                pp.pp(v.last)
               end
             end
             pp.breakable
-
           end
         end
       end

data/lib/nokogiri/xml/pp.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 require_relative "pp/node"
 require_relative "pp/character_data"

data/lib/nokogiri/xml/processing_instruction.rb

@@ -1,8 +1,10 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     class ProcessingInstruction < Node
-      def initialize document, name, content
+      def initialize(document, name, content)
+        super(document, name)
       end
     end
   end

data/lib/nokogiri/xml/reader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     ###
@@ -8,18 +9,18 @@ module Nokogiri
     #
     # Here is an example of usage:
     #
-    #   reader = Nokogiri::XML::Reader(<<-eoxml)
-    #     <x xmlns:tenderlove='http://tenderlovemaking.com/'>
-    #       <tenderlove:foo awesome='true'>snuggles!</tenderlove:foo>
-    #     </x>
-    #   eoxml
+    #     reader = Nokogiri::XML::Reader(<<-eoxml)
+    #       <x xmlns:tenderlove='http://tenderlovemaking.com/'>
+    #         <tenderlove:foo awesome='true'>snuggles!</tenderlove:foo>
+    #       </x>
+    #     eoxml
     #
-    #   reader.each do |node|
+    #     reader.each do |node|
     #
-    #     # node is an instance of Nokogiri::XML::Reader
-    #     puts node.name
+    #       # node is an instance of Nokogiri::XML::Reader
+    #       puts node.name
     #
-    #   end
+    #     end
     #
     # Note that Nokogiri::XML::Reader#each can only be called once!!  Once
     # the cursor moves through the entire document, you must parse the
@@ -70,37 +71,32 @@ module Nokogiri
       # A list of errors encountered while parsing
       attr_accessor :errors
 
-      # The encoding for the document
-      attr_reader :encoding
-
       # The XML source
       attr_reader :source
 
-      alias :self_closing? :empty_element?
+      alias_method :self_closing?, :empty_element?
 
-      def initialize source, url = nil, encoding = nil # :nodoc:
+      def initialize(source, url = nil, encoding = nil) # :nodoc:
         @source   = source
         @errors   = []
         @encoding = encoding
       end
       private :initialize
 
-      ###
-      # Get the attributes of the current node as a Hash
-      # @return [Hash<String, String>] Attribute names and values
+      # Get the attributes and namespaces of the current node as a Hash.
+      #
+      # This is the union of Reader#attribute_hash and Reader#namespaces
+      #
+      # [Returns]
+      #   (Hash<String, String>) Attribute names and values, and namespace prefixes and hrefs.
       def attributes
-        attrs_hash = attribute_nodes.each_with_object({}) do |node, hash|
-                       hash[node.name] = node.to_s
-                     end
-        ns = namespaces
-        attrs_hash.merge!(ns) if ns
-        attrs_hash
+        attribute_hash.merge(namespaces)
       end
 
       ###
       # Move the cursor through the document yielding the cursor to the block
       def each
-        while cursor = self.read
+        while (cursor = read)
           yield cursor
         end
       end

data/lib/nokogiri/xml/relax_ng.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     class << self

data/lib/nokogiri/xml/sax/document.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     ###
@@ -65,7 +66,7 @@ module Nokogiri
       class Document
         ###
         # Called when an XML declaration is parsed
-        def xmldecl version, encoding, standalone
+        def xmldecl(version, encoding, standalone)
         end
 
         ###
@@ -83,13 +84,13 @@ module Nokogiri
         # * +name+ is the name of the tag
         # * +attrs+ are an assoc list of namespaces and attributes, e.g.:
         #     [ ["xmlns:foo", "http://sample.net"], ["size", "large"] ]
-        def start_element name, attrs = []
+        def start_element(name, attrs = [])
         end
 
         ###
         # Called at the end of an element
         # +name+ is the tag name
-        def end_element name
+        def end_element(name)
         end
 
         ###
@@ -99,16 +100,16 @@ module Nokogiri
         # +prefix+ is the namespace prefix for the element
         # +uri+ is the associated namespace URI
         # +ns+ is a hash of namespace prefix:urls associated with the element
-        def start_element_namespace name, attrs = [], prefix = nil, uri = nil, ns = []
+        def start_element_namespace(name, attrs = [], prefix = nil, uri = nil, ns = [])
           ###
           # Deal with SAX v1 interface
-          name = [prefix, name].compact.join(':')
-          attributes = ns.map { |ns_prefix,ns_uri|
-            [['xmlns', ns_prefix].compact.join(':'), ns_uri]
-          } + attrs.map { |attr|
-            [[attr.prefix, attr.localname].compact.join(':'), attr.value]
-          }
-          start_element name, attributes
+          name = [prefix, name].compact.join(":")
+          attributes = ns.map do |ns_prefix, ns_uri|
+            [["xmlns", ns_prefix].compact.join(":"), ns_uri]
+          end + attrs.map do |attr|
+            [[attr.prefix, attr.localname].compact.join(":"), attr.value]
+          end
+          start_element(name, attributes)
         end
 
         ###
@@ -116,10 +117,10 @@ module Nokogiri
         # +name+ is the element's name
         # +prefix+ is the namespace prefix associated with the element
         # +uri+ is the associated namespace URI
-        def end_element_namespace name, prefix = nil, uri = nil
+        def end_element_namespace(name, prefix = nil, uri = nil)
           ###
           # Deal with SAX v1 interface
-          end_element [prefix, name].compact.join(':')
+          end_element([prefix, name].compact.join(":"))
         end
 
         ###
@@ -127,38 +128,38 @@ module Nokogiri
         # times given one contiguous string of characters.
         #
         # +string+ contains the character data
-        def characters string
+        def characters(string)
         end
 
         ###
         # Called when comments are encountered
         # +string+ contains the comment data
-        def comment string
+        def comment(string)
         end
 
         ###
         # Called on document warnings
         # +string+ contains the warning
-        def warning string
+        def warning(string)
         end
 
         ###
         # Called on document errors
         # +string+ contains the error
-        def error string
+        def error(string)
         end
 
         ###
         # Called when cdata blocks are found
         # +string+ contains the cdata content
-        def cdata_block string
+        def cdata_block(string)
         end
 
         ###
         # Called when processing instructions are found
         # +name+ is the target of the instruction
         # +content+ is the value of the instruction
-        def processing_instruction name, content
+        def processing_instruction(name, content)
         end
       end
     end

data/lib/nokogiri/xml/sax/parser.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     module SAX
@@ -36,29 +37,29 @@ module Nokogiri
 
         # Encodinds this parser supports
         ENCODINGS = {
-          'NONE'        => 0, # No char encoding detected
-          'UTF-8'       => 1, # UTF-8
-          'UTF16LE'     => 2, # UTF-16 little endian
-          'UTF16BE'     => 3, # UTF-16 big endian
-          'UCS4LE'      => 4, # UCS-4 little endian
-          'UCS4BE'      => 5, # UCS-4 big endian
-          'EBCDIC'      => 6, # EBCDIC uh!
-          'UCS4-2143'   => 7, # UCS-4 unusual ordering
-          'UCS4-3412'   => 8, # UCS-4 unusual ordering
-          'UCS2'        => 9, # UCS-2
-          'ISO-8859-1'  => 10, # ISO-8859-1 ISO Latin 1
-          'ISO-8859-2'  => 11, # ISO-8859-2 ISO Latin 2
-          'ISO-8859-3'  => 12, # ISO-8859-3
-          'ISO-8859-4'  => 13, # ISO-8859-4
-          'ISO-8859-5'  => 14, # ISO-8859-5
-          'ISO-8859-6'  => 15, # ISO-8859-6
-          'ISO-8859-7'  => 16, # ISO-8859-7
-          'ISO-8859-8'  => 17, # ISO-8859-8
-          'ISO-8859-9'  => 18, # ISO-8859-9
-          'ISO-2022-JP' => 19, # ISO-2022-JP
-          'SHIFT-JIS'   => 20, # Shift_JIS
-          'EUC-JP'      => 21, # EUC-JP
-          'ASCII'       => 22, # pure ASCII
+          "NONE" => 0, # No char encoding detected
+          "UTF-8" => 1, # UTF-8
+          "UTF16LE" => 2, # UTF-16 little endian
+          "UTF16BE" => 3, # UTF-16 big endian
+          "UCS4LE" => 4, # UCS-4 little endian
+          "UCS4BE" => 5, # UCS-4 big endian
+          "EBCDIC" => 6, # EBCDIC uh!
+          "UCS4-2143" => 7, # UCS-4 unusual ordering
+          "UCS4-3412" => 8, # UCS-4 unusual ordering
+          "UCS2" => 9, # UCS-2
+          "ISO-8859-1" => 10, # ISO-8859-1 ISO Latin 1
+          "ISO-8859-2" => 11, # ISO-8859-2 ISO Latin 2
+          "ISO-8859-3" => 12, # ISO-8859-3
+          "ISO-8859-4" => 13, # ISO-8859-4
+          "ISO-8859-5" => 14, # ISO-8859-5
+          "ISO-8859-6" => 15, # ISO-8859-6
+          "ISO-8859-7" => 16, # ISO-8859-7
+          "ISO-8859-8" => 17, # ISO-8859-8
+          "ISO-8859-9" => 18, # ISO-8859-9
+          "ISO-2022-JP" => 19, # ISO-2022-JP
+          "SHIFT-JIS" => 20, # Shift_JIS
+          "EUC-JP" => 21, # EUC-JP
+          "ASCII" => 22, # pure ASCII
         }
 
         # The Nokogiri::XML::SAX::Document where events will be sent.
@@ -68,7 +69,7 @@ module Nokogiri
         attr_accessor :encoding
 
         # Create a new Parser with +doc+ and +encoding+
-        def initialize doc = Nokogiri::XML::SAX::Document.new, encoding = 'UTF-8'
+        def initialize(doc = Nokogiri::XML::SAX::Document.new, encoding = "UTF-8")
           @encoding = check_encoding(encoding)
           @document = doc
           @warned   = false
@@ -77,7 +78,7 @@ module Nokogiri
         ###
         # Parse given +thing+ which may be a string containing xml, or an
         # IO object.
-        def parse thing, &block
+        def parse(thing, &block)
           if thing.respond_to?(:read) && thing.respond_to?(:close)
             parse_io(thing, &block)
           else
@@ -87,34 +88,35 @@ module Nokogiri
 
         ###
         # Parse given +io+
-        def parse_io io, encoding = 'ASCII'
-          @encoding = check_encoding(encoding)
-          ctx = ParserContext.io(io, ENCODINGS[@encoding])
+        def parse_io(io, encoding = @encoding)
+          ctx = ParserContext.io(io, ENCODINGS[check_encoding(encoding)])
           yield ctx if block_given?
-          ctx.parse_with self
+          ctx.parse_with(self)
         end
 
         ###
         # Parse a file with +filename+
-        def parse_file filename
+        def parse_file(filename)
           raise ArgumentError unless filename
           raise Errno::ENOENT unless File.exist?(filename)
           raise Errno::EISDIR if File.directory?(filename)
-          ctx = ParserContext.file filename
+
+          ctx = ParserContext.file(filename)
           yield ctx if block_given?
-          ctx.parse_with self
+          ctx.parse_with(self)
         end
 
-        def parse_memory data
-          ctx = ParserContext.memory data
+        def parse_memory(data)
+          ctx = ParserContext.memory(data)
           yield ctx if block_given?
-          ctx.parse_with self
+          ctx.parse_with(self)
         end
 
         private
+
         def check_encoding(encoding)
           encoding.upcase.tap do |enc|
-            raise ArgumentError.new("'#{enc}' is not a valid encoding") unless ENCODINGS[enc]
+            raise ArgumentError, "'#{enc}' is not a valid encoding" unless ENCODINGS[enc]
           end
         end
       end

data/lib/nokogiri/xml/sax/parser_context.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     module SAX
@@ -7,9 +8,12 @@ module Nokogiri
       # by the user.  Instead, you should be looking at
       # Nokogiri::XML::SAX::Parser
       class ParserContext
-        def self.new thing, encoding = 'UTF-8'
-          [:read, :close].all? { |x| thing.respond_to?(x) } ?
-            io(thing, Parser::ENCODINGS[encoding]) : memory(thing)
+        def self.new(thing, encoding = "UTF-8")
+          if [:read, :close].all? { |x| thing.respond_to?(x) }
+            io(thing, Parser::ENCODINGS[encoding])
+          else
+            memory(thing)
+          end
         end
       end
     end

data/lib/nokogiri/xml/sax/push_parser.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     module SAX
@@ -24,7 +25,6 @@ module Nokogiri
       #   parser << "/div>"
       #   parser.finish
       class PushParser
-
         # The Nokogiri::XML::SAX::Document on which the PushParser will be
         # operating
         attr_accessor :document
@@ -32,7 +32,7 @@ module Nokogiri
         ###
         # Create a new PushParser with +doc+ as the SAX Document, providing
         # an optional +file_name+ and +encoding+
-        def initialize(doc = XML::SAX::Document.new, file_name = nil, encoding = 'UTF-8')
+        def initialize(doc = XML::SAX::Document.new, file_name = nil, encoding = "UTF-8")
           @document = doc
           @encoding = encoding
           @sax_parser = XML::SAX::Parser.new(doc)
@@ -44,16 +44,16 @@ module Nokogiri
         ###
         # Write a +chunk+ of XML to the PushParser.  Any callback methods
         # that can be called will be called immediately.
-        def write chunk, last_chunk = false
+        def write(chunk, last_chunk = false)
           native_write(chunk, last_chunk)
         end
-        alias :<< :write
+        alias_method :<<, :write
 
         ###
         # Finish the parsing.  This method is only necessary for
         # Nokogiri::XML::SAX::Document#end_document to be called.
         def finish
-          write '', true
+          write("", true)
         end
       end
     end

data/lib/nokogiri/xml/sax.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative "sax/document"
 require_relative "sax/parser_context"
 require_relative "sax/parser"

data/lib/nokogiri/xml/schema.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Nokogiri
   module XML
     class << self
@@ -42,7 +43,7 @@ module Nokogiri
       ###
       # Create a new Nokogiri::XML::Schema object using a +string_or_io+
       # object.
-      def self.new string_or_io, options = ParseOptions::DEFAULT_SCHEMA
+      def self.new(string_or_io, options = ParseOptions::DEFAULT_SCHEMA)
         from_document(Nokogiri::XML(string_or_io), options)
       end
 
@@ -51,9 +52,9 @@ module Nokogiri
       # Nokogiri::XML::Document object, or a filename.  An Array of
       # Nokogiri::XML::SyntaxError objects found while validating the
       # +thing+ is returned.
-      def validate thing
-        if thing.is_a?(Nokogiri::XML::Document) 
-          validate_document(thing) 
+      def validate(thing)
+        if thing.is_a?(Nokogiri::XML::Document)
+          validate_document(thing)
         elsif File.file?(thing)
           validate_file(thing)
         else
@@ -64,8 +65,8 @@ module Nokogiri
       ###
       # Returns true if +thing+ is a valid Nokogiri::XML::Document or
       # file.
-      def valid? thing
-        validate(thing).length == 0
+      def valid?(thing)
+        validate(thing).empty?
       end
     end
   end