nokogiri 1.10.3 → 1.12.5

data/ext/nokogiri/xml_document_fragment.c

@@ -1,4 +1,6 @@
-#include <xml_document_fragment.h>
+#include <nokogiri.h>
+
+VALUE cNokogiriXmlDocumentFragment;
 
 /*
  * call-seq:
@@ -6,7 +8,8 @@
  *
  * Create a new DocumentFragment element on the +document+
  */
-static VALUE new(int argc, VALUE *argv, VALUE klass)
+static VALUE
+new (int argc, VALUE *argv, VALUE klass)
 {
   xmlDocPtr xml_doc;
   xmlNodePtr node;
@@ -20,29 +23,24 @@ static VALUE new(int argc, VALUE *argv, VALUE klass)
 
   node = xmlNewDocFragment(xml_doc->doc);
 
-  nokogiri_root_node(node);
+  noko_xml_document_pin_node(node);
 
-  rb_node = Nokogiri_wrap_xml_node(klass, node);
+  rb_node = noko_xml_node_wrap(klass, node);
   rb_obj_call_init(rb_node, argc, argv);
 
-  if(rb_block_given_p()) rb_yield(rb_node);
+  if (rb_block_given_p()) { rb_yield(rb_node); }
 
   return rb_node;
 }
 
-VALUE cNokogiriXmlDocumentFragment;
-void init_xml_document_fragment()
+void
+noko_init_xml_document_fragment()
 {
-  VALUE nokogiri = rb_define_module("Nokogiri");
-  VALUE xml = rb_define_module_under(nokogiri, "XML");
-  VALUE node = rb_define_class_under(xml, "Node", rb_cObject);
-
+  assert(cNokogiriXmlNode);
   /*
    * DocumentFragment represents a DocumentFragment node in an xml document.
    */
-  VALUE klass = rb_define_class_under(xml, "DocumentFragment", node);
-
-  cNokogiriXmlDocumentFragment = klass;
+  cNokogiriXmlDocumentFragment = rb_define_class_under(mNokogiriXml, "DocumentFragment", cNokogiriXmlNode);
 
-  rb_define_singleton_method(klass, "new", new, -1);
+  rb_define_singleton_method(cNokogiriXmlDocumentFragment, "new", new, -1);
 }

data/ext/nokogiri/xml_dtd.c

@@ -1,30 +1,35 @@
-#include <xml_dtd.h>
+#include <nokogiri.h>
 
-static void notation_copier(void *payload, void *data, const xmlChar *name)
+VALUE cNokogiriXmlDtd;
+
+static void
+notation_copier(void *c_notation_ptr, void *rb_hash_ptr, const xmlChar *name)
 {
-  VALUE hash = (VALUE)data;
-  VALUE klass = rb_const_get(mNokogiriXml, rb_intern("Notation"));
+  VALUE rb_hash = (VALUE)rb_hash_ptr;
+  xmlNotationPtr c_notation = (xmlNotationPtr)c_notation_ptr;
+  VALUE rb_notation;
+  VALUE cNokogiriXmlNotation;
+  VALUE rb_constructor_args[3];
 
-  xmlNotationPtr c_notation = (xmlNotationPtr)payload;
-  VALUE notation;
-  VALUE argv[3];
-  argv[0] = (c_notation->name ? NOKOGIRI_STR_NEW2(c_notation->name) : Qnil);
-  argv[1] = (c_notation->PublicID ? NOKOGIRI_STR_NEW2(c_notation->PublicID) : Qnil);
-  argv[2] = (c_notation->SystemID ? NOKOGIRI_STR_NEW2(c_notation->SystemID) : Qnil);
+  rb_constructor_args[0] = (c_notation->name ? NOKOGIRI_STR_NEW2(c_notation->name) : Qnil);
+  rb_constructor_args[1] = (c_notation->PublicID ? NOKOGIRI_STR_NEW2(c_notation->PublicID) : Qnil);
+  rb_constructor_args[2] = (c_notation->SystemID ? NOKOGIRI_STR_NEW2(c_notation->SystemID) : Qnil);
 
-  notation = rb_class_new_instance(3, argv, klass);
+  cNokogiriXmlNotation = rb_const_get_at(mNokogiriXml, rb_intern("Notation"));
+  rb_notation = rb_class_new_instance(3, rb_constructor_args, cNokogiriXmlNotation);
 
-  rb_hash_aset(hash, NOKOGIRI_STR_NEW2(name),notation);
+  rb_hash_aset(rb_hash, NOKOGIRI_STR_NEW2(name), rb_notation);
 }
 
-static void element_copier(void *_payload, void *data, const xmlChar *name)
+static void
+element_copier(void *c_node_ptr, void *rb_hash_ptr, const xmlChar *c_name)
 {
-  VALUE hash = (VALUE)data;
-  xmlNodePtr payload = (xmlNodePtr)_payload;
+  VALUE rb_hash = (VALUE)rb_hash_ptr;
+  xmlNodePtr c_node = (xmlNodePtr)c_node_ptr;
 
-  VALUE element = Nokogiri_wrap_xml_node(Qnil, payload);
+  VALUE rb_node = noko_xml_node_wrap(Qnil, c_node);
 
-  rb_hash_aset(hash, NOKOGIRI_STR_NEW2(name), element);
+  rb_hash_aset(rb_hash, NOKOGIRI_STR_NEW2(c_name), rb_node);
 }
 
 /*
@@ -33,14 +38,15 @@ static void element_copier(void *_payload, void *data, const xmlChar *name)
  *
  * Get a hash of the elements for this DTD.
  */
-static VALUE entities(VALUE self)
+static VALUE
+entities(VALUE self)
 {
   xmlDtdPtr dtd;
   VALUE hash;
 
   Data_Get_Struct(self, xmlDtd, dtd);
 
-  if(!dtd->entities) return Qnil;
+  if (!dtd->entities) { return Qnil; }
 
   hash = rb_hash_new();
 
@@ -55,14 +61,15 @@ static VALUE entities(VALUE self)
  *
  * Get a hash of the notations for this DTD.
  */
-static VALUE notations(VALUE self)
+static VALUE
+notations(VALUE self)
 {
   xmlDtdPtr dtd;
   VALUE hash;
 
   Data_Get_Struct(self, xmlDtd, dtd);
 
-  if(!dtd->notations) return Qnil;
+  if (!dtd->notations) { return Qnil; }
 
   hash = rb_hash_new();
 
@@ -77,7 +84,8 @@ static VALUE notations(VALUE self)
  *
  * Get a hash of the attributes for this DTD.
  */
-static VALUE attributes(VALUE self)
+static VALUE
+attributes(VALUE self)
 {
   xmlDtdPtr dtd;
   VALUE hash;
@@ -86,7 +94,7 @@ static VALUE attributes(VALUE self)
 
   hash = rb_hash_new();
 
-  if(!dtd->attributes) return hash;
+  if (!dtd->attributes) { return hash; }
 
   xmlHashScan((xmlHashTablePtr)dtd->attributes, element_copier, (void *)hash);
 
@@ -99,14 +107,15 @@ static VALUE attributes(VALUE self)
  *
  * Get a hash of the elements for this DTD.
  */
-static VALUE elements(VALUE self)
+static VALUE
+elements(VALUE self)
 {
   xmlDtdPtr dtd;
   VALUE hash;
 
   Data_Get_Struct(self, xmlDtd, dtd);
 
-  if(!dtd->elements) return Qnil;
+  if (!dtd->elements) { return Qnil; }
 
   hash = rb_hash_new();
 
@@ -121,7 +130,8 @@ static VALUE elements(VALUE self)
  *
  * Validate +document+ returning a list of errors
  */
-static VALUE validate(VALUE self, VALUE document)
+static VALUE
+validate(VALUE self, VALUE document)
 {
   xmlDocPtr doc;
   xmlDtdPtr dtd;
@@ -151,12 +161,13 @@ static VALUE validate(VALUE self, VALUE document)
  *
  * Get the System ID for this DTD
  */
-static VALUE system_id(VALUE self)
+static VALUE
+system_id(VALUE self)
 {
   xmlDtdPtr dtd;
   Data_Get_Struct(self, xmlDtd, dtd);
 
-  if(!dtd->SystemID) return Qnil;
+  if (!dtd->SystemID) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(dtd->SystemID);
 }
@@ -167,36 +178,31 @@ static VALUE system_id(VALUE self)
  *
  * Get the External ID for this DTD
  */
-static VALUE external_id(VALUE self)
+static VALUE
+external_id(VALUE self)
 {
   xmlDtdPtr dtd;
   Data_Get_Struct(self, xmlDtd, dtd);
 
-  if(!dtd->ExternalID) return Qnil;
+  if (!dtd->ExternalID) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(dtd->ExternalID);
 }
 
-VALUE cNokogiriXmlDtd;
-
-void init_xml_dtd()
+void
+noko_init_xml_dtd()
 {
-  VALUE nokogiri = rb_define_module("Nokogiri");
-  VALUE xml = rb_define_module_under(nokogiri, "XML");
-  VALUE node = rb_define_class_under(xml, "Node", rb_cObject);
-
+  assert(cNokogiriXmlNode);
   /*
    * Nokogiri::XML::DTD wraps DTD nodes in an XML document
    */
-  VALUE klass = rb_define_class_under(xml, "DTD", node);
-
-  cNokogiriXmlDtd = klass;
-
-  rb_define_method(klass, "notations", notations, 0);
-  rb_define_method(klass, "elements", elements, 0);
-  rb_define_method(klass, "entities", entities, 0);
-  rb_define_method(klass, "validate", validate, 1);
-  rb_define_method(klass, "attributes", attributes, 0);
-  rb_define_method(klass, "system_id", system_id, 0);
-  rb_define_method(klass, "external_id", external_id, 0);
+  cNokogiriXmlDtd = rb_define_class_under(mNokogiriXml, "DTD", cNokogiriXmlNode);
+
+  rb_define_method(cNokogiriXmlDtd, "notations", notations, 0);
+  rb_define_method(cNokogiriXmlDtd, "elements", elements, 0);
+  rb_define_method(cNokogiriXmlDtd, "entities", entities, 0);
+  rb_define_method(cNokogiriXmlDtd, "validate", validate, 1);
+  rb_define_method(cNokogiriXmlDtd, "attributes", attributes, 0);
+  rb_define_method(cNokogiriXmlDtd, "system_id", system_id, 0);
+  rb_define_method(cNokogiriXmlDtd, "external_id", external_id, 0);
 }

data/ext/nokogiri/xml_element_content.c

@@ -1,4 +1,4 @@
-#include <xml_element_content.h>
+#include <nokogiri.h>
 
 VALUE cNokogiriXmlElementContent;
 
@@ -8,12 +8,13 @@ VALUE cNokogiriXmlElementContent;
  *
  * Get the require element +name+
  */
-static VALUE get_name(VALUE self)
+static VALUE
+get_name(VALUE self)
 {
   xmlElementContentPtr elem;
   Data_Get_Struct(self, xmlElementContent, elem);
 
-  if(!elem->name) return Qnil;
+  if (!elem->name) { return Qnil; }
   return NOKOGIRI_STR_NEW2(elem->name);
 }
 
@@ -24,7 +25,8 @@ static VALUE get_name(VALUE self)
  * Get the element content +type+.  Possible values are PCDATA, ELEMENT, SEQ,
  * or OR.
  */
-static VALUE get_type(VALUE self)
+static VALUE
+get_type(VALUE self)
 {
   xmlElementContentPtr elem;
   Data_Get_Struct(self, xmlElementContent, elem);
@@ -38,13 +40,14 @@ static VALUE get_type(VALUE self)
  *
  * Get the first child.
  */
-static VALUE get_c1(VALUE self)
+static VALUE
+get_c1(VALUE self)
 {
   xmlElementContentPtr elem;
   Data_Get_Struct(self, xmlElementContent, elem);
 
-  if(!elem->c1) return Qnil;
-  return Nokogiri_wrap_element_content(rb_iv_get(self, "@document"), elem->c1);
+  if (!elem->c1) { return Qnil; }
+  return noko_xml_element_content_wrap(rb_iv_get(self, "@document"), elem->c1);
 }
 
 /*
@@ -53,13 +56,14 @@ static VALUE get_c1(VALUE self)
  *
  * Get the first child.
  */
-static VALUE get_c2(VALUE self)
+static VALUE
+get_c2(VALUE self)
 {
   xmlElementContentPtr elem;
   Data_Get_Struct(self, xmlElementContent, elem);
 
-  if(!elem->c2) return Qnil;
-  return Nokogiri_wrap_element_content(rb_iv_get(self, "@document"), elem->c2);
+  if (!elem->c2) { return Qnil; }
+  return noko_xml_element_content_wrap(rb_iv_get(self, "@document"), elem->c2);
 }
 
 /*
@@ -69,7 +73,8 @@ static VALUE get_c2(VALUE self)
  * Get the element content +occur+ flag.  Possible values are ONCE, OPT, MULT
  * or PLUS.
  */
-static VALUE get_occur(VALUE self)
+static VALUE
+get_occur(VALUE self)
 {
   xmlElementContentPtr elem;
   Data_Get_Struct(self, xmlElementContent, elem);
@@ -83,17 +88,19 @@ static VALUE get_occur(VALUE self)
  *
  * Get the element content namespace +prefix+.
  */
-static VALUE get_prefix(VALUE self)
+static VALUE
+get_prefix(VALUE self)
 {
   xmlElementContentPtr elem;
   Data_Get_Struct(self, xmlElementContent, elem);
 
-  if(!elem->prefix) return Qnil;
+  if (!elem->prefix) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(elem->prefix);
 }
 
-VALUE Nokogiri_wrap_element_content(VALUE doc, xmlElementContentPtr element)
+VALUE
+noko_xml_element_content_wrap(VALUE doc, xmlElementContentPtr element)
 {
   VALUE elem = Data_Wrap_Struct(cNokogiriXmlElementContent, 0, 0, element);
 
@@ -104,20 +111,18 @@ VALUE Nokogiri_wrap_element_content(VALUE doc, xmlElementContentPtr element)
   return elem;
 }
 
-void init_xml_element_content()
+void
+noko_init_xml_element_content()
 {
-  VALUE nokogiri = rb_define_module("Nokogiri");
-  VALUE xml = rb_define_module_under(nokogiri, "XML");
+  cNokogiriXmlElementContent = rb_define_class_under(mNokogiriXml, "ElementContent", rb_cObject);
 
-  VALUE klass = rb_define_class_under(xml, "ElementContent", rb_cObject);
+  rb_undef_alloc_func(cNokogiriXmlElementContent);
 
-  cNokogiriXmlElementContent = klass;
+  rb_define_method(cNokogiriXmlElementContent, "name", get_name, 0);
+  rb_define_method(cNokogiriXmlElementContent, "type", get_type, 0);
+  rb_define_method(cNokogiriXmlElementContent, "occur", get_occur, 0);
+  rb_define_method(cNokogiriXmlElementContent, "prefix", get_prefix, 0);
 
-  rb_define_method(klass, "name", get_name, 0);
-  rb_define_method(klass, "type", get_type, 0);
-  rb_define_method(klass, "occur", get_occur, 0);
-  rb_define_method(klass, "prefix", get_prefix, 0);
-
-  rb_define_private_method(klass, "c1", get_c1, 0);
-  rb_define_private_method(klass, "c2", get_c2, 0);
+  rb_define_private_method(cNokogiriXmlElementContent, "c1", get_c1, 0);
+  rb_define_private_method(cNokogiriXmlElementContent, "c2", get_c2, 0);
 }

data/ext/nokogiri/xml_element_decl.c

@@ -1,4 +1,6 @@
-#include <xml_element_decl.h>
+#include <nokogiri.h>
+
+VALUE cNokogiriXmlElementDecl;
 
 static ID id_document;
 
@@ -8,7 +10,8 @@ static ID id_document;
  *
  * The element_type
  */
-static VALUE element_type(VALUE self)
+static VALUE
+element_type(VALUE self)
 {
   xmlElementPtr node;
   Data_Get_Struct(self, xmlElement, node);
@@ -21,17 +24,18 @@ static VALUE element_type(VALUE self)
  *
  * The allowed content for this ElementDecl
  */
-static VALUE content(VALUE self)
+static VALUE
+content(VALUE self)
 {
   xmlElementPtr node;
   Data_Get_Struct(self, xmlElement, node);
 
-  if(!node->content) return Qnil;
+  if (!node->content) { return Qnil; }
 
-  return Nokogiri_wrap_element_content(
-      rb_funcall(self, id_document, 0),
-      node->content
-  );
+  return noko_xml_element_content_wrap(
+           rb_funcall(self, id_document, 0),
+           node->content
+         );
 }
 
 /*
@@ -40,30 +44,26 @@ static VALUE content(VALUE self)
  *
  * The namespace prefix for this ElementDecl
  */
-static VALUE prefix(VALUE self)
+static VALUE
+prefix(VALUE self)
 {
   xmlElementPtr node;
   Data_Get_Struct(self, xmlElement, node);
 
-  if(!node->prefix) return Qnil;
+  if (!node->prefix) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(node->prefix);
 }
 
-VALUE cNokogiriXmlElementDecl;
-
-void init_xml_element_decl()
+void
+noko_init_xml_element_decl()
 {
-  VALUE nokogiri = rb_define_module("Nokogiri");
-  VALUE xml = rb_define_module_under(nokogiri, "XML");
-  VALUE node = rb_define_class_under(xml, "Node", rb_cObject);
-  VALUE klass = rb_define_class_under(xml, "ElementDecl", node);
-
-  cNokogiriXmlElementDecl = klass;
+  assert(cNokogiriXmlNode);
+  cNokogiriXmlElementDecl = rb_define_class_under(mNokogiriXml, "ElementDecl", cNokogiriXmlNode);
 
-  rb_define_method(klass, "element_type", element_type, 0);
-  rb_define_method(klass, "content", content, 0);
-  rb_define_method(klass, "prefix", prefix, 0);
+  rb_define_method(cNokogiriXmlElementDecl, "element_type", element_type, 0);
+  rb_define_method(cNokogiriXmlElementDecl, "content", content, 0);
+  rb_define_method(cNokogiriXmlElementDecl, "prefix", prefix, 0);
 
   id_document = rb_intern("document");
 }

data/ext/nokogiri/xml_encoding_handler.c

@@ -1,17 +1,22 @@
-#include <xml_encoding_handler.h>
+#include <nokogiri.h>
+
+VALUE cNokogiriEncodingHandler;
+
 
 /*
  * call-seq: Nokogiri::EncodingHandler.[](name)
  *
  * Get the encoding handler for +name+
  */
-static VALUE get(VALUE klass, VALUE key)
+static VALUE
+get(VALUE klass, VALUE key)
 {
   xmlCharEncodingHandlerPtr handler;
 
   handler = xmlFindCharEncodingHandler(StringValueCStr(key));
-  if(handler)
+  if (handler) {
     return Data_Wrap_Struct(klass, NULL, NULL, handler);
+  }
 
   return Qnil;
 }
@@ -21,9 +26,10 @@ static VALUE get(VALUE klass, VALUE key)
  *
  * Delete the encoding alias named +name+
  */
-static VALUE delete(VALUE klass, VALUE name)
+static VALUE
+delete (VALUE klass, VALUE name)
 {
-  if(xmlDelEncodingAlias(StringValueCStr(name))) return Qnil;
+  if (xmlDelEncodingAlias(StringValueCStr(name))) { return Qnil; }
 
   return Qtrue;
 }
@@ -33,7 +39,8 @@ static VALUE delete(VALUE klass, VALUE name)
  *
  * Alias encoding handler with name +from+ to name +to+
  */
-static VALUE alias(VALUE klass, VALUE from, VALUE to)
+static VALUE
+alias(VALUE klass, VALUE from, VALUE to)
 {
   xmlAddEncodingAlias(StringValueCStr(from), StringValueCStr(to));
 
@@ -45,7 +52,8 @@ static VALUE alias(VALUE klass, VALUE from, VALUE to)
  *
  * Remove all encoding aliases.
  */
-static VALUE clear_aliases(VALUE klass)
+static VALUE
+clear_aliases(VALUE klass)
 {
   xmlCleanupEncodingAliases();
 
@@ -57,7 +65,8 @@ static VALUE clear_aliases(VALUE klass)
  *
  * Get the name of this EncodingHandler
  */
-static VALUE name(VALUE self)
+static VALUE
+name(VALUE self)
 {
   xmlCharEncodingHandlerPtr handler;
 
@@ -66,14 +75,16 @@ static VALUE name(VALUE self)
   return NOKOGIRI_STR_NEW2(handler->name);
 }
 
-void init_xml_encoding_handler()
+void
+noko_init_xml_encoding_handler()
 {
-  VALUE nokogiri = rb_define_module("Nokogiri");
-  VALUE klass = rb_define_class_under(nokogiri, "EncodingHandler", rb_cObject);
-
-  rb_define_singleton_method(klass, "[]", get, 1);
-  rb_define_singleton_method(klass, "delete", delete, 1);
-  rb_define_singleton_method(klass, "alias", alias, 2);
-  rb_define_singleton_method(klass, "clear_aliases!", clear_aliases, 0);
-  rb_define_method(klass, "name", name, 0);
+  cNokogiriEncodingHandler = rb_define_class_under(mNokogiri, "EncodingHandler", rb_cObject);
+
+  rb_undef_alloc_func(cNokogiriEncodingHandler);
+
+  rb_define_singleton_method(cNokogiriEncodingHandler, "[]", get, 1);
+  rb_define_singleton_method(cNokogiriEncodingHandler, "delete", delete, 1);
+  rb_define_singleton_method(cNokogiriEncodingHandler, "alias", alias, 2);
+  rb_define_singleton_method(cNokogiriEncodingHandler, "clear_aliases!", clear_aliases, 0);
+  rb_define_method(cNokogiriEncodingHandler, "name", name, 0);
 }

data/ext/nokogiri/xml_entity_decl.c

@@ -1,4 +1,6 @@
-#include <xml_entity_decl.h>
+#include <nokogiri.h>
+
+VALUE cNokogiriXmlEntityDecl;
 
 /*
  * call-seq:
@@ -6,12 +8,13 @@
  *
  * Get the original_content before ref substitution
  */
-static VALUE original_content(VALUE self)
+static VALUE
+original_content(VALUE self)
 {
   xmlEntityPtr node;
   Data_Get_Struct(self, xmlEntity, node);
 
-  if(!node->orig) return Qnil;
+  if (!node->orig) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(node->orig);
 }
@@ -22,12 +25,13 @@ static VALUE original_content(VALUE self)
  *
  * Get the content
  */
-static VALUE get_content(VALUE self)
+static VALUE
+get_content(VALUE self)
 {
   xmlEntityPtr node;
   Data_Get_Struct(self, xmlEntity, node);
 
-  if(!node->content) return Qnil;
+  if (!node->content) { return Qnil; }
 
   return NOKOGIRI_STR_NEW(node->content, node->length);
 }
@@ -38,7 +42,8 @@ static VALUE get_content(VALUE self)
  *
  * Get the entity type
  */
-static VALUE entity_type(VALUE self)
+static VALUE
+entity_type(VALUE self)
 {
   xmlEntityPtr node;
   Data_Get_Struct(self, xmlEntity, node);
@@ -52,12 +57,13 @@ static VALUE entity_type(VALUE self)
  *
  * Get the external identifier for PUBLIC
  */
-static VALUE external_id(VALUE self)
+static VALUE
+external_id(VALUE self)
 {
   xmlEntityPtr node;
   Data_Get_Struct(self, xmlEntity, node);
 
-  if(!node->ExternalID) return Qnil;
+  if (!node->ExternalID) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(node->ExternalID);
 }
@@ -68,43 +74,39 @@ static VALUE external_id(VALUE self)
  *
  * Get the URI for a SYSTEM or PUBLIC Entity
  */
-static VALUE system_id(VALUE self)
+static VALUE
+system_id(VALUE self)
 {
   xmlEntityPtr node;
   Data_Get_Struct(self, xmlEntity, node);
 
-  if(!node->SystemID) return Qnil;
+  if (!node->SystemID) { return Qnil; }
 
   return NOKOGIRI_STR_NEW2(node->SystemID);
 }
 
-VALUE cNokogiriXmlEntityDecl;
-
-void init_xml_entity_decl()
+void
+noko_init_xml_entity_decl()
 {
-  VALUE nokogiri = rb_define_module("Nokogiri");
-  VALUE xml = rb_define_module_under(nokogiri, "XML");
-  VALUE node = rb_define_class_under(xml, "Node", rb_cObject);
-  VALUE klass = rb_define_class_under(xml, "EntityDecl", node);
-
-  cNokogiriXmlEntityDecl = klass;
+  assert(cNokogiriXmlNode);
+  cNokogiriXmlEntityDecl = rb_define_class_under(mNokogiriXml, "EntityDecl", cNokogiriXmlNode);
 
-  rb_define_method(klass, "original_content", original_content, 0);
-  rb_define_method(klass, "content", get_content, 0);
-  rb_define_method(klass, "entity_type", entity_type, 0);
-  rb_define_method(klass, "external_id", external_id, 0);
-  rb_define_method(klass, "system_id", system_id, 0);
+  rb_define_method(cNokogiriXmlEntityDecl, "original_content", original_content, 0);
+  rb_define_method(cNokogiriXmlEntityDecl, "content", get_content, 0);
+  rb_define_method(cNokogiriXmlEntityDecl, "entity_type", entity_type, 0);
+  rb_define_method(cNokogiriXmlEntityDecl, "external_id", external_id, 0);
+  rb_define_method(cNokogiriXmlEntityDecl, "system_id", system_id, 0);
 
   rb_const_set(cNokogiriXmlEntityDecl, rb_intern("INTERNAL_GENERAL"),
-      INT2NUM(XML_INTERNAL_GENERAL_ENTITY));
+               INT2NUM(XML_INTERNAL_GENERAL_ENTITY));
   rb_const_set(cNokogiriXmlEntityDecl, rb_intern("EXTERNAL_GENERAL_PARSED"),
-      INT2NUM(XML_EXTERNAL_GENERAL_PARSED_ENTITY));
+               INT2NUM(XML_EXTERNAL_GENERAL_PARSED_ENTITY));
   rb_const_set(cNokogiriXmlEntityDecl, rb_intern("EXTERNAL_GENERAL_UNPARSED"),
-      INT2NUM(XML_EXTERNAL_GENERAL_UNPARSED_ENTITY));
+               INT2NUM(XML_EXTERNAL_GENERAL_UNPARSED_ENTITY));
   rb_const_set(cNokogiriXmlEntityDecl, rb_intern("INTERNAL_PARAMETER"),
-      INT2NUM(XML_INTERNAL_PARAMETER_ENTITY));
+               INT2NUM(XML_INTERNAL_PARAMETER_ENTITY));
   rb_const_set(cNokogiriXmlEntityDecl, rb_intern("EXTERNAL_PARAMETER"),
-      INT2NUM(XML_EXTERNAL_PARAMETER_ENTITY));
+               INT2NUM(XML_EXTERNAL_PARAMETER_ENTITY));
   rb_const_set(cNokogiriXmlEntityDecl, rb_intern("INTERNAL_PREDEFINED"),
-      INT2NUM(XML_INTERNAL_PREDEFINED_ENTITY));
+               INT2NUM(XML_INTERNAL_PREDEFINED_ENTITY));
 }