nokogiri-fitzsimmons 1.5.5

data/test/xml/test_node_attributes.rb

@@ -0,0 +1,53 @@
+require "helper"
+
+module Nokogiri
+  module XML
+    class TestNodeAttributes < Nokogiri::TestCase
+      def test_attribute_with_ns
+        doc = Nokogiri::XML <<-eoxml
+          <root xmlns:tlm='http://tenderlovemaking.com/'>
+            <node tlm:foo='bar' foo='baz' />
+          </root>
+        eoxml
+
+        node = doc.at('node')
+
+        assert_equal 'bar',
+          node.attribute_with_ns('foo', 'http://tenderlovemaking.com/').value
+      end
+
+      def test_namespace_key?
+        doc = Nokogiri::XML <<-eoxml
+          <root xmlns:tlm='http://tenderlovemaking.com/'>
+            <node tlm:foo='bar' foo='baz' />
+          </root>
+        eoxml
+
+        node = doc.at('node')
+
+        assert node.namespaced_key?('foo', 'http://tenderlovemaking.com/')
+        assert node.namespaced_key?('foo', nil)
+        assert !node.namespaced_key?('foo', 'foo')
+      end
+
+      def test_set_attribute_frees_nodes # testing a segv
+        skip("JRuby doesn't do GC.") if Nokogiri.jruby?
+        document = Nokogiri::XML.parse("<foo></foo>")
+
+        node = document.root
+        node['visible'] = 'foo'
+        attribute = node.attribute('visible')
+        text = Nokogiri::XML::Text.new 'bar', document
+        attribute.add_child(text)
+
+        begin
+          gc_previous = GC.stress
+          GC.stress = true
+          node['visible'] = 'attr'
+        ensure
+          GC.stress = gc_previous
+        end
+      end
+    end
+  end
+end

data/test/xml/test_node_encoding.rb

@@ -0,0 +1,107 @@
+require "helper"
+
+module Nokogiri
+  module XML
+    if RUBY_VERSION =~ /^1\.9/
+      class TestNodeEncoding < Nokogiri::TestCase
+        def setup
+          super
+          @html = Nokogiri::HTML(File.read(HTML_FILE), HTML_FILE)
+        end
+
+        def test_get_attribute
+          node = @html.css('a').first
+          assert_equal @html.encoding, node['href'].encoding.name
+        end
+
+        def test_text_encoding_is_utf_8
+          @html = Nokogiri::HTML(File.open(NICH_FILE))
+          assert_equal 'UTF-8', @html.text.encoding.name
+        end
+
+        def test_serialize_encoding_html
+          @html = Nokogiri::HTML(File.open(NICH_FILE))
+          assert_equal @html.encoding.downcase,
+            @html.serialize.encoding.name.downcase
+
+          @doc = Nokogiri::HTML(@html.serialize)
+          assert_equal @html.serialize, @doc.serialize
+        end
+
+        def test_serialize_encoding_xml
+          @xml = Nokogiri::XML(File.open(SHIFT_JIS_XML))
+          assert_equal @xml.encoding.downcase,
+            @xml.serialize.encoding.name.downcase
+
+          @doc = Nokogiri::XML(@xml.serialize)
+          assert_equal @xml.serialize, @doc.serialize
+        end
+
+        def test_encode_special_chars
+          foo = @html.css('a').first.encode_special_chars('foo')
+          assert_equal @html.encoding, foo.encoding.name
+        end
+
+        def test_content
+          node = @html.css('a').first
+          assert_equal @html.encoding, node.content.encoding.name
+        end
+
+        def test_name
+          node = @html.css('a').first
+          assert_equal @html.encoding, node.name.encoding.name
+        end
+
+        def test_path
+          node = @html.css('a').first
+          assert_equal @html.encoding, node.path.encoding.name
+        end
+
+        def test_namespace
+          xml = <<-eoxml
+<root>
+ <car xmlns:part="http://general-motors.com/">
+  <part:tire>Michelin Model XGV</part:tire>
+ </car>
+ <bicycle xmlns:part="http://schwinn.com/">
+  <part:tire>I'm a bicycle tire!</part:tire>
+ </bicycle>
+</root>
+          eoxml
+          doc = Nokogiri::XML(xml, nil, 'UTF-8')
+          assert_equal 'UTF-8', doc.encoding
+          n = doc.xpath('//part:tire', { 'part' => 'http://schwinn.com/' }).first
+          assert n
+          assert_equal doc.encoding, n.namespace.href.encoding.name
+          assert_equal doc.encoding, n.namespace.prefix.encoding.name
+        end
+
+        def test_namespace_as_hash
+          xml = <<-eoxml
+<root>
+ <car xmlns:part="http://general-motors.com/">
+  <part:tire>Michelin Model XGV</part:tire>
+ </car>
+ <bicycle xmlns:part="http://schwinn.com/">
+  <part:tire>I'm a bicycle tire!</part:tire>
+ </bicycle>
+</root>
+          eoxml
+          doc = Nokogiri::XML(xml, nil, 'UTF-8')
+          assert_equal 'UTF-8', doc.encoding
+          assert n = doc.xpath('//car').first
+
+          n.namespace_definitions.each do |nd|
+            assert_equal doc.encoding, nd.href.encoding.name
+            assert_equal doc.encoding, nd.prefix.encoding.name
+          end
+
+          n.namespaces.each do |k,v|
+            assert_equal doc.encoding, k.encoding.name
+            assert_equal doc.encoding, v.encoding.name
+          end
+        end
+      end
+    end
+  end
+end

data/test/xml/test_node_inheritance.rb

@@ -0,0 +1,32 @@
+# issue#560
+
+require 'helper'
+
+module Nokogiri
+  module XML
+    class TestNodeInheritance < Nokogiri::TestCase
+      MyNode = Class.new Nokogiri::XML::Node
+      def setup
+        super
+        @node = MyNode.new 'foo', Nokogiri::XML::Document.new
+        @node['foo'] = 'bar' 
+      end
+
+      def test_node_name
+        assert @node.name == 'foo'
+      end
+
+      def test_node_writing_an_attribute_accessing_via_attributes 
+        assert @node.attributes['foo']
+      end
+
+      def test_node_writing_an_attribute_accessing_via_key 
+        assert @node.key? 'foo'
+      end
+
+      def test_node_writing_an_attribute_accessing_via_brackets 
+        assert @node['foo'] == 'bar'
+      end
+    end
+  end
+end

data/test/xml/test_node_reparenting.rb

@@ -0,0 +1,374 @@
+require "helper"
+
+module Nokogiri
+  module XML
+    class TestNodeReparenting < Nokogiri::TestCase
+
+      describe "standard node reparenting behavior" do
+        # describe "namespace handling during reparenting" do
+        #   describe "given a Node" do
+        #     describe "with a Namespace" do
+        #       it "keeps the Namespace"
+        #     end
+        #     describe "given a parent Node with a default and a non-default Namespace" do
+        #       describe "passed an Node without a namespace" do
+        #         it "inserts an Node that inherits the default Namespace"
+        #       end
+        #       describe "passed a Node with a Namespace that matches the parent's non-default Namespace" do
+        #         it "inserts a Node that inherits the matching parent Namespace"
+        #       end
+        #     end
+        #   end
+        #   describe "given a markup string" do
+        #     describe "parsed relative to the document" do
+        #       describe "with a Namespace" do
+        #         it "keeps the Namespace"
+        #       end
+        #       describe "given a parent Node with a default and a non-default Namespace" do
+        #         describe "passed an Node without a namespace" do
+        #           it "inserts an Node that inherits the default Namespace"
+        #         end
+        #         describe "passed a Node with a Namespace that matches the parent's non-default Namespace" do
+        #           it "inserts a Node that inherits the matching parent Namespace"
+        #         end
+        #       end
+        #     end
+        #     describe "parsed relative to a specific node" do
+        #       describe "with a Namespace" do
+        #         it "keeps the Namespace"
+        #       end
+        #       describe "given a parent Node with a default and a non-default Namespace" do
+        #         describe "passed an Node without a namespace" do
+        #           it "inserts an Node that inherits the default Namespace"
+        #         end
+        #         describe "passed a Node with a Namespace that matches the parent's non-default Namespace" do
+        #           it "inserts a Node that inherits the matching parent Namespace"
+        #         end
+        #       end
+        #     end
+        #   end
+        # end
+
+        {
+          :add_child            => {:target => "/root/a1",        :returns_self => false, :children_tags => %w[text b1 b2]},
+          :<<                   => {:target => "/root/a1",        :returns_self => true, :children_tags => %w[text b1 b2]},
+
+          :replace              => {:target => "/root/a1/node()", :returns_self => false, :children_tags => %w[b1 b2]},
+          :swap                 => {:target => "/root/a1/node()", :returns_self => true,  :children_tags => %w[b1 b2]},
+
+          :children=            => {:target => "/root/a1",        :returns_self => false, :children_tags => %w[b1 b2]},
+          :inner_html=          => {:target => "/root/a1",        :returns_self => true,  :children_tags => %w[b1 b2]},
+
+          :add_previous_sibling => {:target => "/root/a1/text()", :returns_self => false, :children_tags => %w[b1 b2 text]},
+          :previous=            => {:target => "/root/a1/text()", :returns_self => false, :children_tags => %w[b1 b2 text]},
+          :before               => {:target => "/root/a1/text()", :returns_self => true,  :children_tags => %w[b1 b2 text]},
+
+          :add_next_sibling     => {:target => "/root/a1/text()", :returns_self => false, :children_tags => %w[text b1 b2]},
+          :next=                => {:target => "/root/a1/text()", :returns_self => false, :children_tags => %w[text b1 b2]},
+          :after                => {:target => "/root/a1/text()", :returns_self => true,  :children_tags => %w[text b1 b2]}
+        }.each do |method, params|
+
+          before do
+            @doc  = Nokogiri::XML "<root><a1>First node</a1><a2>Second node</a2><a3>Third <bx />node</a3></root>"
+            @doc2 = @doc.dup
+            @fragment_string = "<b1>foo</b1><b2>bar</b2>"
+            @fragment        = Nokogiri::XML::DocumentFragment.parse @fragment_string
+            @node_set        = Nokogiri::XML("<root><b1>foo</b1><b2>bar</b2></root>").xpath("/root/node()")
+          end
+
+          describe "##{method}" do
+            describe "passed a Node" do
+              [:current, :another].each do |which|
+                describe "passed a Node in the #{which} document" do
+                  before do
+                    @other_doc = which == :current ? @doc : @doc2
+                    @other_node = @other_doc.at_xpath("/root/a2")
+                  end
+
+                  it "unlinks the Node from its previous position" do
+                    @doc.at_xpath(params[:target]).send(method, @other_node)
+                    @other_doc.at_xpath("/root/a2").must_be_nil
+                  end
+
+                  it "inserts the Node in the proper position" do
+                    @doc.at_xpath(params[:target]).send(method, @other_node)
+                    @doc.at_xpath("/root/a1/a2").wont_be_nil
+                  end
+
+                  it "returns the expected value" do
+                    sendee = @doc.at_xpath(params[:target])
+                    result = sendee.send(method, @other_node)
+                    if params[:returns_self]
+                      result.must_equal sendee
+                    else
+                      result.must_equal @other_node
+                    end
+                  end
+                end
+              end
+            end
+            describe "passed a markup string" do
+              it "inserts the fragment roots in the proper position" do
+                @doc.at_xpath(params[:target]).send(method, @fragment_string)
+                @doc.xpath("/root/a1/node()").collect {|n| n.name}.must_equal params[:children_tags]
+              end
+
+              it "returns the expected value" do
+                sendee = @doc.at_xpath(params[:target])
+                result = sendee.send(method, @fragment_string)
+                if params[:returns_self]
+                  result.must_equal sendee
+                else
+                  result.must_be_kind_of Nokogiri::XML::NodeSet
+                  result.to_html.must_equal @fragment_string
+                end
+              end
+            end
+            describe "passed a fragment" do
+              it "inserts the fragment roots in the proper position" do
+                @doc.at_xpath(params[:target]).send(method, @fragment)
+                @doc.xpath("/root/a1/node()").collect {|n| n.name}.must_equal params[:children_tags]
+              end
+            end
+            describe "passed a document" do
+              it "raises an exception" do
+                proc { @doc.at_xpath("/root/a1").send(method, @doc2) }.must_raise(ArgumentError)
+              end
+            end
+            describe "passed a non-Node" do
+              it "raises an exception" do
+                proc { @doc.at_xpath("/root/a1").send(method, 42) }.must_raise(ArgumentError)
+              end
+            end
+            describe "passed a NodeSet" do
+              it "inserts each member of the NodeSet in the proper order" do
+                @doc.at_xpath(params[:target]).send(method, @node_set)
+                @doc.xpath("/root/a1/node()").collect {|n| n.name}.must_equal params[:children_tags]
+              end
+            end
+          end
+        end
+
+        describe "text node merging" do
+          describe "#add_child" do
+            it "merges the Text node with adjacent Text nodes" do
+              @doc.at_xpath("/root/a1").add_child Nokogiri::XML::Text.new('hello', @doc)
+              @doc.at_xpath("/root/a1/text()").content.must_equal "First nodehello"
+            end
+          end
+
+          describe "#replace" do
+            it "merges the Text node with adjacent Text nodes" do
+              @doc.at_xpath("/root/a3/bx").replace Nokogiri::XML::Text.new('hello', @doc)
+              @doc.at_xpath("/root/a3/text()").content.must_equal "Third hellonode"
+            end
+          end
+        end
+      end
+
+      describe "ad hoc node reparenting behavior" do
+        describe "#<<" do
+          it "allows chaining" do
+            doc   = Nokogiri::XML::Document.new
+            root  = Nokogiri::XML::Element.new('root', doc)
+            doc.root = root
+
+            child1 = Nokogiri::XML::Element.new('child1', doc)
+            child2 = Nokogiri::XML::Element.new('child2', doc)
+
+            doc.root << child1 << child2
+
+            assert_equal [child1, child2], doc.root.children.to_a
+          end
+        end
+
+        describe "#add_child" do
+          describe "given a new node with a namespace" do
+            it "keeps the namespace" do
+              doc   = Nokogiri::XML::Document.new
+              item  = Nokogiri::XML::Element.new('item', doc)
+              doc.root = item
+
+              entry = Nokogiri::XML::Element.new('entry', doc)
+              entry.add_namespace('tlm', 'http://tenderlovemaking.com')
+              assert_equal 'http://tenderlovemaking.com', entry.namespaces['xmlns:tlm']
+              item.add_child(entry)
+              assert_equal 'http://tenderlovemaking.com', entry.namespaces['xmlns:tlm']
+            end
+          end
+
+          describe "given a parent node with a default namespace" do
+            before do
+              @doc = Nokogiri::XML(<<-eoxml)
+                <root xmlns="http://tenderlovemaking.com/">
+                  <first>
+                  </first>
+                </root>
+              eoxml
+            end
+
+            it "inserts a node that inherits the default namespace" do
+              assert node = @doc.at('//xmlns:first')
+              child = Nokogiri::XML::Node.new('second', @doc)
+              node.add_child(child)
+              assert @doc.at('//xmlns:second')
+            end
+          end
+
+          describe "given a parent node with a non-default namespace" do
+            before do
+              @doc = Nokogiri::XML(<<-eoxml)
+                <root xmlns="http://tenderlovemaking.com/" xmlns:foo="http://flavorjon.es/">
+                  <first>
+                  </first>
+                </root>
+              eoxml
+            end
+
+            describe "and a child node with a namespace matching the parent's non-default namespace" do
+              it "inserts a node that inherits the matching parent namespace" do
+                assert node = @doc.at('//xmlns:first')
+                child = Nokogiri::XML::Node.new('second', @doc)
+
+                ns = @doc.root.namespace_definitions.detect { |x| x.prefix == "foo" }
+                child.namespace = ns
+
+                node.add_child(child)
+                assert @doc.at('//foo:second', "foo" => "http://flavorjon.es/")
+              end
+            end
+          end
+        end
+
+        describe "#add_previous_sibling" do
+          it "should not merge text nodes during the operation" do
+            xml = Nokogiri::XML %Q(<root>text node</root>)
+            replacee = xml.root.children.first
+            replacee.add_previous_sibling "foo <p></p> bar"
+            assert_equal "foo <p></p> bartext node", xml.root.children.to_html
+          end
+
+          it 'should remove the child node after the operation' do
+            fragment = Nokogiri::HTML::DocumentFragment.parse("a<a>b</a>")
+            node = fragment.children.last
+            node.add_previous_sibling node.children
+            assert_empty node.children, "should have no childrens"
+          end
+
+          describe "with a text node before" do
+            it "should not defensively dup the 'before' text node" do
+              xml = Nokogiri::XML %Q(<root>before<p></p>after</root>)
+              pivot  = xml.at_css("p")
+              before = xml.root.children.first
+              after  = xml.root.children.last
+              pivot.add_previous_sibling("x")
+
+              assert_equal "after", after.content
+              assert !after.parent.nil?, "unrelated node should not be affected"
+
+              assert_equal "before", before.content
+              assert !before.parent.nil?, "no need to reparent"
+            end
+          end
+        end
+
+        describe "#add_next_sibling" do
+          it "should not merge text nodes during the operation" do
+            xml = Nokogiri::XML %Q(<root>text node</root>)
+            replacee = xml.root.children.first
+            replacee.add_next_sibling "foo <p></p> bar"
+            assert_equal "text nodefoo <p></p> bar", xml.root.children.to_html
+          end
+
+          describe "with a text node after" do
+            it "should not defensively dup the 'after' text node" do
+              xml = Nokogiri::XML %Q(<root>before<p></p>after</root>)
+              pivot  = xml.at_css("p")
+              before = xml.root.children.first
+              after  = xml.root.children.last
+              pivot.add_next_sibling("x")
+
+              assert_equal "before", before.content
+              assert !before.parent.nil?, "unrelated node should not be affected"
+
+              assert_equal "after", after.content
+              assert !after.parent.nil?
+            end
+          end
+        end
+
+        describe "#replace" do
+          describe "a text node with a text node" do
+            it "should not merge text nodes during the operation" do
+              xml = Nokogiri::XML %Q(<root>text node</root>)
+              replacee = xml.root.children.first
+              replacee.replace "new text node"
+              assert_equal "new text node", xml.root.children.first.content
+            end
+          end
+
+          describe "when a document has a default namespace" do
+            before do
+              @fruits = Nokogiri::XML(<<-eoxml)
+                <fruit xmlns="http://fruits.org">
+                  <apple />
+                </fruit>
+              eoxml
+            end
+
+            it "inserts a node with default namespaces" do
+              apple = @fruits.css('apple').first
+
+              orange = Nokogiri::XML::Node.new('orange', @fruits)
+              apple.replace(orange)
+
+              assert_equal orange, @fruits.css('orange').first
+            end
+          end
+        end
+
+        describe "unlinking a node and then reparenting it" do
+          it "not blow up" do
+            # see http://github.com/sparklemotion/nokogiri/issues#issue/22
+            10.times do
+              begin
+                doc = Nokogiri::XML <<-EOHTML
+                  <root>
+                    <a>
+                      <b/>
+                      <c/>
+                    </a>
+                  </root>
+                EOHTML
+
+                assert root = doc.at("root")
+                assert a = root.at("a")
+                assert b = a.at("b")
+                assert c = a.at("c")
+                a.add_next_sibling(b.unlink)
+                c.unlink
+              end
+              GC.start
+            end
+          end
+        end
+
+        describe "replace-merging text nodes" do
+          [
+            ['<root>a<br/></root>',  'afoo'],
+            ['<root>a<br/>b</root>', 'afoob'],
+            ['<root><br/>b</root>',  'foob']
+          ].each do |xml, result|
+            it "doesn't blow up on #{xml}" do
+              doc = Nokogiri::XML.parse(xml)
+              saved_nodes = doc.root.children
+              doc.at_xpath("/root/br").replace(Nokogiri::XML::Text.new('foo', doc))
+              saved_nodes.each { |child| child.inspect } # try to cause a crash
+              assert_equal result, doc.at_xpath("/root/text()").inner_text
+            end
+          end
+        end
+      end
+    end
+  end
+end