noiseless 0.7.2 → 0.9.0

data/lib/noiseless/pagination.rb

@@ -5,6 +5,12 @@ module Noiseless
     DEFAULT_PER_PAGE = 20
     MAX_PER_PAGE = 100
 
+    def self.query_options(paginate)
+      return { from: 0, size: DEFAULT_PER_PAGE } unless paginate
+
+      { from: (paginate.page - 1) * paginate.per_page, size: paginate.per_page }
+    end
+
     # Simple paginated array wrapper - no external dependencies
     class PaginatedArray < Array
       attr_accessor :current_page, :per_page, :total_count
@@ -75,16 +81,16 @@ module Noiseless
 
       # Encode cursor for API response
       def encode
-        Base64.urlsafe_encode64(JSON.generate({ f: field, v: value, d: direction }))
+        [ActiveSupport::JSON.encode({ f: field, v: value, d: direction })].pack("m0").tr("+/", "-_")
       end
 
       # Decode cursor from API request
       def self.decode(encoded)
         return nil if encoded.blank?
 
-        data = JSON.parse(Base64.urlsafe_decode64(encoded))
+        data = JSON.parse(encoded.tr("-_", "+/").unpack1("m0"))
         new(field: data["f"], value: data["v"], direction: data["d"]&.to_sym || :asc)
-      rescue StandardError
+      rescue ArgumentError, JSON::ParserError
         nil
       end
 
@@ -131,6 +137,10 @@ module Noiseless
     # Search paginator - builds and executes paginated queries
     class SearchPaginator
       include Enumerable
+      extend QueryDelegation
+
+      delegate_query_methods :match, :multi_match, :filter, :sort, :aggregation, :geo_distance, :vector,
+                             to: :@query_builder
 
       def initialize(model_class, page: 1, per_page: nil)
         @model_class = model_class
@@ -213,42 +223,6 @@ module Noiseless
         @results.to_a
       end
 
-      # Query building delegation
-      def match(field, value, **)
-        @query_builder.match(field, value, **)
-        self
-      end
-
-      def multi_match(query, fields, **)
-        @query_builder.multi_match(query, fields, **)
-        self
-      end
-
-      def filter(field, value, **)
-        @query_builder.filter(field, value, **)
-        self
-      end
-
-      def sort(field, direction = :asc, **)
-        @query_builder.sort(field, direction, **)
-        self
-      end
-
-      def aggregation(name, type, **)
-        @query_builder.aggregation(name, type, **)
-        self
-      end
-
-      def geo_distance(field, lat:, lon:, distance:, **)
-        @query_builder.geo_distance(field, lat: lat, lon: lon, distance: distance, **)
-        self
-      end
-
-      def vector(field, embedding, **)
-        @query_builder.vector(field, embedding, **)
-        self
-      end
-
       # Response access
       def results
         execute_search unless @executed
@@ -312,7 +286,7 @@ module Noiseless
 
         client = Noiseless.connections.client(@model_class.connection)
         ast = @query_builder.to_ast
-        @results = client.search(ast, model_class: @model_class)
+        @results = Sync { client.search(ast, model_class: @model_class).wait }
         @total_count = @results.total
         @executed = true
       end

data/lib/noiseless/query_builder.rb

@@ -2,9 +2,19 @@
 
 module Noiseless
   class QueryBuilder
+    def self.indexes_for(model)
+      # Multi-search starts without a model and supplies its own indexes.
+      return [] if model.nil?
+
+      return Array(model.search_index) if model.respond_to?(:search_index) && model.search_index&.any?
+      return [model.index_name] if model.respond_to?(:index_name) && model.index_name
+
+      [model.name.demodulize.underscore.pluralize]
+    end
+
     def initialize(model)
       @model        = model
-      @indexes      = determine_indexes(model)
+      @indexes      = self.class.indexes_for(model)
       @nodes        = []
       @aggregations = []
       @collapse     = nil
@@ -143,12 +153,13 @@ module Noiseless
     # @param text_query [String] The text query for BM25 matching
     # @param embedding [Array<Float>] The query embedding vector
     # @param field [Symbol] The embedding field name
+    # @param fields [Array<Symbol>] Fields the text query runs against
     # @param text_weight [Float] Weight for text search score (default: 0.5)
     # @param vector_weight [Float] Weight for vector search score (default: 0.5)
     # @param k [Integer] Number of nearest neighbors (default: 10)
-    def hybrid(text_query, embedding, field:, text_weight: 0.5, vector_weight: 0.5, k: 10)
+    def hybrid(text_query, embedding, field:, fields: [], text_weight: 0.5, vector_weight: 0.5, k: 10)
       vector_node = AST::Vector.new(field, embedding, k: k)
-      @hybrid = AST::Hybrid.new(text_query, vector_node, text_weight: text_weight, vector_weight: vector_weight)
+      @hybrid = AST::Hybrid.new(text_query, vector_node, fields:, text_weight:, vector_weight:)
       self
     end
 
@@ -188,8 +199,8 @@ module Noiseless
     # @param on [Hash] Join conditions
     # @param include_fields [Array] Fields to include from joined collection
     # @param strategy [Symbol] Join strategy :left or :inner
-    def join(collection, on:, include_fields: [], strategy: :left)
-      @joins << AST::Join.new(collection, on: on, include_fields: include_fields, strategy: strategy)
+    def join(collection, include_fields: [], strategy: :left)
+      @joins << AST::Join.new(collection, include_fields:, strategy:)
       self
     end
 
@@ -269,16 +280,5 @@ module Noiseless
         raise ArgumentError, "pinned_hits must be a String, Hash, or Array of [id, position]"
       end
     end
-
-    def determine_indexes(model)
-      # Check for search_index (plural array) first
-      return Array(model.search_index) if model.respond_to?(:search_index) && model.search_index&.any?
-
-      # Check for index_name (singular string) next
-      return [model.index_name] if model.respond_to?(:index_name) && model.index_name
-
-      # Fallback to pluralized model name
-      [model.name.demodulize.underscore.pluralize]
-    end
   end
 end

data/lib/noiseless/query_delegation.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Noiseless
+  module QueryDelegation
+    # Unlike ordinary delegation, fluent query methods return their wrapper.
+    def delegate_query_methods(*names, to:)
+      names.each do |name|
+        define_method(name) do |*args, **options, &block|
+          instance_variable_get(to).public_send(name, *args, **options, &block)
+          self
+        end
+      end
+    end
+  end
+end

data/lib/noiseless/railtie.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "rails/railtie"
-require_relative "instrumentation"
-require_relative "runtime_reset_middleware"
 
 module Noiseless
   class Railtie < Rails::Railtie

data/lib/noiseless/record_class_resolver.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Noiseless
+  module RecordClassResolver
+    # Search definitions and database models are different kinds of classes.
+    # Only a Noiseless::Model uses the explicit record_class mapping.
+    def self.resolve(model_class)
+      if model_class.is_a?(Class) && model_class <= Model
+        model_class.record_class
+      else
+        model_class
+      end
+    end
+  end
+end

data/lib/noiseless/response/records.rb

@@ -4,7 +4,12 @@ module Noiseless
   module Response
     class Records < Base
       def initialize(raw_response, model_class)
-        super
+        record_class = RecordClassResolver.resolve(model_class)
+        unless record_class.respond_to?(:where)
+          raise ArgumentError, "#{model_class || 'nil'} cannot load records; configure record_class on your Noiseless::Model search class"
+        end
+
+        super(raw_response, record_class)
         @records = nil
         @record_hit_map = nil
       end
@@ -62,7 +67,7 @@ module Noiseless
       end
 
       def load_records
-        return [] if hits.empty? || !model_class.respond_to?(:where)
+        return [] if hits.empty?
 
         # Extract IDs from hits
         ids = hits.map { |hit| hit["_id"] }
@@ -75,8 +80,9 @@ module Noiseless
 
         # Sort records by the order they appear in search results
         sorted_records = []
+        records_by_id = loaded_records.index_by { it.id.to_s }
         hits.each_with_index do |hit, hit_index|
-          record = loaded_records.find { |r| r.id.to_s == hit["_id"].to_s }
+          record = records_by_id[hit["_id"].to_s]
           if record
             sorted_records << record
             @record_hit_map[record] = hit_index

data/lib/noiseless/runtime_reset_middleware.rb

@@ -8,7 +8,7 @@ module Noiseless
 
     def call(env)
       # Reset runtime tracking at the beginning of each request
-      Thread.current[:noiseless_runtime] = 0
+      ActiveSupport::IsolatedExecutionState[:noiseless_runtime] = 0
       @app.call(env)
     end
   end

data/lib/noiseless/search_index_update_job.rb

@@ -31,12 +31,9 @@ module Noiseless
         raise ArgumentError, "Unknown operation: #{operation}"
       end
     rescue StandardError => e
-      if options[:raise_on_error]
-        raise e
-      elsif (logger = Rails.logger)
-        # Log error silently
-        logger.error "Noiseless: Background job failed for #{model_class_name}##{record_id}: #{e.message}"
-      end
+      raise if options[:raise_on_error]
+
+      Rails.logger&.error "Noiseless: Background job failed for #{model_class_name}##{record_id}: #{e.message}"
     end
 
     # Minimal object for deleted records
@@ -58,16 +55,21 @@ module Noiseless
         nil
       end
     end
+
+    # Queued runs raise so the job backend retries instead of recording success.
+    module Queued
+      def perform(model_class_name, record_id, operation, options = {})
+        SearchIndexUpdateJob.perform_now(model_class_name, record_id, operation, options.merge(raise_on_error: true))
+      end
+    end
   end
 
   # ActiveJob integration
   if defined?(ActiveJob::Base)
     class ActiveJobSearchIndexUpdateJob < ActiveJob::Base
-      queue_as :default
+      include SearchIndexUpdateJob::Queued
 
-      def perform(model_class_name, record_id, operation, options = {})
-        SearchIndexUpdateJob.perform_now(model_class_name, record_id, operation, options)
-      end
+      queue_as :default
     end
   end
 
@@ -75,10 +77,7 @@ module Noiseless
   if defined?(Sidekiq)
     class SidekiqSearchIndexUpdateJob
       include Sidekiq::Worker
-
-      def perform(model_class_name, record_id, operation, options = {})
-        SearchIndexUpdateJob.perform_now(model_class_name, record_id, operation, options)
-      end
+      include SearchIndexUpdateJob::Queued
     end
   end
 end

data/lib/noiseless/test_case.rb

@@ -2,7 +2,6 @@
 
 require "minitest"
 require "async"
-require "set" # rubocop:disable Lint/RedundantRequireStatement
 require_relative "test_helper"
 
 module Noiseless

data/lib/noiseless/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Noiseless
-  VERSION = "0.7.2"
+  VERSION = "0.9.0"
 end

data/lib/noiseless.rb

@@ -11,7 +11,6 @@ require "singleton"
 require "async"
 require "async/http/endpoint"
 require "async/http/client"
-require "async/pool"
 require_relative "noiseless/version"
 
 module Noiseless
@@ -96,11 +95,7 @@ module Noiseless
 
     # Register all connections statically from YAML - no runtime registration
     config.connections_config.each do |name, params|
-      adapter_name = params[:adapter]
-      hosts = params[:hosts] || []
-      register_params = { adapter: adapter_name, hosts: hosts, timeout: params[:timeout] }
-      register_params[:request_timeout] = params[:request_timeout] if params.key?(:request_timeout)
-      connections.register(name, **register_params)
+      connections.register(name, **params, hosts: params[:hosts] || [])
     end
   end
 
@@ -123,10 +118,6 @@ module Noiseless
   loader.setup
   loader.eager_load if defined?(Rails) && Rails.respond_to?(:env) && Rails.env.test?
 
-  # Manually require response classes since they're in a subdirectory
-  require_relative "noiseless/response"
-  require_relative "noiseless/response_factory"
-
   # Global registry instance
   def self.registry
     ModelRegistry.instance

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noiseless
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.9.0
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -16,6 +16,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '8.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 8.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -23,48 +26,51 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '8.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 8.1.4
 - !ruby/object:Gem::Dependency
   name: async
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.45'
+        version: '2.46'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.45'
+        version: '2.46'
 - !ruby/object:Gem::Dependency
   name: async-http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.103'
+        version: '0.105'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.103'
+        version: '0.105'
 - !ruby/object:Gem::Dependency
-  name: async-pool
+  name: io-event
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: 1.22.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: 1.22.1
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -72,6 +78,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '8.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 8.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -79,6 +88,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '8.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 8.1.4
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -228,13 +240,16 @@ files:
 - lib/noiseless/adapters/execution_modules/opensearch_execution.rb
 - lib/noiseless/adapters/execution_modules/pgvector_support.rb
 - lib/noiseless/adapters/execution_modules/postgresql_execution.rb
+- lib/noiseless/adapters/execution_modules/postgresql_query.rb
 - lib/noiseless/adapters/execution_modules/typesense_execution.rb
+- lib/noiseless/adapters/execution_modules/typesense_query.rb
 - lib/noiseless/adapters/indices_api.rb
 - lib/noiseless/adapters/open_search.rb
 - lib/noiseless/adapters/postgresql.rb
 - lib/noiseless/adapters/typesense.rb
 - lib/noiseless/ast.rb
 - lib/noiseless/ast/aggregation.rb
+- lib/noiseless/ast/aggregation_builder.rb
 - lib/noiseless/ast/bool.rb
 - lib/noiseless/ast/bulk.rb
 - lib/noiseless/ast/collapse.rb
@@ -258,13 +273,17 @@ files:
 - lib/noiseless/bulk_importer.rb
 - lib/noiseless/callbacks.rb
 - lib/noiseless/connection_manager.rb
+- lib/noiseless/controller_runtime.rb
 - lib/noiseless/document_manager.rb
 - lib/noiseless/dsl.rb
+- lib/noiseless/embedding.rb
 - lib/noiseless/generators/application_search_generator.rb
 - lib/noiseless/instrumentation.rb
 - lib/noiseless/introspection.rb
 - lib/noiseless/introspection/console.rb
+- lib/noiseless/introspection/mermaid_diagrams.rb
 - lib/noiseless/introspection/query_visualizer.rb
+- lib/noiseless/log_subscriber.rb
 - lib/noiseless/mapping.rb
 - lib/noiseless/mapping_definition_processor.rb
 - lib/noiseless/model.rb
@@ -272,7 +291,9 @@ files:
 - lib/noiseless/multi_search.rb
 - lib/noiseless/pagination.rb
 - lib/noiseless/query_builder.rb
+- lib/noiseless/query_delegation.rb
 - lib/noiseless/railtie.rb
+- lib/noiseless/record_class_resolver.rb
 - lib/noiseless/response.rb
 - lib/noiseless/response/aggregations.rb
 - lib/noiseless/response/empty.rb
@@ -285,7 +306,6 @@ files:
 - lib/noiseless/test_case.rb
 - lib/noiseless/test_helper.rb
 - lib/noiseless/version.rb
-- lib/tasks/benchmark.rake
 - lib/tasks/release.rake
 - lib/tasks/test.rake
 homepage: https://github.com/seuros/noiseless
@@ -301,14 +321,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.4'
+      version: '4.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Async-first Rails search abstraction with multi-backend support
 test_files: []

data/lib/tasks/benchmark.rake

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-namespace :benchmark do
-  desc "Benchmark search performance across Elasticsearch, OpenSearch, and PostgreSQL"
-  task search: :environment do
-    require "benchmark/ips"
-    require "async"
-
-    # Use configured connections from Rails
-    engines = {
-      elasticsearch: :primary,
-      opensearch: :secondary,
-      postgresql: :postgresql
-    }
-
-    puts "=" * 80
-    puts "MULTI-ENGINE SEARCH BENCHMARK"
-    puts "=" * 80
-    puts "Records: 10k benchmark articles"
-    puts "Engines: #{engines.keys.join(', ')}"
-    puts "=" * 80
-
-    # Load PostgreSQL data
-    puts "\n📊 Loading PostgreSQL..."
-    Article.delete_all
-    fixtures_path = Rails.root.join("../../test/fixtures")
-    ActiveRecord::FixtureSet.create_fixtures(fixtures_path, ["benchmark_articles"])
-    puts "✅ Loaded #{Article.count} records"
-
-    # Register PostgreSQL model
-    Noiseless.connections.client(:postgresql).register_model(Article, index_name: "articles")
-
-    puts "\n🚀 Benchmark ready. Run with: bundle exec rake benchmark:search"
-  end
-end