noiseless 0.3.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f66be9c1d81e3b887f0c0d4485381c4535f087f8365e2581c4c41d89cdba0934
-  data.tar.gz: 1565bffbcfb554d2b6afcc78ebb1ded79c5c58a8f157b1e25ccd9a449cd2abe2
+  metadata.gz: 466267a77224bbf9915eff8b198002c658e2e9c9d368c6c7f6e4e4ee32939892
+  data.tar.gz: 71281cfbbcdd40f83f55eedb0fca494f1e0a75172c4a9523c3000cae81fa752d
 SHA512:
-  metadata.gz: 4a7e23f4eb136bc6c0dc457dcb6f267e000269aceddd6450264ac489429dda2e20c7b382b32c2ab2a91271faeccee419a5c72530e3781087a9f630e8bd16a15d
-  data.tar.gz: 605cf0980142cbe65692b9ef8d2a543969578620fa17b35e069a0344ac1a5ca5947781c6d9cf617203408a73e11cd08626c000d046e4a7a9839508919de8d463
+  metadata.gz: 7a0a6c9aa9134b043b4a87c8434735f837bca7cfc63520693e3bf49ff4001617351cf92259b73a781187fd22812d65f781130570f753d27dd68d4d6f3bb16fd0
+  data.tar.gz: 14387643b5a8c5b5fc506e00b28b8d5b2664d359bd48797c6180df38f03efa370dd86d46d0a871194328ff80f487458e439733b250dfdad9cf369a253e069c3e

data/lib/noiseless/adapters/execution_modules/http_transport.rb

@@ -1,21 +1,48 @@
 # frozen_string_literal: true
 
+require "socket"
+require "timeout"
+
 module Noiseless
   module Adapters
     module ExecutionModules
       # Shared Async::HTTP connection handling for HTTP-based adapters.
       # Host classes must provide a private +default_port+ method.
       module HttpTransport
-        def initialize(hosts: [], **connection_params)
+        # Low-level failures the Async::HTTP stack raises when it cannot
+        # complete a round-trip with the backend (refused/reset connection,
+        # DNS failure, transport timeout). These are wrapped into
+        # Noiseless::ConnectionError so callers never have to know which HTTP
+        # stack is underneath.
+        TRANSPORT_ERRORS = [
+          SystemCallError,
+          SocketError,
+          IOError,
+          IO::TimeoutError,
+          Timeout::Error
+        ].freeze
+
+        # Default per-operation IO timeout (seconds) for the search backend.
+        # This is an *idle* timeout: every socket read/write must make progress
+        # within this window. It bounds a stalled/unresponsive backend without
+        # capping the total duration of streaming operations (e.g. bulk import),
+        # since data keeps flowing during those. Override per-connection with
+        # +timeout:+.
+        DEFAULT_TIMEOUT = 5
+
+        def initialize(hosts: [], timeout: DEFAULT_TIMEOUT, **connection_params)
           # Ensure we always have at least one host
           hosts_array = Array(hosts)
           @hosts = hosts_array.empty? ? ["http://localhost:#{default_port}"] : hosts_array
+          @timeout = timeout
           @connection_params = connection_params
 
-          # Initialize HTTP clients for each host
+          # Initialize HTTP clients for each host. The endpoint timeout makes a
+          # stalled backend raise IO::TimeoutError (wrapped below as
+          # ConnectionError) instead of blocking the fiber/reactor indefinitely.
           @clients = {}
           @hosts.each do |host|
-            endpoint = Async::HTTP::Endpoint.parse(host)
+            endpoint = Async::HTTP::Endpoint.parse(host, timeout: @timeout)
             @clients[host] = Async::HTTP::Client.new(endpoint)
           end
 
@@ -68,7 +95,19 @@ module Noiseless
           host = @hosts.sample
           client = @clients[host]
 
-          yield(client)
+          wrap_transport_errors(host: host) { yield(client) }
+        end
+
+        def parse_json_response!(response, error_class: Noiseless::RequestError, context: nil)
+          wrap_transport_errors { super }
+        end
+
+        def wrap_transport_errors(host: nil)
+          yield
+        rescue *TRANSPORT_ERRORS => e
+          location = host ? " at #{host}" : ""
+          raise Noiseless::ConnectionError,
+                "search backend unreachable#{location} (#{e.class}: #{e.message})"
         end
 
         def default_headers

data/lib/noiseless/callbacks.rb

@@ -54,7 +54,7 @@ module Noiseless
       return unless should_update_search_index?
 
       update_search_index_async if noiseless_new_record? || (respond_to?(:changed?) && changed?)
-    rescue Net::ProtocolError, JSON::ParserError, Timeout::Error => e
+    rescue Noiseless::Error => e
       handle_search_index_error(e, :update)
     end
 
@@ -62,7 +62,7 @@ module Noiseless
       return unless should_update_search_index?
 
       update_search_index_async
-    rescue Net::ProtocolError, JSON::ParserError, Timeout::Error => e
+    rescue Noiseless::Error => e
       handle_search_index_error(e, :update)
     end
 
@@ -70,7 +70,7 @@ module Noiseless
       return unless should_update_search_index?
 
       remove_from_search_index_async
-    rescue Net::ProtocolError, JSON::ParserError, Timeout::Error => e
+    rescue Noiseless::Error => e
       handle_search_index_error(e, :delete)
     end
 
@@ -78,7 +78,7 @@ module Noiseless
       return unless should_update_search_index?
 
       remove_from_search_index_async
-    rescue Net::ProtocolError, JSON::ParserError, Timeout::Error => e
+    rescue Noiseless::Error => e
       handle_search_index_error(e, :delete)
     end
 

data/lib/noiseless/connection_manager.rb

@@ -8,8 +8,8 @@ module Noiseless
     end
 
     # Register a named client statically from YAML (boot-time only)
-    def register(name, adapter:, hosts:)
-      @configs[name.to_sym] = { adapter: adapter, hosts: hosts }
+    def register(name, adapter:, hosts:, timeout: nil)
+      @configs[name.to_sym] = { adapter: adapter, hosts: hosts, timeout: timeout }
     end
 
     # Retrieve a client; defaults to :primary
@@ -19,7 +19,9 @@ module Noiseless
       # Lazy-load the adapter only when actually used
       @clients[name] ||= begin
         config = @configs.fetch(name) { raise "Unknown connection: #{name}" }
-        Adapters.lookup(config[:adapter], hosts: config[:hosts])
+        params = { hosts: config[:hosts] }
+        params[:timeout] = config[:timeout] unless config[:timeout].nil?
+        Adapters.lookup(config[:adapter], **params)
       end
     end
   end

data/lib/noiseless/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Noiseless
-  VERSION = "0.3.0"
+  VERSION = "0.5.0"
 end

data/lib/noiseless.rb

@@ -32,6 +32,14 @@ module Noiseless
   # (malformed query, missing index, shard failures).
   class SearchError < RequestError; end
 
+  # Raised when the search backend cannot be reached at all: connection
+  # refused, DNS failure, reset socket, or transport timeout. Distinct from
+  # RequestError, which means the backend *was* reached and replied with an
+  # HTTP error. Wrapping happens at the transport boundary (HttpTransport),
+  # so callers rescue Noiseless::Error instead of enumerating socket/system
+  # exception classes from whatever HTTP stack the transport happens to use.
+  class ConnectionError < Error; end
+
   class Configuration
     attr_accessor :connections_config, :default_connection, :default_adapter, :config_path
 
@@ -85,7 +93,7 @@ module Noiseless
     config.connections_config.each do |name, params|
       adapter_name = params[:adapter]
       hosts = params[:hosts] || []
-      connections.register(name, adapter: adapter_name, hosts: hosts)
+      connections.register(name, adapter: adapter_name, hosts: hosts, timeout: params[:timeout])
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noiseless
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Abdelkader Boudih