nobspw 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 48035c919105e867a0aa76612c6dcf13708da443
-  data.tar.gz: ab7cdfe7326b2c6bcf9e4afdf8518a17dd21bec2
+SHA256:
+  metadata.gz: 2822386df873b457c238d992dc10557886e06852ff13d3d82ff83aa678d399d5
+  data.tar.gz: 514207c17b7aa170f7e037953ff48dde07c884a86fbba822277e317506d9738f
 SHA512:
-  metadata.gz: 628ec2cae8c6ea70c2a43027e749bf6f1c3c1f1b4b825ed1e0b24a429cea18d043ee25cbef04a37b73dd49f7ee7343cf468e99a50a21e9f05ee458951f43a5ab
-  data.tar.gz: cd3b210d94da9263eb497577d93fb93bc36d8cd45fd9e58ca0267019c646c426832ed9af2ccc001bb2a94a29e05a8aa02ac0b94c96aaf01fb4cf3aebc9bea428
+  metadata.gz: 3c22655a227cddafed368bf1fe64ae30825106ebf50f3c5833868a4cfec9ec077c784d2c62bc78860d6d30be0a169e0dab209920e7424e87e4ee6ad854bcdff6
+  data.tar.gz: ee59f029dc465da9adf867c939c96d62a03a888f54256a6c22256efc666a1bc5b54acdc20a2f9b9746af6a777c305d8eac901a6a46ea087e89468b2399af1cf5

data/.travis.yml

@@ -3,4 +3,5 @@ language: ruby
 rvm:
   - 2.3.3
   - 2.4.0
+  - 2.5.0
 before_install: gem install bundler -v 1.14.2

data/README.md

@@ -82,8 +82,7 @@ PasswordValidator will try to guess the correct field name for each `PasswordChe
 If you have field names different than above, you can tell `PasswordValidator` which fields to use for specific attributes:
 
 ```ruby
-validates :password, presence: true,
-                     password: { :name => :customer_name,
+validates :password, password: { :name => :customer_name,
                                  :email => :electronic_address },
           if: -> { new_record? || changes[:password] }
 ```
@@ -93,6 +92,7 @@ validates :password, presence: true,
 NOBSPW currently validates for the following, in this order:
 
 ```ruby
+password_empty?
 name_included_in_password?
 email_included_in_password?
 domain_included_in_password?

data/lib/nobspw/configuration.rb

@@ -8,6 +8,7 @@ module NOBSPW
     attr_accessor :domain_name
     attr_accessor :blacklist
     attr_accessor :validation_methods
+    attr_accessor :interrupt_validation_for
 
     def initialize
       @min_password_length      = 10
@@ -18,6 +19,7 @@ module NOBSPW
       @domain_name              = nil
       @blacklist                = nil
       @validation_methods       = NOBSPW::ValidationMethods::DEFAULT_VALIDATION_METHODS
+      @interrupt_validation_for = NOBSPW::ValidationMethods::INTERRUPT_VALIDATION_FOR
     end
   end
 end

data/lib/nobspw/password_checker.rb

@@ -4,9 +4,7 @@ module NOBSPW
 
     def initialize(name: nil, username: nil, email: nil, password:)
       @name, @username, @email, @password = \
-        name&.strip, username&.strip, email&.strip, password&.strip
-
-      raise ArgumentError.new("Password was not specified.") if password.nil? || password.strip.length == 0
+        name&.strip, username&.strip, email&.strip, (password || '').strip
     end
 
     def strong?
@@ -30,7 +28,10 @@ module NOBSPW
       @weak_password_reasons = []
 
       NOBSPW.configuration.validation_methods.each do |method|
-        @weak_password_reasons << method.to_s.sub(/\?$/, '').to_sym if send("#{method}")
+        if send("#{method}")
+          @weak_password_reasons << method.to_s.sub(/\?$/, '').to_sym
+          break if NOBSPW.configuration.interrupt_validation_for.include?(method)
+        end
       end
 
       @strong = @weak_password_reasons.empty?

data/lib/nobspw/validation_methods.rb

@@ -1,6 +1,7 @@
 module NOBSPW
   module ValidationMethods
-    DEFAULT_VALIDATION_METHODS = %i(name_included_in_password?
+    DEFAULT_VALIDATION_METHODS = %i(password_empty?
+                                    name_included_in_password?
                                     email_included_in_password?
                                     domain_included_in_password?
                                     password_too_short?
@@ -9,8 +10,14 @@ module NOBSPW
                                     password_not_allowed?
                                     password_too_common?)
 
+    INTERRUPT_VALIDATION_FOR   = %i(password_empty?)
+
     private
 
+    def password_empty?
+      @password.nil? || @password.strip == ''
+    end
+
     def name_included_in_password?
       return nil unless @name
       words = remove_word_separators(@name).split(' ')
@@ -75,16 +82,16 @@ module NOBSPW
     # Helper methods
 
     def email_without_extension(email)
-      name, domain, whatev = email.split("@", 3)
+      name, domain, whatev = email&.split("@", 3)
       "#{name}@#{strip_extension_from_domain(domain)}"
     end
 
     def strip_extension_from_domain(domain)
-      domain.split(".").first
+      domain&.split(".")&.first
     end
 
     def remove_word_separators(str)
-      str.gsub(/-|_|\.|\'|\"|\@/, ' ')
+      str&.gsub(/-|_|\.|\'|\"|\@/, ' ')
     end
 
   end

data/lib/nobspw/version.rb

@@ -1,3 +1,3 @@
 module NOBSPW
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nobspw
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Carl Mercier
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-15 00:00:00.000000000 Z
+date: 2018-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -196,7 +196,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: No Bullshit Password strength checker