nobrainer 0.36.0 → 0.41.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61c15de4e6f0d6ede87a2db309ff25a79d36d61befdfcd280815925d0f66bb68
-  data.tar.gz: f1516356fe4f53577a744dfacca6a8143d98844aee540e8c0290950113bedd88
+  metadata.gz: 5864cbae71a2eaa5c5f7efeb27d46c3a05f083618904641d793bef097b0b66d5
+  data.tar.gz: 1a905f02f1623ade41cc4fe2913dbfbdbcbb539a494a1df37d457b0b695d15df
 SHA512:
-  metadata.gz: 3fabd4ff40209300d3630cee18bd27115d77f6c157b6d9f910ac93896ef11487f1cf1cb116fb7a98ef356e3c78033412c05ddf06d60ed473b753a26a9aab4ab2
-  data.tar.gz: 9d3299f45f30001d6856ea015b15c19a9f5b7ec5642337c3416da160468deb5f00b5714f54eb3837b0af716c1a61fc817963280830bffa6b09bf15775624590f
+  metadata.gz: 8f3effc2a43c6f71f1eb0a42cd19d4ba6652599839998e746f9978a96aa8e3f9bc0b779e0524ac3315bc918cc06cd21399c8006d0f28f88c58d8a62008ab83c0
+  data.tar.gz: 2801dbe94a1268d752dd9844ecd79c56a34e5029797cf5414cabc9ec85189d8703ee1e3ab40d7645ffa260f6f09ba5cc58542d3fa769def2cfb25424312a3b6b

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 
+## [0.41.1] - 2022-03-21
+### Fixed
+- Removing table_config duplicates after a runtime exception (caspiano)
+
+## [0.41.0] - 2021-10-17
+### Added
+- ActiveRecord `store_accessor` helper method
+
+### Fixed
+- gemspec dependencies on activemodel and activesupport
+
+## [0.40.0] - 2021-10-16
+### Fixed
+- Ruby 3 compatibility
+- Test Ruby 3 + Rails 7 alpha2 on Travis CI
+
 ## [0.36.0] - 2021-08-08
 ### Added
 - Array and TypedArray types for validation and serialization
@@ -104,7 +120,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Locks: bug fix: allow small timeouts in lock()
 - Fix reentrant lock counter on steals
 
-[Unreleased]: https://github.com/nobrainerorm/nobrainer/compare/v0.36.0...HEAD
+[Unreleased]: https://github.com/nobrainerorm/nobrainer/compare/v0.41.1...HEAD
+[0.41.1]: https://github.com/nobrainerorm/nobrainer/compare/v0.41.0...v0.41.1
+[0.41.0]: https://github.com/nobrainerorm/nobrainer/compare/v0.40.0...v0.41.0
+[0.40.0]: https://github.com/nobrainerorm/nobrainer/compare/v0.36.0...v0.40.0
 [0.36.0]: https://github.com/nobrainerorm/nobrainer/compare/v0.35.0...v0.36.0
 [0.35.0]: https://github.com/nobrainerorm/nobrainer/compare/v0.34.1...v0.35.0
 [0.34.1]: https://github.com/nobrainerorm/nobrainer/compare/v0.34.0...v0.34.1

data/lib/no_brainer/document/store.rb

@@ -0,0 +1,304 @@
+# frozen_string_literal: true
+
+require 'active_support/core_ext/hash/indifferent_access'
+
+module NoBrainer
+  module Document
+    # Store gives you a way for storing hashes in a single field with accessors
+    # to the Hash keys.
+    # It is a portage of the ActiveRecord::Store which make gems using it
+    # compatible with NoBrainer.
+    #
+    # You can then declare accessors to this store that are then accessible just
+    # like any other attribute of the model. This is very helpful for easily
+    # exposing store keys to a form or elsewhere that's already built around
+    # just accessing attributes on the model.
+    #
+    # Every accessor comes with dirty tracking methods (+key_changed?+,
+    # +key_was+ and +key_change+).
+    #
+    # You can set custom coder to encode/decode your serialized attributes
+    # to/from different formats.
+    # JSON, YAML, Marshal are supported out of the box.
+    # Generally it can be any wrapper that provides +load+ and +dump+.
+    #
+    # NOTE: The {.store}[rdoc-ref:rdoc-ref:ClassMethods#store] method is here
+    # for compatibility reason, but you should use
+    # {.store_accessor}[rdoc-ref:ClassMethods#store_accessor] instead
+    # to generate the accessor methods.
+    # Be aware that these columns use a string keyed hash and do not allow
+    # access using a symbol.
+    #
+    # NOTE: The default validations with the exception of +uniqueness+ will work.
+    #
+    # Examples:
+    #
+    #   class User
+    #     include NoBrainer::Document
+    #
+    #     store :settings, accessors: [ :color, :homepage ], coder: JSON
+    #     store :parent, accessors: [ :name ], coder: JSON, prefix: true
+    #     store :spouse, accessors: [ :name ], coder: JSON, prefix: :partner
+    #     store :settings, accessors: [ :two_factor_auth ], suffix: true
+    #     store :settings, accessors: [ :login_retry ], suffix: :config
+    #   end
+    #
+    #   u = User.new(color: 'black', homepage: '37signals.com',
+    #                parent_name: 'Mary', partner_name: 'Lily')
+    #   u.color                          # Accessor stored attribute
+    #   u.parent_name                    # Accessor stored attribute with prefix
+    #   u.partner_name                   # Accessor stored attribute with custom prefix
+    #   u.two_factor_auth_settings       # Accessor stored attribute with suffix
+    #   u.login_retry_config             # Accessor stored attribute with custom suffix
+    #   u.settings[:country] = 'Denmark' # Any attribute, even if not specified with an accessor
+    #
+    #   # There is no difference between strings and symbols for accessing
+    #   # custom attributes
+    #   u.settings[:country]  # => 'Denmark'
+    #   u.settings['country'] # => 'Denmark'
+    #
+    #   # Dirty tracking
+    #   u.color = 'green'
+    #   u.color_changed? # => true
+    #   u.color_was # => 'black'
+    #   u.color_change # => ['black', 'red']
+    #
+    #   # Add additional accessors to an existing store through store_accessor
+    #   class SuperUser < User
+    #     store_accessor :settings, :privileges, :servants
+    #     store_accessor :parent, :birthday, prefix: true
+    #     store_accessor :settings, :secret_question, suffix: :config
+    #   end
+    #
+    # The stored attribute names can be retrieved using
+    # {.stored_attributes}[rdoc-ref:rdoc-ref:ClassMethods#stored_attributes].
+    #
+    #   User.stored_attributes[:settings]
+    #   #=> [:color, :homepage, :two_factor_auth, :login_retry]
+    #
+    # == Overwriting default accessors
+    #
+    # All stored values are automatically available through accessors on
+    # the NoBrainer Document object, but sometimes you want to specialize
+    # this behavior. This can be done by overwriting the default accessors
+    # (using the same name as the attribute) and calling <tt>super</tt>
+    # to actually change things.
+    #
+    #   class Song
+    #     include NoBrainer::Document
+    #
+    #     # Uses a stored integer to hold the volume adjustment of the song
+    #     store :settings, accessors: [:volume_adjustment]
+    #
+    #     def volume_adjustment=(decibels)
+    #       super(decibels.to_i)
+    #     end
+    #
+    #     def volume_adjustment
+    #       super.to_i
+    #     end
+    #   end
+    module Store
+      extend ActiveSupport::Concern
+
+      included do
+        class << self
+          attr_accessor :local_stored_attributes
+        end
+      end
+
+      module ClassMethods
+        def store(store_attribute, options = {})
+          store_accessor(store_attribute, options[:accessors], **options.slice(:prefix, :suffix)) if options.has_key? :accessors
+        end
+
+        def store_accessor(store_attribute, *keys, prefix: nil, suffix: nil)
+          keys = keys.flatten
+
+          accessor_prefix =
+            case prefix
+            when String, Symbol
+              "#{prefix}_"
+            when TrueClass
+              "#{store_attribute}_"
+            else
+              ""
+            end
+          accessor_suffix =
+            case suffix
+            when String, Symbol
+              "_#{suffix}"
+            when TrueClass
+              "_#{store_attribute}"
+            else
+              ""
+            end
+
+          field store_attribute, type: Hash, default: {} unless has_field?(store_attribute)
+
+          define_method("#{store_attribute}=") do |value|
+            super(value) if value.is_a?(Hash) || value.nil?
+          end
+
+          _store_accessors_module.module_eval do
+            keys.each do |key|
+              accessor_key = "#{accessor_prefix}#{key}#{accessor_suffix}"
+
+              define_method("#{accessor_key}=") do |value|
+                write_store_attribute(store_attribute, key, value)
+              end
+
+              define_method(accessor_key) do
+                read_store_attribute(store_attribute, key)
+              end
+
+              define_method("#{accessor_key}_changed?") do
+                return false unless __send__("#{store_attribute}_changed?")
+                prev_store, new_store = changes[store_attribute]
+                if NoBrainer.rails4?
+                  (prev_store && prev_store[key.to_s]) != (new_store && new_store[key.to_s])
+                else
+                  (prev_store && prev_store.dig(key)) != (new_store && new_store.dig(key))
+                end
+              end
+
+              define_method("#{accessor_key}_change") do
+                return unless __send__("#{store_attribute}_changed?")
+                prev_store, new_store = changes[store_attribute]
+                if NoBrainer.rails4?
+                  [(prev_store && prev_store[key.to_s]), (new_store && new_store[key.to_s])]
+                else
+                  [(prev_store && prev_store.dig(key)), (new_store && new_store.dig(key))]
+                end
+              end
+
+              define_method("#{accessor_key}_was") do
+                return unless __send__("#{store_attribute}_changed?")
+                prev_store, _new_store = changes[store_attribute]
+                if NoBrainer.rails4?
+                  (prev_store && prev_store[key.to_s])
+                else
+                  (prev_store && prev_store.dig(key))
+                end
+              end
+
+              # NoBrainer doesn't have `attribute_will_change!` so those methods
+              # can't be implemented yet.
+              # See https://github.com/NoBrainerORM/nobrainer/pull/190
+              #
+              # define_method("saved_change_to_#{accessor_key}?") do
+              #   return false unless __send__("saved_change_to_#{store_attribute}?")
+              #   prev_store, new_store = __send__("saved_change_to_#{store_attribute}")
+              #   prev_store&.dig(key) != new_store&.dig(key)
+              # end
+
+              # define_method("saved_change_to_#{accessor_key}") do
+              #   return unless __send__("saved_change_to_#{store_attribute}?")
+              #   prev_store, new_store = __send__("saved_change_to_#{store_attribute}")
+              #   [prev_store&.dig(key), new_store&.dig(key)]
+              # end
+
+              # define_method("#{accessor_key}_before_last_save") do
+              #   return unless __send__("saved_change_to_#{store_attribute}?")
+              #   prev_store, _new_store = __send__("saved_change_to_#{store_attribute}")
+              #   prev_store&.dig(key)
+              # end
+            end
+          end
+
+          # assign new store attribute and create new hash to ensure that each class in the hierarchy
+          # has its own hash of stored attributes.
+          self.local_stored_attributes ||= {}
+          self.local_stored_attributes[store_attribute] ||= []
+          self.local_stored_attributes[store_attribute] |= keys
+        end
+
+        def _store_accessors_module # :nodoc:
+          @_store_accessors_module ||= begin
+            mod = Module.new
+            include mod
+            mod
+          end
+        end
+
+        def stored_attributes
+          parent = superclass.respond_to?(:stored_attributes) ? superclass.stored_attributes : {}
+          if local_stored_attributes
+            parent.merge!(local_stored_attributes) { |k, a, b| a | b }
+          end
+          parent
+        end
+      end
+
+      private
+
+      def read_store_attribute(store_attribute, key) # :doc:
+        StringKeyedHashAccessor.read(self, store_attribute, key)
+      end
+
+      def write_store_attribute(store_attribute, key, value) # :doc:
+        StringKeyedHashAccessor.write(self, store_attribute, key, value)
+      end
+
+      class HashAccessor # :nodoc:
+        def self.read(object, attribute, key)
+          prepare(object, attribute)
+          object.public_send(attribute)[key]
+        end
+
+        def self.write(object, attribute, key, value)
+          prepare(object, attribute)
+          if value != read(object, attribute, key)
+            # "#{attribute}_will_change!" is not implemented in NoBrainer. See issue #190
+            # object.public_send :"#{attribute}_will_change!"
+            object.public_send(attribute)[key] = value
+          end
+        end
+
+        def self.prepare(object, attribute)
+          object.public_send :"#{attribute}=", {} unless object.send(attribute)
+        end
+      end
+
+      class StringKeyedHashAccessor < HashAccessor # :nodoc:
+        def self.read(object, attribute, key)
+          super object, attribute, key.to_s
+        end
+
+        def self.write(object, attribute, key, value)
+          super object, attribute, key.to_s, value
+        end
+      end
+
+      class IndifferentCoder # :nodoc:
+        def initialize(attr_name, coder_or_class_name)
+          @coder =
+            if coder_or_class_name.respond_to?(:load) && coder_or_class_name.respond_to?(:dump)
+              coder_or_class_name
+            else
+              NoBrainer::Document::Coders::YAMLColumn.new(attr_name, coder_or_class_name || Object)
+            end
+        end
+
+        def dump(obj)
+          @coder.dump self.class.as_indifferent_hash(obj)
+        end
+
+        def load(yaml)
+          self.class.as_indifferent_hash(@coder.load(yaml || ""))
+        end
+
+        def self.as_indifferent_hash(obj)
+          case obj
+          when ActiveSupport::HashWithIndifferentAccess
+            obj
+          when Hash
+            obj.with_indifferent_access
+          else
+            ActiveSupport::HashWithIndifferentAccess.new
+          end
+        end
+      end
+    end
+  end
+end

data/lib/no_brainer/document/types.rb

@@ -9,7 +9,7 @@ module NoBrainer::Document::Types
   def add_type_errors
     return unless @pending_type_errors
     @pending_type_errors.each do |name, error|
-      errors.add(name, :invalid_type, error.error)
+      errors.add(name, :invalid_type, **error.error)
     end
   end
 

data/lib/no_brainer/document/validation/not_null.rb

@@ -9,7 +9,7 @@ module NoBrainer::Document::Validation::NotNull
 
   class NotNullValidator < ActiveModel::EachValidator
     def validate_each(doc, attr, value)
-      doc.errors.add(attr, :undefined, options) if value.nil?
+      doc.errors.add(attr, :undefined, **options) if value.nil?
     end
   end
 end

data/lib/no_brainer/document/validation/uniqueness.rb

@@ -74,7 +74,7 @@ module NoBrainer::Document::Validation::Uniqueness
       criteria = self.model.unscoped.where(attr => value)
       criteria = apply_scopes(criteria, doc)
       criteria = exclude_doc(criteria, doc) if doc.persisted?
-      doc.errors.add(attr, :taken, options.except(:scope).merge(:value => value)) unless criteria.empty?
+      doc.errors.add(attr, :taken, **options.except(:scope).merge(:value => value)) unless criteria.empty?
     rescue NoBrainer::Error::InvalidType
       # We can't run the uniqueness validator: where() won't accept bad types
       # and we have some values that don't have the right type.

data/lib/no_brainer/document.rb

@@ -7,7 +7,7 @@ module NoBrainer::Document
   autoload_and_include :Core, :TableConfig, :InjectionLayer, :Attributes, :Readonly,
                        :Persistance, :Callbacks, :Validation, :Types, :Dirty, :PrimaryKey,
                        :Association, :Serialization, :Criteria, :Polymorphic, :Index, :Aliases,
-                       :MissingAttributes, :LazyFetch, :AtomicOps, :VirtualAttributes
+                       :MissingAttributes, :LazyFetch, :AtomicOps, :VirtualAttributes, :Store
 
   autoload :DynamicAttributes, :Timestamps
 

data/lib/no_brainer/error.rb

@@ -51,7 +51,7 @@ module NoBrainer::Error
       value = self.value
       mock = model.allocate
       mock.singleton_class.send(:define_method, :read_attribute_for_validation) { |_| value }
-      mock.errors.add(attr_name, :invalid_type, error)
+      mock.errors.add(attr_name, :invalid_type, **error)
       mock.errors.full_messages.first
     end
   end

data/lib/no_brainer/query_runner/table_on_demand.rb

@@ -29,9 +29,13 @@ class NoBrainer::QueryRunner::TableOnDemand < NoBrainer::QueryRunner::Middleware
     env[:last_auto_create_table] = [db_name, table_name]
 
     create_options = model.table_create_options
-
-    NoBrainer.run(:db => db_name) do |r|
-      r.table_create(table_name, create_options.reject { |k,_| k.in? [:name, :write_acks] })
+    begin
+      NoBrainer.run(:db => db_name) do |r|
+        r.table_create(table_name, create_options.reject { |k,_| k.in? [:name, :write_acks] })
+      end
+    rescue RuntimeError => e
+      # We might have raced with another table create
+      raise unless e.message =~ /Table `#{db_name}\.#{table_name}` already exists/
     end
 
     # Prevent duplicate table errors on a cluster.
@@ -49,8 +53,5 @@ class NoBrainer::QueryRunner::TableOnDemand < NoBrainer::QueryRunner::Middleware
         r.table(table_name).config().update(:write_acks => create_options[:write_acks])
       end
     end
-  rescue RuntimeError => e
-    # We might have raced with another table create
-    raise unless e.message =~ /Table `#{db_name}\.#{table_name}` already exists/
   end
 end

data/lib/nobrainer.rb

@@ -37,6 +37,10 @@ module NoBrainer
       RUBY_PLATFORM == 'java'
     end
 
+    def rails4?
+      Gem.loaded_specs['activesupport'].version >= Gem::Version.new('4.0.0')
+    end
+
     def rails5?
       Gem.loaded_specs['activesupport'].version >= Gem::Version.new('5.0.0.beta')
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nobrainer
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.41.1
 platform: ruby
 authors:
 - Nicolas Viennot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-09 00:00:00.000000000 Z
+date: 2022-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -17,6 +17,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,6 +27,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -31,6 +37,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -38,6 +47,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: middleware
   requirement: !ruby/object:Gem::Requirement
@@ -59,6 +71,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -66,6 +81,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: symbol_decoration
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +168,7 @@ files:
 - lib/no_brainer/document/primary_key/generator.rb
 - lib/no_brainer/document/readonly.rb
 - lib/no_brainer/document/serialization.rb
+- lib/no_brainer/document/store.rb
 - lib/no_brainer/document/table_config.rb
 - lib/no_brainer/document/table_config/synchronizer.rb
 - lib/no_brainer/document/timestamps.rb
@@ -222,7 +241,7 @@ files:
 - lib/rails/generators/templates/nobrainer.rb
 homepage: http://nobrainer.io
 licenses:
-- LGPLv3
+- LGPL-3.0-only
 metadata: {}
 post_install_message: 
 rdoc_options: []