no_nonsense_currency_converter 0.0.3 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: f6b73476f75808f770e533a9b4c6cc1c37424147
+  data.tar.gz: 98cbeffaad4f7dfd906671230aa8f1541fc1e908
+SHA512:
+  metadata.gz: 054980e962cfc1d14338e78453899bad2f71e05fb5c349ad42d4e8d2bb1b7df90d400b5a3fc5e7adb6efb3de7efa187260caf9c2f66aef4dfd61afb4c6e2337f
+  data.tar.gz: 4f52ce497e0e93ba27561b83d48ccb31ad8dee9e468d950dbd8fe0a0bade5e83048ccd1e744f7b8fd7428c8fa5390c7ae05cf3baed09e8a2a50a6b348d7d8be9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    no_nonsense_currency_converter (0.0.3)
+    no_nonsense_currency_converter (0.1.0)
 
 GEM
   remote: https://rubygems.org/
@@ -15,3 +15,6 @@ DEPENDENCIES
   bundler (~> 1.3)
   no_nonsense_currency_converter!
   rake
+
+BUNDLED WITH
+   1.10.5

data/README.md

@@ -1,5 +1,5 @@
 No Nonsense Currency Converter
-==============================
+===============================
 A crude currency converter based on the Google Finance API - WIP, no tests. Still very Alpha
 
 Usage
@@ -12,5 +12,3 @@ Example:
 > NoNonsenseCurrencyConverter.get_converted_currency_value('USD', 'GBP', 10)
 => 5.93
 ```
-
-Please report any issues and I will fix them as soon as possible.

data/lib/no_nonsense_currency_converter.rb

@@ -2,27 +2,35 @@ require "no_nonsense_currency_converter/version"
 
 module NoNonsenseCurrencyConverter
 
-  BASE_URL      = 'https://www.google.com/'
-  CONVERTER_URL = 'finance/converter'
+  # BASE_URL      = 'https://www.google.com/'
+  BASE_URL      = 'https://api.fixer.io/'
+  CONVERTER_URL = 'latest'
+  # CONVERTER_URL = 'finance/converter'
 
-  @@rate_hash = {}
+  @@rate_hash   = {}
 
   def self.get_converted_currency_value(from_currency, to_currency, amount)
-    unless @@rate_hash[from_currency].try(:[], to_currency).try(:[], amount).present?
-      data             = get_raw_data(amount, from_currency, to_currency)
-      converted_amount = get_final_parsed_amount(data).to_f.round(2)
-      @@rate_hash.merge!(from_currency => { to_currency => { amount => converted_amount } })
-    end
-    @@rate_hash[from_currency][to_currency][amount]
+    rate =
+        if @@rate_hash[from_currency].try(:[], to_currency).present?
+          @@rate_hash[from_currency][to_currency]
+        else
+          conversion_rate = get_raw_data(from_currency, to_currency)
+          @@rate_hash.merge!(from_currency => { to_currency => conversion_rate })
+          conversion_rate
+        end
+    (rate * amount.to_f).to_f.round(2)
   end
 
   private
-
-  def self.get_raw_data(amount, from, to)
-    open("#{BASE_URL}#{CONVERTER_URL}?a=#{amount}&from=#{from.upcase}&to=#{to.upcase}")
+  def self.get_raw_data(from, to)
+    # open("#{BASE_URL}#{CONVERTER_URL}?a=#{amount}&from=#{from.upcase}&to=#{to.upcase}")
+    uri  = URI("#{BASE_URL}#{CONVERTER_URL}?symbols=#{to.upcase}&base=#{from.upcase}")
+    data = Net::HTTP.get(uri)
+    JSON.parse(data)['rates'][to.upcase]
   end
 
   def self.get_final_parsed_amount(data)
-    data.read.scan(/<span class=bld>(\d+\.?\d*) [A-Z]{3}<\/span>/).flatten.first
+    # data.read.scan(/<span class=bld>(\d+\.?\d*) [A-Z]{3}<\/span>/).flatten.first
+    JSON.parse(data)['rate']['']
   end
 end

data/lib/no_nonsense_currency_converter/version.rb

@@ -1,3 +1,3 @@
 module NoNonsenseCurrencyConverter
-  VERSION = '0.0.3'
+  VERSION = '0.1.0'
 end

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: no_nonsense_currency_converter
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Anshul mengi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-03 00:00:00.000000000 Z
+date: 2015-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,17 +27,15 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A very simple currency converter based on the Google Finance Converter
@@ -62,32 +57,25 @@ files:
 homepage: https://github.com/anshulm/no_nonsense_currency_converter
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2932767722201697778
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2932767722201697778
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.4.8
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: WIP
 test_files: []