no_fly_list 0.7.2 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9fb7865780acd9586b0ff700686a1546a4c294f9fc3d7a71fe47f2fb7a6def0c
-  data.tar.gz: be5186e8116c5db42c4aa4e3536ab4343b95967f5cd05dcfb64c8f99ebb85270
+  metadata.gz: 7a4d0bb308f36212383e565010061a086173ddbd9105fad575193d7abca8ffa5
+  data.tar.gz: 92772d14d0351c3a7a0d1e631d81590fb0a87e49460773cd68e78368ef55906b
 SHA512:
-  metadata.gz: 630d2aa00cc4b2465321d1040697cff6c54124247275a0b75677d70653fe347ec1c0ad7e9c573dea060de07be1de02977f1ff6f467bfe1465299a1f764e35325
-  data.tar.gz: 1201844673a3893a3c760ab1fc88ed6826839d799bca6a93b17c2c3e802fa4e9df4d485bdc5511cec4c7cbf2bdcc3cba9cfd1280970d58b5eaa93492f7ece67a
+  metadata.gz: 793849ef8f48b2ced0c5547187fa02cc704b05bb6ebad05b65c2d7e21780ab6b2efa6349a97ef74af310ef49afa28c79506ee431f45b74613bc9038482ebf970
+  data.tar.gz: 963dd7b6d64a7b159bc4085a6ea80f3641730a108dc820a91bb9201b8e636ac5705e07f4a561a6fa1089d377866ef9fbf0c55d2018796f1bd8a9750573584c85

data/lib/no_fly_list/taggable_record/configuration.rb

@@ -82,8 +82,6 @@ module NoFlyList
 
       # Creates a new tagging class with appropriate configuration
       def create_tagging_class(setup, base_class)
-        setup.context.to_s.singularize
-
         Class.new(base_class) do
           self.table_name = "#{setup.taggable_klass.table_name.singularize}_taggings"
 
@@ -173,21 +171,26 @@ module NoFlyList
         end
 
         # Set up tagging class associations
-        setup.tagging_class_name.constantize.class_eval do
-          belongs_to :tag,
-                     class_name: setup.tag_class_name,
-                     foreign_key: "tag_id"
-
-          # For local tags, we use a simple belongs_to without polymorphic
-          belongs_to :taggable,
-                     class_name: setup.taggable_klass.name,
-                     foreign_key: "taggable_id"
-
-          validates :tag, :taggable, :context, presence: true
-          validates :tag_id, uniqueness: {
-            scope: %i[taggable_id context],
-            message: "has already been tagged on this record in this context"
-          }
+        # Guard belongs_to to prevent STI subclasses from overwriting
+        # the base class association on a shared tagging class
+        tagging_klass = setup.tagging_class_name.constantize
+        existing_taggable = tagging_klass.reflect_on_association(:taggable)
+        if existing_taggable.nil? || existing_taggable.class_name == setup.taggable_klass.name
+          tagging_klass.class_eval do
+            belongs_to :tag,
+                       class_name: setup.tag_class_name,
+                       foreign_key: "tag_id"
+
+            belongs_to :taggable,
+                       class_name: setup.taggable_klass.name,
+                       foreign_key: "taggable_id"
+
+            validates :tag, :taggable, :context, presence: true
+            validates :tag_id, uniqueness: {
+              scope: %i[taggable_id context],
+              message: "has already been tagged on this record in this context"
+            }
+          end
         end
       end
 
@@ -238,11 +241,7 @@ module NoFlyList
         # Define helper methods module for this context
         helper_module = Module.new do
           define_method :create_and_set_proxy do |instance_variable_name, setup|
-            tag_model = if setup.polymorphic
-                          setup.tag_class_name.constantize
-            else
-                          self.class.const_get("#{self.class.name}Tag")
-            end
+            tag_model = setup.tag_class_name.constantize
 
             proxy = TaggingProxy.new(
               self,

data/lib/no_fly_list/taggable_record.rb

@@ -59,7 +59,12 @@ module NoFlyList
 
           proxy = instance_variable_get(var)
           next if proxy.nil?
-          return false unless proxy.save
+          unless proxy.save
+            proxy.errors.each do |error|
+              errors.add(:base, error.message)
+            end
+            throw :abort
+          end
         end
         true
       ensure

data/lib/no_fly_list/tagging_proxy.rb

@@ -332,11 +332,12 @@ module NoFlyList
 
     def current_list_from_database
       if setup[:polymorphic]
-        tagging_table = setup[:tagging_class_name].tableize
+        tagging_klass = setup[:tagging_class_name].constantize
+        tagging_table = tagging_klass.arel_table
+
         @model.send(@context.to_s)
-              .joins("INNER JOIN #{tagging_table} ON #{tagging_table}.tag_id = tags.id")
-              .where("#{tagging_table}.taggable_type = ? AND #{tagging_table}.taggable_id = ?",
-                     @model.class.name, @model.id)
+              .where(tagging_table[:taggable_type].eq(@model.class.name))
+              .where(tagging_table[:taggable_id].eq(@model.id))
               .pluck(:name)
       else
         @model.send(@context.to_s).pluck(:name)
@@ -345,7 +346,7 @@ module NoFlyList
 
     def set_list(_context, value)
       @clear_operation = false
-      @pending_changes = transformer.parse_tags(value)
+      @pending_changes = transformer.parse_tags(value).uniq.reject(&:blank?)
       mark_record_dirty
       valid? # Just check validity without raising
       self

data/lib/no_fly_list/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NoFlyList
-  VERSION = "0.7.2"
+  VERSION = "0.7.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: no_fly_list
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.4
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -23,7 +23,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.2'
-description: Tagging system for ActiveRecord models inspired by the TSA
+description: A flexible, high-performance tagging system for Rails applications with
+  support for polymorphic tags, custom transformers, and database-specific optimizations
 email:
 - terminale@gmail.com
 executables: []
@@ -66,7 +67,12 @@ homepage: https://github.com/contriboss/no_fly_list
 licenses:
 - MIT
 metadata:
+  homepage_uri: https://github.com/contriboss/no_fly_list
+  source_code_uri: https://github.com/contriboss/no_fly_list
+  changelog_uri: https://github.com/contriboss/no_fly_list/blob/master/CHANGELOG.md
+  bug_tracker_uri: https://github.com/contriboss/no_fly_list/issues
   rubygems_mfa_required: 'true'
+  github_repo: ssh://github.com/contriboss/no_fly_list
 rdoc_options: []
 require_paths:
 - lib
@@ -83,5 +89,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 3.6.9
 specification_version: 4
-summary: Tagging system for ActiveRecord models
+summary: Modern tagging system for Rails 7.2+ applications
 test_files: []