no_fly_list 0.7.0 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a83b9c51a6624a462debf10d93389d093ab732e9b7e836ee90bde0f1ae5239e5
-  data.tar.gz: 88e96def76873eaa415431ce3ddb05076f59234d68583bad4d8c4f298fe9c0c4
+  metadata.gz: 5faaa3eaa7a8bc8f8186f8ee0dd10971f0c187963a4b9ef93cf2ef00963bedc0
+  data.tar.gz: 575274c475a0a13b4b94194f904aeec4e4d6d7795cd36db6b12ad6eff28a64f3
 SHA512:
-  metadata.gz: 28621b0b5ed052c16667b41c8398a0533d16b631cc31944a4d48f0f468da34a798e603b568435579afd1b07dae2a11ee9a7276d6b31f2a37baf9212aab5fa80a
-  data.tar.gz: 8740278135b296f312a8ef5189ab25d95c3e6428f27c286b7d10d5d359197e52280682c9adeed0305859663f6d90b4d5596465274d3eb54e5c0893326d305110
+  metadata.gz: a98397336ebfc91db71338a108df13b48af0fdc1287c2c3e9ce98569394fc05cfe8b4450d1ef2272c15b7a077966b21671c6817c4aa2ae55972f4683545f5032
+  data.tar.gz: 1cb1ec3ffcfb380fd616dabf5e5551e5ec5c5f52f24ab966aa68542c6f60f4770b293bdba8ee5841583e93b7a9d8a20a7ef25a02627473382ad2c84baaa9f88c

data/lib/generators/no_fly_list/install_generator.rb

@@ -39,14 +39,19 @@ module NoFlyList
 
       def connection_abstract_class_name
         # should be abstract class name
-        ActiveRecord::Base.descendants.find do |klass|
+        klass = ActiveRecord::Base.descendants.find do |klass|
           klass.abstract_class? && klass.connection_db_config.name == connection_name
-        end.name
+        end
+        klass&.name || "ApplicationRecord"
       end
 
       def migration_version
         "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
       end
+
+      def migration_class_name
+        "CreateApplicationTaggingTable"
+      end
     end
   end
 end

data/lib/generators/no_fly_list/models_generator.rb

@@ -36,18 +36,17 @@ module NoFlyList
         if model_class < ActiveRecord::Base
           true
         else
-          say "#{class_name} is not an ActiveRecord model. Aborting generator.", :red
-          false
+          raise ArgumentError, "#{class_name} is not an ActiveRecord model. Aborting generator."
         end
       rescue NameError
-        say "#{class_name} is not a valid constant. Aborting generator.", :red
-        false
+        raise ArgumentError, "#{class_name} is not a valid constant. Aborting generator."
       end
 
       def model_abstract_class_name
-        model_class.ancestors.find do |klass|
-          klass.is_a?(Class) && klass.abstract_class?
-        end.name
+        klass = model_class.ancestors.find do |ancestor|
+          ancestor.is_a?(Class) && ancestor.abstract_class?
+        end
+        klass&.name || "ApplicationRecord"
       end
     end
   end

data/lib/generators/no_fly_list/tagging_generator.rb

@@ -9,6 +9,7 @@ module NoFlyList
   module Generators
     class TaggingGenerator < Rails::Generators::NamedBase
       include ActiveRecord::Generators::Migration
+      source_root File.expand_path("templates", __dir__)
 
       class_option :database, type: :string, default: "primary",
                               desc: "Use different database for migration"

data/lib/generators/no_fly_list/transformer_generator.rb

@@ -5,15 +5,14 @@ require "rails/generators"
 require "rails/generators/active_record"
 require "rails/generators/named_base"
 
-unless defined?(ApplicationTagTransformer)
-  module NoFlyList
-    module Generators
-      # bin/rails g no_fly_list:transformer
-      class TransformerGenerator < Rails::Generators::Base
-        source_root File.expand_path("templates", __dir__)
-        def create_tag_transformer_file
-          template "tag_transformer.rb", File.join("app/transformers", "application_tag_transformer.rb")
-        end
+module NoFlyList
+  module Generators
+    # bin/rails g no_fly_list:transformer
+    class TransformerGenerator < Rails::Generators::Base
+      source_root File.expand_path("templates", __dir__)
+
+      def create_tag_transformer_file
+        template "tag_transformer.rb", File.join("app/transformers", "application_tag_transformer.rb")
       end
     end
   end

data/lib/no_fly_list/default_transformer.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module NoFlyList
+  module DefaultTransformer
+    module_function
+
+    # @param [String, Array<String>] tags
+    def parse_tags(tags)
+      tags = recreate_string(tags) if tags.is_a?(Array)
+      tags.split(separator).map(&:strip)
+    end
+
+    # Recreate a string from an array of tags
+    # @param [Array<String>] tags
+    # @return [String]
+    def recreate_string(tags)
+      tags.join(separator)
+    end
+
+    # @return [String]
+    def separator
+      ","
+    end
+  end
+end

data/lib/no_fly_list/taggable_record/config.rb

@@ -19,7 +19,7 @@ module NoFlyList
         taggable_class: @taggable_class.to_s,
         tag_class_name: tag_class_name,
         tagging_class_name: tagging_class_name,
-        transformer: options.fetch(:transformer, ApplicationTagTransformer).to_s,
+        transformer: options.fetch(:transformer, "ApplicationTagTransformer").to_s,
         polymorphic: options.fetch(:polymorphic, false),
         restrict_to_existing: options.fetch(:restrict_to_existing, false),
         limit: options.fetch(:limit, nil),

data/lib/no_fly_list/taggable_record/tag_setup.rb

@@ -41,7 +41,7 @@ module NoFlyList
       def initialize(taggable_klass, context, options = {})
         @taggable_klass = taggable_klass
         @context = context
-        @transformer = options.fetch(:transformer, ApplicationTagTransformer)
+        @transformer = options.fetch(:transformer, "ApplicationTagTransformer")
         @polymorphic = options.fetch(:polymorphic, false)
         @restrict_to_existing = options.fetch(:restrict_to_existing, false)
         @counter_cache = options.fetch(:counter_cache, false)

data/lib/no_fly_list/taggable_record.rb

@@ -59,7 +59,12 @@ module NoFlyList
 
           proxy = instance_variable_get(var)
           next if proxy.nil?
-          return false unless proxy.save
+          unless proxy.save
+            proxy.errors.each do |error|
+              errors.add(:base, error.message)
+            end
+            throw :abort
+          end
         end
         true
       ensure

data/lib/no_fly_list/tagging_proxy.rb

@@ -19,19 +19,32 @@ module NoFlyList
     # @param restrict_to_existing [Boolean] Only allow existing tags
     # @param limit [Integer, nil] Maximum number of tags allowed
     def initialize(model, tag_model, context,
-                   transformer: ApplicationTagTransformer,
+                   transformer: "ApplicationTagTransformer",
                    restrict_to_existing: false,
                    limit: nil)
       @model = model
       @tag_model = tag_model
       @context = context
-      @transformer = transformer.is_a?(String) ? transformer.constantize : transformer
+      @transformer = resolve_transformer(transformer)
       @restrict_to_existing = restrict_to_existing
       @limit = limit
       @pending_changes = nil # Use nil to indicate no changes yet
       @clear_operation = false
     end
 
+    def resolve_transformer(trans)
+      const = trans
+      const = const.constantize if const.is_a?(String)
+      unless const.respond_to?(:parse_tags) && const.respond_to?(:recreate_string)
+        warn "NoFlyList: transformer #{trans.inspect} is invalid. Falling back to DefaultTransformer"
+        const = NoFlyList::DefaultTransformer
+      end
+      const
+    rescue NameError
+      warn "NoFlyList: transformer #{trans.inspect} not found. Falling back to DefaultTransformer"
+      NoFlyList::DefaultTransformer
+    end
+
     # Determines if tags have changed from database state
     # @return [Boolean] True if pending changes differ from database
     # @api private
@@ -319,11 +332,12 @@ module NoFlyList
 
     def current_list_from_database
       if setup[:polymorphic]
-        tagging_table = setup[:tagging_class_name].tableize
+        tagging_klass = setup[:tagging_class_name].constantize
+        tagging_table = tagging_klass.arel_table
+
         @model.send(@context.to_s)
-              .joins("INNER JOIN #{tagging_table} ON #{tagging_table}.tag_id = tags.id")
-              .where("#{tagging_table}.taggable_type = ? AND #{tagging_table}.taggable_id = ?",
-                     @model.class.name, @model.id)
+              .where(tagging_table[:taggable_type].eq(@model.class.name))
+              .where(tagging_table[:taggable_id].eq(@model.id))
               .pluck(:name)
       else
         @model.send(@context.to_s).pluck(:name)
@@ -332,7 +346,7 @@ module NoFlyList
 
     def set_list(_context, value)
       @clear_operation = false
-      @pending_changes = transformer.parse_tags(value)
+      @pending_changes = transformer.parse_tags(value).uniq.reject(&:blank?)
       mark_record_dirty
       valid? # Just check validity without raising
       self

data/lib/no_fly_list/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NoFlyList
-  VERSION = "0.7.0"
+  VERSION = "0.7.3"
 end

data/lib/no_fly_list.rb

@@ -28,6 +28,7 @@ module NoFlyList
 
   autoload :TaggingRecord
   autoload :TagRecord
+  autoload :DefaultTransformer
 
   autoload :TaggingProxy
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: no_fly_list
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.3
 platform: ruby
 authors:
 - Abdelkader Boudih
 bindir: bin
 cert_chain: []
-date: 2025-03-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -23,7 +23,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.2'
-description: Tagging system for ActiveRecord models inspired by the TSA
+description: A flexible, high-performance tagging system for Rails applications with
+  support for polymorphic tags, custom transformers, and database-specific optimizations
 email:
 - terminale@gmail.com
 executables: []
@@ -44,6 +45,7 @@ files:
 - lib/no_fly_list.rb
 - lib/no_fly_list/application_tag.rb
 - lib/no_fly_list/application_tagging.rb
+- lib/no_fly_list/default_transformer.rb
 - lib/no_fly_list/railtie.rb
 - lib/no_fly_list/railties/tasks.rake
 - lib/no_fly_list/tag_record.rb
@@ -65,7 +67,12 @@ homepage: https://github.com/contriboss/no_fly_list
 licenses:
 - MIT
 metadata:
+  homepage_uri: https://github.com/contriboss/no_fly_list
+  source_code_uri: https://github.com/contriboss/no_fly_list
+  changelog_uri: https://github.com/contriboss/no_fly_list/blob/master/CHANGELOG.md
+  bug_tracker_uri: https://github.com/contriboss/no_fly_list/issues
   rubygems_mfa_required: 'true'
+  github_repo: ssh://github.com/contriboss/no_fly_list
 rdoc_options: []
 require_paths:
 - lib
@@ -80,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
-summary: Tagging system for ActiveRecord models
+summary: Modern tagging system for Rails 7.2+ applications
 test_files: []