no_fly_list 0.2.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fddc142a9f89b7e7fae0c35c5285ffbdf1a68b0164ffcaf889ea70a572297933
-  data.tar.gz: 6376fad323f9efbfaee941472ba977460dedc5a3a46e994df7a4bef2a8bb7d64
+  metadata.gz: 8e5fd47ff5074ba83503a9c1633bada42f7348aafb9a914d2c5f51a70820427d
+  data.tar.gz: a337a25cdce43d598fd501266ba0d99665c3adb183f994121fd201082e4e874b
 SHA512:
-  metadata.gz: ec568b5205e74c5d856d07122d6325585c12416c33f65ee2852207fa17288f1676a09d2f0757c70a6f88a091510e9d9060f0cb7446ca8d493f3397ade1bd5020
-  data.tar.gz: 76b620b9ce76b112229c770a5a2221bdacb25b9ccc5f85bfb95c77623d26dee7114967323f91dd9b5a4f896355ab0b27cbba948abfbd7effc19f4ed1d1156809
+  metadata.gz: a0063a48bd720527540437b156136c704bd9deea0c4985fb34a9c4a7595c3c932d3c9b13ab5b8032daf277b5e547b358b5343410bdb6bedae1e466bc081edecd
+  data.tar.gz: 2f430e49bc7a6cc8ed09b1aa5686121c8d90d2262f7a6cce48de48e208804ab77899227e2b48ace8a6b017a9147fd368136ce42b99eeaab9668361e1bf10acfc

data/lib/generators/no_fly_list/install_generator.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'rails/generators'
-require 'rails/generators/active_record'
-require 'rails/generators/named_base'
+require "rails/generators"
+require "rails/generators/active_record"
+require "rails/generators/named_base"
 
 # Usage:
 # bin/rails generate no_fly_list:application_tag
@@ -11,15 +11,15 @@ module NoFlyList
   module Generators
     class InstallGenerator < Rails::Generators::Base
       include Rails::Generators::Migration
-      source_root File.expand_path('templates', __dir__)
+      source_root File.expand_path("templates", __dir__)
 
-      argument :connection_name, type: :string, desc: 'The name of the database connection', default: 'primary'
+      argument :connection_name, type: :string, desc: "The name of the database connection", default: "primary"
 
       def copy_application_tag
         ensure_connection_exists
-        template 'application_tag.rb.erb', File.join('app/models', 'application_tag.rb')
-        template 'application_tagging.rb.erb', File.join('app/models', 'application_tagging.rb')
-        migration_template 'create_application_tagging_table.rb.erb', 'db/migrate/create_application_tagging_table.rb'
+        template "application_tag.rb.erb", File.join("app/models", "application_tag.rb")
+        template "application_tagging.rb.erb", File.join("app/models", "application_tagging.rb")
+        migration_template "create_application_tagging_table.rb.erb", "db/migrate/create_application_tagging_table.rb"
       end
 
       def self.next_migration_number(dirname)

data/lib/generators/no_fly_list/models_generator.rb

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
 
-require 'forwardable'
-require 'rails/generators'
-require 'rails/generators/active_record'
-require 'rails/generators/named_base'
+require "forwardable"
+require "rails/generators"
+require "rails/generators/active_record"
+require "rails/generators/named_base"
 
 module NoFlyList
   module Generators
     class ModelsGenerator < Rails::Generators::NamedBase
-      source_root File.expand_path('templates', __dir__)
+      source_root File.expand_path("templates", __dir__)
 
       def create_model_files
         return unless validate_model # Ensure it's an ActiveRecord model
 
-        template 'tagging_model.rb.erb', File.join('app/models', class_path, "#{file_name.underscore}/tagging.rb")
-        template 'tag_model.rb.erb', File.join('app/models', class_path, "#{file_name.underscore}_tag.rb")
+        template "tagging_model.rb.erb", File.join("app/models", class_path, "#{file_name.underscore}/tagging.rb")
+        template "tag_model.rb.erb", File.join("app/models", class_path, "#{file_name.underscore}_tag.rb")
       end
 
       private

data/lib/generators/no_fly_list/tagging_generator.rb

@@ -1,17 +1,17 @@
 # frozen_string_literal: true
 
-require 'forwardable'
-require 'rails/generators'
-require 'rails/generators/active_record'
-require 'rails/generators/named_base'
+require "forwardable"
+require "rails/generators"
+require "rails/generators/active_record"
+require "rails/generators/named_base"
 
 module NoFlyList
   module Generators
     class TaggingGenerator < Rails::Generators::NamedBase
       include ActiveRecord::Generators::Migration
 
-      class_option :database, type: :string, default: 'primary',
-                              desc: 'Use different database for migration'
+      class_option :database, type: :string, default: "primary",
+                              desc: "Use different database for migration"
 
       def self.default_generator_root
         File.dirname(__FILE__)
@@ -19,8 +19,8 @@ module NoFlyList
 
       def create_migration_file
         ensure_model_exists
-        migration_template 'create_tagging_table.rb.erb',
-                           [db_migrate_path, "create_#{migration_name}.rb"].compact.join('/')
+        migration_template "create_tagging_table.rb.erb",
+                           [ db_migrate_path, "create_#{migration_name}.rb" ].compact.join("/")
       end
 
       def self.next_migration_number(dirname)

data/lib/generators/no_fly_list/templates/tag_transformer.rb

@@ -18,6 +18,6 @@ module ApplicationTagTransformer
 
   # @return [String]
   def separator
-    ','
+    ","
   end
 end

data/lib/generators/no_fly_list/transformer_generator.rb

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
-require 'forwardable'
-require 'rails/generators'
-require 'rails/generators/active_record'
-require 'rails/generators/named_base'
+require "forwardable"
+require "rails/generators"
+require "rails/generators/active_record"
+require "rails/generators/named_base"
 
 unless defined?(ApplicationTagTransformer)
   module NoFlyList
     module Generators
       # bin/rails g no_fly_list:transformer
       class TransformerGenerator < Rails::Generators::Base
-        source_root File.expand_path('templates', __dir__)
+        source_root File.expand_path("templates", __dir__)
         def create_tag_transformer_file
-          template 'tag_transformer.rb', File.join('app/transformers', 'application_tag_transformer.rb')
+          template "tag_transformer.rb", File.join("app/transformers", "application_tag_transformer.rb")
         end
       end
     end

data/lib/no_fly_list/railtie.rb

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
-require 'active_record/railtie'
-require 'rails'
+require "active_record/railtie"
+require "rails"
 
 module NoFlyList
   class Railtie < Rails::Railtie # :nodoc:
     config.no_fly_list = ActiveSupport::OrderedOptions.new
-    config.no_fly_list.tag_class_name = 'ApplicationTag'
-    config.no_fly_list.tag_table_name = 'application_tags'
-    config.no_fly_list.tagging_class_name = 'ApplicationTagging'
-    config.no_fly_list.tagging_table_name = 'application_taggings'
+    config.no_fly_list.tag_class_name = "ApplicationTag"
+    config.no_fly_list.tag_table_name = "application_tags"
+    config.no_fly_list.tagging_class_name = "ApplicationTagging"
+    config.no_fly_list.tagging_table_name = "application_taggings"
 
     rake_tasks do
-      load 'no_fly_list/railties/tasks.rake'
+      load "no_fly_list/railties/tasks.rake"
     end
   end
 end

data/lib/no_fly_list/railties/tasks.rake

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 namespace :no_fly_list do
-  desc 'List all taggable records'
+  desc "List all taggable records"
   task taggable_records: :environment do
     Rails.application.eager_load!
     taggable_classes = ActiveRecord::Base.descendants.select do |klass|
-      klass.included_modules.any? { |mod| mod.in?([NoFlyList::TaggableRecord]) }
+      klass.included_modules.any? { |mod| mod.in?([ NoFlyList::TaggableRecord ]) }
     end
 
     puts "Found #{taggable_classes.size} taggable classes:\n\n"
@@ -15,11 +15,11 @@ namespace :no_fly_list do
     end
   end
 
-  desc 'List all tag records'
+  desc "List all tag records"
   task tag_records: :environment do
     Rails.application.eager_load!
     tag_classes = ActiveRecord::Base.descendants.select do |klass|
-      klass.included_modules.any? { |mod| mod.in?([NoFlyList::ApplicationTag, NoFlyList::TagRecord]) }
+      klass.included_modules.any? { |mod| mod.in?([ NoFlyList::ApplicationTag, NoFlyList::TagRecord ]) }
     end
 
     puts "Found #{tag_classes.size} tag classes:\n\n"
@@ -29,11 +29,11 @@ namespace :no_fly_list do
     end
   end
 
-  desc 'Check taggable records and their associated tables'
+  desc "Check taggable records and their associated tables"
   task check_taggable_records: :environment do
     Rails.application.eager_load!
     taggable_classes = ActiveRecord::Base.descendants.select do |klass|
-      klass.included_modules.any? { |mod| mod.in?([NoFlyList::TaggableRecord]) }
+      klass.included_modules.any? { |mod| mod.in?([ NoFlyList::TaggableRecord ]) }
     end
 
     puts "Checking #{taggable_classes.size} taggable classes:\n\n"

data/lib/no_fly_list/taggable_record/config.rb

@@ -24,7 +24,8 @@ module NoFlyList
         restrict_to_existing: options.fetch(:restrict_to_existing, false),
         limit: options.fetch(:limit, nil),
         case_sensitive: options.fetch(:case_sensitive, true),
-        adapter: @adapter
+        adapter: @adapter,
+        counter_cache: options.fetch(:counter_cache, false)
       }
     end
 
@@ -32,9 +33,9 @@ module NoFlyList
 
     def determine_adapter
       case taggable_class.connection.adapter_name.downcase
-      when 'postgresql'
+      when "postgresql"
         :postgresql
-      when 'mysql2'
+      when "mysql2"
         :mysql
       else
         :sqlite

data/lib/no_fly_list/taggable_record/configuration.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require_relative 'mutation'
-require_relative 'query'
-require_relative 'tag_setup'
+require_relative "mutation"
+require_relative "query"
+require_relative "tag_setup"
 
 module NoFlyList
   module TaggableRecord
@@ -90,11 +90,12 @@ module NoFlyList
           # Add the basic associations
           belongs_to :tag,
                      class_name: setup.tag_class_name,
-                     foreign_key: 'tag_id'
+                     foreign_key: "tag_id"
 
           belongs_to :taggable,
                      class_name: setup.taggable_klass.name,
-                     foreign_key: 'taggable_id'
+                     foreign_key: "taggable_id",
+                     counter_cache: setup.counter_cache ? "#{setup.context}_count" : nil
 
           include NoFlyList::TaggingRecord
         end
@@ -118,12 +119,12 @@ module NoFlyList
         # Set up the tag model associations
         setup.tag_class_name.constantize.class_eval do
           # Fix: Use 'tagging' for the join association when context is 'tag'
-          association_name = (singular_name == 'tag' ? :taggings : :"#{singular_name}_taggings")
+          association_name = (singular_name == "tag" ? :taggings : :"#{singular_name}_taggings")
 
           has_many association_name,
                    -> { where(context: singular_name) },
                    class_name: setup.tagging_class_name,
-                   foreign_key: 'tag_id',
+                   foreign_key: "tag_id",
                    dependent: :destroy
 
           # Fix: Use consistent naming for through association
@@ -137,7 +138,7 @@ module NoFlyList
         setup.tagging_class_name.constantize.class_eval do
           belongs_to :tag,
                      class_name: setup.tag_class_name,
-                     foreign_key: 'tag_id'
+                     foreign_key: "tag_id"
 
           belongs_to :taggable,
                      polymorphic: true
@@ -149,19 +150,21 @@ module NoFlyList
 
           validates :tag_id, uniqueness: {
             scope: %i[taggable_type taggable_id context],
-            message: 'has already been tagged on this record in this context'
+            message: "has already been tagged on this record in this context"
           }
         end
       end
 
       # Sets up associations for local (non-global) tags
       def setup_local_tag_associations(setup, singular_name)
+        plural_name = setup.context.to_s
         # Set up tag class associations
         setup.tag_class_name.constantize.class_eval do
           has_many :"#{singular_name}_taggings",
                    -> { where(context: singular_name) },
                    class_name: setup.tagging_class_name,
-                   foreign_key: 'tag_id',
+                   foreign_key: "tag_id",
+                   counter_cache: setup.counter_cache ? "#{plural_name}_count" : nil,
                    dependent: :destroy
 
           has_many :"#{singular_name}_taggables",
@@ -173,17 +176,17 @@ module NoFlyList
         setup.tagging_class_name.constantize.class_eval do
           belongs_to :tag,
                      class_name: setup.tag_class_name,
-                     foreign_key: 'tag_id'
+                     foreign_key: "tag_id"
 
           # For local tags, we use a simple belongs_to without polymorphic
           belongs_to :taggable,
                      class_name: setup.taggable_klass.name,
-                     foreign_key: 'taggable_id'
+                     foreign_key: "taggable_id"
 
           validates :tag, :taggable, :context, presence: true
           validates :tag_id, uniqueness: {
             scope: %i[taggable_id context],
-            message: 'has already been tagged on this record in this context'
+            message: "has already been tagged on this record in this context"
           }
         end
       end
@@ -196,7 +199,7 @@ module NoFlyList
             has_many :"#{singular_name}_taggings",
                      -> { where(context: singular_name) },
                      class_name: setup.tagging_class_name,
-                     foreign_key: 'taggable_id',
+                     foreign_key: "taggable_id",
                      as: :taggable,
                      dependent: :destroy
 
@@ -217,7 +220,7 @@ module NoFlyList
             has_many :"#{singular_name}_taggings",
                      -> { where(context: singular_name) },
                      class_name: setup.tagging_class_name,
-                     foreign_key: 'taggable_id',
+                     foreign_key: "taggable_id",
                      dependent: :destroy
 
             has_many setup.context,
@@ -237,9 +240,9 @@ module NoFlyList
           define_method :create_and_set_proxy do |instance_variable_name, setup|
             tag_model = if setup.polymorphic
                           setup.tag_class_name.constantize
-                        else
+            else
                           self.class.const_get("#{self.class.name}Tag")
-                        end
+            end
 
             proxy = TaggingProxy.new(
               self,
@@ -298,9 +301,9 @@ module NoFlyList
       end
 
       def define_constant_in_namespace(const_name)
-        parts = const_name.split('::')
+        parts = const_name.split("::")
         const_name = parts.pop
-        namespace = parts.join('::').safe_constantize || Object
+        namespace = parts.join("::").safe_constantize || Object
         return if namespace.const_defined?(const_name, false)
 
         namespace.const_set(const_name, yield)

data/lib/no_fly_list/taggable_record/query/mysql_strategy.rb

@@ -40,8 +40,8 @@ module NoFlyList
               return none if tags.empty?
 
               count_function = Arel::Nodes::NamedFunction.new(
-                'COUNT',
-                [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:name]])]
+                "COUNT",
+                [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:name] ]) ]
               )
 
               query = Arel::SelectManager.new(self)
@@ -78,11 +78,11 @@ module NoFlyList
                                 .where(context: singular_name)
                                 .where(taggable_type: name)
                                 .select(:taggable_id)
-                         else
+              else
                            setup.tagging_class_name.constantize
                                 .where(context: singular_name)
                                 .select(:taggable_id)
-                         end
+              end
 
               where("#{table_name}.#{primary_key} NOT IN (?)", subquery)
             }
@@ -95,8 +95,8 @@ module NoFlyList
                 send("without_#{context}")
               else
                 Arel::Nodes::NamedFunction.new(
-                  'COUNT',
-                  [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:id]])]
+                  "COUNT",
+                  [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:id] ]) ]
                 )
 
                 # Build the query for records having exactly the tags

data/lib/no_fly_list/taggable_record/query/postgresql_strategy.rb

@@ -40,8 +40,8 @@ module NoFlyList
               return none if tags.empty?
 
               count_function = Arel::Nodes::NamedFunction.new(
-                'COUNT',
-                [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:name]])]
+                "COUNT",
+                [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:name] ]) ]
               )
 
               query = Arel::SelectManager.new(self)
@@ -78,11 +78,11 @@ module NoFlyList
                                 .where(context: singular_name)
                                 .where(taggable_type: name)
                                 .select(:taggable_id)
-                         else
+              else
                            setup.tagging_class_name.constantize
                                 .where(context: singular_name)
                                 .select(:taggable_id)
-                         end
+              end
 
               where.not(primary_key => subquery)
             }
@@ -95,8 +95,8 @@ module NoFlyList
                 send("without_#{context}")
               else
                 Arel::Nodes::NamedFunction.new(
-                  'COUNT',
-                  [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:id]])]
+                  "COUNT",
+                  [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:id] ]) ]
                 )
 
                 # Build the query for records having exactly the tags

data/lib/no_fly_list/taggable_record/query/sqlite_strategy.rb

@@ -40,8 +40,8 @@ module NoFlyList
               return none if tags.empty?
 
               count_function = Arel::Nodes::NamedFunction.new(
-                'COUNT',
-                [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:name]])]
+                "COUNT",
+                [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:name] ]) ]
               )
 
               query = Arel::SelectManager.new(self)
@@ -70,7 +70,7 @@ module NoFlyList
                            .pluck("#{table_name}.id")
 
               # Handle empty tagged_ids explicitly for SQLite compatibility
-              where("#{table_name}.id NOT IN (?)", tagged_ids.present? ? tagged_ids : [-1])
+              where("#{table_name}.id NOT IN (?)", tagged_ids.present? ? tagged_ids : [ -1 ])
             }
 
             # Find records without any tags
@@ -79,12 +79,12 @@ module NoFlyList
                            setup.tagging_class_name.constantize
                                 .where(context: singular_name, taggable_type: name)
                                 .select(:taggable_id)
-                         else
+              else
                            setup.tagging_class_name.constantize
                                 .where(context: singular_name)
                                 .select(:taggable_id)
-                         end
-              where('id NOT IN (?)', subquery)
+              end
+              where("id NOT IN (?)", subquery)
             }
 
             # Find records with exactly these tags
@@ -95,8 +95,8 @@ module NoFlyList
                 send("without_#{context}")
               else
                 Arel::Nodes::NamedFunction.new(
-                  'COUNT',
-                  [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:id]])]
+                  "COUNT",
+                  [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:id] ]) ]
                 )
 
                 # Build the query for records having exactly the tags
@@ -130,8 +130,8 @@ module NoFlyList
                 send("without_#{context}")
               else
                 Arel::Nodes::NamedFunction.new(
-                  'COUNT',
-                  [Arel::Nodes::NamedFunction.new('DISTINCT', [tag_table[:id]])]
+                  "COUNT",
+                  [ Arel::Nodes::NamedFunction.new("DISTINCT", [ tag_table[:id] ]) ]
                 )
 
                 # Build the query for records having exactly the tags

data/lib/no_fly_list/taggable_record/tag_setup.rb

@@ -4,7 +4,7 @@ module NoFlyList
   module TaggableRecord
     class TagSetup
       attr_reader :taggable_klass, :context, :transformer, :polymorphic,
-                  :restrict_to_existing, :limit,
+                  :restrict_to_existing, :limit, :counter_cache,
                   :tag_class_name, :tagging_class_name, :adapter
 
       def initialize(taggable_klass, context, options = {})
@@ -13,6 +13,8 @@ module NoFlyList
         @transformer = options.fetch(:transformer, ApplicationTagTransformer)
         @polymorphic = options.fetch(:polymorphic, false)
         @restrict_to_existing = options.fetch(:restrict_to_existing, false)
+        @counter_cache = options.fetch(:counter_cache, false)
+        @counter_cache_column = "#{context}_count"
         @limit = options.fetch(:limit, nil)
         @tag_class_name = determine_tag_class_name(taggable_klass, options)
         @tagging_class_name = determine_tagging_class_name(taggable_klass, options)
@@ -23,9 +25,9 @@ module NoFlyList
 
       def determine_adapter
         case ActiveRecord::Base.connection.adapter_name.downcase
-        when 'postgresql'
+        when "postgresql"
           :postgresql
-        when 'mysql2'
+        when "mysql2"
           :mysql
         else
           :sqlite

data/lib/no_fly_list/taggable_record.rb

@@ -12,6 +12,10 @@ module NoFlyList
       before_validation :validate_tag_proxies
     end
 
+    def changed_for_autosave?
+      super || tag_proxies_changed?
+    end
+
     private
 
     def validate_tag_proxies
@@ -66,6 +70,19 @@ module NoFlyList
       tag_contexts[context.to_sym]
     end
 
+    def tag_proxies_changed?
+      return false if @saving_proxies || @validating_proxies
+
+      instance_variables.any? do |var|
+        next unless var.to_s.match?(/_list_proxy$/)
+
+        proxy = instance_variable_get(var)
+        next if proxy.nil?
+
+        proxy.changed?
+      end
+    end
+
     class_methods do
       def has_tags(*contexts, **options)
         contexts.each do |context|

data/lib/no_fly_list/tagging_proxy.rb

@@ -26,6 +26,10 @@ module NoFlyList
       @pending_changes = []
     end
 
+    def changed?
+      @pending_changes.present? && @pending_changes != current_list_from_database
+    end
+
     def method_missing(method_name, *args)
       if current_list.respond_to?(method_name)
         current_list.send(method_name, *args)
@@ -47,7 +51,7 @@ module NoFlyList
     end
 
     def coerce(other)
-      [other, to_a]
+      [ other, to_a ]
     end
 
     def to_ary
@@ -65,13 +69,16 @@ module NoFlyList
         model.class.transaction do
           # Always save parent first if needed
           if model.new_record? && !model.save
-            errors.add(:base, 'Failed to save parent record')
+            errors.add(:base, "Failed to save parent record")
             raise ActiveRecord::Rollback
           end
 
           # Clear existing tags
+          old_count = model.send(context_taggings).count
           model.send(context_taggings).delete_all
 
+          # Update counter
+          model.update_column("#{@context}_count", 0) if setup[:counter_cache]
           # Create new tags
           @pending_changes.each do |tag_name|
             tag = find_or_create_tag(tag_name)
@@ -91,6 +98,8 @@ module NoFlyList
             model.send(context_taggings).create!(attributes)
           end
         end
+        # Update counter to match the actual count
+        model.update_column("#{@context}_count", @pending_changes.size) if setup[:counter_cache]
 
         refresh_from_database
         true
@@ -143,10 +152,10 @@ module NoFlyList
       "#<#{self.class.name} tags=#{current_list.inspect} transformer_with=#{transformer_name} >"
     end
 
-    def add(tag)
+    def add(*tags)
       return self if limit_reached?
 
-      new_tags = transformer.parse_tags(tag)
+      new_tags = tags.flatten.map { |tag| transformer.parse_tags(tag) }.flatten
       return self if new_tags.empty?
 
       @pending_changes = current_list + new_tags
@@ -154,13 +163,15 @@ module NoFlyList
       self
     end
 
-    def add!(tag)
-      add(tag)
+    def add!(*tags)
+      add(*tags)
       save
     end
 
     def remove(tag)
-      @pending_changes = current_list - [tag.to_s.strip]
+      old_list = current_list.dup
+      @pending_changes = current_list - [ tag.to_s.strip ]
+      mark_record_dirty if @pending_changes != old_list
       self
     end
 
@@ -170,13 +181,17 @@ module NoFlyList
     end
 
     def clear
+      old_list = current_list.dup
       @pending_changes = []
+      mark_record_dirty if @pending_changes != old_list
+      model.write_attribute("#{@context}_count", 0) if setup[:counter_cache]
       self
     end
 
     def clear!
       @model.send(@context.to_s).destroy_all
       @pending_changes = []
+      @model.update_column("#{@context}_count", 0) if setup[:counter_cache]
       self
     end
 
@@ -194,6 +209,19 @@ module NoFlyList
 
     private
 
+    def current_list_from_database
+      if setup[:polymorphic]
+        tagging_table = setup[:tagging_class_name].tableize
+        @model.send(@context.to_s)
+              .joins("INNER JOIN #{tagging_table} ON #{tagging_table}.tag_id = tags.id")
+              .where("#{tagging_table}.taggable_type = ? AND #{tagging_table}.taggable_id = ?",
+                     @model.class.name, @model.id)
+              .pluck(:name)
+      else
+        @model.send(@context.to_s).pluck(:name)
+      end
+    end
+
     def set_list(_context, value)
       @pending_changes = transformer.parse_tags(value)
       valid? # Just check validity without raising
@@ -221,7 +249,7 @@ module NoFlyList
 
       # Transform tags to lowercase for comparison
       normalized_changes = @pending_changes.map(&:downcase)
-      existing_tags = @tag_model.where('LOWER(name) IN (?)', normalized_changes).pluck(:name)
+      existing_tags = @tag_model.where("LOWER(name) IN (?)", normalized_changes).pluck(:name)
       missing_tags = @pending_changes - existing_tags
 
       return unless missing_tags.any?
@@ -279,20 +307,21 @@ module NoFlyList
     def current_list
       if @pending_changes.any?
         @pending_changes
-      elsif setup[:polymorphic]
-        tagging_table = setup[:tagging_class_name].tableize
-        @model.send(@context.to_s)
-              .joins("INNER JOIN #{tagging_table} ON #{tagging_table}.tag_id = tags.id")
-              .where("#{tagging_table}.taggable_type = ? AND #{tagging_table}.taggable_id = ?",
-                     @model.class.name, @model.id)
-              .pluck(:name)
       else
-        @model.send(@context.to_s).pluck(:name)
+        current_list_from_database
       end
     end
 
     def limit_reached?
       @limit && current_list.size >= @limit
     end
+
+    def mark_record_dirty
+      return unless model.respond_to?(:changed_attributes)
+
+      # We use a virtual attribute name based on the context
+      # This ensures the record is marked as changed when tags are modified
+      model.send(:attribute_will_change!, "#{context}_list")
+    end
   end
 end

data/lib/no_fly_list/test_helper.rb

@@ -45,9 +45,9 @@ module NoFlyList
     def assert_polymorphic_tag_classes_exist(tags_klass, tagging_klass)
       # Verify they include the correct modules
       assert tags_klass.include?(NoFlyList::ApplicationTag),
-             'Polymorphic Tag should include NoFlyList::ApplicationTag'
+             "Polymorphic Tag should include NoFlyList::ApplicationTag"
       assert tagging_klass.include?(NoFlyList::ApplicationTagging),
-             'Polymorphic Tagging should include NoFlyList::ApplicationTagging'
+             "Polymorphic Tagging should include NoFlyList::ApplicationTagging"
     end
 
     def assert_local_tag_classes_exist(klass, context)

data/lib/no_fly_list/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NoFlyList
-  VERSION = '0.2.1'
+  VERSION = "0.4.0"
 end

data/lib/no_fly_list.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require 'active_record'
-require 'active_support'
-require 'active_support/rails'
-require 'active_support/core_ext/numeric/time'
-require_relative 'no_fly_list/version'
-require 'no_fly_list/railtie' if defined?(Rails)
+require "active_record"
+require "active_support"
+require "active_support/rails"
+require "active_support/core_ext/numeric/time"
+require_relative "no_fly_list/version"
+require "no_fly_list/railtie" if defined?(Rails)
 
 module NoFlyList
   extend ActiveSupport::Autoload
@@ -16,10 +16,10 @@ module NoFlyList
   # Common tagging tables
   autoload :TaggableRecord
 
-  autoload_under 'taggable_record' do
+  autoload_under "taggable_record" do
     autoload :Configuration
     autoload :Config
-    autoload_under 'taggable_record/query' do
+    autoload_under "taggable_record/query" do
       autoload :SqliteStrategy
       autoload :MysqlStrategy
       autoload :PostgresqlStrategy

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: no_fly_list
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Abdelkader Boudih