nne_client 0.0.2 → 0.0.3

data/History.md

@@ -1,4 +1,9 @@
 
+0.0.3 / 2012-06-25 
+==================
+
+  * [BUGFIX] Result#trades is an empty array if no trades present for company
+
 0.0.2 / 2012-05-21 
 ==================
 

data/lib/nne_client/result.rb

@@ -68,7 +68,7 @@ module NNEClient
 
     # List of trades
     def trades
-      trades = Fetch.new(tdc_id, 'fetchCompanyTrade').result_set.to_hash[:trade]
+      trades = Fetch.new(tdc_id, 'fetchCompanyTrade').result_set.to_hash[:trade] || []
       if trades.kind_of?(Hash)
         [Trade.new(trades)]
       else

data/lib/nne_client/version.rb

@@ -1,3 +1,3 @@
 module NNEClient
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/result_spec.rb

@@ -114,6 +114,14 @@ describe NNEClient::Result do
     end
   end
 
+  context "with no trades" do
+    it 'returns an empty array of trades' do
+      soap_vcr('result_no_trade') do
+        NNEClient::Result.new(:tdc_id => '202355845').trades.should == []
+      end
+    end
+  end
+
   context "with a single trade" do
     around(:each) do |example|
       soap_vcr('result_trades') do

data/spec/vcr_cassettes/result_no_trade.yml

@@ -0,0 +1,40 @@
+--- 
+recorded_with: VCR 2.1.1
+http_interactions: 
+- request: 
+    method: post
+    uri: http://service.nnerhverv.dk/nne-ws/3.1/NNE
+    body: 
+      string: <?xml version="1.0" encoding="UTF-8"?><env:Envelope xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ins0="http://com.stibo.net/nne/3.1/Types/NNE" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:wsdl="http://com.stibo.net/nne/3.1/NNE"><env:Body><wsdl:fetchCompanyTrade env:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><int_1 xsi:type="xsd:int">202355845</int_1><int_2 xsi:type="xsd:int">0</int_2><String_3 xsi:type="xsd:string"></String_3><String_4 xsi:type="xsd:string"></String_4></wsdl:fetchCompanyTrade></env:Body></env:Envelope>
+    headers: 
+      content-type: 
+      - text/xml;charset=UTF-8
+      accept: 
+      - "*/*"
+      soapaction: 
+      - "\"fetchCompanyTrade\""
+      content-length: 
+      - "614"
+  response: 
+    status: 
+      code: 200
+      message: OK
+    headers: 
+      content-type: 
+      - text/xml; charset="utf-8"
+      date: 
+      - Mon, 25 Jun 2012 14:00:40 GMT
+      x-powered-by: 
+      - ASP.NET
+      soapaction: 
+      - "\"\""
+      connection: 
+      - close
+      server: 
+      - Microsoft-IIS/6.0
+    body: 
+      string: |-
+        <?xml version="1.0" encoding="UTF-8"?>
+        <env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:enc="http://schemas.xmlsoap.org/soap/encoding/" xmlns:ns0="http://com.stibo.net/nne/3.1/Types/NNE" env:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><env:Body><ans1:fetchCompanyTradeResponse xmlns:ans1="http://com.stibo.net/nne/3.1/NNE"><result href="#ID1"/></ans1:fetchCompanyTradeResponse><ns0:ArrayOfTrade id="ID1" xsi:type="enc:Array" enc:arrayType="ns0:Trade[0]"/></env:Body></env:Envelope>
+    http_version: "1.1"
+  recorded_at: Mon, 25 Jun 2012 14:00:40 GMT

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: nne_client
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - Jacob Atzen
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-05-21 00:00:00 Z
+date: 2012-06-25 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: savon
@@ -159,6 +159,7 @@ files:
 - spec/vcr_cassettes/result_no_finance.yml
 - spec/vcr_cassettes/result_no_ownerships.yml
 - spec/vcr_cassettes/result_no_subsidiaries.yml
+- spec/vcr_cassettes/result_no_trade.yml
 - spec/vcr_cassettes/result_single_finance.yml
 - spec/vcr_cassettes/result_single_ownership.yml
 - spec/vcr_cassettes/result_single_subsidiary.yml
@@ -224,6 +225,7 @@ test_files:
 - spec/vcr_cassettes/result_no_finance.yml
 - spec/vcr_cassettes/result_no_ownerships.yml
 - spec/vcr_cassettes/result_no_subsidiaries.yml
+- spec/vcr_cassettes/result_no_trade.yml
 - spec/vcr_cassettes/result_single_finance.yml
 - spec/vcr_cassettes/result_single_ownership.yml
 - spec/vcr_cassettes/result_single_subsidiary.yml