nne_client 0.0.1 → 0.0.2

data/History.md

@@ -0,0 +1,12 @@
+
+0.0.2 / 2012-05-21 
+==================
+
+  * Convert finance info to floats
+  * Don't force net_http
+  * Store wsdl locally
+
+0.0.1 / 2012-05-15 
+==================
+
+Initial release

data/README.md

@@ -16,10 +16,6 @@ Or install it yourself as:
 
     $ gem install nne_client
 
-## Warning
-
-NNEClient only works with the Net/HTTP and will force HTTPI to use this.
-
 ## Usage
 
 If you need to provide an access key configure NNE Client with:

data/lib/nne_client/record_types/finance.rb

@@ -7,37 +7,38 @@ module NNEClient
     end
 
     attributes :accounting_date,
-               :assets,
-               :available_funds,
-               :available_funds_ratio,
-               :balance,
-               :capacity_ratio,
-               :contribution_ratio,
                :credit_rating,
-               :current_assets,
-               :depreciations,
-               :fixed_assets,
-               :fixed_cost,
-               :gross_profit,
-               :income_before_income_tax,
                :link_pdf,
-               :long_termed_liability,
-               :lots_and_sites,
-               :net_outcome,
                :number_of_employees,
-               :placings,
-               :profit,
-               :profit_for_the_year,
-               :profit_ratio,
                :published_date,
-               :return_on_assets,
-               :share_holders_funds_of_interest,
-               :shareholders_funds,
-               :short_termed_liability,
-               :solvency_ratio,
-               :stock,
-               :trade_debitors,
-               :turnover,
                :year
+
+    float_attributes :assets,
+                     :available_funds,
+                     :available_funds_ratio,
+                     :balance,
+                     :capacity_ratio,
+                     :contribution_ratio,
+                     :current_assets,
+                     :depreciations,
+                     :fixed_assets,
+                     :fixed_cost,
+                     :gross_profit,
+                     :income_before_income_tax,
+                     :long_termed_liability,
+                     :lots_and_sites,
+                     :net_outcome,
+                     :placings,
+                     :profit,
+                     :profit_for_the_year,
+                     :profit_ratio,
+                     :return_on_assets,
+                     :share_holders_funds_of_interest,
+                     :shareholders_funds,
+                     :short_termed_liability,
+                     :solvency_ratio,
+                     :stock,
+                     :trade_debitors,
+                     :turnover
   end
 end

data/lib/nne_client/request.rb

@@ -15,6 +15,9 @@ module NNEClient
       retries = 3
       begin
         ResultSet.new(perform_request(&block))
+      rescue HTTPClient::ReceiveTimeoutError => e
+        retries -= 1
+        retry if retries > 0
       rescue Net::HTTPRequestTimeOut => e
         retries -= 1
         retry if retries > 0
@@ -45,12 +48,10 @@ module NNEClient
       { "env:encodingStyle" => "http://schemas.xmlsoap.org/soap/encoding/" }
     end
 
-    def wsdl_url
-      'http://service.nnerhverv.dk/nne-ws/3.1/NNE?WSDL'
-    end
-
     def client
-      @client ||= Savon::Client.new(wsdl_url)
+      @client ||= Savon::Client.new do
+        wsdl.document = File.expand_path("../../../wsdl/nne.wsdl", __FILE__)
+      end
     end
   end
 end

data/lib/nne_client/result_attributes.rb

@@ -33,5 +33,14 @@ module NNEClient
         end
       end
     end
+
+    # Create a method that converts to float for each key listed in attrs
+    def float_attributes(*attrs)
+      attrs.each do |attribute|
+        define_method(attribute) do
+          @hash[attribute].to_f unless @hash[attribute].kind_of?(Hash)
+        end
+      end
+    end
   end
 end

data/lib/nne_client/version.rb

@@ -1,3 +1,3 @@
 module NNEClient
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/nne_client.rb

@@ -14,8 +14,6 @@ require "nne_client/record_types/ownership"
 require "nne_client/record_types/subsidiary"
 require "nne_client/record_types/trade"
 
-HTTPI.adapter = :net_http
-
 # Namespace for the library
 module NNEClient
   extend self

data/spec/finance_spec.rb

@@ -44,36 +44,36 @@ describe NNEClient::Finance do
   subject { NNEClient::Finance.new(hash) }
 
   its(:accounting_date)                 { should == hash[:accounting_date] }
-  its(:assets)                          { should == hash[:assets] }
-  its(:available_funds)                 { should == hash[:available_funds] }
-  its(:available_funds_ratio)           { should == hash[:available_funds_ratio] }
-  its(:balance)                         { should == hash[:balance] }
-  its(:capacity_ratio)                  { should == hash[:capacity_ratio] }
-  its(:contribution_ratio)              { should == hash[:contribution_ratio] }
+  its(:assets)                          { should == hash[:assets].to_f }
+  its(:available_funds)                 { should == hash[:available_funds].to_f }
+  its(:available_funds_ratio)           { should == hash[:available_funds_ratio].to_f }
+  its(:balance)                         { should == hash[:balance].to_f }
+  its(:capacity_ratio)                  { should == hash[:capacity_ratio].to_f }
+  its(:contribution_ratio)              { should == hash[:contribution_ratio].to_f }
   its(:credit_rating)                   { should be_nil }
-  its(:current_assets)                  { should == hash[:current_assets] }
-  its(:depreciations)                   { should == hash[:depreciations] }
-  its(:fixed_assets)                    { should == hash[:fixed_assets] }
-  its(:fixed_cost)                      { should == hash[:fixed_cost] }
-  its(:gross_profit)                    { should == hash[:gross_profit] }
-  its(:income_before_income_tax)        { should == hash[:income_before_income_tax] }
+  its(:current_assets)                  { should == hash[:current_assets].to_f }
+  its(:depreciations)                   { should == hash[:depreciations].to_f }
+  its(:fixed_assets)                    { should == hash[:fixed_assets].to_f }
+  its(:fixed_cost)                      { should == hash[:fixed_cost].to_f }
+  its(:gross_profit)                    { should == hash[:gross_profit].to_f }
+  its(:income_before_income_tax)        { should == hash[:income_before_income_tax].to_f }
   its(:link_pdf)                        { should == hash[:link_pdf] }
-  its(:long_termed_liability)           { should == hash[:long_termed_liability] }
-  its(:lots_and_sites)                  { should == hash[:lots_and_sites] }
-  its(:net_outcome)                     { should == hash[:net_outcome] }
+  its(:long_termed_liability)           { should == hash[:long_termed_liability].to_f }
+  its(:lots_and_sites)                  { should == hash[:lots_and_sites].to_f }
+  its(:net_outcome)                     { should == hash[:net_outcome].to_f }
   its(:number_of_employees)             { should == hash[:number_of_employees] }
-  its(:placings)                        { should == hash[:placings] }
-  its(:profit)                          { should == hash[:profit] }
-  its(:profit_for_the_year)             { should == hash[:profit_for_the_year] }
-  its(:profit_ratio)                    { should == hash[:profit_ratio] }
+  its(:placings)                        { should == hash[:placings].to_f }
+  its(:profit)                          { should == hash[:profit].to_f }
+  its(:profit_for_the_year)             { should == hash[:profit_for_the_year].to_f }
+  its(:profit_ratio)                    { should == hash[:profit_ratio].to_f }
   its(:published_date)                  { should == hash[:published_date] }
-  its(:return_on_assets)                { should == hash[:return_on_assets] }
-  its(:share_holders_funds_of_interest) { should == hash[:share_holders_funds_of_interest] }
-  its(:shareholders_funds)              { should == hash[:shareholders_funds] }
-  its(:short_termed_liability)          { should == hash[:short_termed_liability] }
-  its(:solvency_ratio)                  { should == hash[:solvency_ratio] }
-  its(:stock)                           { should == hash[:stock] }
-  its(:trade_debitors)                  { should == hash[:trade_debitors] }
-  its(:turnover)                        { should == hash[:turnover] }
+  its(:return_on_assets)                { should == hash[:return_on_assets].to_f }
+  its(:share_holders_funds_of_interest) { should == hash[:share_holders_funds_of_interest].to_f }
+  its(:shareholders_funds)              { should == hash[:shareholders_funds].to_f }
+  its(:short_termed_liability)          { should == hash[:short_termed_liability].to_f }
+  its(:solvency_ratio)                  { should == hash[:solvency_ratio].to_f }
+  its(:stock)                           { should == hash[:stock].to_f }
+  its(:trade_debitors)                  { should == hash[:trade_debitors].to_f }
+  its(:turnover)                        { should == hash[:turnover].to_f }
   its(:year)                            { should == hash[:year] }
 end

data/spec/result_spec.rb

@@ -94,7 +94,7 @@ describe NNEClient::Result do
       its(:homepage)            { should be_nil }
       its(:founded_year)        { should == '2009' }
       its(:number_of_employees) { should == '0' }
-      its(:tdf_name)            { should == 'Incremental' }
+      its(:tdf_name)            { should == 'Jacob Atzen' }
       its(:status_text)         { should == 'Selskabet er i normal drift.' }
     end
 
@@ -109,7 +109,7 @@ describe NNEClient::Result do
       its(:homepage)            { should be_nil }
       its(:founded_year)        { should == '2009' }
       its(:number_of_employees) { should == '0' }
-      its(:tdf_name)            { should == 'Incremental' }
+      its(:tdf_name)            { should == 'Jacob Atzen' }
       its(:status_text)         { should == 'Selskabet er i normal drift.' }
     end
   end
@@ -257,14 +257,17 @@ describe NNEClient::Result do
 
   it "knows all names" do
     soap_vcr('result_names') do
-      result = NNEClient::Result.new(:official_name => 'Name', :tdc_id => '100323228')
+      result = NNEClient::Result.new(:official_name => 'Name', :tdc_id => '100055268')
       result.additional_names.should == [
-        "Tv Holbæk A/S",
+        "A/S Kalundborg Folkeblad",
+        "Aktieselskabet Holbæk Amts Venstreblad",
         "A/S Trykkeriet Nordvest",
         "A/S Trykkeriet Nordvestsjælland",
+        "Havision A/S",
         "Nordvestsjællands Media Selskab A/S",
-        "Radio Holbæk A/S"
-      ]
+        "Radio Holbæk A/S",
+        "Tv Holbæk A/S"
+        ]
     end
   end