nmax_cli 0.0.0 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e6accd6271507af5f799533ff9534c8347aa63b5c152cb053bafa96ea2f3a5a
-  data.tar.gz: f4a36cdb53679dd8aa7abba00021d7638ed6482625994d4f52cd8a83b37d774c
+  metadata.gz: 65ce5c5fda602899dff55ad51ddbfdad53d52ea39118ca285503f310383f46f0
+  data.tar.gz: 62c142ca5cd4be2aba6b7e61ab86d4bb5b04d89174aa08d88f24e687d49ec6eb
 SHA512:
-  metadata.gz: 7802233ca87d09266126a69043b6954e6d38037d64fac10f2838a4f10c0d617357fe020e7caf5251bae6b69f43a2d943fb28cbaa1d92f3b179b8674f74488770
-  data.tar.gz: 182b2bb39ebe771bee286905268f20a5f1b00e4b97d6c4a6d21d1c3dd4060eb93ebd4f368304485513164f80b6f9f60e825d24649648d48ad144e0ada13891fd
+  metadata.gz: 86e86f33631b217c87747c7731b106e5b7cbdcede5580f897fab6d10cd181dc035bfd18097bf532e5a73ff0afce4fc83fce80523740103b39b5fc2290d8ea4e7
+  data.tar.gz: af6f994a68552c8c225ff3ca9d10d32004783220046de1d469f54656e1a83966cbfe8af9bc1524f1b623696f43107cd40ebb0a4cc50f8359b21b0fc694219ff3

data/.gitignore

@@ -1,2 +1,5 @@
 /test/sample_files
-*.gem
+*.gem
+/coverage
+Gemfile.lock
+.bundle/

data/.travis.yml

@@ -0,0 +1,10 @@
+sudo: false
+dist: trusty
+
+language: ruby
+deploy:
+  provider: rubygems
+  api_key: $RUBYGEMS_API_KEY
+  gem: nmax_cli
+  on: deploy-gem-release
+  skip_cleanup: true

data/Gemfile

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gem 'coveralls', require: false
+gem 'minitest'
+gem 'rake'

data/README.md

@@ -1,7 +1,30 @@
+[![Build Status](https://travis-ci.org/neverovda/nmax.svg?branch=master)](https://travis-ci.org/neverovda/nmax)
+[![Coverage Status](https://coveralls.io/repos/github/neverovda/nmax/badge.svg?branch=master)](https://coveralls.io/github/neverovda/nmax?branch=master)
+
 # nmax
 Output N maximum numbers from input stream
 
-скрипт nmax, делает следующее: 
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem ' nmax_cli'
+```
+
+And then execute:
+
+    $ bundle install
+
+Or install it yourself as:
+
+    $ gem install nmax_cli
+
+## Example
+
+    cat sample_data_40GB.txt | nmax 10000 
+
+## скрипт nmax, делает следующее: 
 * читает из входящего потока текстовые данные
 * по завершении ввода выводит n самых больших целых чисел, встретившихся в полученных текстовых данных
 

data/lib/nmax.rb

@@ -1,51 +1,64 @@
 module Nmax
   class << self
     def run
-      parameter_check
+      warning
       return if wrong_args?
+      return if not_presence_stdin?
+
       @size = ARGV[0].to_i
       @numbers = []
+      strings_processing
 
-      $stdin.each do |line|
-        add_nums_to_result nums(line)
-      end
-      puts '' if @numbers.empty?
-      puts @numbers
+      puts numbers
     end
 
     private
 
-    def parameter_check
+    attr_reader :size
+    attr_accessor :numbers
+
+    def warning
+      warn 'Not reading from stdin' if not_presence_stdin?
       warn 'Nmax must receive one argument (number). Example: nmax 100' if wrong_args?
     end
 
+    def not_presence_stdin?
+      $stdin.tty?
+    end
+
     def wrong_args?
-      ARGV.size != 1 || first_arg_not_number?
+      ARGV.size != 1 || argument_not_number?
     end
 
-    def first_arg_not_number?
+    def argument_not_number?
       !ARGV[0].match?(/^\d+$/)
     end
 
-    def nums(line)
+    def strings_processing
+      $stdin.each { |line| add_nums search_numbers(line) }
+    end
+
+    def search_numbers(line)
       line.scan(/\d+/).map(&:to_i)
     end
 
-    def add_nums_to_result(nums)
+    def add_nums(nums)
       return if nums.empty?
 
-      nums.each { |n| add(n) }
+      nums.each { |n| add_number(n) }
     end
 
-    def add(num)
-      insert_at = @numbers.bsearch_index { |n| num >= n }
-      @numbers.insert(insert_at, num) if insert_at
-      @numbers << num unless insert_at
-      shorten
+    def add_number(num)
+      return if numbers.include?(num)
+
+      insert_at = numbers.bsearch_index { |n| num > n }
+      numbers.insert(insert_at, num) if insert_at
+      numbers << num unless insert_at
+      fix_overflow
     end
 
-    def shorten
-      @numbers.pop if @numbers.size > @size
+    def fix_overflow
+      numbers.pop if numbers.size > size
     end
   end
 end

data/{nmax.gemspec → nmax_cli.gemspec}

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'nmax_cli'
-  s.version     = '0.0.0'
+  s.version     = '0.0.2'
   s.executables << 'nmax'
   s.date        = '2020-09-22'
   s.summary     = 'Nmax - Simple gem for search bigest integers from input stream'

data/test/test_nmax.rb

@@ -1,22 +1,36 @@
+require 'coveralls'
+Coveralls.wear!
+
 require 'minitest/autorun'
 require_relative '../lib/nmax.rb'
 
 module TestNmaxHelper
+  attr_reader :out, :err
   def start(strings, argv)
-    io = StringIO.new
-    strings.each { |str| io.puts str}
-    io.rewind
-    $stdin = io
+    io_associate_with_terminal_device if strings.empty?
+    io_like_input_strings(strings) unless strings.empty?
     ARGV.replace argv
     @out, @err = capture_io do
       Nmax.run
     end
   end
+
+  private
+
+  def io_associate_with_terminal_device
+    $stdin = File.new('/dev/tty')
+  end
+
+  def io_like_input_strings(strings)
+    io = StringIO.new
+    strings.each { |str| io.puts str }
+    io.rewind
+    $stdin = io
+  end
 end
 
 class TestNmax < Minitest::Test
   include TestNmaxHelper
-  attr_reader :out, :err
   def setup
     @strings = ['Lorem ipsum dolor sit amet, consectetur adipiscing elit...']
     @argv = ['1']
@@ -25,7 +39,7 @@ class TestNmax < Minitest::Test
 
   def test_without_numbers
     start(@strings, @argv)
-    assert_equal("\n", out)
+    assert_equal('', out)
   end
 
   def test_with_one_number
@@ -43,6 +57,15 @@ class TestNmax < Minitest::Test
     assert_equal("3000\n2000\n1000\n", out)
   end
 
+  def test_the_same_big_numbers
+    strings = ['L 3000 ipsum 4 consectetur..1000',
+               'Lorem 2 3000dolor am 3',
+               'tetur2000 5 2000 elit']
+    argv = ['3']
+    start(strings, argv)
+    assert_equal("3000\n2000\n1000\n", out)
+  end
+
   def test_arguments_empty
     argv = []
     start(@strings, argv)
@@ -56,8 +79,13 @@ class TestNmax < Minitest::Test
   end
 
   def test_many_arguments
-    argv = ['100', 'arg']
+    argv = %w[100 arg]
     start(@strings, argv)
     assert_equal(@error_out, err)
   end
+
+  def test_stdin
+    start([], @argv)
+    assert_equal("Not reading from stdin\n", err)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nmax_cli
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.0.2
 platform: ruby
 authors:
 - Dmitrii Neverov
@@ -20,11 +20,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
+- Gemfile
 - README.md
 - Rakefile
 - bin/nmax
 - lib/nmax.rb
-- nmax.gemspec
+- nmax_cli.gemspec
 - test/test_nmax.rb
 homepage: https://github.com/neverovda/nmax
 licenses:
@@ -45,7 +47,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Nmax - Simple gem for search bigest integers from input stream