nio4r 2.5.2 → 2.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f22175cceb7b718a2406d97b20a040f6d52890518791c128a5e27d93559ca7e2
-  data.tar.gz: bf20935122a88cc94ff9989558b019c47c43b48c9e47847725f75469767a0518
+  metadata.gz: b2f91e950d2b359914f616398cde41cf003910ee62838e63de394215429083ac
+  data.tar.gz: e68a7d42ad6a361c1e72af4118d1220c23bda526b0517d1888869afd3ee8d1a1
 SHA512:
-  metadata.gz: ffee3fa5a0fdea7460a7f6b754f4c72a0ccba4607e743508f43db88b2d515fc484bc73904652625721218381b873d29bdbb1a8e98dd1150814111cb0a08768d1
-  data.tar.gz: 9126b4ac6087248ad726abeced9dc001c7cbc350f42b562981e3b9c660d55c76b2d73cce15f96cb14873321b2802310dcf348caaa805d4ab69c7b8df28f2e6a4
+  metadata.gz: d2ca4be61b7262f36189846fbbb50f18b96621de525fdad9b997320d58100b1eb7fe7997429025f183408282535dafea5cea05eb523b417a3aa1a883a20e7772
+  data.tar.gz: d603073fe98cdafecac3e380ac5bbf745d8e18066fdc095cb22baa0304768625f89ccdb6ab95bd8d9a8bad0a25fdd93ce9358b958848ac8a4a1b98cae01ed863

data/.github/workflows/workflow.yml

@@ -0,0 +1,43 @@
+name: nio4r
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    name: >-
+      ${{matrix.os}}, ${{matrix.ruby}}
+    env:
+      CI: true
+      TESTOPTS: -v
+
+    runs-on: ${{matrix.os}}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-16.04, ubuntu-18.04, macos-latest, windows-latest]
+        ruby: [2.4, 2.5, 2.6, 2.7, jruby, truffleruby-head]
+        exclude:
+          - { os: windows-latest, ruby: jruby }
+          - { os: windows-latest, ruby: truffleruby-head }
+
+    steps:
+      - name: repo checkout
+        uses: actions/checkout@v2
+
+      - name: load ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{matrix.ruby}}
+
+      - name: RubyGems, Bundler Update
+        run: gem update --system --no-document --conservative
+
+      - name: bundle install
+        run: bundle install --path .bundle/gems --without development
+
+      - name: compile
+        run: bundle exec rake compile
+
+      - name: test
+        run: bundle exec rake spec
+        timeout-minutes: 10

data/.rubocop.yml

@@ -1,23 +1,40 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   DisplayCopNames: true
 
+Layout/HashAlignment:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 128
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
 Layout/SpaceInsideBlockBraces:
   Enabled: false
 
 Style/IfUnlessModifier:
   Enabled: false
 
+Style/UnpackFirst:
+  Enabled: false
+
 #
 # Lint
 #
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Enabled: false
 
 Lint/Loop:
   Enabled: false
 
+Lint/RaiseException:
+  Enabled: false
+
+Lint/StructNewOverride:
+  Enabled: false
 #
 # Metrics
 #
@@ -32,9 +49,6 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 128
 
-Metrics/LineLength:
-  Max: 128
-
 Metrics/MethodLength:
   CountComments: false
   Max: 50
@@ -46,16 +60,12 @@ Metrics/PerceivedComplexity:
   Max: 15
 
 #
-# Performance
+# Style
 #
 
-Performance/RegexpMatch:
+Style/ExponentialNotation:
   Enabled: false
 
-#
-# Style
-#
-
 Style/FormatStringToken:
   Enabled: false
 
@@ -65,6 +75,15 @@ Style/FrozenStringLiteralComment:
 Style/GlobalVars:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
 Style/NumericPredicate:
   Enabled: false
 

data/CHANGES.md

@@ -1,3 +1,19 @@
+## 2.5.3 (2020-09-07)
+
+* [#241](https://github.com/socketry/nio4r/issues/241)
+  Possible bug with Ruby >= 2.7.0 and `GC.compact`.
+  ([@boazsegev])
+
+## 2.5.2 (2019-09-24)
+
+* [#220](https://github.com/socketry/nio4r/issues/220)
+  Update to libev-4.27 & fix assorted warnings.
+  ([@ioquatix])
+
+* [#225](https://github.com/socketry/nio4r/issues/225)
+  Avoid need for linux headers.
+  ([@ioquatix])
+
 ## 2.4.0 (2019-07-07)
 
 * [#211](https://github.com/socketry/nio4r/pull/211)
@@ -9,7 +25,7 @@
 
 * Assorted fixes for TruffleRuby & JRuby.
   ([@eregon], [@olleolleolle])
-
+Possible bug with Ruby >= 2.7.0 and `GC.compact`
 * Update libev to v4.25.
   ([@ioquatix])
 
@@ -242,3 +258,4 @@
 [@ioquatix]: https://github.com/ioquatix
 [@eregon]: https://github.com/eregon
 [@olleolleolle]: https://github.com/olleolleolle
+[@boazsegev]: https://github.com/boazsegev

data/Gemfile

@@ -15,5 +15,5 @@ group :development, :test do
   gem "coveralls", require: false
   gem "rake-compiler", require: false
   gem "rspec", "~> 3.7", require: false
-  gem "rubocop", "0.52.1", require: false
+  gem "rubocop", "0.82.0", require: false
 end

data/README.md

@@ -47,6 +47,7 @@ writing.
 * Ruby 2.4
 * Ruby 2.5
 * Ruby 2.6
+* Ruby 2.7
 * [JRuby](https://github.com/jruby/jruby)
 * [TruffleRuby](https://github.com/oracle/truffleruby)
 

data/examples/echo_server.rb

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-$LOAD_PATH.push File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("../lib", __dir__)
 require "nio"
 require "socket"
 
@@ -19,7 +19,7 @@ class EchoServer
 
   def run
     loop do
-      @selector.select { |monitor| monitor.value.call(monitor) }
+      @selector.select { |monitor| monitor.value.call }
     end
   end
 

data/ext/nio4r/extconf.rb

@@ -4,6 +4,7 @@ require "rubygems"
 
 # Write a dummy Makefile on Windows because we use the pure Ruby implementation there
 if Gem.win_platform?
+  require "devkit" if RUBY_PLATFORM.include?("mingw")
   File.write("Makefile", "all install::\n")
   File.write("nio4r_ext.so", "")
   exit

data/ext/nio4r/monitor.c

@@ -66,6 +66,7 @@ static VALUE NIO_Monitor_allocate(VALUE klass)
 
 static void NIO_Monitor_mark(struct NIO_Monitor *monitor)
 {
+    return rb_gc_mark(monitor->self);
 }
 
 static void NIO_Monitor_free(struct NIO_Monitor *monitor)

data/lib/nio/bytebuffer.rb

@@ -24,6 +24,7 @@ module NIO
     # @return [NIO::ByteBuffer]
     def initialize(capacity)
       raise TypeError, "no implicit conversion of #{capacity.class} to Integer" unless capacity.is_a?(Integer)
+
       @capacity = capacity
       clear
     end
@@ -119,9 +120,11 @@ module NIO
     # @return [self]
     def put(str)
       raise TypeError, "expected String, got #{str.class}" unless str.respond_to?(:to_str)
+
       str = str.to_str
 
       raise OverflowError, "buffer is full" if str.length > @limit - @position
+
       @buffer[@position...str.length] = str
       @position += str.length
       self
@@ -188,6 +191,7 @@ module NIO
     # @raise [NIO::ByteBuffer::MarkUnsetError] mark has not been set (call `#mark` first)
     def reset
       raise MarkUnsetError, "mark has not been set" unless @mark
+
       @position = @mark
       self
     end

data/lib/nio/monitor.rb

@@ -8,7 +8,7 @@ module NIO
 
     # :nodoc:
     def initialize(io, interests, selector)
-      unless io.is_a? OpenSSL::SSL::SSLSocket
+      unless defined?(::OpenSSL) && io.is_a?(::OpenSSL::SSL::SSLSocket)
         unless io.is_a?(IO)
           if IO.respond_to? :try_convert
             io = IO.try_convert(io)

data/lib/nio/selector.rb

@@ -44,7 +44,7 @@ module NIO
     # * :w - is the IO writeable?
     # * :rw - is the IO either readable or writeable?
     def register(io, interest)
-      unless io.is_a? OpenSSL::SSL::SSLSocket
+      unless defined?(::OpenSSL) && io.is_a?(::OpenSSL::SSL::SSLSocket)
         io = IO.try_convert(io)
       end
 

data/lib/nio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NIO
-  VERSION = "2.5.2"
+  VERSION = "2.5.3"
 end

data/nio4r.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path("../lib/nio/version", __FILE__)
+require File.expand_path("lib/nio/version", __dir__)
 
 Gem::Specification.new do |spec|
   spec.authors       = ["Tony Arcieri"]
@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
     "wiki_uri"          => "https://github.com/socketry/nio4r/wiki"
   }
 
-  spec.required_ruby_version = ">= 2.3"
+  spec.required_ruby_version = ">= 2.4"
 
   if defined? JRUBY_VERSION
     spec.files << "lib/nio4r_ext.jar"

data/spec/nio/bytebuffer_spec.rb

@@ -352,4 +352,3 @@ RSpec.describe NIO::ByteBuffer do
     end
   end
 end
-# rubocop:enable Metrics/BlockLength

data/spec/nio/selectables/ssl_socket_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 require "spec_helper"
-require "openssl"
 
 RSpec.describe OpenSSL::SSL::SSLSocket do
+
+  require "openssl"
+
   before(:all) do
     @tls = []
   end

data/spec/nio/selectables/udp_socket_spec.rb

@@ -33,8 +33,8 @@ RSpec.describe UDPSocket, if: !defined?(JRUBY_VERSION) do
       peer.send("X" * 1024, 0)
       cntr += 1
       t = select [], [peer], [], 0
-    rescue Errno::ECONNREFUSED => ex
-      skip "Couldn't make writable UDPSocket subject: #{ex.class}: #{ex}"
+    rescue Errno::ECONNREFUSED => e
+      skip "Couldn't make writable UDPSocket subject: #{e.class}: #{e}"
     end while t && t[1].include?(peer) && cntr < 5
 
     peer

data/spec/nio/selector_spec.rb

@@ -234,4 +234,3 @@ RSpec.describe NIO::Selector do
     expect(subject).to be_closed
   end
 end
-# rubocop:enable Metrics/BlockLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nio4r
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.5.3
 platform: ruby
 authors:
 - Tony Arcieri
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-09-24 00:00:00.000000000 Z
+date: 2020-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -47,16 +47,15 @@ extensions:
 - ext/nio4r/extconf.rb
 extra_rdoc_files: []
 files:
+- ".github/workflows/workflow.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGES.md
 - Gemfile
 - Guardfile
 - README.md
 - Rakefile
-- appveyor.yml
 - examples/echo_server.rb
 - ext/libev/Changes
 - ext/libev/LICENSE
@@ -109,10 +108,10 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/socketry/nio4r/issues
   changelog_uri: https://github.com/socketry/nio4r/blob/master/CHANGES.md
-  documentation_uri: https://www.rubydoc.info/gems/nio4r/2.5.2
-  source_code_uri: https://github.com/socketry/nio4r/tree/v2.5.2
+  documentation_uri: https://www.rubydoc.info/gems/nio4r/2.5.3
+  source_code_uri: https://github.com/socketry/nio4r/tree/v2.5.3
   wiki_uri: https://github.com/socketry/nio4r/wiki
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -120,15 +119,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: New IO for Ruby
 test_files:

data/.travis.yml

@@ -1,44 +0,0 @@
-language: ruby
-cache: bundler
-dist: xenial
-env: OS="xenial 16.04"
-bundler_args: --without development
-
-after_script:
-  - ruby -ropenssl -e "puts ENV['OS'], RUBY_DESCRIPTION, OpenSSL::OPENSSL_LIBRARY_VERSION"
-
-matrix:
-  fast_finish: true
-  include:
-    - rvm: 2.3
-    - rvm: 2.4
-    - rvm: 2.5
-    - rvm: 2.6
-      env: NIO4R_PURE=true
-    - rvm: 2.6
-    - rvm: 2.3
-      dist: trusty
-      env: OS="trusty 14.04"
-    - rvm: 2.6.3
-      dist: bionic
-      env: OS="bionic 18.04"
-    - rvm: 2.6
-      os: osx
-      env: OS="osx"
-    - rvm: 2.4.6
-      os: osx
-      osx_image: xcode10.2
-      env: OS="osx xcode 10.2"
-    - rvm: truffleruby
-    - rvm: truffleruby
-      env: NIO4R_PURE=true
-    - rvm: jruby
-      env: JRUBY_OPTS="--debug -X+O --dev -J-Djruby.launch.inproc=true -J-Xmx1024M"
-    - rvm: jruby-head
-      env: JRUBY_OPTS="--debug -X+O --dev -J-Djruby.launch.inproc=true -J-Xmx1024M"
-    - rvm: ruby-head
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: truffleruby
-    - rvm: jruby-head
-    - rvm: jruby

data/appveyor.yml

@@ -1,40 +0,0 @@
-build: off
-deploy: off
-
-environment:
-  PATH: C:\Ruby%RUBY_VERSION%\bin;%PATH%
-  APPVEYOR_SAVE_CACHE_ON_ERROR: True
-  matrix:
-  - RUBY_VERSION: _trunk
-  - RUBY_VERSION: 26-x64
-  - RUBY_VERSION: 25-x64
-  - RUBY_VERSION: 24-x64
-  - RUBY_VERSION: 23-x64
-  - RUBY_VERSION: 23
-
-init:
-  - ps: |
-      if ($env:RUBY_VERSION -eq '_trunk') {
-        $trunk_uri = 'https://ci.appveyor.com/api/projects/MSP-Greg/ruby-loco/artifacts/ruby_trunk.7z'
-        (New-Object Net.WebClient).DownloadFile($trunk_uri, 'C:\ruby_trunk.7z')
-        7z.exe x C:\ruby_trunk.7z -oC:\Ruby_trunk
-      }
-
-install:
-  - SET RAKEOPT=-rdevkit
-  - gem update --system --conservative --no-document
-  - ruby -v
-  - gem -v
-  - bundle -v
-  - bundle install --path vendor\bundle --without development
-
-test_script:
-  - bundle exec rake spec
-
-matrix:
-  allow_failures:
-    - RUBY_VERSION: _trunk
-
-cache:
-  # If one of the files after the right arrow changes, cache will be invalidated
-  - vendor\bundle -> appveyor.yml, Gemfile, nio4r.gemspec