ninoxe 0.1.2 → 0.1.3

data/README.md

@@ -0,0 +1,4 @@
+# Ninoxe [![Gem Version](https://badge.fury.io/rb/ninoxe.png)](http://badge.fury.io/rb/ninoxe) [![Build Status](https://travis-ci.org/dryade/ninoxe.png)](http://travis-ci.org/dryade/ninoxe?branch=master) [![Dependency Status](https://gemnasium.com/dryade/ninoxe.png)](https://gemnasium.com/dryade/ninoxe) [![Code Climate](https://codeclimate.com/github/dryade/ninoxe.png)](https://codeclimate.com/github/dryade/ninoxe)
+
+This gem rocks and uses MIT-LICENSE.
+

data/app/models/chouette/access_link.rb

@@ -1,6 +1,6 @@
 class Chouette::AccessLink < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   attr_accessor :access_link_type, :link_orientation_type, :link_key
 
@@ -59,5 +59,9 @@ class Chouette::AccessLink < Chouette::TridentActiveRecord
       "S_#{stop_area.id}-A_#{access_point.id}"
     end
   end
+
+  def geometry_presenter
+    Chouette::Geometry::AccessLinkPresenter.new self
+  end
 end
 

data/app/models/chouette/access_point.rb

@@ -3,23 +3,24 @@ require 'geo_ruby'
 
 class Chouette::AccessPoint < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
   include Geokit::Mappable
   has_many :access_links, :dependent => :destroy
   belongs_to :stop_area
   
   attr_accessor :access_point_type
   attr_accessible :objectid, :object_version, :creation_time, :creator_id, :name, :comment
-  attr_accessible :longitude, :latitude, :long_lat_type, :x, :y, :projection_type
+  attr_accessible :longitude, :latitude, :long_lat_type
+  #attr_accessible :x, :y, :projection_type
   attr_accessible :country_code, :street_name
   attr_accessible :openning_time, :closing_time, :access_type, :access_point_type
   attr_accessible :mobility_restricted_suitability, :stairs_availability, :lift_availability
   attr_accessible :stop_area_id
   
   # workaround of ruby 1.8 private method y block attribute y reading access
-  def y
-    read_attribute :y
-  end
+  #def y
+  #  read_attribute :y
+  #end
 
   validates_presence_of :name
   validates_presence_of :access_type
@@ -29,13 +30,13 @@ class Chouette::AccessPoint < Chouette::TridentActiveRecord
   validates_numericality_of :latitude, :less_than_or_equal_to => 90, :greater_than_or_equal_to => -90, :allow_nil => true
   validates_numericality_of :longitude, :less_than_or_equal_to => 180, :greater_than_or_equal_to => -180, :allow_nil => true
 
-  validates_presence_of :x, :if => :y
-  validates_presence_of :y, :if => :x
-  validates_numericality_of :x, :allow_nil => true
-  validates_numericality_of :y, :allow_nil => true
+  #validates_presence_of :x, :if => :y
+  #validates_presence_of :y, :if => :x
+  #validates_numericality_of :x, :allow_nil => true
+  #validates_numericality_of :y, :allow_nil => true
 
   def self.nullable_attributes
-    [:street_name, :country_code, :comment, :projection_type, :long_lat_type, :x, :y]
+    [:street_name, :country_code, :comment, :long_lat_type]
   end
 
   def to_lat_lng
@@ -142,4 +143,7 @@ class Chouette::AccessPoint < Chouette::TridentActiveRecord
      matrix
   end
 
+  def geometry_presenter
+    Chouette::Geometry::AccessPointPresenter.new self
+  end
 end

data/app/models/chouette/connection_link.rb

@@ -1,6 +1,6 @@
 class Chouette::ConnectionLink < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   attr_accessor :connection_link_type
 
@@ -39,5 +39,9 @@ class Chouette::ConnectionLink < Chouette::TridentActiveRecord
     GeoRuby::SimpleFeatures::LineString.from_points( [ departure.geometry, arrival.geometry], 4326) if departure.geometry and arrival.geometry
   end
 
+  def geometry_presenter
+    Chouette::Geometry::ConnectionLinkPresenter.new self
+  end
+
 end
 

data/app/models/chouette/group_of_line.rb

@@ -1,6 +1,6 @@
 class Chouette::GroupOfLine < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
   
   has_and_belongs_to_many :lines, :class_name => 'Chouette::Line', :order => 'lines.name'
 

data/app/models/chouette/journey_pattern.rb

@@ -1,6 +1,6 @@
 class Chouette::JourneyPattern < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   belongs_to :route
   has_many :vehicle_journeys, :dependent => :destroy

data/app/models/chouette/line.rb

@@ -1,6 +1,6 @@
 class Chouette::Line < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   attr_accessor :transport_mode
   attr_accessible :transport_mode, :network_id, :company_id, :objectid, :object_version
@@ -29,6 +29,10 @@ class Chouette::Line < Chouette::TridentActiveRecord
     [:published_name, :number, :comment]
   end
 
+  def geometry_presenter
+    Chouette::Geometry::LinePresenter.new self
+  end
+
   def transport_mode
     # return nil if transport_mode_name is nil
     transport_mode_name && Chouette::TransportMode.new( transport_mode_name.underscore)

data/app/models/chouette/mobility_need.rb

@@ -0,0 +1,4 @@
+class Chouette::MobilityNeed < Chouette::ActiveRecord
+  set_primary_key :id
+  
+end

data/app/models/chouette/network.rb

@@ -1,6 +1,6 @@
 class Chouette::Network < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
   
   has_many :lines
 

data/app/models/chouette/pt_link.rb

@@ -2,7 +2,7 @@ require 'geokit'
 
 class Chouette::PtLink < Chouette::ActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   attr_accessible :start_of_link_id, :end_of_link_id, :route_id, :objectid, :object_version, :creation_time, :creator_id, :name, :comment, :link_distance
   include Geokit::Mappable

data/app/models/chouette/route.rb

@@ -1,6 +1,6 @@
 class Chouette::Route < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   attr_accessor :wayback_code
   attr_accessor :direction_code
@@ -60,6 +60,10 @@ class Chouette::Route < Chouette::TridentActiveRecord
   
   before_destroy :dereference_opposite_route
   
+  def geometry_presenter
+    Chouette::Geometry::RoutePresenter.new self
+  end
+
   def dereference_opposite_route
     self.line.routes.each do |r|
       r.update_attributes( :opposite_route => nil) if r.opposite_route == self

data/app/models/chouette/stop_area.rb

@@ -3,7 +3,7 @@ require 'geo_ruby'
 
 class Chouette::StopArea < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
   include Geokit::Mappable
   has_many :stop_points, :dependent => :destroy
   has_many :access_points, :dependent => :destroy
@@ -18,14 +18,11 @@ class Chouette::StopArea < Chouette::TridentActiveRecord
   
   attr_accessible :routing_stop_ids, :routing_line_ids, :children_ids, :stop_area_type, :parent_id, :objectid
   attr_accessible :object_version, :creation_time, :creator_id, :name, :comment, :area_type, :registration_number
-  attr_accessible :nearest_topic_name, :fare_code, :longitude, :latitude, :long_lat_type, :x, :y, :projection_type
+  attr_accessible :nearest_topic_name, :fare_code, :longitude, :latitude, :long_lat_type
   attr_accessible :country_code, :street_name
-  
-  # workaround of ruby 1.8 private method y block attribute y reading access
-  def y
-    read_attribute :y
-  end
+  attr_accessible :mobility_restricted_suitability, :stairs_availability, :lift_availability, :int_user_needs
 
+  
   validates_uniqueness_of :registration_number, :allow_nil => true, :allow_blank => true
   validates_format_of :registration_number, :with => %r{\A[0-9A-Za-z_-]+\Z}, :allow_blank => true
   validates_presence_of :name
@@ -36,13 +33,8 @@ class Chouette::StopArea < Chouette::TridentActiveRecord
   validates_numericality_of :latitude, :less_than_or_equal_to => 90, :greater_than_or_equal_to => -90, :allow_nil => true
   validates_numericality_of :longitude, :less_than_or_equal_to => 180, :greater_than_or_equal_to => -180, :allow_nil => true
 
-  validates_presence_of :x, :if => :y
-  validates_presence_of :y, :if => :x
-  validates_numericality_of :x, :allow_nil => true
-  validates_numericality_of :y, :allow_nil => true
-
   def self.nullable_attributes
-    [:registration_number, :street_name, :country_code, :fare_code, :nearest_topic_name, :comment, :projection_type, :long_lat_type]
+    [:registration_number, :street_name, :country_code, :fare_code, :nearest_topic_name, :comment, :long_lat_type]
   end
 
   after_update :clean_invalid_access_links
@@ -75,6 +67,10 @@ class Chouette::StopArea < Chouette::TridentActiveRecord
     end
   end
 
+  def geometry_presenter
+    Chouette::Geometry::StopAreaPresenter.new self
+  end
+
   def lines
     if (area_type == 'CommercialStopPoint')
       self.children.collect(&:stop_points).flatten.collect(&:route).flatten.collect(&:line).flatten.uniq
@@ -91,6 +87,18 @@ class Chouette::StopArea < Chouette::TridentActiveRecord
     where :area_type => "CommercialStopPoint"
   end
 
+  def self.stop_place
+    where :area_type => "StopPlace"
+  end
+ 
+  def self.physical
+    where :area_type => [ "BoardingPosition", "Quay" ]
+  end
+
+  def self.itl
+    where :area_type => "ITL"
+  end
+
   def to_lat_lng
     Geokit::LatLng.new(latitude, longitude) if latitude and longitude
   end

data/app/models/chouette/stop_point.rb

@@ -1,6 +1,6 @@
 class Chouette::StopPoint < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   belongs_to :stop_area
   belongs_to :route

data/app/models/chouette/suitability.rb

@@ -0,0 +1,5 @@
+class Chouette::Suitability < Chouette::ActiveRecord
+  set_primary_key :id
+  
+end
+

data/app/models/chouette/time_table.rb

@@ -1,6 +1,6 @@
 class Chouette::TimeTable < Chouette::TridentActiveRecord
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
   
   attr_accessible :objectid, :object_version, :creation_time, :creator_id, :version, :comment
   attr_accessible :int_day_types,:monday,:tuesday,:wednesday,:thursday,:friday,:saturday,:sunday
@@ -60,8 +60,17 @@ class Chouette::TimeTable < Chouette::TridentActiveRecord
     end
   end
 
+  # Return days which intersects with the time table dates and periods
+  def intersects(days)
+    [].tap do |intersect_days|
+      days.each do |day|
+        intersect_days << day if include_day?(day)
+      end
+    end
+  end
+
   def include_day?(day)
-    self.dates.any?{ |d| d.date === day } || self.periods.any?{ |period| period.period_start <= day && day <= period.period_end }
+    include_in_dates?(day) || include_in_periods?(day)
   end
 
   def include_in_dates?(day)

data/app/models/chouette/time_table_date.rb

@@ -1,5 +1,5 @@
 class Chouette::TimeTableDate < Chouette::ActiveRecord
-  set_primary_key :id
+  self.primary_key = "id"
   belongs_to :time_table
   acts_as_list :scope => 'time_table_id = #{time_table_id}',:top_of_list => 0
   

data/app/models/chouette/time_table_period.rb

@@ -1,5 +1,5 @@
 class Chouette::TimeTablePeriod < Chouette::ActiveRecord
-  set_primary_key :id
+  self.primary_key = "id"
   belongs_to :time_table
   acts_as_list :scope => 'time_table_id = #{time_table_id}',:top_of_list => 0
 

data/app/models/chouette/vehicle_journey.rb

@@ -1,7 +1,7 @@
 class Chouette::VehicleJourney < Chouette::TridentActiveRecord
   #
   # FIXME http://jira.codehaus.org/browse/JRUBY-6358
-  set_primary_key :id
+  self.primary_key = "id"
 
   attr_accessor :transport_mode_name
   attr_accessible :route_id, :journey_pattern_id, :time_slot_id, :company_id, :objectid, :object_version, :creation_time, :creator_id, :comment, :status_value

data/app/models/chouette/vehicle_journey_at_stop.rb

@@ -1,5 +1,5 @@
 class Chouette::VehicleJourneyAtStop < Chouette::ActiveRecord
-  set_primary_key :id
+  self.primary_key = "id"
   
   belongs_to :stop_point
   belongs_to :vehicle_journey

data/app/presenters/chouette/geometry/access_link_presenter.rb

@@ -0,0 +1,11 @@
+class Chouette::Geometry::AccessLinkPresenter
+  include Chouette::Geometry::GeneralPresenter
+
+  def initialize(access_link)
+    @access_link = access_link
+  end
+
+  def geometry
+    to_line_string_feature( [ @access_link.stop_area , @access_link.access_point ] )
+  end
+end

data/app/presenters/chouette/geometry/access_point_presenter.rb

@@ -0,0 +1,11 @@
+class Chouette::Geometry::AccessPointPresenter
+  include Chouette::Geometry::GeneralPresenter
+
+  def initialize(access_point)
+    @access_point = access_point
+  end
+
+  def geometry
+    to_point_feature( @access_point)
+  end
+end

data/app/presenters/chouette/geometry/connection_link_presenter.rb

@@ -0,0 +1,11 @@
+class Chouette::Geometry::ConnectionLinkPresenter
+  include Chouette::Geometry::GeneralPresenter
+
+  def initialize(connection_link)
+    @connection_link = connection_link
+  end
+
+  def geometry
+    to_line_string_feature( @connection_link.stop_areas)
+  end
+end

data/app/presenters/chouette/geometry/general_presenter.rb

@@ -0,0 +1,20 @@
+module Chouette::Geometry::GeneralPresenter
+
+  def to_line_string_feature( stop_areas)
+    points = stop_areas.collect(&:geometry).compact
+    GeoRuby::SimpleFeatures::LineString.from_points(points)
+  end
+
+  def to_multi_point_feature( stop_areas)
+    points = stop_areas.collect(&:geometry).compact
+    GeoRuby::SimpleFeatures::MultiPoint.from_points( points )
+  end
+
+  def to_point_feature( stop_area)
+    return nil unless stop_area.longitude && stop_area.latitude
+    GeoRuby::SimpleFeatures::Point.from_lon_lat( stop_area.longitude, stop_area.latitude, 4326)
+  end
+
+end
+
+

data/app/presenters/chouette/geometry/line_presenter.rb

@@ -0,0 +1,42 @@
+class Chouette::Geometry::LinePresenter
+  include Chouette::Geometry::GeneralPresenter
+
+  def initialize(line)
+    @line = line
+  end
+
+  # return line geometry based on CommercialStopPoint
+  #
+  def geometry
+    features = commercial_links.map { |link| to_line_string_feature(link) }
+    GeoRuby::SimpleFeatures::MultiLineString.from_line_strings( features, 4326)
+  end
+  #
+  # return line's stop_areas cloud geometry
+  #
+  def stop_areas_geometry
+    to_multi_point_feature( @line.commercial_stop_areas)
+  end
+
+  def commercial_links
+    link_keys = []
+    [].tap do |stop_area_links|
+      @line.routes.each do |route|
+        previous_commercial = nil
+        routes_localized_commercials(route).each do |commercial|
+          if previous_commercial && !link_keys.include?( "#{previous_commercial.id}-#{commercial.id}")
+            stop_area_links << [ previous_commercial, commercial]
+            link_keys << "#{previous_commercial.id}-#{commercial.id}"
+            link_keys << "#{commercial.id}-#{previous_commercial.id}"
+          end
+          previous_commercial = commercial
+        end
+      end
+    end
+  end
+
+  def routes_localized_commercials(route)
+    route.stop_areas.map { |sa| sa.parent}.compact.select { |sa| sa.latitude && sa.longitude}
+  end
+
+end

data/app/presenters/chouette/geometry/route_presenter.rb

@@ -0,0 +1,22 @@
+class Chouette::Geometry::RoutePresenter
+  include Chouette::Geometry::GeneralPresenter
+
+  def initialize(route)
+    @route = route
+  end
+
+  # return route's stop_areas cloud geometry
+  #
+  def stop_areas_geometry
+    to_multi_point_feature( @route.stop_areas.with_geometry )
+  end
+
+  # return route geometry based on BoardingPosition or Quay
+  #
+  def geometry
+    to_line_string_feature( @route.stop_areas.with_geometry )
+  end
+
+
+end
+

data/app/presenters/chouette/geometry/stop_area_presenter.rb

@@ -0,0 +1,13 @@
+class Chouette::Geometry::StopAreaPresenter
+  include Chouette::Geometry::GeneralPresenter
+
+  def initialize(stop_area)
+    @stop_area = stop_area
+  end
+
+  # return line geometry based on CommercialStopPoint
+  #
+  def geometry
+    to_point_feature( @stop_area)
+  end
+end

data/db/migrate/20130628124932_remove_projection_from_stop_areas.rb

@@ -0,0 +1,19 @@
+class RemoveProjectionFromStopAreas < ActiveRecord::Migration
+  def up
+    if column_exists? :stop_areas, :x
+      remove_column :stop_areas, :x
+    end
+    if column_exists? :stop_areas, :y
+      remove_column :stop_areas, :y
+    end
+    if column_exists? :stop_areas, :projection_type
+      remove_column :stop_areas, :projection_type
+    end
+  end
+
+  def down
+    add_column :stop_areas, :x, :decimal,:precision => 19, :scale => 2
+    add_column :stop_areas, :y, :decimal,:precision => 19, :scale => 2
+    add_column :stop_areas, :projection_type, :string
+  end
+end

data/db/migrate/20130628124951_remove_projection_from_access_points.rb

@@ -0,0 +1,19 @@
+class RemoveProjectionFromAccessPoints < ActiveRecord::Migration
+  def up
+    if column_exists? :access_points, :x
+      remove_column :access_points, :x
+    end
+    if column_exists? :access_points, :y
+      remove_column :access_points, :y
+    end
+    if column_exists? :access_points, :projection_type
+      remove_column :access_points, :projection_type
+    end
+  end
+
+  def down
+    add_column :access_points, :x, :decimal,:precision => 19, :scale => 2
+    add_column :access_points, :y, :decimal,:precision => 19, :scale => 2
+    add_column :access_points, :projection_type, :string
+  end
+end

data/db/migrate/20130708081951_add_accessibility_to_stop_areas.rb

@@ -0,0 +1,30 @@
+class AddAccessibilityToStopAreas < ActiveRecord::Migration
+  def up
+    unless column_exists? :stop_areas, :mobility_restricted_suitability
+      add_column :stop_areas, :mobility_restricted_suitability, :boolean
+    end
+    unless column_exists? :stop_areas, :stairs_availability
+      add_column :stop_areas, :stairs_availability, :boolean
+    end
+    unless column_exists? :stop_areas, :lift_availability
+      add_column :stop_areas, :lift_availability, :boolean
+    end
+    unless column_exists? :stop_areas, :int_user_needs
+      add_column :stop_areas, :int_user_needs, :integer
+    end
+  end
+  def down
+    if column_exists? :stop_areas, :mobility_restricted_suitability
+      remove_column :stop_areas, :mobility_restricted_suitability
+    end
+    if column_exists? :stop_areas, :stairs_availability
+      remove_column :stop_areas, :stairs_availability
+    end
+    if column_exists? :stop_areas, :lift_availability
+      remove_column :stop_areas, :lift_availability
+    end
+    if column_exists? :stop_areas, :int_user_needs
+      remove_column :stop_areas, :int_user_needs
+    end
+  end
+end

data/db/migrate/20130710122648_set_accessibiliity_to_existing_stop_area.rb

@@ -0,0 +1,16 @@
+class SetAccessibiliityToExistingStopArea < ActiveRecord::Migration
+  def up
+    Chouette::StopArea.all.each do |s|
+      if s.mobility_restricted_suitability.nil?
+        s.mobility_restricted_suitability = false
+        s.stairs_availability = false
+        s.lift_availability = false
+        s.int_user_needs = 0
+        s.save
+      end
+    end
+  end
+
+  def down
+  end
+end

data/lib/factories/chouette_lines.rb

@@ -18,3 +18,14 @@ Factory.define :line_with_stop_areas, :parent => :line do |line|
     end   
   end
 end
+
+Factory.define :line_with_stop_areas_having_parent, :parent => :line do |line|
+  line.after_build do |line|
+    route = Factory(:route, :line => line)
+    route.stop_points.each do |stop_point|
+      commercial = Factory(:stop_area, :area_type => "CommercialStopPoint")
+      physical = Factory(:stop_area, :area_type => "Quay", :parent_id => commercial.id)
+      stop_point.update_attributes( :stop_area_id => physical.id)
+    end
+  end
+end

data/lib/ninoxe/version.rb

@@ -1,3 +1,3 @@
 module Ninoxe
-  VERSION = "0.1.2" 
+  VERSION = "0.1.3" 
 end

data/spec/models/chouette/access_point_spec.rb

@@ -7,35 +7,6 @@ describe Chouette::AccessPoint do
   it { should validate_presence_of :name }
   it { should validate_numericality_of :latitude }
   it { should validate_numericality_of :longitude }
-  it { should validate_numericality_of :x }
-  it { should validate_numericality_of :y }
-
-  describe ".x_y" do
-    it "should accept x and y both as nil" do
-      subject = Factory :access_point
-      subject.x = nil
-      subject.y = nil
-      subject.valid?.should be_true
-    end
-    it "should accept x and y both numerical" do
-      subject = Factory :access_point
-      subject.x = 10
-      subject.y = 10
-      subject.valid?.should be_true
-    end
-    it "should reject x nil with y numerical" do
-      subject = Factory :access_point
-      subject.x = nil
-      subject.y = 10
-      subject.valid?.should be_false
-    end
-    it "should reject x numerical with y nil" do
-      subject = Factory :access_point
-      subject.x = 10
-      subject.y = nil
-      subject.valid?.should be_false
-    end
-  end 
   
   describe ".latitude" do
     it "should accept -90 value" do

data/spec/models/chouette/stop_area_spec.rb

@@ -13,35 +13,7 @@ describe Chouette::StopArea do
   it { should validate_presence_of :area_type }
   it { should validate_numericality_of :latitude }
   it { should validate_numericality_of :longitude }
-  it { should validate_numericality_of :x }
-  it { should validate_numericality_of :y }
 
-  describe ".x_y" do
-    it "should accept x and y both as nil" do
-      subject = Factory :stop_area, :area_type => "BoardingPosition"
-      subject.x = nil
-      subject.y = nil
-      subject.valid?.should be_true
-    end
-    it "should accept x and y both numerical" do
-      subject = Factory :stop_area, :area_type => "BoardingPosition"
-      subject.x = 10
-      subject.y = 10
-      subject.valid?.should be_true
-    end
-    it "should reject x nil with y numerical" do
-      subject = Factory :stop_area, :area_type => "BoardingPosition"
-      subject.x = nil
-      subject.y = 10
-      subject.valid?.should be_false
-    end
-    it "should reject x numerical with y nil" do
-      subject = Factory :stop_area, :area_type => "BoardingPosition"
-      subject.x = 10
-      subject.y = nil
-      subject.valid?.should be_false
-    end
-  end 
   
   describe ".latitude" do
     it "should accept -90 value" do