ninja_van_api 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 498b64c23b4c90326050957887a23552deda6444bdf1ee6b779015d007a7da3a
-  data.tar.gz: 831f91cba7c2368c42ac03325df4d2eadf602c3b23286a62180a3d89e34286bc
+  metadata.gz: 8e52db5dc47fb26dc3db9e5bc25fd170d377240a3d79dae39f02069bfb0de840
+  data.tar.gz: a277b4cee9e41a804617d3341455400cd9c4548e66a8ae113e7c9c3b74135e06
 SHA512:
-  metadata.gz: a8017469ab59a08951a908bf9f7a89b7da7d558351d785e4cc3714aa5b82f7f05402355a56f3666066659c69494f2f2f2a643f22218879206cdf5608e971fa2e
-  data.tar.gz: 4388e9cfba5ec46a464e283a61fb007aa4560613a40f6fda3bc65980038004238c33e234975b4097d4ab1db3e6fa036d515d9e1a939868a0b0d18a4d220bf6aa
+  metadata.gz: a4c035d321e2d0715492b790f6d9f595db4a9cae1ecad05f62f12d24c03f7cc7858ec4394b472e842ecd05a6d19e38b406b516caad2f8df3c524bceeb5db1336
+  data.tar.gz: e6615160d71b61dc4a7354c5b55af8b0ccc51ab574f5d24282f67e21103765c439829d7e80c56baa85a9a0e0db13b8abf7cd0189875b0b28cbe8a94933dc877e

data/app/controllers/ninja_van_api/webhook_controller.rb

@@ -21,17 +21,17 @@ module NinjaVanAPI
     def verify_webhook_signature
       # Extract country code from the request path
       # Example: /ninjavan/sg/webhooks -> 'sg'
-      country_code = request.path.split('/')[2]&.downcase
+      country_code = request.path.split("/")[2]&.downcase
       return head :unauthorized unless country_code.present?
 
       webhook_secret = NinjaVanAPI.configuration.get_webhook_secret(country_code)
       return head :unauthorized unless webhook_secret
 
-      signature = request.headers['X-Ninjavan-Hmac-Sha256']
+      signature = request.headers["X-Ninjavan-Hmac-Sha256"]
       return head :unauthorized unless signature.present?
 
       payload = request.raw_post
-      hash = OpenSSL::HMAC.digest('sha256', webhook_secret, payload)
+      hash = OpenSSL::HMAC.digest("sha256", webhook_secret, payload)
       expected_signature = Base64.encode64(hash).strip
 
       return head :unauthorized unless Rack::Utils.secure_compare(signature, expected_signature)

data/lib/ninja_van_api/client.rb

@@ -30,8 +30,7 @@ module NinjaVanAPI
           # access_token will be evaluated on each request using proc
           conn.request :authorization, :Bearer, -> { access_token }
           conn.request :json
-          conn.response :json
-          conn.response :raise_error # Raises error on 4xx and 5xx responses
+          conn.response :json, content_type: "application/json"
         end
     end
 

data/lib/ninja_van_api/resources/base_resource.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'active_support'
-require 'active_support/core_ext/string'
+require "active_support"
+require "active_support/core_ext/string"
 
 module NinjaVanAPI
   class BaseResource
@@ -16,18 +16,21 @@ module NinjaVanAPI
     end
 
     def post_request(url, body:, headers: {})
-      handle_response client.connection.post(url, parse_body(body), headers)
+      handle_response client.connection.post(url, body, headers)
     end
 
     def put_request(url, body:, headers: {})
-      handle_response client.connection.put(url, parse_body(body), headers)
+      handle_response client.connection.put(url, body, headers)
     end
 
     def delete_request(url, body: {}, headers: {})
-      response = client.connection.delete(url) do |request|
-        request.body = parse_body(body)
-        request.headers = request.headers.merge(headers)
-      end
+      response =
+        client
+          .connection
+          .delete(url) do |request|
+            request.body = body
+            request.headers = request.headers.merge(headers)
+          end
 
       handle_response response
     end
@@ -66,27 +69,16 @@ module NinjaVanAPI
     end
 
     def retry_request(env, retry_count)
-      request = client.connection.build_request(env.method.downcase) do |req|
-        req.url env.url.to_s
-        req.body = env.request_body
-        req.headers = env.request_headers
-      end
+      request =
+        client
+          .connection
+          .build_request(env.method.downcase) do |req|
+            req.url env.url.to_s
+            req.body = env.request_body
+            req.headers = env.request_headers
+          end
 
       handle_response(request.run, retry_count)
     end
-
-    def parse_body(params)
-      if params.is_a?(Array)
-        params.map { |value| parse_body(value) }
-      elsif params.is_a?(Hash)
-        params.deep_transform_keys { |key| key.to_s.underscore }
-      else
-        params
-      end
-    end
-
-    def parse_response(response)
-      response.body.deep_transform_keys { |key| key.to_s.underscore }
-    end
   end
 end

data/lib/ninja_van_api/resources/order_resource.rb

@@ -3,13 +3,13 @@
 module NinjaVanAPI
   class OrderResource < BaseResource
     def create(params = {})
-      response = post_request('/4.2/orders', body: params)
-      Order.new(parse_response(response))
+      response = post_request("/4.2/orders", body: params)
+      Order.new(response.body)
     end
 
     def cancel(tracking_number)
       response = delete_request("/2.2/orders/#{tracking_number}")
-      Order.new(parse_response(response))
+      Order.new(response.body)
     end
   end
 end

data/lib/ninja_van_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NinjaVanAPI
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/ninja_van_api.rb

@@ -1,19 +1,19 @@
 # frozen_string_literal: true
 
-require_relative 'ninja_van_api/version'
+require_relative "ninja_van_api/version"
 
 module NinjaVanAPI
   # Objects
-  autoload :Base, 'ninja_van_api/objects/base'
-  autoload :Order, 'ninja_van_api/objects/order'
+  autoload :Base, "ninja_van_api/objects/base"
+  autoload :Order, "ninja_van_api/objects/order"
 
   # Resources
-  autoload :BaseResource, 'ninja_van_api/resources/base_resource'
-  autoload :OrderResource, 'ninja_van_api/resources/order_resource'
+  autoload :BaseResource, "ninja_van_api/resources/base_resource"
+  autoload :OrderResource, "ninja_van_api/resources/order_resource"
 
   # Core components
-  autoload :Client, 'ninja_van_api/client'
-  autoload :Error, 'ninja_van_api/error'
-  autoload :UnsupportedCountryCodeError, 'ninja_van_api/error'
-  autoload :AuthenticationError, 'ninja_van_api/error'
+  autoload :Client, "ninja_van_api/client"
+  autoload :Error, "ninja_van_api/error"
+  autoload :UnsupportedCountryCodeError, "ninja_van_api/error"
+  autoload :AuthenticationError, "ninja_van_api/error"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ninja_van_api
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jane Trang Mai Nguyen
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email:
 - jane.trangm@gmail.com
@@ -127,7 +141,6 @@ files:
 - lib/ninja_van_api.rb
 - lib/ninja_van_api/client.rb
 - lib/ninja_van_api/configuration.rb
-- lib/ninja_van_api/engine.rb
 - lib/ninja_van_api/error.rb
 - lib/ninja_van_api/objects/base.rb
 - lib/ninja_van_api/objects/order.rb

data/lib/ninja_van_api/engine.rb

@@ -1,14 +0,0 @@
-require 'rails/engine'
-
-module NinjaVanAPI
-  class Engine < ::Rails::Engine
-    isolate_namespace NinjaVanAPI
-
-
-    config.generators do |g|
-      g.test_framework :rspec
-      g.assets false
-      g.helper false
-    end
-  end
-end