ninja-model 0.4.2 → 0.5.1

data/spec/ninja_model/predicate_spec.rb

@@ -1,13 +1,47 @@
 require 'spec_helper'
 
 describe NinjaModel::Predicate do
-  before(:each) do
-    @pred = NinjaModel::Predicate.new(:var, :ge)
+  before { @pred = NinjaModel::Predicate.new(:var, :ge) }
+  subject { @pred }
+  it { should respond_to(:value=) }
+  its(:has_value?) { should be_false }
+  its(:attribute) { should eql(:var) }
+  its(:meth) { should eql(:ge) }
+
+  it 'should have a value after update' do
+    subject.value = 'valued'
+    subject.has_value?.should be_true
   end
 
-  it { @pred.has_value?.should be_false }
-  it 'should have value after update' do
-    @pred.value = 'value'
-    @pred.has_value?.should be_true
+  describe 'test' do
+    context 'with a @value of 1' do
+      def expectations
+        { :eq => false, :ne => true, :gt => true, :gte => true, :lt => false, :lte => false }
+      end
+      NinjaModel::Predicate::PREDICATES.each do |p|
+        if p.eql?(:in)
+          subject { NinjaModel::Predicate.new(:var, :in, 1) }
+          describe ':in 2' do
+            specify { lambda { subject.test(2) }.should raise_error }
+          end
+        else
+          describe ":#{p} 2" do
+            specify { NinjaModel::Predicate.new(:var, p, 1).test(2).should eql(expectations[p]) }
+          end
+        end
+      end
+    end
   end
 end
+
+#describe NinjaModel::Predicate do
+#  before(:each) do
+#    @pred = NinjaModel::Predicate.new(:var, :ge)
+#  end
+#
+#  it { @pred.has_value?.should be_false }
+#  it 'should have value after update' do
+#    @pred.value = 'value'
+#    @pred.has_value?.should be_true
+#  end
+#end

data/spec/ninja_model/query_methods_spec.rb

@@ -1,76 +1,78 @@
 require 'spec_helper'
 
-describe NinjaModel::QueryMethods do
-  before(:each) do
-    @model = mock('model')
-    @attribute = NinjaModel::Attribute.new(:valid, :integer, @model, {})
-    @model.stubs(:model_attributes).returns({:valid => @attribute}.with_indifferent_access)
-    @rel = NinjaModel::Relation.new(@model)
-  end
-
-  describe 'order' do
-    it 'should update the relations\'s order_values' do
-      new_rel = @rel.order(:new_order)
-      new_rel.ordering.first.should eql(:new_order)
-    end
-  end
-
-  describe 'where' do
-    it 'should update the relation\'s where_values' do
-      new_rel = @rel.where(:valid => 2)
-      new_rel.predicates.first.should be_kind_of(NinjaModel::Predicate)
-      new_rel.predicates.first.value.should eql(2)
-    end
-  end
-
-  describe 'limit' do
-    it 'should update the relation\'s limit' do
-      new_rel = @rel.limit(5)
-      new_rel.limit_value.should eql(5)
-    end
-  end
-
-  describe 'build_predicates' do
-    it 'should reject a string' do
-      lambda { @rel.send :build_predicates, 'foo < 1' }.should raise_error(ArgumentError)
-    end
-
-    describe 'with an array' do
-      it 'should return an array of NinjaModel::Predicates' do
-        res = @rel.send :build_predicates, [{:valid => 1}]
-        res.should be_kind_of(Array)
-        res.first.should be_kind_of(NinjaModel::Predicate)
-        res.first.value.should eql(1)
-      end
-    end
-    describe 'with a hash' do
-      it 'should handle a valid symbol' do
-        res = @rel.send :build_predicates, {:valid => 1}
-        res.should be_kind_of(Array)
-        res.first.should be_kind_of(NinjaModel::Predicate)
-        res.first.value.should eql(1)
-      end
-
-      it 'should reject an invalid symbol' do
-        lambda { @rel.send :build_predicates, {:invalid => 2} }.should raise_error(ArgumentError)
-      end
-
-      it 'should handle a predicate' do
-        rel = NinjaModel::Predicate.new(:valid, :eq)
-        res = @rel.send :build_predicates, {rel => 1}
-        res.should be_kind_of(Array)
-        res.first.should be_kind_of(NinjaModel::Predicate)
-        res.first.value.should eql(1)
-      end
-      it 'should reject an unkrecognized key' do
-        lambda { @rel.send :build_predicates, {'bad' => 12} }.should raise_error(ArgumentError)
-      end
-    end
-
-    it 'should reject an unprocessable argument' do
-      lambda { @rel.send :build_predicates, 5 }.should raise_error(ArgumentError)
-    end
-
-  end
-
-end
+#describe NinjaModel::QueryMethods do
+#  class FakeModel < NinjaModel::Base
+#    attribute :valid, :integer, 1
+#  end
+#
+#  before(:each) do
+#    @model = FakeModel
+#    @rel = NinjaModel::Relation.new(@model)
+#  end
+#
+#  describe 'order' do
+#    it 'should update the relations\'s order_values' do
+#      new_rel = @rel.order(:new_order)
+#      new_rel.ordering.first.should eql(:new_order)
+#    end
+#  end
+#
+#  describe 'where' do
+#    it 'should update the relation\'s where_values' do
+#      new_rel = @rel.where(:valid => 2)
+#      new_rel.predicates.first.should be_kind_of(NinjaModel::Predicate)
+#      new_rel.predicates.first.value.should eql(2)
+#    end
+#  end
+#
+#  describe 'limit' do
+#    it 'should update the relation\'s limit' do
+#      new_rel = @rel.limit(5)
+#      new_rel.limit_value.should eql(5)
+#    end
+#  end
+#
+#  describe 'build_predicates' do
+#    it 'should reject a string' do
+#      lambda { @rel.send :build_predicates, 'foo < 1' }.should raise_error(ArgumentError)
+#    end
+#
+#    describe 'with an array' do
+#      it 'should return an array of NinjaModel::Predicates' do
+#        res = @rel.send :build_predicates, [{:valid => 1}]
+#        res.should be_kind_of(Array)
+#        res.first.should be_kind_of(NinjaModel::Predicate)
+#        res.first.value.should eql(1)
+#      end
+#    end
+#    describe 'with a hash' do
+#      it 'should handle a valid symbol' do
+#        res = @rel.send :build_predicates, {:valid => 1}
+#        res.should be_kind_of(Array)
+#        res.first.should be_kind_of(NinjaModel::Predicate)
+#        res.first.value.should eql(1)
+#      end
+#
+#      it 'should reject an invalid symbol' do
+#        lambda { @rel.send :build_predicates, {:invalid => 2} }.should raise_error(ArgumentError)
+#      end
+#
+#      it 'should handle a predicate' do
+#        rel = NinjaModel::Predicate.new(:valid, :eq)
+#        res = @rel.send :build_predicates, {rel => 1}
+#        res.should be_kind_of(Array)
+#        res.first.should be_kind_of(NinjaModel::Predicate)
+#        res.first.value.should eql(1)
+#      end
+#      it 'should reject an unkrecognized key' do
+#        lambda { @rel.send :build_predicates, {'bad' => 12} }.should raise_error(ArgumentError)
+#      end
+#    end
+#
+#    it 'should reject an unprocessable argument' do
+#      lambda { @rel.send :build_predicates, 5 }.should raise_error(ArgumentError)
+#    end
+#
+#  end
+#
+#end

data/spec/ninja_model/reflection_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+describe NinjaModel::Reflection do
+  class BareModel
+  end
+  class ReflectionModel < NinjaModel::Base
+    attribute :test, :string
+  end
+  class TargetModel < NinjaModel::Base
+    attribute :test2, :string
+  end
+
+  subject { ReflectionModel }
+  it { should respond_to(:create_reflection) }
+
+  describe 'ninja_model?' do
+    specify { NinjaModel::Base.ninja_model?(:has_one, :bare_model).should be_false }
+    specify { NinjaModel::Base.ninja_model?(:has_one, :reflection_model).should be_true }
+  end
+
+  describe 'create_reflection' do
+    it 'should store the reflections on the class' do
+      @klass = Class.new(NinjaModel::Base)
+      @reflection = @klass.create_reflection(:has_one, :target_model, {}, @klass)
+      @klass.reflections.should eql(:target_model => @reflection)
+    end
+
+    it 'should return a reflection for a particular association' do
+      @klass = Class.new(NinjaModel::Base)
+      @reflection = @klass.create_reflection(:has_one, :target_model, {}, @klass)
+      @klass.reflect_on_association(:target_model).should eql(@reflection)
+    end
+
+    context 'has_one' do
+      subject { ReflectionModel.create_reflection(:has_one, :target_model, {}, ReflectionModel) }
+      its(:class_name) { should eql('TargetModel') }
+      its(:klass) { should eql(TargetModel) }
+      its(:collection?) { should be_false }
+      its(:primary_key_name) { should eql('reflection_model_id') }
+      its(:association_foreign_key) { should eql('target_model_id') }
+      its(:belongs_to?) { should be_false }
+    end
+
+    context 'has_many' do
+      subject { ReflectionModel.create_reflection(:has_many, :target_models, {}, ReflectionModel) }
+      its(:class_name) { should eql('TargetModel') }
+      its(:klass) { should eql(TargetModel) }
+      its(:collection?) { should be_true }
+      its(:primary_key_name) { should eql('reflection_model_id') }
+      its(:association_foreign_key) { should eql('target_model_id') }
+      its(:belongs_to?) { should be_false }
+    end
+
+    context 'belongs_to' do
+      subject { TargetModel.create_reflection(:belongs_to, :reflection_model, {}, TargetModel) }
+      its(:class_name) { should eql('ReflectionModel') }
+      its(:klass) { should eql(ReflectionModel) }
+      its(:collection?) { should be_false }
+      its(:primary_key_name) { should eql('reflection_model_id') }
+      its(:association_foreign_key) { should eql('reflection_model_id') }
+      its(:belongs_to?) { should be_true }
+    end
+  end
+end

data/spec/ninja_model/relation_spec.rb

@@ -1,26 +1,219 @@
 require 'spec_helper'
 
 describe NinjaModel::Relation do
-  describe 'with an instance' do
-    before(:each) do
-      @model = mock('NinjaModel')
-      @model.stubs(:adapter => stub('NinjaAdapter', :read => 'object_list'))
-      @rel = NinjaModel::Relation.new(@model)
-    end
-    it { @rel.should respond_to(:klass) }
-    it { @rel.should respond_to(:loaded?) }
-    it { @rel.should respond_to(:limit_value) }
-    it { @rel.limit_value.should be_nil }
-    it { @rel.should respond_to(:offset_value) }
-    it { @rel.offset_value.should be_nil }
-    it { @rel.should respond_to(:ordering) }
-    it { @rel.ordering.should eql([]) }
-    it { @rel.should respond_to(:predicates) }
-    it { @rel.predicates.should eql([]) }
-    it { @rel.loaded?.should be_false }
-
-    it 'should try to read when to_a is called' do
-      @rel.to_a.should eql('object_list')
+  class RelationModel < NinjaModel::Base
+    attribute :id, :integer, :primary_key => true
+    attribute :attr1, :integer
+    attribute :attr2, :string
+
+    scope :foo, where(:attr2 => 'foo')
+  end
+
+  before {
+    @rel = NinjaModel::Relation.new(RelationModel)
+    @adapter = mock('Adapter')
+    @adapter.stubs(:read).returns(['foo'])
+    RelationModel.stubs(:adapter).returns(@adapter)
+  }
+  subject { @rel }
+  it { should respond_to(:to_a) }
+  it { should respond_to(:scoping) }
+  it { should respond_to(:size) }
+  it { should respond_to(:blank?) }
+  it { should respond_to(:empty?) }
+  it { should respond_to(:order) }
+  it { should respond_to(:where) }
+  it { should respond_to(:limit) }
+  its(:loaded?) { should be_false }
+  its(:limit_value) { should be_nil }
+  its(:offset_value) { should be_nil }
+  its(:ordering) { should be_blank }
+  its(:predicates) { should be_blank }
+  its(:inspect) { should eql(['foo'].inspect) }
+
+  it 'should respond to array methods' do
+    subject.expects(:to_a).returns([])
+    subject.flatten
+  end
+
+  it 'should respond to scopes' do
+    subject.expects(:merge)
+    subject.foo
+  end
+
+  it 'should raise NoMethodError for a true invalid method' do
+    lambda { subject.blarg }.should raise_error(NoMethodError)
+  end
+
+  describe 'first' do
+    context 'with no arguments' do
+      it 'should call find_first' do
+        @rel.expects(:find_first)
+        @rel.first
+      end
+    end
+    context 'with find arguments' do
+      it 'should update the relation and return the first record' do
+        @rel.expects(:apply_finder_options).with(:arg1 => 1).returns(@rel)
+        @rel.first(:arg1 => 1)
+      end
+    end
+  end
+
+  describe 'all' do
+    context 'with no arguments' do
+      it 'should call to_a' do
+        @rel.expects(:to_a)
+        @rel.all
+      end
+      context 'when chained to a find_first' do
+        it 'should reuse the cached records' do
+          @rel.all
+          @rel.expects(:to_a).never
+          @rel.find(:first)
+        end
+      end
+    end
+
+    context 'with arguments' do
+      it 'should update the relation and call to_a' do
+        @rel.expects(:apply_finder_options).with(:arg1 => 1)
+        @rel.all(:arg1 => 1)
+      end
+    end
+  end
+
+  describe 'find' do
+    context 'with no args' do
+      it 'should raise RecordNotFound' do
+        lambda { subject.find }.should raise_error(NinjaModel::RecordNotFound)
+      end
+    end
+    context 'with an id arg' do
+      it 'should call find_one' do
+        subject.expects(:find_one).with(1)
+        subject.find(1)
+      end
+      it 'add the primary key to the relation' do
+        subject.expects(:where).with(:id => 1).returns(subject)
+        subject.find(1)
+      end
+    end
+    context 'with :all as the arg' do
+      it 'should call :all' do
+        subject.expects(:all)
+        subject.find(:all)
+      end
+    end
+    context 'with an array of ids' do
+      it 'should raise NotImplementedError' do
+        lambda { subject.find([1, 2, 3]) }.should raise_error(NotImplementedError)
+      end
+    end
+    context 'with query arguments' do
+      it 'should update the relation' do
+        subject.expects(:apply_finder_options).with(:arg1 => 2).returns(@rel)
+        subject.find(:first, :arg1 => 2)
+      end
+    end
+  end
+
+  describe 'exists?' do
+    it 'should add the where predicate for the id' do
+      @rel.expects(:where).with(:id => 3).returns(@rel)
+      @rel.exists?(3)
+    end
+  end
+
+  describe 'order' do
+    it 'should update the ordering' do
+      @rel2 = @rel.order(:attr1 => :desc).order(:attr2 => :asc)
+      @rel2.ordering.should eql([{:attr1 => :desc}, {:attr2 => :asc}])
+    end
+  end
+
+  describe 'where' do
+    it 'should merge the predicates' do
+      @rel2 = @rel.where(:attr1 => 1).where(:attr2 => 'foo')
+      @rel2.predicates.length.should eql(2)
+    end
+    it 'should accept a hash' do
+      @rel2 = @rel.where(:attr1 => 1)
+      @pred = @rel2.predicates.first
+      @pred.attribute.should eql(:attr1)
+      @pred.meth.should eql(:eq)
+      @pred.value.should eql(1)
+    end
+    it 'should accept an array' do
+      @rel2 = @rel.where([{:attr1 => 1}, {:attr2 => 'foo'}])
+      @pred = @rel2.predicates.first
+      @pred.attribute.should eql(:attr1)
+      @pred.meth.should eql(:eq)
+      @pred.value.should eql(1)
+      @pred = @rel2.predicates.last
+      @pred.attribute.should eql(:attr2)
+      @pred.meth.should eql(:eq)
+      @pred.value.should eql('foo')
+    end
+    it 'should accept a Predicate' do
+      @pred = NinjaModel::Predicate.new(:attr1, :ne, 3)
+      @rel2 = @rel.where(@pred)
+      @rel2.predicates.first.attribute.should eql(:attr1)
+      @rel2.predicates.first.meth.should eql(:ne)
+      @rel2.predicates.first.value.should eql(3)
+    end
+    it 'should accept a predicate symbol' do
+      @rel2 = @rel.where(:attr1.gt => 2)
+      @rel2.predicates.first.attribute.should eql(:attr1)
+      @rel2.predicates.first.meth.should eql(:gt)
+      @rel2.predicates.first.value.should eql(2)
+    end
+    it 'should raise an exception for an invalid attribute' do
+      lambda { @rel.where(:attr3 => 4) }.should raise_error(ArgumentError)
+    end
+    it 'should raise an error for an unsupported argument' do
+      lambda { @rel.where(1) }.should raise_error(ArgumentError)
+    end
+    it 'should raise an error for a string' do
+      lambda { @rel.where('attr4 = 5') }.should raise_error(ArgumentError)
+    end
+    it 'should raise an error for an unsupported hash key' do
+      lambda { @rel.where(1 => 34) }.should raise_error(ArgumentError)
+    end
+  end
+
+  describe 'limit' do
+    it 'should update the limit value' do
+      @rel2 = @rel.limit(5)
+      @rel2.limit_value.should eql(5)
+      @rel2 = @rel2.limit(10)
+      @rel2.limit_value.should eql(10)
+    end
+  end
+
+  describe 'when triggered' do
+    it 'should read from the adapter' do
+      @adapter.expects(:read)
+      subject.to_a
+    end
+    it 'should be loaded' do
+      subject.to_a
+      subject.loaded?.should be_true
+    end
+    it 'should not access the adapter when triggered a second time' do
+      subject.to_a
+      @adapter.expects(:read).never
+      subject.to_a
+    end
+    context 'with a valid result' do
+      before {
+        @records = [mock('Record')]
+        @adapter.stubs(:read).returns(@records)
+      }
+      its(:to_a) { should eql(@records) }
+      its(:size) { should eql(1) }
+      its(:blank?) { should be_false }
+      its(:empty?) { should be_false }
     end
   end
 end