nimble-auth 1.0.0

data/spec/fixtures/vcr/invalid-facebook.yml

@@ -0,0 +1,63 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://graph.facebook.com/v2.10/me?access_token=0&fields=id,email,name,location,birthday,picture
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - rest-client/2.0.1 (darwin16.5.0 x86_64) ruby/2.3.1p112
+      Host:
+      - graph.facebook.com
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      Access-Control-Allow-Origin:
+      - "*"
+      Www-Authenticate:
+      - OAuth "Facebook Platform" "invalid_request" "An active access token must be
+        used to query information about the current user."
+      Pragma:
+      - no-cache
+      Cache-Control:
+      - no-store
+      X-Fb-Rev:
+      - '3176548'
+      Content-Type:
+      - application/json; charset=UTF-8
+      X-Fb-Trace-Id:
+      - E2nAx+UwJGh
+      Facebook-Api-Version:
+      - v2.10
+      Expires:
+      - Sat, 01 Jan 2000 00:00:00 GMT
+      Vary:
+      - Accept-Encoding
+      Content-Encoding:
+      - gzip
+      X-Fb-Debug:
+      - jfNsriUTQiVRSAi8+B1ehng78bLNYD9I8qxMFiaWFZWxWVu80akpTGEtHOyrdk4wJVuhplU8c932O11ijtL7BA==
+      Date:
+      - Tue, 25 Jul 2017 02:37:02 GMT
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '157'
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAAAAAAAAAxXMsQqDMBAA0F85bm0oInTJ5iCFLp06l3ieNRRz9nJpFfHf
+        i/vjbciqoug3nDjn8GL02CQIZPHLEIg4ZzB5c4KpZIOOoWTuwQQ+hXWFmAbR
+        KViUBKGTYmAjAxVVTnZYPaNDW+djvjfFxnYhng+PDkl6Rl9fqsrh0JkG4mfs
+        0WNbp2Y5PX6364j7/gd6MSYzpwAAAA==
+    http_version: 
+  recorded_at: Tue, 25 Jul 2017 02:36:59 GMT
+recorded_with: VCR 3.0.3

data/spec/models/identity_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+RSpec.describe NimbleAuth.configuration.resource_identity_class.constantize, type: :model do
+  describe 'db columns' do
+    ## Attributes
+    it { should have_db_column(:uid).of_type(:string) }
+    it { should have_db_column(:provider).of_type(:string) }
+    it { should have_db_column(:oauth_token).of_type(:string) }
+    it { should have_db_column(:oauth_secret).of_type(:string) }
+  end
+
+  describe 'associations' do
+    it { should belong_to(:user) }
+  end
+
+  describe 'validations' do
+    it { should validate_presence_of(:uid) }
+    it { should validate_presence_of(:provider) }
+    it { should validate_presence_of(:oauth_token) }
+  end
+
+  describe '.create_for' do
+    it 'creates a new identity' do
+      oauth_info = Fabricate.to_params(:identity).merge(credentials: { token: SecureRandom.urlsafe_base64 })
+
+      expect { described_class.create_for(oauth: oauth_info, user: Fabricate(:user)) }.to change(Identity, :count).by(1)
+    end
+  end
+end

data/spec/models/user_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+RSpec.describe NimbleAuth.configuration.resource_class.constantize, type: :model do
+  describe 'db columns' do
+    ## Attributes
+    it { should have_db_column(:first_name).of_type(:string) }
+    it { should have_db_column(:last_name).of_type(:string) }
+    it { should have_db_column(:avatar).of_type(:text) }
+
+    ## Database authenticatable
+    it { should have_db_column(:email).of_type(:string) }
+    it { should have_db_column(:username).of_type(:string) }
+    it { should have_db_column(:encrypted_password).of_type(:string) }
+
+    ## Confirmable
+    it { should have_db_column(:confirmation_token).of_type(:string) }
+    it { should have_db_column(:confirmed_at).of_type(:datetime) }
+    it { should have_db_column(:confirmation_sent_at).of_type(:datetime) }
+    it { should have_db_column(:unconfirmed_email).of_type(:string) }
+
+    ## Recoverable
+    it { should have_db_column(:reset_password_token).of_type(:string) }
+    it { should have_db_column(:reset_password_sent_at).of_type(:datetime) }
+
+    ## Rememberable
+    it { should have_db_column(:remember_created_at).of_type(:datetime) }
+
+    ## Trackable
+    it { should have_db_column(:sign_in_count).of_type(:integer) }
+    it { should have_db_column(:current_sign_in_at).of_type(:datetime) }
+    it { should have_db_column(:last_sign_in_at).of_type(:datetime) }
+  end
+
+  describe 'Validations' do
+    it { should validate_presence_of(:email) }
+
+    context 'uniqueness' do
+      subject { Fabricate(:user) }
+
+      it { should validate_uniqueness_of(:email).ignoring_case_sensitivity }
+    end
+  end
+
+  describe 'associations' do
+    it { should have_many(:identities) }
+  end
+
+  describe '.with_oauth' do
+    context 'with valid oauth params' do
+      it 'fetches the user' do
+        email = FFaker::Internet.email
+        user = Fabricate(:user, email: email)
+        oauth_params = {
+          info: {
+            'email' => email
+          }
+        }
+        response = described_class.with_oauth(oauth_params)
+        expect(response).to eq(user)
+      end
+    end
+
+    context 'with invalid oauth params' do
+      it 'returns nil' do
+        oauth_params = {
+          info: {
+            'email' => FFaker::Internet.email
+          }
+        }
+        response = described_class.with_oauth(oauth_params)
+        expect(response).to eq(nil)
+      end
+    end
+  end
+end

data/spec/routing/routes_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe 'routes for NimbleAuth' do
+  routes { NimbleAuth::Engine.routes }
+
+  describe 'Custom Routes' do
+    context 'Omniauth' do
+      context 'Facebook' do
+        it '[GET] Handles authentication request' do
+          expect(get: '/auth/facebook/callback').to route_to(controller: 'nimble_auth/omniauth_callbacks', action: 'facebook')
+        end
+
+        it '[POST] Handles authentication request' do
+          expect(post: '/auth/facebook/callback').to route_to(controller: 'nimble_auth/omniauth_callbacks', action: 'facebook')
+        end
+      end
+    end
+
+    context 'Registrations' do
+      it '[GET] Renders the signup page' do
+        expect(get: '/signup').to route_to(controller: 'devise/registrations', action: 'new')
+      end
+    end
+
+    context 'Sessions' do
+      it '[GET] Renders the login page' do
+        expect(get: '/signin').to route_to(controller: 'nimble_auth/sessions', action: 'new')
+      end
+
+      it '[POST] Accepts login requests' do
+        expect(post: '/signin').to route_to(controller: 'nimble_auth/sessions', action: 'create')
+      end
+
+      it '[GET] Accepts logout requests' do
+        expect(get: '/signout').to route_to(controller: 'nimble_auth/sessions', action: 'destroy')
+      end
+    end
+  end
+end

data/spec/services/nimble_auth/omniauth_authentication_service_spec.rb

@@ -0,0 +1,157 @@
+require 'spec_helper'
+
+RSpec.describe NimbleAuth::OmniauthAuthenticationService, type: :service do
+  describe '#call' do
+    context 'new user' do
+      context 'Valid params' do
+        context 'Facebook' do
+          it 'creates a user' do
+            service = described_class.new(omniauth_facebook_response)
+
+            expect { service.call }.to change(User, :count).by(1)
+          end
+
+          it 'creates an identity for the user' do
+            service = described_class.new(omniauth_facebook_response)
+
+            expect { service.call }.to change(Identity, :count).by(1)
+          end
+
+          it 'responds with success response' do
+            service = described_class.new(omniauth_facebook_response)
+            response = service.call
+
+            expect(response[:status]).to eq(:ok)
+            expect(response[:message]).to eq(I18n.t('activerecord.notices.models.user.create'))
+          end
+        end
+
+        context 'Google' do
+          it 'creates a user' do
+            service = described_class.new(omniauth_google_oauth2_response)
+
+            expect { service.call }.to change(User, :count).by(1)
+          end
+
+          it 'creates an identity for the user' do
+            service = described_class.new(omniauth_google_oauth2_response)
+
+            expect { service.call }.to change(Identity, :count).by(1)
+          end
+
+          it 'responds with success response' do
+            service = described_class.new(omniauth_google_oauth2_response)
+            response = service.call
+
+            expect(response[:status]).to eq(:ok)
+            expect(response[:message]).to eq(I18n.t('activerecord.notices.models.user.create'))
+          end
+        end
+      end
+
+      context 'Invalid params' do
+        context 'Facebook' do
+          it 'responds with error message' do
+            oauth_response = omniauth_facebook_response
+            oauth_response[:extra] = nil
+
+            service = described_class.new(oauth_response)
+            response = service.call
+
+            expect(response[:status]).to eq(:error)
+            expect(response[:message]).to be_present
+          end
+        end
+
+        context 'Google' do
+          it 'responds with error message' do
+            oauth_response = omniauth_google_oauth2_response
+            oauth_response[:info] = {}
+
+            service = described_class.new(oauth_response)
+            response = service.call
+
+            expect(response[:status]).to eq(:error)
+            expect(response[:message]).to be_present
+          end
+        end
+      end
+    end
+
+    context 'existing user with new provider' do
+      it 'responds with success response' do
+        # email matching one in facebook oauth mock
+        user = Fabricate(:user, email: 'joe@bloggs.com')
+        Fabricate(:identity, user_id: user.id, provider: 'facebook', uid: '1461189797258916')
+
+        service = described_class.new(omniauth_google_oauth2_response)
+        response = service.call
+
+        expect(response[:status]).to eq(:ok)
+        expect(response[:message]).to eq(I18n.t('activerecord.notices.models.identity.create_for_existing_user'))
+      end
+    end
+
+    context 'existing user with same oauth creds' do
+      context 'Facebook' do
+        it 'does not create a new user' do
+          user = Fabricate(:user, email: 'joe@bloggs.com')
+          Fabricate(:identity, user_id: user.id, provider: 'facebook', uid: '1461189797258916')
+
+          authentication_service = described_class.new(omniauth_facebook_response)
+
+          expect { authentication_service.call }.to change(User, :count).by(0)
+        end
+
+        it 'does not create a new identity' do
+          user = Fabricate(:user, email: 'joe@bloggs.com')
+          Fabricate(:identity, user_id: user.id, provider: 'facebook', uid: '1461189797258916')
+
+          authentication_service = described_class.new(omniauth_facebook_response)
+
+          expect { authentication_service.call }.to change(Identity, :count).by(0)
+        end
+
+        it 'responds with success response' do
+          user = Fabricate(:user, email: 'joe@bloggs.com')
+          Fabricate(:identity, user_id: user.id, provider: 'facebook', uid: '1461189797258916')
+
+          authentication_service = described_class.new(omniauth_facebook_response)
+          response = authentication_service.call
+
+          expect(response[:status]).to eq(:ok)
+        end
+      end
+
+      context 'Google' do
+        it 'does not create a new user' do
+          user = Fabricate(:user, email: 'joe@bloggs.com')
+          Fabricate(:identity, user_id: user.id, provider: 'google_oauth2', uid: '117222194916469421589')
+
+          authentication_service = described_class.new(omniauth_google_oauth2_response)
+
+          expect { authentication_service.call }.to change(User, :count).by(0)
+        end
+
+        it 'does not create a new identity' do
+          user = Fabricate(:user, email: 'joe@bloggs.com')
+          Fabricate(:identity, user_id: user.id, provider: 'google_oauth2', uid: '117222194916469421589')
+
+          authentication_service = described_class.new(omniauth_google_oauth2_response)
+
+          expect { authentication_service.call }.to change(Identity, :count).by(0)
+        end
+
+        it 'responds with success response' do
+          user = Fabricate(:user, email: 'joe@bloggs.com')
+          Fabricate(:identity, user_id: user.id, provider: 'google_oauth2', uid: '117222194916469421589')
+
+          authentication_service = described_class.new(omniauth_google_oauth2_response)
+          response = authentication_service.call
+
+          expect(response[:status]).to eq(:ok)
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,35 @@
+ENV['RAILS_ENV'] ||= 'test'
+
+require File.expand_path('dummy/config/environment.rb', __dir__)
+
+require 'rspec/rails'
+require 'ffaker'
+require 'fabrication'
+
+Dir['spec/support/**/*.rb'].each { |f| require "#{Dir.pwd}/#{f}" }
+
+RSpec.configure do |config|
+  config.color = true
+
+  config.fixture_path = 'spec/fabricators'
+
+  config.use_transactional_fixtures = true
+
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.default_formatter = 'doc' if config.files_to_run.one?
+
+  config.infer_spec_type_from_file_location!
+
+  config.infer_base_class_for_anonymous_controllers = false
+
+  config.filter_rails_from_backtrace!
+
+  config.order = :random
+end

data/spec/support/capybara.rb

@@ -0,0 +1,16 @@
+require 'capybara'
+
+Capybara.register_driver(:headless_chrome) do |app|
+  capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
+    chromeOptions: { args: %w[headless disable-gpu window-size=1280,720] }
+  )
+
+  Capybara::Selenium::Driver.new(
+    app,
+    browser: :chrome,
+    desired_capabilities: capabilities
+  )
+end
+
+# https://github.com/rails/rails/pull/30638
+Capybara.server = :puma, { Silent: true }

data/spec/support/controller_test.rb

@@ -0,0 +1,3 @@
+require 'rails-controller-testing'
+
+Rails::Controller::Testing.install

data/spec/support/devise.rb

@@ -0,0 +1,5 @@
+require 'devise'
+
+RSpec.configure do |config|
+  config.include Devise::Test::ControllerHelpers, type: :controller
+end

data/spec/support/fabrication.rb

@@ -0,0 +1,5 @@
+Fabrication.configure do |config|
+  config.fabricator_path = '/spec/fabricators'
+  config.path_prefix = Dir.pwd
+  config.sequence_start = 10_000
+end

data/spec/support/oauth_helpers.rb

@@ -0,0 +1,19 @@
+module OauthHelpers
+  module OAuthHelpers
+    def omniauth_facebook_response
+      response_json = File.read('spec/fixtures/mock/omniauth-facebook.json')
+
+      JSON.parse(response_json).deep_symbolize_keys
+    end
+
+    def omniauth_google_oauth2_response
+      response_json = File.read('spec/fixtures/mock/omniauth-google_oauth2.json')
+
+      JSON.parse(response_json).deep_symbolize_keys
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include OauthHelpers::OAuthHelpers
+end