nihaopay-ruby 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7b4c64acc91099c56a7c9aa62ead290eeeb578b
-  data.tar.gz: d93246938e0dcfda73a733ea91ab71acb94a0be8
+  metadata.gz: 5c51db6e7eb5d095fc84393b22004416a765ca3a
+  data.tar.gz: 3c81b8f3620533c0b9143f5b93f1986cac3f6b72
 SHA512:
-  metadata.gz: cd977863d45dadb49ea0a0035a32835cd28533e40931d68df91cc4a9ff9677e1c5a129e0c333a3308575ca48d493fce93fd935e08b63bbe92e1e95dba2093c2a
-  data.tar.gz: d90b8510e72895eb4864f4e04c2066fa4db41dab443834a5202ce89b99cf0d7d57f7c6c84d07808c28be995128779969993d9971cf01de60400e13b05623a144
+  metadata.gz: d549e0b6fe92e697f5d692469fccc17aec27ae44d7cb8b170af90a967af81f62f8f60ee84ae0257432de93f4bcd5099a9caa85a2ea88d30894c3de7989bdf050
+  data.tar.gz: 71b909b6ca9e42f1a73c9a5b6c87b7afe3027f4a88e27ee395672fe0198d77ff5596382288cb3a64a708412295af72b8292379936f7f35ef61c50af37b5419e9

data/CHANGELOG.md

@@ -1,17 +1,26 @@
 # CHANGELOG
 
+## Upcoming
+
+* Your changes here
+
+## 0.2.2
+
+* API Update: Support client IP to be passed in ExpressPay transactions ([@JagdeepSingh](https://github.com/JagdeepSingh))
+* Rubocop: Upgrade percent array literal syntax to use brackets ([@johnnyshields](https://github.com/johnnyshields))
+
 ## 0.2.1
 
-* API Addition: Allow sub_mid parameter (@JagdeepSingh)
+* API Addition: Allow sub_mid parameter ([@JagdeepSingh](https://github.com/JagdeepSingh))
 
 ## 0.2.0
 
-* API Change: Time should be returned as a Ruby time object (@JagdeepSingh)
+* API Change: Time should be returned as a Ruby time object ([@JagdeepSingh](https://github.com/JagdeepSingh))
 
 ## 0.1.1
 
-* Bug Fix: Add time to Nihaopay response if not present (@JagdeepSingh)
+* Bug Fix: Add time to Nihaopay response if not present ([@JagdeepSingh](https://github.com/JagdeepSingh))
 
 ## 0.1.0
 
-* Initial release (@JagdeepSingh)
+* Initial release ([@JagdeepSingh](https://github.com/JagdeepSingh))

data/README.md

@@ -134,9 +134,11 @@ Acceptable values for `expiry_month` are `01` through `12`.
 Now initiate the transaction using above credit card.
 
 ```ruby
-express_pay = Nihaopay::Transactions::Authorize.start(amount, credit_card)
+express_pay = Nihaopay::Transactions::Authorize.start(amount, credit_card, client_ip: '192.x.x.x')
 ```
 
+NOTE: `client_ip` is a required parameter and replace its value with actual IP address.
+
 This returns an instance of `Nihaopay::Transactions::ExpressPay` on which you can access following methods:
 
 ```ruby
@@ -154,7 +156,7 @@ Other methods available are `note` and `time`.
 #### Purchase transaction on ExpressPay
 
 ```ruby
-express_pay = Nihaopay::Transactions::Purchase.start(amount, credit_card)
+express_pay = Nihaopay::Transactions::Purchase.start(amount, credit_card, client_ip: '192.x.x.x')
 ```
 
 This again returns an instance of `Nihaopay::Transactions::ExpressPay`.
@@ -164,7 +166,8 @@ This again returns an instance of `Nihaopay::Transactions::ExpressPay`.
 For `authorize` and `purchase`, you can pass `currency`, `description`, `note`, and `reference` as options.
 
 ```ruby
-express_pay = Nihaopay::Transactions::Authorize.start(amount, credit_card, { currency: 'USD',
+express_pay = Nihaopay::Transactions::Authorize.start(amount, credit_card, { client_ip: '192.x.x.x',  # Required
+                                                                             currency: 'JPY',
                                                                              description: 'Your order description',
                                                                              note: 'Something to remember',
                                                                              reference: 'A unique alphanumeric string',
@@ -327,10 +330,10 @@ express_pay = nihaopay_merchant.authorize(amount, credit_card)
 OR
 
 ```ruby
-express_pay = nihaopay_merchant.authorize(amount, credit_card, options)
+express_pay = nihaopay_merchant.authorize(amount, credit_card, client_ip: '192.x.x.x')
 ```
 
-`options` may include `currency`, `description`, `reference`, `note`, and `sub_mid`.
+Other options include `currency`, `description`, `reference`, `note`, and `sub_mid`.
 
 Similarly, you can do other transactions directly on `Nihaopay::Merchant` object:
 
@@ -339,8 +342,7 @@ Similarly, you can do other transactions directly on `Nihaopay::Merchant` object
 express_pay = nihaopay_merchant.capture(transaction_id, amount, currency)
 
 # purchase
-express_pay = nihaopay_merchant.purchase(amount, credit_card)
-express_pay = nihaopay_merchant.purchase(amount, credit_card, options)
+express_pay = nihaopay_merchant.purchase(amount, credit_card, client_ip: '192.x.x.x')
 
 # release
 express_pay = nihaopay_merchant.release(transaction_id)

data/lib/nihaopay/credit_card.rb

@@ -1,6 +1,6 @@
 module Nihaopay
   class CreditCard
-    ATTRIBUTES = %i(number expiry_year expiry_month cvv).freeze
+    ATTRIBUTES = %i[number expiry_year expiry_month cvv].freeze
 
     attr_accessor(*ATTRIBUTES)
 

data/lib/nihaopay/query.rb

@@ -2,7 +2,7 @@ module Nihaopay
   class Query
     include ::Nihaopay::Api
 
-    VALID_OPTIONS = %i(limit starting_after ending_before).freeze
+    VALID_OPTIONS = %i[limit starting_after ending_before].freeze
 
     def limit(num)
       @limit = num

data/lib/nihaopay/transactions/authorize.rb

@@ -26,7 +26,7 @@ module Nihaopay
         end
 
         def valid_options
-          %i(currency description note reference)
+          %i[currency description note reference client_ip].freeze
         end
 
         def capture_param

data/lib/nihaopay/transactions/base.rb

@@ -61,7 +61,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(token transaction_id type status captured currency reference amount note time)
+          %i[token transaction_id type status captured currency reference amount note time].freeze
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/cancel.rb

@@ -21,7 +21,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(transaction_id status cancelled cancel_transaction_id time)
+          %i[transaction_id status cancelled cancel_transaction_id time].freeze
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/capture.rb

@@ -23,11 +23,11 @@ module Nihaopay
         end
 
         def valid_options
-          %i(amount currency)
+          %i[amount currency].freeze
         end
 
         def valid_attributes
-          %i(transaction_id status captured capture_transaction_id time)
+          %i[transaction_id status captured capture_transaction_id time].freeze
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/refund.rb

@@ -9,11 +9,11 @@ module Nihaopay
         end
 
         def valid_options
-          super | %i(reason)
+          (super | %i[reason]).freeze
         end
 
         def valid_attributes
-          %i(transaction_id status refunded refund_transaction_id time)
+          %i[transaction_id status refunded refund_transaction_id time].freeze
         end
 
         def response_keys_map

data/lib/nihaopay/transactions/release.rb

@@ -9,7 +9,7 @@ module Nihaopay
         end
 
         def valid_attributes
-          %i(transaction_id status released release_transaction_id time)
+          %i[transaction_id status released release_transaction_id time].freeze
         end
 
         def response_keys_map

data/lib/nihaopay/version.rb

@@ -1,3 +1,3 @@
 module Nihaopay
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.2.2'.freeze
 end

data/spec/transactions/authorize_spec.rb

@@ -29,23 +29,25 @@ describe Nihaopay::Transactions::Authorize do
         'captured' => false }
     end
 
-    context 'without options' do
+    context 'with client_ip' do
       let(:body) do
         'card_number=6221558812340000'\
         '&card_exp_year=17'\
         '&card_exp_month=11'\
         '&card_cvv=123'\
+        '&client_ip=192.168.0.1'\
         '&capture=false'\
         '&amount=1000'\
         '&currency=USD'
       end
       it { expect(HTTParty).to receive(:post).with(url, headers: headers, body: body) }
-      after { described_class.start(1000, cc) }
+      after { described_class.start(1000, cc, client_ip: '192.168.0.1') }
     end
 
-    context 'with options' do
+    context 'with other options' do
       let(:options) do
-        { currency: 'USD',
+        { client_ip: '192.168.0.1',
+          currency: 'USD',
           description: 'Lorem ipsum',
           note: 'To self',
           reference: '111111' }
@@ -59,6 +61,7 @@ describe Nihaopay::Transactions::Authorize do
         '&description=Lorem ipsum'\
         '&note=To self'\
         '&reference=111111'\
+        '&client_ip=192.168.0.1'\
         '&capture=false'\
         '&amount=1000'
       end
@@ -67,12 +70,13 @@ describe Nihaopay::Transactions::Authorize do
     end
 
     context 'with invalid options' do
-      let(:options) { { foo: :bar } }
+      let(:options) { { client_ip: '192.168.0.1', foo: :bar } }
       let(:body) do
         'card_number=6221558812340000'\
         '&card_exp_year=17'\
         '&card_exp_month=11'\
         '&card_cvv=123'\
+        '&client_ip=192.168.0.1'\
         '&capture=false'\
         '&amount=1000'\
         '&currency=USD'
@@ -82,7 +86,7 @@ describe Nihaopay::Transactions::Authorize do
     end
 
     context 'with :token in options' do
-      let(:options) { { token: 'ec471780ad1' } }
+      let(:options) { { client_ip: '192.168.0.1', token: 'ec471780ad1' } }
       let(:headers) do
         { 'Authorization' => 'Bearer ec471780ad1',
           'Content-Type' => 'application/x-www-form-urlencoded' }
@@ -92,6 +96,7 @@ describe Nihaopay::Transactions::Authorize do
         '&card_exp_year=17'\
         '&card_exp_month=11'\
         '&card_cvv=123'\
+        '&client_ip=192.168.0.1'\
         '&capture=false'\
         '&amount=1000'\
         '&currency=USD'
@@ -104,12 +109,13 @@ describe Nihaopay::Transactions::Authorize do
     end
 
     context 'with :sub_mid in options' do
-      let(:options) { { sub_mid: 'foobar' } }
+      let(:options) { { client_ip: '192.168.0.1', sub_mid: 'foobar' } }
       let(:body) do
         'card_number=6221558812340000'\
         '&card_exp_year=17'\
         '&card_exp_month=11'\
         '&card_cvv=123'\
+        '&client_ip=192.168.0.1'\
         '&capture=false'\
         '&amount=1000'\
         '&reserved={"sub_mid":"foobar"}'\
@@ -121,7 +127,7 @@ describe Nihaopay::Transactions::Authorize do
 
     describe '.build_from_response!' do
       it 'should return transaction object' do
-        txn = described_class.start(1000, cc)
+        txn = described_class.start(1000, cc, client_ip: '192.168.0.1')
         expect(txn).to be_a Nihaopay::Transactions::Base
         expect(txn.transaction_id).to eq '20160714132438002485'
         expect(txn.status).to eq 'success'

data/spec/transactions/base_spec.rb

@@ -185,7 +185,7 @@ describe Nihaopay::Transactions::Base do
 
   describe '.valid_attributes' do
     let(:expectation) do
-      %i(token transaction_id type status captured currency reference amount note time)
+      %i[token transaction_id type status captured currency reference amount note time]
     end
     it { expect(described_class.valid_attributes).to eq expectation }
   end

data/spec/transactions/cancel_spec.rb

@@ -72,7 +72,7 @@ describe Nihaopay::Transactions::Cancel do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status cancelled cancel_transaction_id time) }
+    let(:expectation) { %i[transaction_id status cancelled cancel_transaction_id time] }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

data/spec/transactions/capture_spec.rb

@@ -81,7 +81,7 @@ describe Nihaopay::Transactions::Capture do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status captured capture_transaction_id time) }
+    let(:expectation) { %i[transaction_id status captured capture_transaction_id time] }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

data/spec/transactions/refund_spec.rb

@@ -87,7 +87,7 @@ describe Nihaopay::Transactions::Refund do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status refunded refund_transaction_id time) }
+    let(:expectation) { %i[transaction_id status refunded refund_transaction_id time] }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

data/spec/transactions/release_spec.rb

@@ -72,7 +72,7 @@ describe Nihaopay::Transactions::Release do
   end
 
   describe '.valid_attributes' do
-    let(:expectation) { %i(transaction_id status released release_transaction_id time) }
+    let(:expectation) { %i[transaction_id status released release_transaction_id time] }
     it { expect(described_class.valid_attributes).to eq expectation }
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nihaopay-ruby
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - JagdeepSingh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-30 00:00:00.000000000 Z
+date: 2017-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.48'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.48'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement