nigilist 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '03859e345e50ed0007f19d98268f1592f010926105ca8574d489c95b1cd62319'
-  data.tar.gz: 9e116b02024911bd4c539f255e8cf44f60341b3633055d192273ce7d824446cf
+  metadata.gz: a586c6911dc9db595a024023cc0ce60a71fb4fc9dbc550206d13249bc6108d37
+  data.tar.gz: cea1e62f69d40782d265d169db670526083d92d98fc7287e9a271994268cc7e2
 SHA512:
-  metadata.gz: 76bb2c37211677ce4bb4a7e691438d69a0421f5dcca715b5d45396887a32e20542d47725f0854c26bcf53a254e56ca05c1233ad4fdde36cb7df46eebf1413dec
-  data.tar.gz: dca4da8b1109575a2ea6ab0b5ad503aebd6c66f8548492463e416ac17b55c872c6769554ff2438e972e6a0854bc5b983bacf36302e25f6c246dcc3a7c797600d
+  metadata.gz: cf85e5252552d1e1efdb39dfa22e37d0809c53253c60d63bc7cafb7335e0835eb318902f3b2b835d891830a87934befec057ad4fef995b6e206b7d704ce20aaa
+  data.tar.gz: cc5a1445e53c58daa7ec9ec98463f0bf8f7d31d0aa3e539e22033f29ed6e2730064584a4cac11aac945ed84ca987282449230a1685b7b871456c22ad27f887cb

data/.travis.yml

@@ -1,4 +1,5 @@
 dist: trusty
 language: ruby
+cache: bundler
 script:
   - bundle exec rake

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+## 1.0.0
+
+### Features
+
+- [**BREAKING**] For Ruby on Rails plural method call now return ActiveRecord's model null relation if model with same singular name exists, otherwise return `[]` ([#6](https://github.com/aishek/nihilist/pull/6))
+- `respond_to?` now return `true` if method call handled by nigilist ([#6](https://github.com/aishek/nihilist/pull/6))
+
+### Fixes
+
+- [**BREAKING**] Methods with plural name and underscore at the end (for example `monkeys_`) now return `nil` instead of `[]` ([#6](https://github.com/aishek/nihilist/pull/6))

data/README.md

@@ -5,7 +5,7 @@
 [![Code Climate](https://codeclimate.com/github/aishek/nihilist.svg)](https://codeclimate.com/github/aishek/nihilist)
 
 
-Nigilist is extremely useful for implement Null Object pattern. It allows null object to return `false` for all question-methods, `nil` for all non-bang-methods, `[]` for all methods in plural form without defining them.
+Nigilist is extremely useful for implement Null Object pattern. It allows null object to return `false` for all question-methods, `nil` for all non-bang-methods, `[]` for all methods in plural form (and in Ruby on Rails null-relation for same name ActiveRecord model) without defining them.
 
 ## Installation
 
@@ -16,6 +16,9 @@ gem install nigilist
 ## Usage
 
 ```ruby
+class Order < ActiveRecord::Base
+end
+
 class Guest
   include Nigilist
 
@@ -24,16 +27,17 @@ class Guest
   end
 
   def locale
-    'ru'.freeze
+    'ru'
   end
 end
 
 current_user = Guest.new
-current_user.admin? # false
-current_user.polite? # true
-current_user.address # nil
-current_user.locale # 'ru'
-current_user.planets # []
+current_user.admin?  # false — for all question methods
+current_user.polite? # true — becase it is explicit defined
+current_user.orders  # Order.none — for all plural methods because same singular name ActiveRecord model exists
+current_user.planets # [] — for all plural methods without because singular name ActiveRecord model doesn't exists
+current_user.address # nil — for all non question, non plural and non bang methods
+current_user.locale  # 'ru' — becase it is explicit defined
 ```
 
 ### Explanation of Null Object pattern
@@ -51,15 +55,15 @@ current_user = current_session.user || Guest.new
 current_user.admin?
 ```
 
-So when your project grow and other methods got it place inside `User` model you have to define same methods in `Guest` model which contains no logic but only return `false` or `nil`.
+So when your project grows and other methods got it place inside `User` model you have to define same methods in `Guest` model which contains no logic but only return `false` or `nil`. In that case Nigilist could be helpful.
 
 ## License
 
-Nigilist is free software, and may be redistributed under the terms specified in the LICENSE.txt file.
+Nigilist is free software, and may be redistributed under the MIT License.
 
 ## Credits
 
-Gem nigilist is maintained by [Cifronomika](http://cifronomika.ru/).
+Gem nigilist is maintained by [Cifronomika](https://cifronomika.com/).
 
 Contributors:
 

data/VERSION

@@ -1 +1 @@
-0.1.0
+1.0.0

data/lib/nigilist.rb

@@ -1,14 +1,31 @@
+# frozen_string_literal: true
+
 module Nigilist
   def method_missing(message, *args, &block)
     method_name = message.to_s
-    if method_name.end_with?('?')
-      false
-    elsif method_name.split("_").last.end_with?('s')
-      []
-    elsif !method_name.end_with?('!')
-      nil
-    else
-      super
+
+    return false if method_name.end_with?('?')
+
+    if method_name.end_with?('s') && method_name[-2..-1] != 'ss'
+      if defined?(Rails)
+        ar_relation_klass = method_name.singularize.camelize.safe_constantize
+        return ar_relation_klass.none if ar_relation_klass && ar_relation_klass.respond_to?(:none)
+      end
+
+      return []
     end
+
+    return nil unless method_name.end_with?('!')
+
+    super
+  end
+
+  def respond_to_missing?(message, include_private = false)
+    method_name = message.to_s
+
+    method_name.end_with?('?') ||
+    (method_name.end_with?('s') && method_name[-2..-1] != 'ss') ||
+    !method_name.end_with?('!') ||
+      super
   end
 end

data/nigilist.gemspec

@@ -2,17 +2,17 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: nigilist 0.1.0 ruby lib
+# stub: nigilist 1.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "nigilist".freeze
-  s.version = "0.1.0"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.metadata = { "allowed_push_host" => "https://rubygems.org" } if s.respond_to? :metadata=
   s.require_paths = ["lib".freeze]
   s.authors = ["Alexandr Borisov".freeze]
-  s.date = "2018-02-05"
+  s.date = "2019-07-10"
   s.description = "After include Nigilist module all ?-ends methods will return false, all non-!-ends methods will return nil.".freeze
   s.email = "ab@cifronomika.ru".freeze
   s.extra_rdoc_files = [
@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".travis.yml",
+    "CHANGELOG.md",
     "Gemfile",
     "Gemfile.lock",
     "LISENCE.txt",
@@ -28,11 +29,12 @@ Gem::Specification.new do |s|
     "VERSION",
     "lib/nigilist.rb",
     "nigilist.gemspec",
+    "test/nihilist_on_rails_test.rb",
     "test/nihilist_test.rb"
   ]
   s.homepage = "https://github.com/aishek/nihilist".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "2.7.3".freeze
+  s.rubygems_version = "3.0.3".freeze
   s.summary = "Nigilist simplifies NullObject pattern classes".freeze
 
   if s.respond_to? :specification_version then

data/test/nihilist_on_rails_test.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'minitest/pride'
+require 'minitest/power_assert'
+
+require 'nigilist'
+
+class Guest
+  include Nigilist
+
+  def costs
+    {}
+  end
+end
+
+class NigilistRailsTest < Minitest::Test
+  def setup
+    Object.const_set('Rails', Module.new)
+
+    String.send(:define_method, :singularize) do self[0..-2] end
+    String.send(:define_method, :camelize) do capitalize end
+    String.send(:define_method, :safe_constantize) do
+      if self == 'Post'
+        return Class.new do
+          def self.none
+            :fake_active_record_null_relation
+          end
+        end
+      end
+      nil
+    end
+
+    @guest = Guest.new
+  end
+
+  def test_explicit_plural_method_without_active_record_model_return_its_value
+    assert { @guest.costs == {} }
+  end
+
+  def test_plural_method_without_active_record_model_return_empty_array
+    assert { @guest.planets == [] }
+  end
+
+  def test_plural_method_with_active_record_model_return_null_relation
+    assert { @guest.posts == :fake_active_record_null_relation }
+  end
+
+  def teardown
+    Object.send(:remove_const, 'Rails')
+
+    String.send(:remove_method, :singularize)
+    String.send(:remove_method, :camelize)
+    String.send(:remove_method, :safe_constantize)
+  end
+end

data/test/nihilist_test.rb

@@ -7,12 +7,16 @@ require 'nigilist'
 class Guest
   include Nigilist
 
+  def hosts
+    :all
+  end
+
   def polite?
     true
   end
 
   def planet
-    'Earth'.freeze
+    'Earth'
   end
 end
 
@@ -21,31 +25,55 @@ class NigilistTest < Minitest::Test
     @guest = Guest.new
   end
 
-  def test_undefined_question_end_method_return_false
+  def test_question_end_method_return_false
     assert { @guest.admin? == false }
   end
 
-  def test_defined_question_end_method_return_its_result
+  def test_explicit_defined_question_end_method_return_its_result
     assert { @guest.polite? == true }
   end
 
-  def test_undefined_non_bang_end_method_return_nil
+  def test_non_bang_end_method_return_nil
     assert { @guest.name.nil? }
   end
 
-  def test_defined_non_bang_end_method_return_its_result
+  def test_explicit_non_bang_end_method_return_its_result
     assert { @guest.planet == 'Earth' }
   end
 
-  def test_undefined_plural_method_return_its_result
+  def test_plural_method_return_empty_array
     assert { @guest.planets == [] }
   end
 
-  def test_undefined_plural_method_with_undersores_return_its_result
+  def test_plural_method_with_undersores_return_empty_array
     assert { @guest.planets_and_monkeys == [] }
   end
 
-  def test_undefined_plural_method_with_undersore_at_the_end_return_its_result
-    assert { @guest.monkeys_ == [] }
+  def test_explicit_plural_method_return_its_result
+    assert { @guest.hosts == :all }
+  end
+
+  def test_plural_method_with_undersore_at_the_end_return_nil
+    assert { @guest.monkeys_ == nil }
+  end
+
+  def test_method_with_doudle_s_ending_return_nil
+    assert { @guest.stress == nil }
+  end
+
+  def test_respond_to_plural_method
+    assert { @guest.respond_to?(:socks) }
+  end
+
+  def test_respond_to_question_method
+    assert { @guest.respond_to?(:intresting?) }
+  end
+
+  def test_respond_to_regular_method
+    assert { @guest.respond_to?(:mess) }
+  end
+
+  def test_does_not_respond_to_bang_method
+    assert { !@guest.respond_to?(:catch!) }
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nigilist
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Alexandr Borisov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-05 00:00:00.000000000 Z
+date: 2019-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -89,6 +89,7 @@ extra_rdoc_files:
 - README.md
 files:
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LISENCE.txt
@@ -97,6 +98,7 @@ files:
 - VERSION
 - lib/nigilist.rb
 - nigilist.gemspec
+- test/nihilist_on_rails_test.rb
 - test/nihilist_test.rb
 homepage: https://github.com/aishek/nihilist
 licenses:
@@ -118,8 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Nigilist simplifies NullObject pattern classes