niftany 0.5.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5bf91705f64576fd41a260006215c2b61760a731c5137de5c40445da683ad4eb
-  data.tar.gz: f5ad80dd870b64d68faa74855acb03302117c4e43cfebe9384aa86ab7e51aad0
+  metadata.gz: e7d595491f6830b1348ae95055cfcc9f07c7aa63aa4d3f2ec480131a2b954fcd
+  data.tar.gz: 68501f826457628cec281a8f0dcbe406d225c432b6a244780ac6705d3cbd54a1
 SHA512:
-  metadata.gz: 17409ed3226dbc64b48917632fb7544a7908d0dc695d383654149bdb994ac27a0bb568e3522a61799440ee363f42abdbd59e7e6e6bbd1ae7bc717fff66f34e40
-  data.tar.gz: 76d6ceb812f870ece48526a250aecc429c3567e0b79ff1be42fc103fc68d5c38ca8a3d20aee31c1b1af2570287ac72b16f77c16f7c875e8a81b1b41ad6e0d947
+  metadata.gz: da186b9080ca9587e1354369716cb00a01ab1b6117e0e61a659bab1890499f12d580c977152699465d2bc3edcacc63534694817c10d9d48b7047e21450edea94
+  data.tar.gz: 7c8507cc4510803d5044df304b46a4c4448e15e5296a91e41a7cc640cf0414957f4a1200e42e5df93e00ca84f5c2fb81df194ec4285d9660e0a022400974954c

data/.github/workflows/ci.yml

@@ -0,0 +1,25 @@
+name: CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.6', '2.7']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run Rubocop
+      run: bundle exec rubocop

data/.rubocop.yml

@@ -1,2 +1,2 @@
-inherit_from: .rubocop_todo.yml
+inherit_from: niftany_rubocop.yml
 

data/.rubocop_todo.yml

@@ -14,5 +14,5 @@ Metrics/MethodLength:
 # Offense count: 2
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 114

data/.ruby-version

@@ -1 +1 @@
-2.6.3
+2.7.1

data/exe/niftany

@@ -12,6 +12,7 @@ require 'colorize'
 def parse_opts(args)
   options = OpenStruct.new
   options.auto_correct = false
+  options.parallel = false
 
   parser = OptionParser.new do |opts|
     opts.banner = 'Usage: niftany [options]'
@@ -20,6 +21,10 @@ def parse_opts(args)
       options.auto_correct = auto
     end
 
+    opts.on('-p', '--parallel', 'Run RuboCop in parallel') do |parallel|
+      options.parallel = parallel
+    end
+
     opts.on_tail('-h', '--help', 'Show this message') do
       puts opts
       exit
@@ -30,9 +35,10 @@ def parse_opts(args)
 end
 
 def rubocop_options(options)
-  return [] unless options.auto_correct
-
-  ['--auto-correct']
+  rubocop_options = []
+  rubocop_options.append('--auto-correct') if options.auto_correct
+  rubocop_options.append('--parallel') if options.parallel
+  rubocop_options
 end
 
 def erblint_options(options)
@@ -65,7 +71,7 @@ else
 end
 
 puts 'Running SCSSLint'.yellow
-logger = SCSSLint::Logger.new(STDOUT)
+logger = SCSSLint::Logger.new($stdout)
 scss_lint = SCSSLint::CLI.new(logger).run(ARGV) # returns integer
 
 if scss_lint.zero?

data/niftany.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'niftany'
-  spec.version       = '0.5.0'
+  spec.version       = '0.9.0'
   spec.authors       = ['Adam Wead']
   spec.email         = ['amsterdamos@gmail.com']
   spec.summary       = 'Manages configurations and versions of linters used in projects at '\
@@ -13,10 +13,13 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
 
+  spec.required_ruby_version = '>= 2.6.0'
+
   spec.add_dependency 'colorize', '~> 0.8.1'
   spec.add_dependency 'erb_lint', '~> 0.0.22'
-  spec.add_dependency 'rubocop', '~> 0.61'
+  spec.add_dependency 'rubocop', '~> 0.79'
   spec.add_dependency 'rubocop-performance', '~> 1.1'
+  spec.add_dependency 'rubocop-rails', '~> 2.3'
   spec.add_dependency 'rubocop-rspec', '~> 1.3'
   spec.add_dependency 'scss_lint', '~> 0.55'
 

data/niftany_erblint.yml

@@ -22,7 +22,7 @@ linters:
           - niftany_rubocop_rails.yml
       Layout/InitialIndentation:
         Enabled: false
-      Layout/TrailingBlankLines:
+      Layout/TrailingEmptyLines:
         Enabled: false
       Layout/TrailingWhitespace:
         Enabled: false
@@ -30,7 +30,7 @@ linters:
         Enabled: false
       Style/FrozenStringLiteralComment:
         Enabled: false
-      Metrics/LineLength:
+      Layout/LineLength:
         Enabled: false
       Lint/UselessAssignment:
         Enabled: false

data/niftany_rubocop_rails.yml

@@ -1,4 +1,6 @@
 ---
+require: rubocop-rails
+
 Rails/Delegate:
   Description: 'Prefer delegate method for delegations.'
   Enabled: false

data/niftany_rubocop_rspec.yml

@@ -43,3 +43,11 @@ RSpec/DescribeClass:
 
 RSpec/BeforeAfterAll:
   Enabled: false
+
+RSpec/ExampleLength:
+  Enabled:
+    false
+
+RSpec/MultipleExpectations:
+  Enabled:
+    false

data/niftany_rubocop_ruby.yml

@@ -8,4 +8,6 @@ inherit_from:
   - rubocop/style.yml
 
 AllCops:
+  TargetRubyVersion: 2.6
   DisplayCopNames: true
+  NewCops: enable

data/rubocop/layout.yml

@@ -1,5 +1,5 @@
 ---
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: 'Here we check if the parameters on a multi-line method call or definition are aligned.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-double-indent'
   Enabled: false
@@ -41,8 +41,20 @@ Layout/ConditionPosition:
 
 Layout/IndentationConsistency:
   Description: 'Checks for inconsistent indentation.'
-  EnforcedStyle: rails
+  EnforcedStyle: indented_internal_methods
 
 Layout/MultilineBlockLayout:
   Description: 'Checks whether the multiline do end blocks have a newline after the start of the block.'
   Enabled: true
+
+Layout/LineLength:
+  Description: 'Limit lines to 120 characters.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#80-character-limits'
+  Enabled: true
+  Max: 120
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true

data/rubocop/lint.yml

@@ -25,7 +25,7 @@ Lint/DeprecatedClassMethods:
   Description: 'Check for deprecated class method calls.'
   Enabled: false
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Description: 'Check for duplicate keys in hash literals.'
   Enabled: true
 
@@ -41,7 +41,7 @@ Lint/FormatParameterMismatch:
   Description: 'The number of parameters to format/sprint must match the fields.'
   Enabled: false
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: "Don't suppress exception."
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions'
   Enabled: false
@@ -101,3 +101,10 @@ Lint/UselessAssignment:
                 Checks for every useless assignment to local variable in every scope.
                 The basic idea for this cop was from the warning of `ruby -cw`:'
   Enabled: true
+
+Lint/RaiseException:
+  Description: 'This cop checks for raise or fail statements which are raising Exception class.'
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true

data/rubocop/metrics.yml

@@ -1,4 +1,8 @@
 ---
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
 Metrics/BlockNesting:
   Description: 'Avoid excessive block nesting'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count'
@@ -30,13 +34,6 @@ Metrics/PerceivedComplexity:
                 the reader experiences when looking at a method
   Enabled: true
 
-# Override style guide to allow length of up to 120 characters.
-Metrics/LineLength:
-  Description: 'Limit lines to 120 characters.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#80-character-limits'
-  Enabled: true
-  Max: 120
-
 Metrics/MethodLength:
   Description: 'Avoid methods longer than 10 lines of code.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#short-methods'

data/rubocop/naming.yml

@@ -21,7 +21,7 @@ Naming/BinaryOperatorParameterName:
 Naming/PredicateName:
   Description: 'Check the names of predicate methods.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark'
-  NamePrefixBlacklist:
+  ForbiddenPrefixes:
     - is_
 
 Naming/VariableName:

data/rubocop/style.yml

@@ -19,12 +19,6 @@ Style/Attr:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#attr'
   Enabled: false
 
-Style/BracesAroundHashParameters:
-  Description: >-
-                Checks for braces around the last parameter in a method call if the last parameter is a hash.
-                It supports 3 styles: braces, no_braces, context_dependent
-  Enabled: true
-
 Style/CaseEquality:
   Description: 'Avoid explicit use of the case equality operator(===).'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-case-equality'
@@ -315,3 +309,18 @@ Style/Sample:
                   `shuffle.last`, and `shuffle[Fixnum]`.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
   Enabled: false
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
+Style/SlicingWithRange:
+  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: niftany
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Adam Wead
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-05-08 00:00:00.000000000 Z
+date: 2021-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.61'
+        version: '0.79'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.61'
+        version: '0.79'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -132,11 +146,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".erb-linters/self_closing_custom.rb"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - LICENSE.md
 - README.md
@@ -160,7 +174,7 @@ files:
 homepage: https://github.com/psu-libraries/niftany
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -168,15 +182,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Manages configurations and versions of linters used in projects at Penn State
   University Libraries.

data/.travis.yml

@@ -1,8 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.6.3
-before_install:
-  - gem update --system
-  - gem install bundler
-script: bundle exec rubocop