nielsm-metric_fu 1.1.1 → 1.3.1

data/spec/generators/flay_spec.rb

@@ -5,19 +5,25 @@ describe Flay do
     MetricFu::Flay.stub!(:verify_dependencies!).and_return(true)
   end
   describe "emit method" do
-    before :each do
+    it "should look at the dirs" do
       MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => ['app', 'lib']  } }
       File.stub!(:directory?).and_return(true)
-      @flay = MetricFu::Flay.new('base_dir')
-      
-    end
+      @flay = MetricFu::Flay.new('base_dir')    
     
-    it "should look at the dirs" do
       Dir.should_receive(:[]).with(File.join("app", "**/*.rb")).and_return("path/to/app")
       Dir.should_receive(:[]).with(File.join("lib", "**/*.rb")).and_return("path/to/lib")
       @flay.should_receive(:`).with("flay path/to/app path/to/lib")
       output = @flay.emit
     end
+    
+    it "should limit flay scores by the minimum_score" do
+      MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => [], :minimum_score => 99 } }
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+
+      @flay.should_receive(:`).with("flay --mass 99 ")
+      output = @flay.emit
+    end
   end
   
   describe "analyze method" do

data/spec/generators/flog_spec.rb

@@ -184,6 +184,7 @@ describe Flog do
       File.stub!(:directory?).and_return(true)
       flog = MetricFu::Flog.new('base_dir')
       flog.should_receive(:open).and_return(@text)
+      flog.stub!(:is_file_current?).and_return(true)
       Dir.should_receive(:glob).and_return(["tmp/metric_fu/scratch/flog/app/controllers/user_controller.txt"])
       flog.analyze
       @flog_hash = flog.to_h
@@ -206,6 +207,24 @@ describe Flog do
     end
   end
   
+  describe "to_h function ignore files not current" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flog = MetricFu::Flog.new('base_dir')
+      flog.should_receive(:open).and_return(@text)
+      flog.stub!(:is_file_current?).and_return(false)
+      Dir.should_receive(:glob).and_return(["tmp/metric_fu/scratch/flog/app/controllers/user_controller.txt"])
+      flog.analyze
+      @flog_hash = flog.to_h
+    end
+    
+    it "should put the total in the hash" do
+      @flog_hash.should == {:flog=>{:total=>0, :pages=>[], :average=>0}}
+    end
+  
+  end
+  
   describe "to_h function with zero total" do
     it "should not blow up" do
       MetricFu::Configuration.run {}

data/spec/generators/reek_spec.rb

@@ -58,3 +58,68 @@ NewlineController#some_method calls current_user.<< "new line\n" multiple times
   end
   
 end
+
+describe Reek do
+  before :each do
+    MetricFu::Reek.stub!(:verify_dependencies!).and_return(true)
+    MetricFu::Configuration.run {}
+    @reek = MetricFu::Reek.new
+    @lines11 = <<-HERE
+"app/controllers/activity_reports_controller.rb" -- 4 warnings:
+ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
+ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
+ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
+ActivityReportsController#authorize_user has approx 6 statements (Long Method)
+
+"app/controllers/application.rb" -- 1 warnings:
+ApplicationController#start_background_task/block/block is nested (Nested Iterators)
+
+"app/controllers/link_targets_controller.rb" -- 1 warnings:
+LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
+
+"app/controllers/newline_controller.rb" -- 1 warnings:
+NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
+      HERE
+    @lines12 = <<-HERE
+app/controllers/activity_reports_controller.rb -- 4 warnings (+3 masked):
+  ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
+  ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
+  ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
+  ActivityReportsController#authorize_user has approx 6 statements (Long Method)
+app/controllers/application.rb -- 1 warnings:
+  ApplicationController#start_background_task/block/block is nested (Nested Iterators)
+app/controllers/link_targets_controller.rb -- 1 warnings (+1 masked):
+  LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
+app/controllers/newline_controller.rb -- 1 warnings:
+  NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
+      HERE
+  end
+
+  context 'with Reek 1.1 output format' do
+    it 'reports 1.1 style when the output is empty' do
+      @reek.instance_variable_set(:@output, "")
+      @reek.should_not be_reek_12
+    end
+    it 'detects 1.1 format output' do
+      @reek.instance_variable_set(:@output, @lines11)
+      @reek.should_not be_reek_12
+    end
+
+    it 'massages empty output to be unchanged' do
+      @reek.instance_variable_set(:@output, "")
+      @reek.massage_for_reek_12.should be_empty
+    end
+  end
+
+  context 'with Reek 1.2 output format' do
+    it 'detects 1.2 format output' do
+      @reek.instance_variable_set(:@output, @lines12)
+      @reek.should be_reek_12
+    end
+
+    it 'correctly massages 1.2 output' do
+      @reek.instance_variable_set(:@output, @lines12)
+      @reek.massage_for_reek_12.should == @lines11
+    end
+  end
+end

data/spec/graphs/engines/bluff_spec.rb

@@ -0,0 +1,16 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+
+describe "Bluff graphers responding to #graph!" do
+  it "should write chart file" do
+    MetricFu.configuration
+    graphs = {}
+    MetricFu::AVAILABLE_GRAPHS.each do |graph|
+      graphs[graph] = MetricFu.const_get("#{graph.to_s.capitalize}BluffGrapher").new
+    end
+    graphs.each do |key, val|
+      val.graph!
+      output_dir = File.expand_path(File.join(MetricFu.output_directory))
+      lambda{ File.open(File.join(output_dir, "#{key.to_s.downcase}.js")) }.should_not raise_error
+    end
+  end
+end

data/spec/graphs/engines/gchart_spec.rb

@@ -0,0 +1,108 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+describe MetricFu::GchartGrapher do
+  describe "determine_y_axis_scale" do
+    it "should set defaults when empty array" do
+      grapher = Object.new.extend(MetricFu::GchartGrapher)
+      grapher.determine_y_axis_scale([])
+      grapher.instance_variable_get(:@max_value).should == 10
+      grapher.instance_variable_get(:@yaxis).should == [0, 2, 4, 6, 8, 10]
+    end
+    
+    it "should set max value of the graph above largest value" do
+      grapher = Object.new.extend(MetricFu::GchartGrapher)
+      grapher.determine_y_axis_scale([19])
+      grapher.instance_variable_get(:@max_value).should == 20
+      
+      grapher.determine_y_axis_scale([20])
+      grapher.instance_variable_get(:@max_value).should == 25
+    end
+  end
+end
+
+describe "Gchart graphers" do
+  before :each do
+    MetricFu.configuration
+  end
+  
+  describe "FlayGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = FlayGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Flay: duplication"),
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'flay.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+  
+  describe "FlogGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = FlogGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Flog: code complexity"),
+        :stacked => false,
+        :bar_colors => MetricFu::GchartGrapher::COLORS[0..1],
+        :legend => ['average', 'top 5%25 average'],
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'flog.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+  
+  describe "RcovGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = RcovGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Rcov: code coverage"),
+        :max_value => 101,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [grapher.labels.values, [0,20,40,60,80,100]],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'rcov.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+  
+  describe "ReekGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = ReekGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Reek: code smells"),
+        :stacked => false,
+        :bar_colors => MetricFu::GchartGrapher::COLORS,
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'reek.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+  
+  describe "RoodiGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = RoodiGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Roodi: potential design problems"),
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'roodi.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+end

data/spec/graphs/flay_grapher_spec.rb

@@ -0,0 +1,37 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe FlayGrapher do 
+  before :each do
+    @flay_grapher = MetricFu::FlayGrapher.new
+    MetricFu.configuration
+  end
+  
+  it "should respond to flay_score and labels" do
+    @flay_grapher.should respond_to(:flay_score)
+    @flay_grapher.should respond_to(:labels)
+  end
+  
+  describe "responding to #initialize" do
+    it "should initialise flay_score and labels" do
+      @flay_grapher.flay_score.should == []
+      @flay_grapher.labels.should == {}
+    end
+  end
+  
+  describe "responding to #get_metrics" do
+    before(:each) do
+      @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "20090630.yml")))
+      @date = "1/2"
+    end
+    
+    it "should push 476 to flay_score" do
+      @flay_grapher.flay_score.should_receive(:push).with(476)      
+      @flay_grapher.get_metrics(@metrics, @date)
+    end
+    
+    it "should update labels with the date" do
+      @flay_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+      @flay_grapher.get_metrics(@metrics, @date)
+    end
+  end
+end

data/spec/graphs/flog_grapher_spec.rb

@@ -1,15 +1,45 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
 describe MetricFu::FlogGrapher do
-  it "should not fall over when given empty results" do
-    MetricFu::Configuration.run {}
+  before :each do
+    @flog_grapher = MetricFu::FlogGrapher.new
+    MetricFu.configuration
+  end
+  
+  it "should respond to flog_total, flog_average and labels" do
+    @flog_grapher.should respond_to(:flog_average)
+    @flog_grapher.should respond_to(:labels)
+    @flog_grapher.should respond_to(:top_five_percent_average)
+  end
+  
+  describe "responding to #initialize" do
+    it "should initialize top_five_percent_average, flog_average and labels" do
+      @flog_grapher.flog_average.should == []
+      @flog_grapher.labels.should == {}
+      @flog_grapher.top_five_percent_average.should == []
+    end
+  end
+  
+  describe "responding to #get_metrics" do
+    before(:each) do
+      @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "20090630.yml")))
+      @date = "1/2"
+    end
+    
+    it "should push to top_five_percent_average" do
+      average = (73.6 + 68.5 + 66.1 + 46.6 + 44.8 + 44.1 + 41.2 + 36.0) / 8.0
+      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)      
+      @flog_grapher.get_metrics(@metrics, @date)
+    end
     
-    gruff_line = Gruff::Line.new(MetricFu.graph_size)
-    gruff_line.stub!(:write)
-    Gruff::Line.stub!(:new).and_return(gruff_line)
+    it "should push 9.9 to flog_average" do
+      @flog_grapher.flog_average.should_receive(:push).with(9.9)
+      @flog_grapher.get_metrics(@metrics, @date)
+    end
     
-    grapher = FlogGrapher.new()
-    metrics_hash = {:flog => {:average => 0, :pages => [], :total => 0}}
-    grapher.get_metrics(metrics_hash ,"20090629")
-    grapher.graph!
+    it "should update labels with the date" do
+      @flog_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+      @flog_grapher.get_metrics(@metrics, @date)
+    end
   end
-end
+end

data/spec/graphs/rcov_grapher_spec.rb

@@ -0,0 +1,37 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe RcovGrapher do 
+  before :each do
+    @rcov_grapher = MetricFu::RcovGrapher.new
+    MetricFu.configuration
+  end
+  
+  it "should respond to rcov_percent and labels" do
+    @rcov_grapher.should respond_to(:rcov_percent)
+    @rcov_grapher.should respond_to(:labels)
+  end
+  
+  describe "responding to #initialize" do
+    it "should initialise rcov_percent and labels" do
+      @rcov_grapher.rcov_percent.should == []
+      @rcov_grapher.labels.should == {}
+    end
+  end
+  
+  describe "responding to #get_metrics" do
+    before(:each) do
+      @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "20090630.yml")))
+      @date = "1/2"
+    end
+    
+    it "should push 49.6 to rcov_percent" do
+      @rcov_grapher.rcov_percent.should_receive(:push).with(49.6)      
+      @rcov_grapher.get_metrics(@metrics, @date)
+    end
+    
+    it "should update labels with the date" do
+      @rcov_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+      @rcov_grapher.get_metrics(@metrics, @date)
+    end
+  end
+end

data/spec/graphs/reek_grapher_spec.rb

@@ -0,0 +1,46 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe ReekGrapher do 
+  before :each do
+    @reek_grapher = MetricFu::ReekGrapher.new
+    MetricFu.configuration
+  end
+  
+  it "should respond to reek_count and labels" do
+    @reek_grapher.should respond_to(:reek_count)
+    @reek_grapher.should respond_to(:labels)
+  end
+  
+  describe "responding to #initialize" do
+    it "should initialise reek_count and labels" do
+      @reek_grapher.reek_count.should == {}
+      @reek_grapher.labels.should == {}
+    end
+  end
+  
+  describe "responding to #get_metrics" do
+    before(:each) do
+      @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "20090630.yml")))
+      @date = "1/2"
+    end
+    
+    it "should set a hash of code smells to reek_count" do
+      @reek_grapher.get_metrics(@metrics, @date)
+      @reek_grapher.reek_count.should == {
+        "Uncommunicative Name" => [27],
+        "Feature Envy" => [20],
+        "Utility Function" => [15],
+        "Long Method" => [26],
+        "Nested Iterators" => [12],
+        "Control Couple" => [4],
+        "Duplication" => [48],
+        "Large Class" => [1] 
+      }
+    end
+    
+    it "should update labels with the date" do
+      @reek_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+      @reek_grapher.get_metrics(@metrics, @date)
+    end
+  end
+end

data/spec/graphs/roodi_grapher_spec.rb

@@ -0,0 +1,37 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe RoodiGrapher do 
+  before :each do
+    @roodi_grapher = MetricFu::RoodiGrapher.new
+    MetricFu.configuration
+  end
+  
+  it "should respond to roodi_count and labels" do
+    @roodi_grapher.should respond_to(:roodi_count)
+    @roodi_grapher.should respond_to(:labels)
+  end
+  
+  describe "responding to #initialize" do
+    it "should initialise roodi_count and labels" do
+      @roodi_grapher.roodi_count.should == []
+      @roodi_grapher.labels.should == {}
+    end
+  end
+  
+  describe "responding to #get_metrics" do
+    before(:each) do
+      @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "20090630.yml")))
+      @date = "1/2"
+    end
+    
+    it "should push 13 to roodi_count" do
+      @roodi_grapher.roodi_count.should_receive(:push).with(13)      
+      @roodi_grapher.get_metrics(@metrics, @date)
+    end
+    
+    it "should update labels with the date" do
+      @roodi_grapher.labels.should_receive(:update).with({ 0 => "1/2" })
+      @roodi_grapher.get_metrics(@metrics, @date)
+    end
+  end
+end