nice_partials 0.9.1 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a1bc9c01590139038135f1cd6856c79529485c970225a5aa4d82a35d11bc33a
-  data.tar.gz: 19f2f3754c6c590745ee649a94e32de934ced12a2602956d0aa7fff7a8db4c74
+  metadata.gz: 14580892ce441161fda38b893e61d4b4733b1fd1c0130f22cf73dc7170f9ddd2
+  data.tar.gz: '0696801e28b1ab5f3574cca9d71bcb03a702fa76d5076a25881ef0dfaa883638'
 SHA512:
-  metadata.gz: 99fca66a8450503cbd2348187680c0f82b995d1830515cebe35401d9fd4e1d2395ba35fceedeb18bf4bf36ffbc8a4273811344a4c5fa58d7e5981d6d0ac9b866
-  data.tar.gz: b3215bcdb6c639faeed18ec17b57bdcaba2c71c70a738c25c48faf00201535198b5dbb56f18686a2b2a2877d5896246275012cad0555ff2e558c13684291f805
+  metadata.gz: 302fdc205c1c433b670bcdd22d45a0a66bccdcdc15fae841ef88ae0209079a77cd2bddff199060a17be941164a7a8e852c16d6b508674483e123eebdb8f5c892
+  data.tar.gz: 8b9cff626b4a6c713d274609427c6ed28dbc20a31b9825aa52b21e8670c59f37e5c1f5552460a357ff06b47aca3af7a0fd78c937882bf6779c8f0281ac2b6b0c

data/CHANGELOG.md

@@ -1,5 +1,56 @@
 ## CHANGELOG
 
+### 0.9.3
+
+* Fixed: section predicates not respecting `local_assigns` content
+
+  Previously, when doing something like this:
+
+  ```erb
+  <%= render "card", title: "Hello there" %>
+  ```
+
+  If the inner card partial had this,
+
+  ```erb
+  <% if partial.title? %>
+    <%= partial.title %>
+  <% end %>
+  ```
+
+  The `title?` predicate would fail, because it didn't look up content from the passed `local_assigns`. Now it does.
+
+### 0.9.2
+
+* Changed: view methods don't clobber section names
+
+  Previously, we'd eagerly delegate to the view context so if the view had a `label` method, `partial.label` would call the view's `label` instead of making a `label` section.
+
+  This was to support `partial.helpers` but we've changed the implementation to support the above. `partial.helpers` still works the same too.
+
+* Changed: `partial.helpers` no longer automatically calls `partial` methods
+
+  Previously, if a user defined a partial helper like this:
+
+  ```ruby
+  partial.helpers do
+    def some_helper
+      some_section
+    end
+  end
+  ```
+
+  If `some_section` wasn't a view method, it would automatically call `partial.some_section`
+  thereby adding a new content section to the partial.
+
+  Now `partial.helpers` behaves exactly like view helpers — making it easier to copy code directly when migrating — so users would have to explicitly call `partial.some_section`.
+
+### 0.9.1
+
+* Fix Ruby 2.7 compatibility
+
+### 0.9.0
+
 * Fix rendering with special characters in a view path.
 
   Ref: https://github.com/bullet-train-co/nice_partials/pull/70

data/lib/nice_partials/monkey_patch.rb

@@ -8,7 +8,7 @@ module NicePartials::RenderingWithLocalePrefix
   end
 
   def t(key, options = {})
-    if (prefix = @_nice_partials_t_prefix) && key.first == '.'
+    if (prefix = @_nice_partials_t_prefix) && key&.start_with?(".")
       key = "#{prefix}#{key}"
     end
 

data/lib/nice_partials/partial.rb

@@ -4,8 +4,6 @@ module NicePartials
     autoload :Section, "nice_partials/partial/section"
     autoload :Stack, "nice_partials/partial/stack"
 
-    delegate_missing_to :@view_context
-
     def initialize(view_context, local_assigns = nil)
       @view_context, @local_assigns = view_context, local_assigns
     end
@@ -19,7 +17,7 @@ module NicePartials
     end
 
     def helpers(&block)
-      self.class.class_eval(&block)
+      Helpers.class_eval(&block)
     end
 
     # `translate` is a shorthand to set `content_for` with content that's run through
@@ -72,12 +70,12 @@ module NicePartials
     end
 
     def section?(name)
-      @sections&.dig(name).present?
+      section_from(name).present?
     end
     alias content_for? section?
 
     def content_for(...)
-      section(...)&.to_s
+      section(...).presence&.to_s
     end
 
     def slice(*keys)
@@ -94,12 +92,12 @@ module NicePartials
       @sections ||= {} and @sections[name] ||= Section.new(@view_context, @local_assigns&.dig(name))
     end
 
+    def respond_to_missing?(meth, include_private = false)
+      meth != :to_ary # Avoid creating a section when doing `*partial`.
+    end
+
     def method_missing(meth, *arguments, **keywords, &block)
-      if @view_context.respond_to?(meth)
-        @view_context.public_send(meth, *arguments, **keywords, &block)
-      else
-        define_accessor meth and public_send(meth, *arguments, **keywords, &block)
-      end
+      define_accessor meth and public_send(meth, *arguments, **keywords, &block)
     end
 
     def define_accessor(name)
@@ -107,5 +105,16 @@ module NicePartials
       self.class.define_method(name) { |content = nil, **options, &block| section(name, content, **options, &block) }
       self.class.define_method("#{name}?") { section?(name) }
     end
+
+    def helpers_context
+      @helpers_context ||= Helpers.new(@view_context)
+    end
+
+    class Helpers < SimpleDelegator
+      def self.method_added(name)
+        super
+        NicePartials::Partial.delegate name, to: :helpers_context
+      end
+    end
   end
 end

data/lib/nice_partials/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NicePartials
-  VERSION = "0.9.1"
+  VERSION = "0.9.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nice_partials
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.3
 platform: ruby
 authors:
 - Andrew Culver
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-16 00:00:00.000000000 Z
+date: 2023-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -95,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.7
 signing_key:
 specification_version: 4
 summary: A little bit of magic to make partials perfect for components.