nice_partials 0.9.0 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3b70755595cff02588aa600004e44ec9f20847a4fdd026e0326876a2cad7f52
-  data.tar.gz: 24e42267606eb6a56ed481d2b82d137210618dff3282f6586036aa68bfad71c0
+  metadata.gz: e8c2fc27ad0c01eda3e489191c6ba385498ec49580f38400f8447600ee8d0488
+  data.tar.gz: e138bd379b7f805e0be27054d6a689e31d58169e27ad118bec43a3538b24c9f9
 SHA512:
-  metadata.gz: de339636e922f606a268eb0a9888686e3f0c6b3bdd0f874c8c50998a55437dfc8dff7f4a1c4293d4814277f75a49a959aa47ba9318ad9d9898d651c87d5fc6f8
-  data.tar.gz: ed7d3ff442df563d12aba16982a7a3ecae8a5f5b3022255e733bd2b5fd816c828064ddb659162839ef234fc26b22bd3f3a3a6be175e918a5518688a5cfe8bde2
+  metadata.gz: 24aa6946079c6663a907b6e7eb2c6158b07105bc3cf0273a9907c2a7732fc6ba030e3b733b8beacd1221288e32c995067a0af6b30649e8a6c8ec7960e8adcd22
+  data.tar.gz: 70548909852322e987e7a11aafb81f927b9652ac03bef500f1ddf3b3daca915bc37d22270a537a37580ac67e0fa76ef158bc7a783bf8327c603ad108cc275a5b

data/CHANGELOG.md

@@ -1,5 +1,36 @@
 ## CHANGELOG
 
+### 0.9.2
+
+* Changed: view methods don't clobber section names
+
+  Previously, we'd eagerly delegate to the view context so if the view had a `label` method, `partial.label` would call the view's `label` instead of making a `label` section.
+
+  This was to support `partial.helpers` but we've changed the implementation to support the above. `partial.helpers` still works the same too.
+
+* Changed: `partial.helpers` no longer automatically calls `partial` methods
+
+  Previously, if a user defined a partial helper like this:
+
+  ```ruby
+  partial.helpers do
+    def some_helper
+      some_section
+    end
+  end
+  ```
+
+  If `some_section` wasn't a view method, it would automatically call `partial.some_section`
+  thereby adding a new content section to the partial.
+
+  Now `partial.helpers` behaves exactly like view helpers — making it easier to copy code directly when migrating — so users would have to explicitly call `partial.some_section`.
+
+### 0.9.1
+
+* Fix Ruby 2.7 compatibility
+
+### 0.9.0
+
 * Fix rendering with special characters in a view path.
 
   Ref: https://github.com/bullet-train-co/nice_partials/pull/70

data/lib/nice_partials/partial/section.rb

@@ -24,7 +24,6 @@ class NicePartials::Partial::Section < NicePartials::Partial::Content
   #    <% partial.title.h2 ", appended" %> # => <h2 class="xl">Some title content, appended</h2>
   #
   # Note that NicePartials don't support deep merging attributes out of the box.
-  # For that, bundle https://github.com/seanpdoyle/attributes_and_token_lists
   def method_missing(meth, *arguments, **keywords, &block)
     if meth != :p && @view_context.respond_to?(meth)
       append @view_context.public_send(meth, *arguments, **keywords, &block)
@@ -32,7 +31,10 @@ class NicePartials::Partial::Section < NicePartials::Partial::Content
       @view_context.tag.public_send(meth, @content + arguments.first.to_s, **options.merge(keywords), &block)
     end
   end
-  def respond_to_missing?(...) = @view_context.respond_to?(...)
+
+  def respond_to_missing?(...)
+    @view_context.respond_to?(...)
+  end
 
   private
 
@@ -44,5 +46,7 @@ class NicePartials::Partial::Section < NicePartials::Partial::Content
     end
   end
 
-  def chunks() = @chunks ||= []
+  def chunks
+    @chunks ||= []
+  end
 end

data/lib/nice_partials/partial.rb

@@ -4,8 +4,6 @@ module NicePartials
     autoload :Section, "nice_partials/partial/section"
     autoload :Stack, "nice_partials/partial/stack"
 
-    delegate_missing_to :@view_context
-
     def initialize(view_context, local_assigns = nil)
       @view_context, @local_assigns = view_context, local_assigns
     end
@@ -19,7 +17,7 @@ module NicePartials
     end
 
     def helpers(&block)
-      self.class.class_eval(&block)
+      Helpers.class_eval(&block)
     end
 
     # `translate` is a shorthand to set `content_for` with content that's run through
@@ -77,7 +75,7 @@ module NicePartials
     alias content_for? section?
 
     def content_for(...)
-      section(...)&.to_s
+      section(...).presence&.to_s
     end
 
     def slice(*keys)
@@ -94,12 +92,12 @@ module NicePartials
       @sections ||= {} and @sections[name] ||= Section.new(@view_context, @local_assigns&.dig(name))
     end
 
+    def respond_to_missing?(meth, include_private = false)
+      meth != :to_ary # Avoid creating a section when doing `*partial`.
+    end
+
     def method_missing(meth, *arguments, **keywords, &block)
-      if @view_context.respond_to?(meth)
-        @view_context.public_send(meth, *arguments, **keywords, &block)
-      else
-        define_accessor meth and public_send(meth, *arguments, **keywords, &block)
-      end
+      define_accessor meth and public_send(meth, *arguments, **keywords, &block)
     end
 
     def define_accessor(name)
@@ -107,5 +105,16 @@ module NicePartials
       self.class.define_method(name) { |content = nil, **options, &block| section(name, content, **options, &block) }
       self.class.define_method("#{name}?") { section?(name) }
     end
+
+    def helpers_context
+      @helpers_context ||= Helpers.new(@view_context)
+    end
+
+    class Helpers < SimpleDelegator
+      def self.method_added(name)
+        super
+        NicePartials::Partial.delegate name, to: :helpers_context
+      end
+    end
   end
 end

data/lib/nice_partials/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NicePartials
-  VERSION = "0.9.0"
+  VERSION = "0.9.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nice_partials
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.2
 platform: ruby
 authors:
 - Andrew Culver
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-15 00:00:00.000000000 Z
+date: 2023-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -75,7 +75,6 @@ files:
 - lib/nice_partials/partial/section.rb
 - lib/nice_partials/partial/stack.rb
 - lib/nice_partials/version.rb
-- nice_partials.gemspec
 homepage: https://github.com/bullet-train-co/nice_partials
 licenses:
 - MIT
@@ -95,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: A little bit of magic to make partials perfect for components.

data/nice_partials.gemspec

@@ -1,32 +0,0 @@
-# -*- encoding: utf-8 -*-
-
-require File.dirname(__FILE__) + "/lib/nice_partials/version"
-
-Gem::Specification.new do |gem|
-  gem.name          = "nice_partials"
-  gem.version       = NicePartials::VERSION
-  gem.summary       = "A little bit of magic to make partials perfect for components."
-  gem.description   = "A little bit of magic to make partials perfect for components."
-  gem.authors       = ["Andrew Culver", "Dom Christie"]
-  gem.email         = ["andrew.culver@gmail.com", "christiedom@gmail.com"]
-  gem.homepage      = "https://github.com/bullet-train-co/nice_partials"
-  gem.license       = "MIT"
-
-    # Specify which files should be added to the gem when it is released.
-  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  gem.files = Dir.chdir(__dir__) do
-    `git ls-files -z`.split("\x0").reject do |f|
-      (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
-    end
-  end
-  gem.bindir = "exe"
-  gem.executables = gem.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  gem.require_paths = ["lib"]
-
-  gem.required_ruby_version = ">= 2.0"
-
-  gem.add_dependency "actionview", '>= 4.2.6'
-
-  gem.add_development_dependency "rails"
-  gem.add_development_dependency "standard"
-end