nhtsa_vin 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 304f6e9a4706dcfd739db613ae7c72498315105c
-  data.tar.gz: d4d6d09d018be6ad53808f6f1373fd2bf8ab1b62
+  metadata.gz: 9c417b90ce601fa0150143c271fded5fa77e06a9
+  data.tar.gz: a2a5c574e0f4ce6c8761dc363a50dfd6c6ca777b
 SHA512:
-  metadata.gz: 85c5e99bbd033576db5f582aeaff92ec8317fa74e459d58e8e68a396b134d2cdeebd601fb43d0446274e04ea26e24b7706d1047ae18ce1237b4f017cc4bc3716
-  data.tar.gz: 2d5b4cb48f8ebab768ce8ee7cda45bb5b2dc106e15bb6a09892195ea9570ea79da42ff06423c2f928a4b874d147c9b71c216594871dbc951807154a800592570
+  metadata.gz: a5c0100a5a611a127f8fbedd315b28be5580cd33420783c1e7f98b29dd3d82f969a19011ca78ac4d808325520cd0582786a9addab3563f7e00e9459b2e6c1e82
+  data.tar.gz: ca722daf6017b49ce6775249fa666bcff33aa7585b7ac43347b8110d95aa3035236b879d59246e4cf06d1a45a8482230d47f1341199ceb9c7825dfac9acbd920

data/.circleci/config.yml

@@ -16,17 +16,17 @@ jobs:
     steps:
       - checkout
 
-      - run:
-          name: install dependencies
-          command: |
-            bundle install
-
       - run:
           name: Setup Code Climate test-reporter
           command: |
             curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
             chmod +x ./cc-test-reporter
-            
+
+      - run:
+          name: install dependencies
+          command: |
+            bundle install
+
       # run tests!
       - run:
           name: run tests
@@ -34,12 +34,12 @@ jobs:
             mkdir /tmp/test-results
             ./cc-test-reporter before-build
             TEST_FILES="$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)"
-            rspec spec --format progress \
+            bundle exec rspec spec --format progress \
                        --format RspecJunitFormatter \
                        --out /tmp/test-results/rspec.xml \
-                       --format progress \
                        $TEST_FILES
-            ./cc-test-reporter after-build --coverage-input-type simplecov --prefix coverage --exit-code $?          
+            ./cc-test-reporter sum-coverage coverage/coverage.json
+            ./cc-test-reporter after-build --coverage-input-type simplecov --prefix coverage --exit-code $?
 
       # collect reports
       - store_test_results:

data/lib/nhtsa_vin/query.rb

@@ -9,14 +9,20 @@ module NhtsaVin
     attr_reader :vin, :url, :response, :data, :error, :error_code, :raw_response
 
     def initialize(vin, options={})
-      @vin = vin
+      @vin = vin.strip.upcase
+      @http_options = options[:http] || {}
       build_url
     end
 
     def get
       @raw_response = fetch
       return if @raw_response.nil?
-      parse(JSON.parse(@raw_response))
+      begin
+        parse(JSON.parse(@raw_response))
+      rescue JSON::ParserError
+        @valid = false
+        @error = 'Response is not valid JSON'
+      end
     end
 
     def valid?
@@ -92,19 +98,38 @@ module NhtsaVin
 
       def fetch
         begin
-          Net::HTTP.get(URI.parse(@url))
+          @valid = false
+
+          url = URI.parse(@url)
+          Net::HTTP.start(url.host, url.port, use_ssl: (url.scheme == 'https')) do |http|
+            @http_options.each do |key, val|
+              http.send("#{key}=", val) if val
+            end
+
+            resp = http.request_get(url)
+            case resp
+            when Net::HTTPSuccess
+              @valid = true
+              resp.body
+            when Net::HTTPRedirection
+              raise 'No support for HTTP redirection from NHTSA API'
+            when Net::HTTPClientError
+              @error = "Client error: #{resp.code} #{resp.message}"
+              nil
+            else
+              @error = resp.message
+              nil
+            end
+          end
         rescue Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, EOFError, SocketError,
                Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError,
                Net::ProtocolError, Errno::ECONNREFUSED => e
-          @valid = false
           @error = e.message
           nil
         end
       end
-
   end
 
   Struct.new('NhtsaResponse', :vin, :make, :model, :trim, :type, :year,
              :body_style, :vehicle_class, :doors)
 end
-

data/lib/nhtsa_vin/validation.rb

@@ -21,7 +21,7 @@ module NhtsaVin
         @error = 'Blank VIN provided'
         return
       end
-      @vin = vin.strip
+      @vin = vin.strip.upcase
       if !regex
         @error = 'Invalid VIN format'
         return

data/lib/nhtsa_vin/version.rb

@@ -1,3 +1,3 @@
 module NhtsaVin
-  VERSION = '0.0.6'.freeze
+  VERSION = '0.0.7'.freeze
 end

data/spec/lib/nhtsa_vin/query_spec.rb

@@ -66,9 +66,30 @@ describe NhtsaVin::Query do
         expect(client.error_code).to eq 11
       end
     end
+    context 'invalid response format' do
+      before do
+        allow(client).to receive(:fetch).and_return('This is not JSON')
+        client.get
+      end
+      it 'is not valid' do
+        expect(client).not_to be_valid
+      end
+      it 'has an error message' do
+        expect(client.error).to eq 'Response is not valid JSON'
+      end
+    end
+    context 'HTTP error' do
+      it '5xx' do
+        resp = Net::HTTPServerError.new(1.1, 503, 'Service unhappy')
+        allow_any_instance_of(Net::HTTP).to receive(:request).and_return(resp)
+        client.get
+        expect(client).not_to be_valid
+        expect(client.error).to eq 'Service unhappy'
+      end
+    end
     context 'connection or network error' do
       before do
-        allow(Net::HTTP).to receive(:get_response).and_raise(Net::ReadTimeout)
+        allow_any_instance_of(Net::HTTP).to receive(:request).and_raise(Net::ReadTimeout)
         client.get
       end
       it 'should not raise' do

data/spec/lib/nhtsa_vin/validation_spec.rb

@@ -41,6 +41,10 @@ describe NhtsaVin::Validation do
         expect(NhtsaVin::Validation.new(' 4T1BD1FK5CU061770  ').valid?)
           .to be true
       end
+      it 'converts to uppercase' do
+        expect(NhtsaVin::Validation.new('4t1bd1fk5cu061770').valid?)
+          .to be true
+      end
       it 'validates BMW VINs' do
         expect(NhtsaVin::Validation.new('WBAEV534X2KM16113').valid?)
           .to be true
@@ -105,4 +109,4 @@ describe NhtsaVin::Validation do
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nhtsa_vin
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Barclay Loftus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-08 00:00:00.000000000 Z
+date: 2018-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake