nhtsa_vin 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 229a1d9a1796b76010ca429bfbb4bb8c81231f84
-  data.tar.gz: fa8190298f3a7c40c60c37cb56888f9423c18cb3
+  metadata.gz: 987b6fadc99bac8045a8288ca6effb187501f19d
+  data.tar.gz: bcdb074f6bf27055805bd9a6821446c3fed38ec6
 SHA512:
-  metadata.gz: 0d44d9bb2df77c7abc880d378a48e72700a8b75546ed454dee0bc06d17e35f2022459530ecca71ba46694a1bfcdb909ec230030e9da27623804c17ca64b38ac3
-  data.tar.gz: 852880cac552c1fa041811fd15caea7a495bb5cdd0fc38826247b99a375cbd58c1bc7283d84609c7213bca6b251905b6d04e386402dbd80a8e6971e0e80f49e4
+  metadata.gz: 28447017cd5ea2d27cf6cc684085fe2720744cc64a0f37587916574fd138c018e80c0313a694921524a53c0117163a53fd170aa86e8a73533ee5bbc11c6e2ff9
+  data.tar.gz: c82a876e940ca2aea5ae07d0f533614129b644cc7f824c571f89b543779edfac53e734729ba46274b8b4656c3b0f3a331da7398fc137ed592adcacbea938ea33

data/README.md

@@ -1,5 +1,6 @@
 # NHTSA Vin
-----
+
+[![Gem Version](https://badge.fury.io/rb/nhtsa_vin.svg)](https://badge.fury.io/rb/nhtsa_vin)
 
 A ruby gem for fetching and parsing vehicle identification via the vehicle identification number (VIN) from the [NHTSA webservice](https://vpic.nhtsa.dot.gov/api/Home). Note, this gem is not officially affiliated with the NHTSA.
 

data/lib/nhtsa_vin/query.rb

@@ -6,7 +6,7 @@ module NhtsaVin
 
     NHTSA_URL = 'https://vpic.nhtsa.dot.gov/api/vehicles/decodevin/'.freeze
 
-    attr_reader :vin, :url, :response, :raw_response
+    attr_reader :vin, :url, :response, :data, :error, :error_code, :raw_response
 
     def initialize(vin, options={})
       @vin = vin
@@ -32,8 +32,13 @@ module NhtsaVin
       # 6 - Incomplete VIN.
       # 8 - No detailed data available currently.
       # 11- Incorrect Model Year, decoded data may not be accurate!
-      @valid = (value_id_for('Error Code').to_i < 4) ? true : false
-      return unless valid?
+      @error_code = value_id_for('Error Code')&.to_i
+      @valid = (@error_code < 4) ? true : false
+
+      if @error_code != 0
+        @error = value_for('Error Code')
+      end
+      return nil unless valid?
 
       make = value_for('Make').capitalize
       model = value_for('Model')

data/lib/nhtsa_vin/version.rb

@@ -1,3 +1,3 @@
 module NhtsaVin
-  VERSION = '0.0.1'
+  VERSION = '0.0.3'
 end

data/nhtsa_vin.gemspec

@@ -6,7 +6,11 @@ Gem::Specification.new do |gem|
   gem.platform      = Gem::Platform::RUBY
 
   gem.summary       = 'A ruby library for accessing vin records from the NHTSA'
-  gem.description   = IO.read(File.join(File.dirname(__FILE__), 'README.md'))
+  gem.description   = 'A ruby gem for fetching and parsing vehicle identificationi'\
+                      'via the vehicle identification number (VIN) from the NHTSA'\
+                      'webservice. Note, this gem is not officially affiliated with'\
+                      'the NHTSA.'
+
   gem.homepage      = 'https://github.com/deliv/nhtsa_vin'
   gem.licenses      = ['MIT']
   gem.authors       = ['Barclay Loftus']

data/spec/lib/nhtsa_vin/query_spec.rb

@@ -23,7 +23,12 @@ describe NhtsaVin::Query do
         expect(client.raw_response).to eq success_response
         expect(client.valid?).to be true
       end
-
+      it 'has no error' do
+        expect(client.error).to be_nil
+      end
+      it 'has an error code of 0' do
+        expect(client.error_code).to eq 0
+      end
       context 'its response' do
         let(:response) { client.get }
         it 'returns a struct' do
@@ -36,7 +41,7 @@ describe NhtsaVin::Query do
           expect(response.body_style).to eq 'Wagon'
           expect(response.doors).to eq 4
         end
-        it 'parses out the type' do
+        it 'parses out the type enumeration' do
           expect(response.type).to eq 'Minivan'
         end
       end
@@ -54,6 +59,12 @@ describe NhtsaVin::Query do
       it 'returns nil' do
         expect(client.get).to be_nil
       end
+      it 'has an error message' do
+        expect(client.error).to eq '11- Incorrect Model Year, decoded data may not be accurate!'
+      end
+      it 'has an error code' do
+        expect(client.error_code).to eq 11
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nhtsa_vin
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Barclay Loftus
@@ -52,21 +52,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: "# NHTSA Vin\n----\n\nA ruby gem for fetching and parsing vehicle identification
-  via the vehicle identification number (VIN) from the [NHTSA webservice](https://vpic.nhtsa.dot.gov/api/Home).
-  Note, this gem is not officially affiliated with the NHTSA.\n\nPlease note, this
-  gem is currently in early development. \n\n## Installation\n\nAdd this line to your
-  application's Gemfile:\n\n```ruby\ngem 'nhsta_vin'\n```\n\nAnd then execute:\n\n
-  \   bundle\n\nOr install it yourself as:\n\n    gem install nhsta_vin\n\n## Usage\n\nUsage
-  is fairly simple. Provide a VIN, and the gem will return a struct of vehicle data.
-  \n\n```ruby\nquery = NhtsaVin.get('1J4BA5H11AL143811')\nquery.valid? # => true\nquery.response
-  # => <Struct::NhtsaResponse make=\"Jeep\", model=\"Grand Cherokee\", trim=\"Laredo/Rocky
-  Mountain Edition\", type=\"SUV\", year=\"2008\", size=nil, ... doors=4>\n```\n\nIn
-  the result no match is found, the result will be `nil`, and `#valid?` will return
-  `false`. \n\nVehicle Types\n----\n\nFor brievity, we're reducing the `Vehicle Type`
-  response to an enumerated set of `[\"Car\", \"Truck\", \"Van\", \"SUV\", \"Minivan\"]`.
-  We're doing a rough parse of the type and body style to achieve this. It's probably
-  not perfect. \n\n\n## License\n\nLicensed under the MIT License.\n"
+description: A ruby gem for fetching and parsing vehicle identificationivia the vehicle
+  identification number (VIN) from the NHTSAwebservice. Note, this gem is not officially
+  affiliated withthe NHTSA.
 email:
 - barclay@deliv.co
 executables: []