ngi_api 0.0.3 → 0.0.5

data/.gitignore

@@ -1,3 +1,4 @@
+<<<<<<< HEAD
 /.bundle/
 /.yardoc
 /Gemfile.lock
@@ -13,3 +14,39 @@
 *.a
 mkmf.log
 cacert.pem
+=======
+*.gem
+*.rbc
+/.config
+/coverage/
+/InstalledFiles
+/pkg/
+/spec/reports/
+/test/tmp/
+/test/version_tmp/
+/tmp/
+
+## Specific to RubyMotion:
+.dat*
+.repl_history
+build/
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/
+
+## Environment normalisation:
+/.bundle/
+/lib/bundler/man/
+
+# for a library or gem, you might want to ignore these files since the code is
+# intended to run in multiple environments; otherwise, check them in:
+# Gemfile.lock
+# .ruby-version
+# .ruby-gemset
+
+# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
+.rvmrc
+>>>>>>> 71defb1db547347cf4973972add9a39d23ab6fc8

data/lib/ngi_api/version.rb

@@ -1,4 +1,4 @@
 class NgiAPI
     # gem version
-    VERSION = "0.0.3"
+    VERSION = "0.0.5"
 end

data/lib/ngi_api.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 
 require "digest"
-# gem "rubyntlm", "~> 0.3.2" # no "gems" in here! Dependencies go through gemspec. 
+# gem "rubyntlm", "~> 0.3.2" # no "gems" in here! Dependencies go in gemspec. 
 require "rubyntlm"
 require "savon"
 require "net/http"
@@ -85,9 +85,9 @@ class NgiAPI
     # call-seq:
     #   MyNGIAccess.infoBts(btsID) => {...}    
     #  
-    # Obtain the exact informations about a specific BTS. btsID is a non-negative integer.
+    # Obtain the exact informations about a specific BTS. btsID is a non-negative integer, number or string
     def infoBts(btsID)
-        raise ArgumentError, "btsID value not allowed" unless btsID.to_i > 0 && btsID.class.to_s == "Fixnum"
+        raise ArgumentError, "btsID value not allowed" unless btsID.to_i > 0 && btsID.to_s[/\A[-+]?\d+\z/] === btsID.to_s # kudos to http://stackoverflow.com/a/1235990/2513430
         build_and_send_query(:info_bts,
             {
                 btsID: parameter_to_string(btsID)
@@ -125,7 +125,7 @@ class NgiAPI
     #  
     # Obtain the istat code for the town.
     def listComuni(comune)
-        raise ArgumentError, "comune is not >=2 and <= 35 in length, or has not allowed characters" unless is_valid_comune(parameter_to_string(comune))
+        raise ArgumentError, "comune is not >= 2 and <= 35 in length, or has not allowed characters" unless is_valid_comune(parameter_to_string(comune))
         build_and_send_query(:list_comuni,
             {
                 comune: parameter_to_string(comune)
@@ -173,6 +173,11 @@ class NgiAPI
         login.upcase
     end
 
+    # check if string is integer
+    def is_i?
+       /\A[-+]?\d+\z/ === self
+    end
+
     # Download the 'cacert.pem' file from "curl.haxx.se" if not found in the running directory
     # Courtesy of https://gist.github.com/fnichol/867550
     def fetch_cacert

data/spec/ngi_api_spec.rb

@@ -1,6 +1,132 @@
 require 'spec_helper'
 
-describe NgiApi do
+describe NgiAPI do
+	context 'when in test mode' do
+		
+		before :all do
+	    	@myNgiAPI = NgiAPI.new({test: true})
+		end
+
+		it 'can build a test instance' do 
+			expect(@myNgiAPI).to be_an_instance_of NgiAPI
+		end
+
+		describe '#listBts' do
+			# OKs
+			it 'returns a BtsListType' do
+				expect(@myNgiAPI.listBts[:lista_bts][:"@xsi:type"]).to eq("ns1:BtsListType")
+			end
+
+			# KOs
+			it 'sometimes returns an empty list (1 in 10)' do
+				sample = ""
+				10.times do
+					sample = @myNgiAPI.listBts[:lista_bts][:items]
+					break if sample.nil?
+				end
+				expect(sample).to be_nil
+			end
+		end
+
+		describe '#infoRadio' do
+			# OKs
+			it 'is fine with a dot separated single mac' do 
+				expect(@myNgiAPI.infoRadio('00.aA.bB.cC.dD.11')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is fine with a colon divided single mac' do 
+				expect(@myNgiAPI.infoRadio('00:aA:bB:cC:dD:11')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is fine with a dashed single mac' do 
+				expect(@myNgiAPI.infoRadio('00-aA-bB-cC-dD-11')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is fine with an unspaced single mac' do 
+				expect(@myNgiAPI.infoRadio('00aAbBcCdD11')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is fine with a mixed separated single mac' do 
+				expect(@myNgiAPI.infoRadio('00aA:bB.cC-dD-11')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is okay with a single lowercase login' do
+				expect(@myNgiAPI.infoRadio('w12345678901')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is okay with a single uppercase login' do
+				expect(@myNgiAPI.infoRadio('W12345678901')[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end
+			it 'is fine with an array of mixed values' do
+				test_array = [
+					'00.aA.bB.cC.dD.11',
+					'00-aA-bB-cC-dD-11',
+					'00aAbBcCdD11',
+					'00aA:bB.cC-dD-11',
+					'w12345678901',
+					'W12345678901'
+				]
+				expect(@myNgiAPI.infoRadio(test_array)[:info][:"@xsi:type"]).to eq("ns1:radioInfoListType")
+			end 
+
+			# KOs
+			it 'fails with a non-mac non-login value' do
+				expect{ @myNgiAPI.infoRadio('someinvalidstring') }.to raise_error(ArgumentError)
+			end
+			it 'fails with a large (> 20) array' do
+				large_test_array = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22]
+				expect{ @myNgiAPI.infoRadio(large_test_array) }.to raise_error(ArgumentError)
+			end
+			it 'fails with a mac value of 000000000000' do
+				expect{ @myNgiAPI.infoRadio('000000000000') }.to raise_error
+				expect{ @myNgiAPI.infoRadio('00.00.00.00.00.00') }.to raise_error
+				expect{ @myNgiAPI.infoRadio('00:00:00:00:00:00') }.to raise_error
+				expect{ @myNgiAPI.infoRadio('00-00-00-00-00-00') }.to raise_error
+				expect{ @myNgiAPI.infoRadio('000000:00.00-00') }.to raise_error
+			end
+			it 'fails with a login value of W00000000000' do
+				expect{ @myNgiAPI.infoRadio('W00000000000') }.to raise_error
+				expect{ @myNgiAPI.infoRadio('w00000000000') }.to raise_error
+			end
+
+		end
+
+		describe '#infoBts' do
+			# OKs
+			it 'returns sample data with a numeric param' do
+				expect( @myNgiAPI.infoBts(3)[:info_bts][:"@xsi:type"] ).to eq("ns1:BtsFullInfoType")
+			end
+
+			it 'returns sample data with a numeric string param' do
+				expect( @myNgiAPI.infoBts("3")[:info_bts][:"@xsi:type"] ).to eq("ns1:BtsFullInfoType")
+			end
+
+			# KOs
+			it 'throws an error with btsId < 1' do
+				expect{ @myNgiAPI.infoBts(0) }.to raise_error(ArgumentError)
+				expect{ @myNgiAPI.infoBts('0') }.to raise_error(ArgumentError)
+			end
+
+		end
+
+		describe '#infoCoverage' do
+
+		end
+
+		describe '#listComuni' do
+
+		end
+
+		describe '#setEthernet' do
+
+		end
+
+		describe '#rebootRadio' do
+			# OKs
+			it 'returns true'
+
+			# KOs
+			it 'throws an error if mac address is invalid'			
+			it 'returns an error if mac is all 0s or all 1s'
+		end
+	end
+
+
+
 #  subject { NgiApi.new }
 
 #  describe '#process' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ngi_api
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-25 00:00:00.000000000 Z
+date: 2015-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler