nfl_data 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 20602999e287b633dfc6351d01e33a834a1df252
-  data.tar.gz: a62ef29bef9b64b1447d6914b433039c6f1fc1a3
+  metadata.gz: 9fd1960572c8ad1676477b259f550f616665d587
+  data.tar.gz: 23369e62b15791b7885d8b21ab5ab85a9c2cab04
 SHA512:
-  metadata.gz: 445d8ac1df6b875dc53097db63ac7c9135e18ea57ad7ce3e16fbe57f70ee295dde7bfb9e61a8ae70eaa08f742f9fab203777d8eec0946025a8e6c66e6a01d228
-  data.tar.gz: 74164f1e2c0b8e0d8e37cf1c189d6cc19bfc7d79fb6bb2a59b147b043c9375359299f1112b4eed1f02b8c186810f58a01c909ca7356de95286f12a92fcc4d0d6
+  metadata.gz: 393b22f179d6c5eb1d7e986d727e634ba647fdd8534bdc6a40f00e9e8ec0a33837f5a795f264d8966e3db74f523c3291ce10e386e09a3215cd18dfbd588ff653
+  data.tar.gz: 3473ede86be3f67842d75ba6fe118d70625781e71bb8bd1cf555908722bfe4bc62815fad05466cfdeb30b26e5871a1bc6c97cc402877a79e9b1c1ca3872b4798

data/lib/nfl_data.rb

@@ -8,6 +8,7 @@ require 'nfl_data/models/player'
 require 'nfl_data/models/statline'
 require 'nfl_data/models/team'
 
+require 'nfl_data/parsers/parser_helper'
 require 'nfl_data/parsers/player_parser'
 require 'nfl_data/parsers/statline_parser'
 require 'nfl_data/parsers/team_parser'

data/lib/nfl_data/models/team.rb

@@ -22,14 +22,13 @@ module NflData
       end
 
       class Game
-        attr_accessor :week, :opponent, :date, :time, :home_game
+        attr_accessor :week, :opponent, :date, :home_game
 
         def to_hash
           {
             week: week,
             opponent: opponent,
             date: date,
-            time: time,
             home_game: home_game
           }
         end

data/lib/nfl_data/parsers/parser_helper.rb

@@ -0,0 +1,6 @@
+module ParserHelper
+  def make_jacksonville_abbreviation_consistent(team_name)
+    # Use JAX because schedule pages use JAX and it's easier to fix it here
+    team_name == 'JAC' ? 'JAX' : team_name
+  end
+end

data/lib/nfl_data/parsers/player_parser.rb

@@ -1,5 +1,7 @@
 module NflData
   class PlayerParser
+    include ParserHelper
+
     attr_reader :base_url
 
     def initialize
@@ -65,7 +67,7 @@ module NflData
         player.number = elements[1].inner_text.strip
         name = elements[2].inner_text.strip
         player.status = elements[3].inner_text.strip
-        player.team = elements[12].inner_text.strip
+        player.team = make_jacksonville_abbreviation_consistent(elements[12].inner_text.strip)
 
         #Get NFL.com Unique player id
         player.nfl_player_id = elements[2].to_s.split('/')[3]

data/lib/nfl_data/parsers/team_parser.rb

@@ -1,5 +1,7 @@
 module NflData
   class TeamParser
+    include ParserHelper
+
     attr_reader :base_url
 
     def initialize
@@ -32,19 +34,13 @@ module NflData
       team_links.map do |link|
         team = Team.new
         team.name = link.inner_text.strip
-        team.short_name = link.attribute('href').value.scan(/=(.*)/).flatten.first
-        make_jacksonville_abbreviation_consistent(team)
+        team.short_name = make_jacksonville_abbreviation_consistent(link.attribute('href').value.scan(/=(.*)/).flatten.first)
         team.schedule = get_schedule(team, year) if with_schedule
 
         team.to_hash
       end
     end
 
-    def make_jacksonville_abbreviation_consistent(team)
-      # Use JAX because schedule pages use JAX and it's easier to fix it here
-      team.short_name = 'JAX' if team.short_name == 'JAC'
-    end
-
     def get_schedule(team, year)
       url = "http://www.nfl.com/teams/schedule?seasonType=REG&team=#{team.short_name}&season=#{year}"
       schedule = Team::Schedule.new
@@ -54,9 +50,13 @@ module NflData
       tables = doc.search('table.data-table1')
 
       tables.each do |table|
+        # Skip any empty tables. They put these in between post season and regular seasons game tables
+        next if table.children.count <= 1
         title = table.search('tr.thd1 td')
 
-        if title.inner_text.strip == 'Regular Season'
+        # Need to check for the Regular Season table and a table with no title
+        # because during the season the NFl splits the games between 2 tables
+        if ['Regular Season', ''].include?(title.inner_text.strip)
           weeks = table.search('tr.tbdy1')
 
           weeks.each do |week|
@@ -64,7 +64,6 @@ module NflData
             elements = week.search('td')
             game.week = elements[0].inner_text.strip
             game.date = elements[1].inner_text.strip
-            game.time = elements[3].nil? ? nil : elements[3].inner_text.strip
             participants = elements[2].search('a')
             game.opponent = get_opponent(team, participants)
             game.home_game = home_game?(team, participants)

data/lib/nfl_data/version.rb

@@ -1,3 +1,3 @@
 module NflData
-  VERSION = '0.0.9'
+  VERSION = '0.0.10'
 end

data/test/nfl_data/parsers/player_parser_test.rb

@@ -19,7 +19,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:quarterbacks)
 
         response.keys.must_include :quarterbacks
-        response[:quarterbacks].count.must_equal 121
+        response[:quarterbacks].count.must_equal 123
       end
     end
 
@@ -28,7 +28,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:runningbacks)
 
         response.keys.must_include :runningbacks
-        response[:runningbacks].count.must_equal 231
+        response[:runningbacks].count.must_equal 245
       end
     end
 
@@ -37,7 +37,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:wide_receivers)
 
         response.keys.must_include :wide_receivers
-        response[:wide_receivers].count.must_equal 372
+        response[:wide_receivers].count.must_equal 398
       end
     end
 
@@ -46,7 +46,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:tight_ends)
 
         response.keys.must_include :tight_ends
-        response[:tight_ends].count.must_equal 190
+        response[:tight_ends].count.must_equal 206
       end
     end
 
@@ -55,15 +55,26 @@ describe PlayerParser do
         response = @parser.get_by_position(:all)
 
         {
-          quarterbacks: 121,
-          runningbacks: 231,
-          wide_receivers: 372,
-          tight_ends: 190
+          quarterbacks: 123,
+          runningbacks: 245,
+          wide_receivers: 398,
+          tight_ends: 206
         }.each do |position, player_count|
           response.keys.must_include position
           response[position].count.must_equal player_count
         end
       end
     end
+
+    it 'should use JAX as Jacksonville abbreviation for all JAX team players' do
+      VCR.use_cassette('all_players') do
+        response = @parser.get_by_position(:all)
+
+        players = [response[:quarterbacks], response[:runningbacks], response[:wide_receivers], response[:tight_ends]].flatten
+
+        players.any? {|player| player[:team] == 'JAX'}.must_equal true
+        players.none? {|player| player[:team] == 'JAC'}.must_equal true
+      end
+    end
   end
 end

data/test/nfl_data/parsers/team_parser_test.rb

@@ -32,7 +32,9 @@ describe TeamParser do
 
     it 'should use JAX as the abbreviation for Jacksonville' do
       VCR.use_cassette('teams_with_schedule') do
-        @parser.get_by_year(2014, true).any? {|team| team[:short_name] == 'JAX'}.must_equal true
+        result = @parser.get_by_year(2014, true)
+        result.any? {|team| team[:short_name] == 'JAX'}.must_equal true
+        result.none? {|team| team[:short_name] == 'JAC'}.must_equal true
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nfl_data
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - thetizzo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -115,6 +115,7 @@ files:
 - lib/nfl_data/models/player.rb
 - lib/nfl_data/models/statline.rb
 - lib/nfl_data/models/team.rb
+- lib/nfl_data/parsers/parser_helper.rb
 - lib/nfl_data/parsers/player_parser.rb
 - lib/nfl_data/parsers/statline_parser.rb
 - lib/nfl_data/parsers/team_parser.rb