nfl_data 0.0.10 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9fd1960572c8ad1676477b259f550f616665d587
-  data.tar.gz: 23369e62b15791b7885d8b21ab5ab85a9c2cab04
+SHA256:
+  metadata.gz: e8aae3b48befa5e49a3400e2e4955cca323f7e3ed4aa7e4ecd17d888eea7029c
+  data.tar.gz: 9e03e003f759db815c8d8be2eca6592ce610fa1148b709f8156002ffe86a26a7
 SHA512:
-  metadata.gz: 393b22f179d6c5eb1d7e986d727e634ba647fdd8534bdc6a40f00e9e8ec0a33837f5a795f264d8966e3db74f523c3291ce10e386e09a3215cd18dfbd588ff653
-  data.tar.gz: 3473ede86be3f67842d75ba6fe118d70625781e71bb8bd1cf555908722bfe4bc62815fad05466cfdeb30b26e5871a1bc6c97cc402877a79e9b1c1ca3872b4798
+  metadata.gz: 10f022e51cec852029038277ffeaff0887946bb44129ee309e32329f427cea141980fbb5f98d34d5cd9feca1c7537c8f7367e7497546fa5a738b93e1ef618e47
+  data.tar.gz: 73788afad7732273a27f4daf8f66028b0baf7b96b0f66a15a6174a73c16778775647712ac3b1f69f67ddb57dd91d8c1ec0d2b27bae836fe89fec357dacd05a64

data/.envrc

@@ -0,0 +1,7 @@
+# Load .env variables automatically with direnv
+# http://direnv.net/
+
+if [ -e ./.env ]
+then
+  dotenv
+fi

data/.gitignore

@@ -12,14 +12,14 @@ lib/bundler/man
 pkg
 rdoc
 spec/reports
-test/tmp
-test/version_tmp
 tmp
 *.bundle
 *.so
 *.o
 *.a
 mkmf.log
-test/fixtures/cassettes
 .ruby-version
 .ruby-gemset
+spec/examples.txt
+spec/cassettes
+.env

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/.standard.yml

@@ -0,0 +1,2 @@
+parallel: true
+format: progress

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+cache: bundler
+rvm:
+  - 2.7
+  - 2.6
+  - 2.5

data/CHANGELOG.md

@@ -0,0 +1,7 @@
+## 0.1.0 / 2020-08-31
+
+* No more NFL.com parsing, using MySportsFeeds API instead. This will require users to acquire their own MySportsFeeds accounts and API tokens. Please see the README or [the MySportsFeeds website](https://www.mysportsfeeds.com for more details.
+
+## 0.0.14 and previous
+
+* This version and previous used Nokogiri to parse NFL.com. NFL has since changed their website and broken all of the parsing code. Any version before here probably won't work and should be upgraded.

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in nfl_data.gemspec
 gemspec

data/README.md

@@ -1,11 +1,21 @@
 # NflData
 
-This gem is for parsing data from NFL.com and returning a JSON blob that can be used for any fantasy related activities you may wish to pursue.
+This gem is for parsing data from NFL.com and returning a JSON blob that can be used
+for any fantasy related activities you may wish to pursue.
 
-This was written by @mikesells and @thetizzo
+**However** since NFL.com has updated their website to a much more difficult to parse version,
+this gem is now going to be using [MySportsFeeds API](https://www.mysportsfeeds.com/data-feeds/) instead.
+
+Thanks to the people at [MySportsFeeds](https://www.mysportsfeeds.com) for providing an affordable
+service for this type of data.  If you would like to use this gem I encourage you to head over to their
+website and sign up for an account.
+
+This gem was written by @mikesells and @thetizzo
 
 [![Gem Version](https://badge.fury.io/rb/nfl_data.svg)](http://badge.fury.io/rb/nfl_data)
 
+[![Build Status](https://travis-ci.com/thetizzo/nfl_data.svg?branch=master)](https://travis-ci.com/thetizzo/nfl_data)
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -20,24 +30,56 @@ Or install it yourself as:
 
     $ gem install nfl_data
 
-## Usage
+## Configuration
 
-To use this gem there are some simple calls that can be made.  Everything should return JSON.
+Configuration for [MySportsFeeds API](https://www.mysportsfeeds.com/data-feeds/) credentials
+can be set with the following Environment Variables:
 
-### Players
+```
+MYSPORTSFEEDS_API_KEY
+MYSPORTSFEEDS_API_HOST
+MYSPORTSFEEDS_API_VERSION
+```
 
-Pull players by position:
+### MySportsFeeds API Docs
 
-```ruby
-  NflData::API::Player.get_all
+https://www.mysportsfeeds.com/data-feeds/api-docs/
 
-  NflData::API::Player.get_quarterbacks
+I've written this to use >= v2.1 of the MSF API.
 
-  NflData::API::Player.get_runningbacks
+## Usage
 
-  NflData::API::Player.get_wide_receivers
+To use this gem there are some simple calls that can be made.  Everything will return JSON.
+
+### Players
 
-  NflData::API::Player.get_tight_ends
+Pull players by position. Not passing a position param will pull all players.
+
+Position param is passed through to MySportsFeeds and can be any value they accept.  Please see
+their docs above.
+
+```ruby
+  NflData::API::Player.new.players(position: "qb")
+```
+
+#### Example Response
+
+```json
+{
+  "players": [
+    {
+      "first_name": "John",
+      "last_name": "Elway",
+      "full_name": "John Elway",
+      "position": "QB",
+      "number": 7,
+      "team": "DEN",
+      "msf_player_id": 12345,
+      "image_source":""
+    },
+    ...
+  ]
+}
 ```
 
 ### Statlines
@@ -45,21 +87,52 @@ Pull players by position:
 Pull statlines by week and year:
 
 ```ruby
-  NflData::API::Statline.get_passing(1, 2014)
-
-  NflData::API::Statline.get_rushing(1, 2014)
-
-  NflData::API::Statline.get_receiving(1, 2014)
+  NflData::API::Statline.new.statlines(year: 2020, week: 1)
 ```
 
-### Teams
+#### Example Response
+
+```json
+{
+  "statlines": [
+    {
+      "rush_atts": 2,
+      "rush_yards": 11,
+      "rush_tds": 1,
+      "fumbles": 0,
+      "pass_comp": 11,
+      "pass_att": 23,
+      "pass_yards": 123,
+      "pass_tds": 2,
+      "ints": 1,
+      "qb_rating": 92.6,
+      "receptions": 3,
+      "rec_yards": 10,
+      "rec_tds": 0,
+      "msf_game_id": 51465,
+      "msf_player_id": 6826
+    }
+    ...
+  ]
+}
+```
 
-Pull teams by year with or without schedules:
+### Schedule
 
+Pull season schedule by year:
 ```ruby
-  NflData::API::Team.get_all(2014)
+  NflData::Api::Schedule.new.season(year: 2020)
+```
+
+#### Example Response
 
-  NflData::API::Team.get_all_with_schedule(2014)
+```json
+{
+  "games": [
+    {"week":1,"away_team":"HOU","home_team":"KC","start_time":"2020-09-10T04:25:00.000Z"}
+    ...
+  ]
+}
 ```
 
 ## Contributing

data/Rakefile

@@ -1,8 +1,7 @@
-require 'bundler/gem_tasks'
+require "bundler/gem_tasks"
+require "standard/rake"
+require "rspec/core/rake_task"
 
-require 'rake/testtask'
+RSpec::Core::RakeTask.new(:spec)
 
-Rake::TestTask.new do |t|
-  t.libs << 'test'
-  t.pattern = "test/**/*_test.rb"
-end
+task default: [:spec, :standard]

data/bin/console

@@ -5,4 +5,4 @@ require 'irb'
 require 'irb/completion'
 require 'nfl_data'
 
-IRB.start
+IRB.start(__FILE__)

data/bin/setup

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/lib/nfl_data.rb

@@ -1,21 +1,13 @@
-require 'nfl_data/version'
-
-require 'nokogiri'
-require 'open-uri'
-require 'json'
-
-require 'nfl_data/models/player'
-require 'nfl_data/models/statline'
-require 'nfl_data/models/team'
-
-require 'nfl_data/parsers/parser_helper'
-require 'nfl_data/parsers/player_parser'
-require 'nfl_data/parsers/statline_parser'
-require 'nfl_data/parsers/team_parser'
-
-require 'nfl_data/api/player'
-require 'nfl_data/api/statline'
-require 'nfl_data/api/team'
+require "nokogiri"
+require "open-uri"
+require "json"
+require "typhoeus"
+require "base64"
+require "zeitwerk"
+
+loader = Zeitwerk::Loader.for_gem
+loader.collapse("lib/nfl_data/models")
+loader.setup
 
 module NflData
 end

data/lib/nfl_data/api/player.rb

@@ -1,39 +1,17 @@
 module NflData
-  module API
+  module Api
     class Player
+      attr_reader :parser, :feed
 
-      def initialize
-        @parser = PlayerParser.new
+      def initialize(parser: Parsers::PlayerParser.new, feed: MySportsFeeds::PlayersFeed.new)
+        @parser = parser
+        @feed = feed
       end
 
-      def get(position)
-        @parser.get_by_position(position).to_json
+      def players(position: nil)
+        player_data = feed.feed(position: position)
+        {players: parser.parse(player_data: player_data).map(&:to_h)}.to_json
       end
-
-      class << self
-
-        def get_all
-          self.new.get(:all)
-        end
-
-        def get_quarterbacks
-          self.new.get(:quarterbacks)
-        end
-
-        def get_runningbacks
-          self.new.get(:runningbacks)
-        end
-
-        def get_wide_receivers
-          self.new.get(:wide_receivers)
-        end
-
-        def get_tight_ends
-          self.new.get(:tight_ends)
-        end
-
-      end
-
     end
   end
 end

data/lib/nfl_data/api/schedule.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module NflData
+  module Api
+    class Schedule
+      attr_reader :parser, :feed
+
+      def initialize(parser: Parsers::ScheduleParser.new, feed: MySportsFeeds::SeasonalGamesFeed.new)
+        @parser = parser
+        @feed = feed
+      end
+
+      def season(year:)
+        schedule_data = feed.feed(season_start_year: year)
+        parser.parse(schedule_data: schedule_data).to_h.to_json
+      end
+    end
+  end
+end

data/lib/nfl_data/api/statline.rb

@@ -1,31 +1,16 @@
 module NflData
-  module API
+  module Api
     class Statline
+      attr_reader :parser, :feed
 
-      def initialize
-        @parser = StatlineParser.new
+      def initialize(parser: Parsers::StatlineParser.new, feed: MySportsFeeds::WeeklyPlayerGamelogs.new)
+        @parser = parser
+        @feed = feed
       end
 
-      def get(week, year, stat_type)
-        @parser.get(week, year, stat_type).to_json
-      end
-
-      class << self
-        def get_all(week, year)
-          self.new.get(week, year, :all)
-        end
-
-        def get_passing(week, year)
-          self.new.get(week, year, :passing)
-        end
-
-        def get_rushing(week, year)
-          self.new.get(week, year, :rushing)
-        end
-
-        def get_receiving(week, year)
-          self.new.get(week, year, :receiving)
-        end
+      def statlines(year:, week:)
+        statline_data = feed.feed(season_start_year: year, week: week)
+        {statlines: parser.parse(statline_data: statline_data).map(&:to_h)}.to_json
       end
     end
   end

data/lib/nfl_data/models/game.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module NflData
+  Game = Struct.new(:week, :away_team, :home_team, :start_time, keyword_init: true)
+end

data/lib/nfl_data/models/player.rb

@@ -1,21 +1,13 @@
 module NflData
-
-  class Player
-    attr_accessor :first_name, :last_name, :full_name, :position, :number, :status, :team, :nfl_player_id
-
-    def to_hash
-      {
-        first_name: first_name,
-        last_name: last_name,
-        full_name: full_name,
-        position: position,
-        number: number,
-        status: status,
-        team: team,
-        nfl_player_id: nfl_player_id
-      }
-    end
-
-  end
-
+  Player = Struct.new(
+    :first_name,
+    :last_name,
+    :full_name,
+    :position,
+    :number,
+    :team,
+    :msf_player_id,
+    :image_source,
+    keyword_init: true
+  )
 end

data/lib/nfl_data/models/schedule.rb

@@ -0,0 +1,12 @@
+module NflData
+  Schedule = Struct.new(:games, keyword_init: true) {
+    def initialize(games: [])
+      super
+    end
+
+    def to_h
+      games.map!(&:to_h)
+      super
+    end
+  }
+end