nfl_data 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fd1960572c8ad1676477b259f550f616665d587
-  data.tar.gz: 23369e62b15791b7885d8b21ab5ab85a9c2cab04
+  metadata.gz: fde80abd92b5afed0b3c16a9cd3d687387380bd5
+  data.tar.gz: f904cf0f9158c3996494aff4864f1ab3767daa59
 SHA512:
-  metadata.gz: 393b22f179d6c5eb1d7e986d727e634ba647fdd8534bdc6a40f00e9e8ec0a33837f5a795f264d8966e3db74f523c3291ce10e386e09a3215cd18dfbd588ff653
-  data.tar.gz: 3473ede86be3f67842d75ba6fe118d70625781e71bb8bd1cf555908722bfe4bc62815fad05466cfdeb30b26e5871a1bc6c97cc402877a79e9b1c1ca3872b4798
+  metadata.gz: 6e7d173e1e01bdf293fda1ad9c5c495bb6d7a3f4d5ee0382a680e411241450aaf0c6c762aeb7334a48ec6f403de1e702ceeec7981d29b5478123f9dac38b415e
+  data.tar.gz: fd76a8e7240ae7b46e4c5b084c52138f11eb671de0ae7d8115d926a205e510636563d670e3291ec138e68688e1e594e134baeb729fc57c200944f1059528b365

data/.codeclimate.yml

@@ -0,0 +1,5 @@
+engines:
+  rubocop:
+    enabled: true
+  bundler-audit:
+    enabled: true

data/.rubocop.yml

@@ -0,0 +1,2 @@
+Style/Documentation:
+  Enabled: false

data/README.md

@@ -5,6 +5,7 @@ This gem is for parsing data from NFL.com and returning a JSON blob that can be
 This was written by @mikesells and @thetizzo
 
 [![Gem Version](https://badge.fury.io/rb/nfl_data.svg)](http://badge.fury.io/rb/nfl_data)
+[![Code Climate](https://codeclimate.com/github/thetizzo/nfl_data/badges/gpa.svg)](https://codeclimate.com/github/thetizzo/nfl_data)
 
 ## Installation
 

data/Rakefile

@@ -4,5 +4,5 @@ require 'rake/testtask'
 
 Rake::TestTask.new do |t|
   t.libs << 'test'
-  t.pattern = "test/**/*_test.rb"
+  t.pattern = 'test/**/*_test.rb'
 end

data/lib/nfl_data/api/player.rb

@@ -1,7 +1,6 @@
 module NflData
   module API
     class Player
-
       def initialize
         @parser = PlayerParser.new
       end
@@ -11,29 +10,26 @@ module NflData
       end
 
       class << self
-
         def get_all
-          self.new.get(:all)
+          new.get(:all)
         end
 
         def get_quarterbacks
-          self.new.get(:quarterbacks)
+          new.get(:quarterbacks)
         end
 
         def get_runningbacks
-          self.new.get(:runningbacks)
+          new.get(:runningbacks)
         end
 
         def get_wide_receivers
-          self.new.get(:wide_receivers)
+          new.get(:wide_receivers)
         end
 
         def get_tight_ends
-          self.new.get(:tight_ends)
+          new.get(:tight_ends)
         end
-
       end
-
     end
   end
 end

data/lib/nfl_data/api/statline.rb

@@ -1,7 +1,6 @@
 module NflData
   module API
     class Statline
-
       def initialize
         @parser = StatlineParser.new
       end
@@ -12,19 +11,19 @@ module NflData
 
       class << self
         def get_all(week, year)
-          self.new.get(week, year, :all)
+          new.get(week, year, :all)
         end
 
         def get_passing(week, year)
-          self.new.get(week, year, :passing)
+          new.get(week, year, :passing)
         end
 
         def get_rushing(week, year)
-          self.new.get(week, year, :rushing)
+          new.get(week, year, :rushing)
         end
 
         def get_receiving(week, year)
-          self.new.get(week, year, :receiving)
+          new.get(week, year, :receiving)
         end
       end
     end

data/lib/nfl_data/api/team.rb

@@ -1,7 +1,6 @@
 module NflData
   module API
     class Team
-
       def initialize
         @parser = TeamParser.new
       end
@@ -11,15 +10,13 @@ module NflData
       end
 
       class << self
-
         def get_all(year)
-          self.new.get(year)
+          new.get(year)
         end
 
         def get_all_with_schedule(year)
-          self.new.get(year, true)
+          new.get(year, true)
         end
-
       end
     end
   end

data/lib/nfl_data/models/player.rb

@@ -1,21 +1,20 @@
 module NflData
-
   class Player
-    attr_accessor :first_name, :last_name, :full_name, :position, :number, :status, :team, :nfl_player_id
+    ATTRIBUTES = [
+      :first_name, :last_name, :full_name, :position, :number,
+      :status, :team, :nfl_player_id, :picture_link
+    ]
 
-    def to_hash
-      {
-        first_name: first_name,
-        last_name: last_name,
-        full_name: full_name,
-        position: position,
-        number: number,
-        status: status,
-        team: team,
-        nfl_player_id: nfl_player_id
-      }
+    attr_accessor(*ATTRIBUTES)
+
+    def initialize(attributes = {})
+      attributes.each { |attr, value| send("#{attr}=", value) }
     end
 
+    def to_hash
+      attributes_hash = {}
+      ATTRIBUTES.each { |attr| attributes_hash.merge!(attr => send(attr)) }
+      attributes_hash
+    end
   end
-
 end

data/lib/nfl_data/models/statline.rb

@@ -1,30 +1,21 @@
 module NflData
-
   class Statline
-    attr_accessor :week, :year, :rush_atts, :rush_yards, :rush_tds, :fumbles,
-      :pass_comp, :pass_att, :pass_yards, :pass_tds, :ints, :qb_rating, :receptions,
-      :rec_yards, :rec_tds, :nfl_player_id, :sacks
+    ATTRIBUTES = [
+      :week, :year, :rush_atts, :rush_yards, :rush_tds, :fumbles, :pass_comp,
+      :pass_att, :pass_yards, :pass_tds, :ints, :qb_rating, :receptions,
+      :rec_yards, :rec_tds, :nfl_player_id
+    ]
+
+    attr_accessor(*ATTRIBUTES)
+
+    def initialize(attributes = {})
+      attributes.each { |attr, value| send("#{attr}=", value) }
+    end
 
     def to_hash
-      {
-        nfl_player_id: nfl_player_id,
-        week: week,
-        year: year,
-        rush_atts: rush_atts,
-        rush_yards: rush_yards,
-        rush_tds: rush_tds,
-        fumbles: fumbles,
-        pass_comp: pass_comp,
-        pass_att: pass_att,
-        pass_yards: pass_yards,
-        pass_tds: pass_tds,
-        ints: ints,
-        qb_rating: qb_rating,
-        receptions: receptions,
-        rec_yards: rec_yards,
-        rec_tds: rec_tds
-      }
+      attributes_hash = {}
+      ATTRIBUTES.each { |attr| attributes_hash.merge!(attr => send(attr)) }
+      attributes_hash
     end
   end
-
 end

data/lib/nfl_data/models/team.rb

@@ -18,7 +18,7 @@ module NflData
       end
 
       def to_hash
-        @games.map { |game| game.to_hash }
+        @games.map(&:to_hash)
       end
 
       class Game
@@ -33,7 +33,6 @@ module NflData
           }
         end
       end
-
     end
   end
 end

data/lib/nfl_data/parsers/player_parser.rb

@@ -5,84 +5,80 @@ module NflData
     attr_reader :base_url
 
     def initialize
-      @base_url = "http://www.nfl.com/players/search?category=position&conferenceAbbr=null&playerType=current&conference=ALL&filter="
+      @base_url = 'http://www.nfl.com/players/search?category=position&conferenceAbbr=null&playerType=current&conference=ALL&filter='
     end
 
     def get_by_position(position)
-      case position
-      when :quarterbacks
-        { position => get('quarterback') }
-      when :runningbacks
-        { position => get('runningback') }
-      when :wide_receivers
-        { position => get('widereceiver') }
-      when :tight_ends
-        { position => get('tightend') }
-      when :all
+      if position == :all
         {
           quarterbacks: get('quarterback'),
           runningbacks: get('runningback'),
           wide_receivers: get('widereceiver'),
           tight_ends: get('tightend')
         }
+      else
+        # We have to remove the '_' and 's' because the NFL url has
+        # singular position names and all are one word.
+        { position => get(position.to_s.gsub(/s|_/, '')) }
       end
     end
 
     private
 
     def get(position)
-      baseurl = @base_url + position
-      url = baseurl
-      returnVal = []
-      page_num = 1
-
-      count = 100
+      page_number = 1
+      url = "#{@base_url}#{position}&d-447263-p=#{page_number}"
+      return_val = []
 
       loop do
-        page_num += 1
         players_found = update_or_create_players(url)
-        returnVal.push(players_found[1])
+        return_val.push(players_found[1])
         break if players_found[0] == 0
-        url = baseurl + '&d-447263-p='
-        url += page_num.to_s
+        url = url.chomp(page_number.to_s)
+        page_number += 1
+        url += page_number.to_s
       end
 
-      returnVal.flatten.map{ |player| player.to_hash }
+      return_val.flatten.map(&:to_hash)
     end
 
     def update_or_create_players(url)
-      # puts "Pulling from url = #{url}"
       doc = open(url) { |f| Nokogiri(f) }
 
-      #NFL.com stores players in 2 types of rows. Class = Odd or Even. This pulls them all.
-      odds = doc.search("tr.odd")
-      evens = doc.search("tr.even")
-
-      all = odds + evens
-
-      players = all.map do |p|
-        player = Player.new
-        elements = p.search("td")
-        player.position = elements[0].inner_text.strip
-        player.number = elements[1].inner_text.strip
-        name = elements[2].inner_text.strip
-        player.status = elements[3].inner_text.strip
-        player.team = make_jacksonville_abbreviation_consistent(elements[12].inner_text.strip)
-
-        #Get NFL.com Unique player id
-        player.nfl_player_id = elements[2].to_s.split('/')[3]
-
-        names = name.split(',')
-
-        player.first_name = names[1].strip
-        player.last_name = names[0].strip
-
-        player.full_name = [player.first_name, player.last_name].join(' ')
-        player
-      end
-
+      # NFL.com stores players in 2 types of rows.
+      # css class = odd or even.
+      all_rows = doc.search('tr.odd') + doc.search('tr.even')
+      players = all_rows.map { |row| parse_player_from_row(row.search('td')) }
       [players.count, players]
     end
 
+    def parse_player_from_row(elements)
+      # Get NFL.com Unique player id
+      nfl_player_id = elements[2].to_s.split('/')[3]
+
+      # player id is the only one with complicated parsing so we
+      # can just extract the inner text out of the rest of the elements
+      elements = elements.map(&:inner_text).map(&:strip)
+      names = elements[2].split(',').map(&:strip).reverse
+
+      Player.new(
+        nfl_player_id: nfl_player_id,
+        position: elements[0],
+        number: elements[1],
+        status: elements[3],
+        team: make_jacksonville_abbreviation_consistent(elements[12]),
+        first_name: names[0],
+        last_name: names[1],
+        full_name: names.join(' '),
+        picture_link: get_picture_link(nfl_player_id, names[0], names[1])
+      )
+    end
+
+    def get_picture_link(nfl_player_id, first_name, last_name)
+      return nil if ENV['NFL_DATA_ENV'] == 'test'
+      url = "http://www.nfl.com/player/#{first_name.gsub(/\s/, '')}#{last_name.gsub(/\s/, '')}/#{nfl_player_id}/profile"
+      doc = open(url) { |f| Nokogiri(f) }
+      doc.search('div.player-photo img').first.attributes['src'].value
+    end
   end
 end

data/lib/nfl_data/parsers/statline_parser.rb

@@ -1,6 +1,5 @@
 module NflData
   class StatlineParser
-
     def initialize
     end
 
@@ -18,8 +17,9 @@ module NflData
     private
 
     def get_player_id_from_profile_url(element)
-      old_url = "http://nfl.com" + element.search('a').first.attributes['href'].value
-      new_url = ""
+      old_url = 'http://nfl.com' +
+                element.search('a').first.attributes['href'].value
+      new_url = ''
 
       begin
         open(old_url) do |resp|
@@ -29,26 +29,22 @@ module NflData
         return nil
       end
 
-      new_url.gsub("http://www.nfl.com","").to_s.split('/')[3]
+      new_url.gsub('http://www.nfl.com', '').to_s.split('/')[3]
     end
 
     def grab_week(weeknum, year, stat_type)
-      baseUrl = "http://www.nfl.com/stats/weeklyleaders?type=REG"
-      weekUrl = "&week="
-      seasonUrl = "&season=" + year.to_s
-      catUrl = "&showCategory="
-
-      url = baseUrl + weekUrl + weeknum.to_s + seasonUrl + catUrl + stat_type
+      url = 'http://www.nfl.com/stats/weeklyleaders?type=REG' \
+                 "&week=#{weeknum}&season=#{year}&showCategory=#{stat_type}"
 
       doc = open(url) { |f| Nokogiri(f) }
 
-      odds = doc.search("tr.odd")
-      evens = doc.search("tr.even")
+      odds = doc.search('tr.odd')
+      evens = doc.search('tr.even')
 
       all = odds + evens
 
       all.map do |player_row|
-        elements = player_row.search("td")
+        elements = player_row.search('td')
 
         statline = Statline.new
 
@@ -56,21 +52,20 @@ module NflData
         statline.week = weeknum
         statline.year = year
 
-        if (stat_type == 'Rushing')
+        if stat_type == 'Rushing'
           statline.rush_atts = elements[4].inner_text.strip
           statline.rush_yards = elements[5].inner_text.strip
           statline.rush_tds = elements[7].inner_text.strip
           statline.fumbles = elements[8].inner_text.strip
-        elsif (stat_type == 'Passing')
+        elsif stat_type == 'Passing'
           statline.pass_comp = elements[4].inner_text.strip
           statline.pass_att = elements[5].inner_text.strip
           statline.pass_yards = elements[6].inner_text.strip
           statline.pass_tds = elements[7].inner_text.strip
           statline.ints = elements[8].inner_text.strip
-          statline.sacks = elements[9].inner_text.strip
           statline.qb_rating = elements[11].inner_text.strip
           statline.fumbles = elements [10].inner_text.strip
-        elsif (stat_type == 'Receiving')
+        elsif stat_type == 'Receiving'
           statline.receptions = elements[4].inner_text.strip
           statline.rec_yards = elements[5].inner_text.strip
           statline.rec_tds = elements[7].inner_text.strip

data/lib/nfl_data/parsers/team_parser.rb

@@ -5,7 +5,7 @@ module NflData
     attr_reader :base_url
 
     def initialize
-      @base_url = "http://www.nfl.com/standings?category=league&split=Overall&season="
+      @base_url = 'http://www.nfl.com/standings?category=league&split=Overall&season='
     end
 
     def get_by_year(year, with_schedule)
@@ -27,14 +27,15 @@ module NflData
         if href.nil?
           true
         else
-          !href.value.start_with?("/teams/profile?team=")
+          !href.value.start_with?('/teams/profile?team=')
         end
       end
 
       team_links.map do |link|
         team = Team.new
         team.name = link.inner_text.strip
-        team.short_name = make_jacksonville_abbreviation_consistent(link.attribute('href').value.scan(/=(.*)/).flatten.first)
+        short_name = link.attribute('href').value.scan(/=(.*)/).flatten.first
+        team.short_name = make_jacksonville_abbreviation_consistent(short_name)
         team.schedule = get_schedule(team, year) if with_schedule
 
         team.to_hash
@@ -42,7 +43,9 @@ module NflData
     end
 
     def get_schedule(team, year)
-      url = "http://www.nfl.com/teams/schedule?seasonType=REG&team=#{team.short_name}&season=#{year}"
+      url = 'http://www.nfl.com/teams/schedule?seasonType=REG&' \
+            "team=#{team.short_name}&season=#{year}"
+
       schedule = Team::Schedule.new
 
       doc = open(url) { |f| Nokogiri(f) }
@@ -50,25 +53,25 @@ module NflData
       tables = doc.search('table.data-table1')
 
       tables.each do |table|
-        # Skip any empty tables. They put these in between post season and regular seasons game tables
+        # Skip any empty tables. They put these in between post season
+        # and regular seasons game tables
         next if table.children.count <= 1
         title = table.search('tr.thd1 td')
 
         # Need to check for the Regular Season table and a table with no title
         # because during the season the NFl splits the games between 2 tables
-        if ['Regular Season', ''].include?(title.inner_text.strip)
-          weeks = table.search('tr.tbdy1')
-
-          weeks.each do |week|
-            game = Team::Schedule::Game.new
-            elements = week.search('td')
-            game.week = elements[0].inner_text.strip
-            game.date = elements[1].inner_text.strip
-            participants = elements[2].search('a')
-            game.opponent = get_opponent(team, participants)
-            game.home_game = home_game?(team, participants)
-            schedule.games << game
-          end
+        next unless ['Regular Season', ''].include?(title.inner_text.strip)
+        weeks = table.search('tr.tbdy1')
+
+        weeks.each do |week|
+          game = Team::Schedule::Game.new
+          elements = week.search('td')
+          game.week = elements[0].inner_text.strip
+          game.date = elements[1].inner_text.strip
+          participants = elements[2].search('a')
+          game.opponent = get_opponent(team, participants)
+          game.home_game = home_game?(team, participants)
+          schedule.games << game
         end
       end
 

data/lib/nfl_data/version.rb

@@ -1,3 +1,3 @@
 module NflData
-  VERSION = '0.0.10'
+  VERSION = '0.0.11'
 end

data/nfl_data.gemspec

@@ -11,8 +11,8 @@ Gem::Specification.new do |spec|
   spec.email         = ['j.m.taylor1@gmail.com']
   spec.homepage      = 'https://github.com/thetizzo/nfl_data'
   spec.license       = 'MIT'
-  spec.summary       = %q{Parse NFL data like a boss}
-  spec.description   = %q{Parse NFL data like a boss}
+  spec.summary       = 'Parse NFL data like a boss'
+  spec.description   = 'Parse NFL data like a boss'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest', '~> 5.4.1'
   spec.add_development_dependency 'vcr', '~> 2.9.3'
   spec.add_development_dependency 'webmock', '~> 1.19.0'
+  spec.add_development_dependency 'rubocop', '~> 0.35.1'
 
   spec.add_dependency 'nokogiri', '~> 1.6'
 end

data/test/nfl_data/models/player_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 describe Player do
-
   before do
     @player = Player.new
   end
@@ -42,6 +41,10 @@ describe Player do
     @player.must_respond_to :nfl_player_id
   end
 
+  it 'has a picture_link' do
+    @player.must_respond_to :picture_link
+  end
+
   describe 'to_hash' do
     before do
       @player.first_name = 'John'
@@ -52,6 +55,7 @@ describe Player do
       @player.status = 'Retired'
       @player.team = 'Broncos'
       @player.nfl_player_id = '123'
+      @player.picture_link = 'google.com'
     end
 
     def valid_player_hash
@@ -63,13 +67,13 @@ describe Player do
         number: 7,
         status: 'Retired',
         team: 'Broncos',
-        nfl_player_id: '123'
+        nfl_player_id: '123',
+        picture_link: 'google.com'
       }
     end
 
     it 'can return itself as hash' do
       @player.to_hash.must_equal valid_player_hash
     end
-
   end
 end

data/test/nfl_data/models/statline_test.rb

@@ -73,28 +73,24 @@ describe Statline do
     @statline.must_respond_to :nfl_player_id
   end
 
-  it 'has sacks' do
-    @statline.must_respond_to :sacks
-  end
-
   describe 'to_hash' do
     before do
-        @statline.nfl_player_id = '123'
-        @statline.week = 1
-        @statline.year = 2014
-        @statline.rush_atts = 1
-        @statline.rush_yards = 25
-        @statline.rush_tds = 1
-        @statline.fumbles = 0
-        @statline.pass_comp = 1
-        @statline.pass_att = 2
-        @statline.pass_yards = 100
-        @statline.pass_tds = 1
-        @statline.ints = 1
-        @statline.qb_rating = "46.8"
-        @statline.receptions = 2
-        @statline.rec_yards = 25
-        @statline.rec_tds = 1
+      @statline.nfl_player_id = '123'
+      @statline.week = 1
+      @statline.year = 2014
+      @statline.rush_atts = 1
+      @statline.rush_yards = 25
+      @statline.rush_tds = 1
+      @statline.fumbles = 0
+      @statline.pass_comp = 1
+      @statline.pass_att = 2
+      @statline.pass_yards = 100
+      @statline.pass_tds = 1
+      @statline.ints = 1
+      @statline.qb_rating = '46.8'
+      @statline.receptions = 2
+      @statline.rec_yards = 25
+      @statline.rec_tds = 1
     end
 
     def valid_statline_hash
@@ -111,7 +107,7 @@ describe Statline do
         pass_yards: 100,
         pass_tds: 1,
         ints: 1,
-        qb_rating: "46.8",
+        qb_rating: '46.8',
         receptions: 2,
         rec_yards: 25,
         rec_tds: 1
@@ -121,6 +117,5 @@ describe Statline do
     it 'can return itself as hash' do
       @statline.to_hash.must_equal valid_statline_hash
     end
-
   end
 end

data/test/nfl_data/models/team_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 describe Team do
-
   before do
     @team = Team.new
   end
@@ -40,6 +39,5 @@ describe Team do
     it 'can return itself as hash' do
       @team.to_hash.must_equal valid_player_hash
     end
-
   end
 end

data/test/nfl_data/parsers/player_parser_test.rb

@@ -10,7 +10,11 @@ describe PlayerParser do
   end
 
   it 'should know the correct base url' do
-    @parser.base_url.must_equal "http://www.nfl.com/players/search?category=position&conferenceAbbr=null&playerType=current&conference=ALL&filter="
+    expected_base_url = 'http://www.nfl.com/players/search?category=' \
+                        'position&conferenceAbbr=null&playerType=current' \
+                        '&conference=ALL&filter='
+
+    @parser.base_url.must_equal expected_base_url
   end
 
   describe 'get_by_position' do
@@ -19,7 +23,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:quarterbacks)
 
         response.keys.must_include :quarterbacks
-        response[:quarterbacks].count.must_equal 123
+        response[:quarterbacks].count.must_equal 118
       end
     end
 
@@ -28,7 +32,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:runningbacks)
 
         response.keys.must_include :runningbacks
-        response[:runningbacks].count.must_equal 245
+        response[:runningbacks].count.must_equal 243
       end
     end
 
@@ -37,7 +41,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:wide_receivers)
 
         response.keys.must_include :wide_receivers
-        response[:wide_receivers].count.must_equal 398
+        response[:wide_receivers].count.must_equal 339
       end
     end
 
@@ -46,7 +50,7 @@ describe PlayerParser do
         response = @parser.get_by_position(:tight_ends)
 
         response.keys.must_include :tight_ends
-        response[:tight_ends].count.must_equal 206
+        response[:tight_ends].count.must_equal 188
       end
     end
 
@@ -55,10 +59,10 @@ describe PlayerParser do
         response = @parser.get_by_position(:all)
 
         {
-          quarterbacks: 123,
-          runningbacks: 245,
-          wide_receivers: 398,
-          tight_ends: 206
+          quarterbacks: 118,
+          runningbacks: 243,
+          wide_receivers: 339,
+          tight_ends: 188
         }.each do |position, player_count|
           response.keys.must_include position
           response[position].count.must_equal player_count
@@ -70,10 +74,12 @@ describe PlayerParser do
       VCR.use_cassette('all_players') do
         response = @parser.get_by_position(:all)
 
-        players = [response[:quarterbacks], response[:runningbacks], response[:wide_receivers], response[:tight_ends]].flatten
+        players =
+          [response[:quarterbacks], response[:runningbacks],
+           response[:wide_receivers], response[:tight_ends]].flatten
 
-        players.any? {|player| player[:team] == 'JAX'}.must_equal true
-        players.none? {|player| player[:team] == 'JAC'}.must_equal true
+        players.any? { |player| player[:team] == 'JAX' }.must_equal true
+        players.none? { |player| player[:team] == 'JAC' }.must_equal true
       end
     end
   end

data/test/nfl_data/parsers/statline_parser_test.rb

@@ -30,6 +30,5 @@ describe StatlineParser do
         response.count.must_equal 210
       end
     end
-
   end
 end

data/test/nfl_data/parsers/team_parser_test.rb

@@ -10,7 +10,7 @@ describe TeamParser do
   end
 
   it 'should know the correct base url' do
-    @parser.base_url.must_equal "http://www.nfl.com/standings?category=league&split=Overall&season="
+    @parser.base_url.must_equal 'http://www.nfl.com/standings?category=league&split=Overall&season='
   end
 
   describe 'get_by_year' do
@@ -33,8 +33,8 @@ describe TeamParser do
     it 'should use JAX as the abbreviation for Jacksonville' do
       VCR.use_cassette('teams_with_schedule') do
         result = @parser.get_by_year(2014, true)
-        result.any? {|team| team[:short_name] == 'JAX'}.must_equal true
-        result.none? {|team| team[:short_name] == 'JAC'}.must_equal true
+        result.any? { |team| team[:short_name] == 'JAX' }.must_equal true
+        result.none? { |team| team[:short_name] == 'JAC' }.must_equal true
       end
     end
   end

data/test/test_helper.rb

@@ -1,3 +1,5 @@
+ENV['NFL_DATA_ENV'] = 'test'
+
 require 'nfl_data'
 
 require 'minitest/autorun'
@@ -7,6 +9,6 @@ require 'vcr'
 include NflData
 
 VCR.configure do |c|
-  c.cassette_library_dir = 'test/fixtures/cassettes'
+  c.cassette_library_dir = 'test/cassettes'
   c.hook_into :webmock
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nfl_data
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - thetizzo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-12 00:00:00.000000000 Z
+date: 2017-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.19.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.35.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.35.1
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -102,7 +116,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -151,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Parse NFL data like a boss