nfg-client 1.0.2 → 1.0.3

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OGRmZDY3ZDM3OTM0ODdkM2RjNmY2NDhkOTNkZTgzMThkNTI1MjJhMQ==
-  data.tar.gz: !binary |-
-    YWVlNjNkZWUxNzNiN2E2ZmNhMTMxNDRiMDFiMWRmYzI5NDY1MWUwOQ==
+SHA1:
+  metadata.gz: 5a7c8e37dc56b5de8b54200c7d918339a1ce1f08
+  data.tar.gz: 29c4314bc8ab18a48f2c2cec814b13fbdca7ce6d
 SHA512:
-  metadata.gz: !binary |-
-    ZjFhYjcwN2E0NDkyYjU5NGY4MTM4YWQzYzk0YzIwYjg2YjlmYTlmNDk0ZTY4
-    NGJkOTQ5N2VjMjlmNDJhMWI3YjM3ZmQ3ZDVjODE5ODUzZTUyM2U2YTY2NjRl
-    ZTkxMjFlNzhhZTFjNjFhYjI0OWUzZDBmOTE1NjJkYjM1ZDBmNjU=
-  data.tar.gz: !binary |-
-    Y2M3ZGIzMjk2ZjE0YmZkNTBkNWIyYzZhMjc4OTk4MDUyZmE4MjI3ODU3ZTRm
-    NzY0MTc5NTRkYWZhZmFkODU2NzExMTM5ZmRlMTNjYjBmNTdlZWY3YWVjYjQ2
-    ODc2YjgzZWM5YzVmNmIyZWFmNTNkYmMyZTAxN2U5ZTkxYTE0NDc=
+  metadata.gz: d0bbbec1c0d14c051319fa35da773b02f14ebe96e639cf7feb799dca011e9817490ed7ea56e31fb6a05ae5d18ab214e87e2ac2c6e442519d3afde93b7e5239f2
+  data.tar.gz: 54104188e5a9adec36e386f05dead00ac00d8cae7b55824149fcddd8fe0981949be83f1f1c527d7a4b15505e4236e3a0db657818c7ba0d3697f2c57ce960ec63

data/lib/nfg-client/utils.rb

@@ -1,5 +1,7 @@
 require 'net/http'
 require 'rexml/document'
+require 'cgi'
+require 'logger'
 
 module NFGClient
   module Utils
@@ -22,6 +24,7 @@ module NFGClient
     #   nfg_method: (String)
     #   params: (Hash)
     def nfg_soap_request(nfg_method, params)
+      @logger = defined?(Rails) ? Rails.logger : ::Logger.new(STDOUT)
       if (nfg_method.is_a? String) && (params.is_a? Hash)
 
         # Build SOAP 1.2 request
@@ -29,11 +32,17 @@ module NFGClient
 
         headers = format_headers(nfg_method, soap_request)
 
+        @logger.info headers
+        @logger.info soap_request
         # Being HTTP Post
         begin
           response = ssl_post(soap_request, headers)
+          @logger.info " nfg_soap_request succeeded: #{ response.body.inspect }"
           return_value = parse_result(response.code, response.body, response.message, nfg_method)
         rescue StandardError => e
+          @logger.error " nfg_soap_request failed: #{ e.message }"
+          @logger.error e.backtrace.join(' ')
+
           return_value = Hash.new
           return_value['StatusCode'] = 'UnexpectedError'
           return_value['Message'] = e
@@ -127,13 +136,22 @@ module NFGClient
     #   hash: (Hash)
     def hash_to_xml(hash)
       hash.map do |k, v|
-        text = (v.is_a? Hash) ? hash_to_xml(v) : v
+        text = (v.is_a? Hash) ? hash_to_xml(v) : encode_if_text(v)
         # It removes the digits at the end of each "DonationItem" hash key
         xml_elem = (v.is_a? Hash) ? k.to_s.gsub(/(\d)/, "") : k
         "<%s>%s</%s>" % [xml_elem, text, xml_elem]
       end.join
     end
 
+    # HTML Encodes the string if it is text, otherwise, leaves it as is
+    def encode_if_text(item)
+      if item.respond_to?(:gsub)
+        CGI.escapeHTML(item)
+      else
+        item
+      end
+    end
+
     # Raises an exception if the required params are not part of the given hash
     #
     # Arguments:

data/lib/nfg-client/version.rb

@@ -1,3 +1,3 @@
 module NFGClient
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/nfg-client.gemspec

@@ -23,4 +23,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec', '~> 2.13.0'
   gem.add_development_dependency 'simplecov'
   gem.add_development_dependency 'mocha'
+  gem.add_development_dependency 'rake'
 end

data/spec/unit/make_cof_donation_spec.rb

@@ -7,7 +7,7 @@ describe NFGClient::Client do
 
   describe "#make_cof_donation" do
     context "with a successful response" do
-      it "should return a hash with a new COFId" do
+      it "should return a hash with the COFId" do
         nfg_client.expects(:ssl_post).returns(nfg_response('200',successful_make_cof_donation_response))
         expect(subject['StatusCode']).to eq('Success')
         expect(subject['COFId']).to eq('1111111')

metadata

@@ -1,69 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: nfg-client
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Antonio Ruano Cuesta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-08 00:00:00.000000000 Z
+date: 2014-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: andand
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.13.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Client for the Network for Good SOAP API.
@@ -73,8 +87,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.md
 - README.md
@@ -114,12 +128,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -149,4 +163,3 @@ test_files:
 - spec/unit/response_stubs/make_cof_donation_stubs.rb
 - spec/unit/response_stubs/make_donation_add_cof_stubs.rb
 - spec/unit/response_stubs/spec_response_helpers.rb
-has_rdoc: