next_rails 1.4.4 → 1.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d1c67d799d599530c9a05a6dc5c45ce565a131cd9d3ae1ef0d433931873ea9e2
-  data.tar.gz: d48ba5e3aa9332eb34d0a489dbc3977640dd15ffe51845d4c1050ba794ea5a27
+  metadata.gz: ebc27419f01357f8e9d26fd7b7c5022ebd7993cc83c055f97d8ae1941de7c0e3
+  data.tar.gz: 06d4d044f30b054aa99ad746e389c44753248d99d7d829d11687e6fd344b45e5
 SHA512:
-  metadata.gz: b8083833e12cfaa07b7787b28fc1ce088b42ad09bada36d81af657787a10dadfe6b8f30e0925cb85b96f568dcd7bdf9bf4b1a1ff3bc3f5941e9c19a2767a84dd
-  data.tar.gz: b838fe07dc40f693974088d1e828210f335139c17a17f183dcaeca1beb2b1a87a9d83634efe3d9e03ba1402469c39810250bcb2a8641fac2f615caa0aeb9c65b
+  metadata.gz: 33ad7eb2b31696266e009755d91689787761b74ebf719728a1ff8070ba49afe1b1fee97cb97f0539b30572fd31a3175d548dbcbb67245a70fc706e2dd76082fe
+  data.tar.gz: c1f025b9b067b4949fbea7611d6560d2ffd2edf70988be503022ea83704f5ddf88e8bff2907099efecc734665b72f088c47295842bfc6a80642cea3d876a3fed

data/.gitignore

@@ -14,3 +14,4 @@
 
 .ruby-version
 Gemfile.lock
+.gem

data/CHANGELOG.md

@@ -1,9 +1,17 @@
-# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.4.4...main)
+# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.4.6...main)
 
 - [BUGFIX: example](https://github.com/fastruby/next_rails/pull/<number>)
 
 * Your changes/patches go here.
 
+# v1.4.6 / 2025-04-15 [(commits)](https://github.com/fastruby/next_rails/compare/v1.4.5...v1.4.6)
+
+- [BUFIX: Fix compatibilities performance bug](https://github.com/fastruby/next_rails/pull/150)
+
+# v1.4.5 / 2025-03-07 [(commits)](https://github.com/fastruby/next_rails/compare/v1.4.4...v1.4.5)
+
+- [Move rails_version compatibility to its own class](https://github.com/fastruby/next_rails/pull/137)
+
 # v1.4.4 / 2025-02-26 [(commits)](https://github.com/fastruby/next_rails/compare/v1.4.3...v1.4.4)
 
 - [FEATURE: Update deprecation tracker to support newer Rails versions (7.1+)](https://github.com/fastruby/next_rails/pull/142)

data/README.md

@@ -140,7 +140,7 @@ next_rails --help # For more options and examples
 This command helps you dual-boot your application.
 
 ```bash
-next_next --init    # Create Gemfile.next and Gemfile.next.lock
+next_rails --init    # Create Gemfile.next and Gemfile.next.lock
 vim Gemfile         # Tweak your dependencies conditionally using `next?`
 next bundle install # Install new gems
 next rails s        # Start server using Gemfile.next

data/exe/bundle_report

@@ -67,9 +67,9 @@ at_exit do
   when "outdated" then NextRails::BundleReport.outdated(options.fetch(:format, nil))
   else
     if options[:ruby_version]
-      NextRails::BundleReport.compatibility(ruby_version: options.fetch(:ruby_version, "2.3"))
+      NextRails::BundleReport.ruby_compatibility(ruby_version: options.fetch(:ruby_version, "2.3"))
     else
-      NextRails::BundleReport.compatibility(rails_version: options.fetch(:rails_version, "5.0"), include_rails_gems: options.fetch(:include_rails_gems, false))
+      NextRails::BundleReport.rails_compatibility(rails_version: options.fetch(:rails_version, "5.0"), include_rails_gems: options.fetch(:include_rails_gems, false))
     end
   end
 end

data/lib/next_rails/bundle_report/rails_version_compatibility.rb

@@ -0,0 +1,84 @@
+class NextRails::BundleReport::RailsVersionCompatibility
+  def initialize(gems: NextRails::GemInfo.all, options: {})
+    @gems = gems
+    @options = options
+  end
+
+  def generate
+    erb_output
+  end
+
+  def incompatible_gems_by_state
+    @incompatible_gems_by_state ||= begin
+      incompatible_gems.each { |gem| gem.find_latest_compatible(rails_version: rails_version) }
+      incompatible_gems.group_by { |gem| gem.state(rails_version) }
+    end
+  end
+
+  private
+
+  def erb_output
+    template = <<-ERB
+<% if incompatible_gems_by_state[:found_compatible] -%>
+<%= Rainbow("=> Incompatible with Rails #{rails_version} (with new versions that are compatible):").white.bold %>
+<%= Rainbow("These gems will need to be upgraded before upgrading to Rails #{rails_version}.").italic %>
+
+<% incompatible_gems_by_state[:found_compatible].each do |gem| -%>
+<%= gem_header(gem) %> - upgrade to <%= gem.latest_compatible_version.version %>
+<% end -%>
+
+<% end -%>
+<% if incompatible_gems_by_state[:incompatible] -%>
+<%= Rainbow("=> Incompatible with Rails #{rails_version} (with no new compatible versions):").white.bold %>
+<%= Rainbow("These gems will need to be removed or replaced before upgrading to Rails #{rails_version}.").italic %>
+
+<% incompatible_gems_by_state[:incompatible].each do |gem| -%>
+<%= gem_header(gem) %> - new version, <%= gem.latest_version.version %>, is not compatible with Rails #{rails_version}
+<% end -%>
+
+<% end -%>
+<% if incompatible_gems_by_state[:no_new_version] -%>
+<%= Rainbow("=> Incompatible with Rails #{rails_version} (with no new versions):").white.bold %>
+<%= Rainbow("These gems will need to be upgraded by us or removed before upgrading to Rails #{rails_version}.").italic %>
+<%= Rainbow("This list is likely to contain internal gems, like Cuddlefish.").italic %>
+
+<% incompatible_gems_by_state[:no_new_version].each do |gem| -%>
+<%= gem_header(gem) %> - new version not found
+<% end -%>
+
+<% end -%>
+<%= Rainbow(incompatible_gems.length.to_s).red %> gems incompatible with Rails <%= rails_version %>
+    ERB
+
+    erb_version = ERB.version
+    if erb_version =~ /erb.rb \[([\d\.]+) .*\]/
+      erb_version = $1
+    end
+
+    if Gem::Version.new(erb_version) < Gem::Version.new("2.2")
+      ERB.new(template, nil, "-").result(binding)
+    else
+      ERB.new(template, trim_mode: "-").result(binding)
+    end
+  end
+
+  def gem_header(_gem)
+    header = Rainbow("#{_gem.name} #{_gem.version}").bold
+    header << Rainbow(" (loaded from git)").magenta if _gem.sourced_from_git?
+    header
+  end
+
+  def incompatible_gems
+    @incompatible_gems ||= @gems.reject do |gem|
+      gem.compatible_with_rails?(rails_version: rails_version) || (!include_rails_gems && gem.from_rails?)
+    end.sort_by { |gem| gem.name }
+  end
+
+  def rails_version
+    @options[:rails_version]
+  end
+
+  def include_rails_gems
+    @options[:include_rails_gems]
+  end
+end

data/lib/next_rails/bundle_report.rb

@@ -8,69 +8,18 @@ module NextRails
   module BundleReport
     extend self
 
-    def compatibility(rails_version: nil, ruby_version: nil, include_rails_gems: nil)
-      return puts RubyVersionCompatibility.new(options: { ruby_version: ruby_version }).generate if ruby_version
+    def ruby_compatibility(ruby_version: nil)
+      return unless ruby_version
 
-      incompatible_gems = NextRails::GemInfo.all.reject do |gem|
-        gem.compatible_with_rails?(rails_version: rails_version) || (!include_rails_gems && gem.from_rails?)
-      end.sort_by { |gem| gem.name }
-
-      incompatible_gems.each { |gem| gem.find_latest_compatible(rails_version: rails_version) }
-
-      incompatible_gems_by_state = incompatible_gems.group_by { |gem| gem.state(rails_version) }
-
-      puts erb_output(incompatible_gems_by_state, incompatible_gems, rails_version)
+      options = { ruby_version: ruby_version }
+      puts RubyVersionCompatibility.new(options: options).generate
     end
 
-    def erb_output(incompatible_gems_by_state, incompatible_gems, rails_version)
-      template = <<-ERB
-<% if incompatible_gems_by_state[:found_compatible] -%>
-<%= Rainbow("=> Incompatible with Rails #{rails_version} (with new versions that are compatible):").white.bold %>
-<%= Rainbow("These gems will need to be upgraded before upgrading to Rails #{rails_version}.").italic %>
-
-<% incompatible_gems_by_state[:found_compatible].each do |gem| -%>
-<%= gem_header(gem) %> - upgrade to <%= gem.latest_compatible_version.version %>
-<% end -%>
-
-<% end -%>
-<% if incompatible_gems_by_state[:incompatible] -%>
-<%= Rainbow("=> Incompatible with Rails #{rails_version} (with no new compatible versions):").white.bold %>
-<%= Rainbow("These gems will need to be removed or replaced before upgrading to Rails #{rails_version}.").italic %>
-
-<% incompatible_gems_by_state[:incompatible].each do |gem| -%>
-<%= gem_header(gem) %> - new version, <%= gem.latest_version.version %>, is not compatible with Rails #{rails_version}
-<% end -%>
-
-<% end -%>
-<% if incompatible_gems_by_state[:no_new_version] -%>
-<%= Rainbow("=> Incompatible with Rails #{rails_version} (with no new versions):").white.bold %>
-<%= Rainbow("These gems will need to be upgraded by us or removed before upgrading to Rails #{rails_version}.").italic %>
-<%= Rainbow("This list is likely to contain internal gems, like Cuddlefish.").italic %>
-
-<% incompatible_gems_by_state[:no_new_version].each do |gem| -%>
-<%= gem_header(gem) %> - new version not found
-<% end -%>
-
-<% end -%>
-<%= Rainbow(incompatible_gems.length.to_s).red %> gems incompatible with Rails <%= rails_version %>
-      ERB
-
-      erb_version = ERB.version
-      if erb_version =~ /erb.rb \[([\d\.]+) .*\]/
-        erb_version = $1
-      end
-
-      if Gem::Version.new(erb_version) < Gem::Version.new("2.2")
-        ERB.new(template, nil, "-").result(binding)
-      else
-        ERB.new(template, trim_mode: "-").result(binding)
-      end
-    end
+    def rails_compatibility(rails_version: nil, include_rails_gems: nil)
+      return unless rails_version
 
-    def gem_header(_gem)
-      header = Rainbow("#{_gem.name} #{_gem.version}").bold
-      header << Rainbow(" (loaded from git)").magenta if _gem.sourced_from_git?
-      header
+      options = { rails_version: rails_version, include_rails_gems: include_rails_gems }
+      puts RailsVersionCompatibility.new(options: options).generate
     end
 
     def compatible_ruby_version(rails_version)

data/lib/next_rails/gem_info.rb

@@ -109,7 +109,7 @@ module NextRails
 
     def find_latest_compatible(rails_version: nil)
       dependency = Gem::Dependency.new(@name)
-      fetcher = Gem::SpecFetcher.new
+      fetcher = Gem::SpecFetcher.fetcher # Use fetcher instead of ::new to reduce object allocation.
 
       # list all available data for released gems
       list, errors = fetcher.available_specs(:released)

data/lib/next_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NextRails
-  VERSION = "1.4.4"
+  VERSION = "1.4.6"
 end

data/lib/next_rails.rb

@@ -5,6 +5,7 @@ require "next_rails/version"
 require "next_rails/init"
 require "next_rails/bundle_report"
 require "next_rails/bundle_report/ruby_version_compatibility"
+require "next_rails/bundle_report/rails_version_compatibility"
 require "deprecation_tracker"
 
 module NextRails

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: next_rails
 version: !ruby/object:Gem::Version
-  version: 1.4.4
+  version: 1.4.6
 platform: ruby
 authors:
 - Ernesto Tagwerker
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-02-26 00:00:00.000000000 Z
+date: 2025-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -183,6 +183,7 @@ files:
 - lib/deprecation_tracker.rb
 - lib/next_rails.rb
 - lib/next_rails/bundle_report.rb
+- lib/next_rails/bundle_report/rails_version_compatibility.rb
 - lib/next_rails/bundle_report/ruby_version_compatibility.rb
 - lib/next_rails/gem_info.rb
 - lib/next_rails/init.rb