next_rails 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c82f6a12b6cd481313202fce9894ca2690c222d4397a14398f74c4dd0e6d31f
-  data.tar.gz: 546438cf1893b369c1f4c0d05f507a99c96a3dbd939b78b8e3bacbed560f2150
+  metadata.gz: 7531328eccac69326b09b911f6fadb8f69b8d9713e6364af67c756059ed3ea18
+  data.tar.gz: 2bdaab8c916972e76b2623ff37519a2363da4537f4f0a4a4ce47b81343c227cf
 SHA512:
-  metadata.gz: a1330ca26c90f32978737bbf780156458bc8254377addbfdb860c63b1ff697f06a554e640d457bc7c7d1433a3baa7f2cd0115d4860bf451b85d468f8d0501eec
-  data.tar.gz: a5b5da58d00c288258931320c395cbccf1341f4eed15f56b680693f2ef3919d96ec97542a9bc2c3c11e5cf82ee5371f44d64162e9630901a4c702ded146e1415
+  metadata.gz: e65d7cb5da7f4eee2b56210db1a64a2a989a089b84f8ff7024385865710ef78c95aa3eeb16d4f1c194c67a0cf47f51b2970aeeccd6c3fde876c44e000c0d867a
+  data.tar.gz: 6926ab189b14413dcda593151c3a5586c71dc1ac7880fea0a024a16eb536bb03e46dafb72f568e1c04bb29c155b20423ce1b39fa749cd2ee01409974c3939332

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 * Your changes/patches go here.
 
+# v1.4.1 / 2024-10-22 [(commits)](https://github.com/fastruby/next_rails/compare/v1.4.0...v1.4.1)
+
+- [BUGFIX: Fix performance regression due to rainbow refinement](https://github.com/fastruby/next_rails/pull/131)
+
 # v1.4.0 / 2024-09-24 [(commits)](https://github.com/fastruby/next_rails/compare/v1.3.0...v1.4.0)
 
 - [CHORE: Use next_rails namespace on spec tests.](https://github.com/fastruby/next_rails/pull/117)

data/exe/bundle_report

@@ -55,7 +55,7 @@ at_exit do
   begin
     option_parser.parse!
   rescue OptionParser::ParseError => e
-    STDERR.puts e.message.red
+    STDERR.puts Rainbow(e.message).red
     puts option_parser
     exit 1
   end

data/exe/deprecations

@@ -1,11 +1,9 @@
 #!/usr/bin/env ruby
 require "json"
-require "rainbow/refinement"
+require "rainbow"
 require "optparse"
 require "set"
 
-using Rainbow
-
 def run_tests(deprecation_warnings, opts = {})
   tracker_mode = opts[:tracker_mode]
   next_mode = opts[:next_mode]
@@ -30,11 +28,11 @@ def print_info(deprecation_warnings, opts = {})
     end
   end.sort_by {|message, data| data[:occurrences] }.reverse.to_h
 
-  puts "Ten most common deprecation warnings:".underline
+  puts Rainbow("Ten most common deprecation warnings:").underline
   frequency_by_message.take(10).each do |message, data|
-    puts "Occurrences: #{data.fetch(:occurrences)}".bold
+    puts Rainbow("Occurrences: #{data.fetch(:occurrences)}").bold
     puts "Test files: #{data.fetch(:test_files).to_a.join(" ")}" if verbose
-    puts message.red
+    puts Rainbow(message).red
     puts "----------"
   end
 end
@@ -106,10 +104,10 @@ case options.fetch(:mode, "info")
 when "run" then run_tests(deprecation_warnings, next_mode: options[:next], tracker_mode: options[:tracker_mode])
 when "info" then print_info(deprecation_warnings, verbose: options[:verbose])
 when nil
-  STDERR.puts "Must pass a mode: run or info".red
+  STDERR.puts Rainbow("Must pass a mode: run or info").red
   puts option_parser
   exit 1
 else
-  STDERR.puts "Unknown mode: #{options[:mode]}".red
+  STDERR.puts Rainbow("Unknown mode: #{options[:mode]}").red
   exit 1
 end

data/lib/deprecation_tracker.rb

@@ -1,8 +1,6 @@
-require "rainbow/refinement"
+require "rainbow"
 require "json"
 
-using Rainbow
-
 # A shitlist for deprecation warnings during test runs. It has two modes: "save" and "compare"
 #
 # DEPRECATION_TRACKER=save
@@ -152,7 +150,7 @@ class DeprecationTracker
     end
 
     if changed_buckets.length > 0
-      message = <<-MESSAGE.red
+      message = <<-MESSAGE
         ⚠️  Deprecation warnings have changed!
 
         Code called by the following spec files is now generating different deprecation warnings:
@@ -170,7 +168,7 @@ class DeprecationTracker
         See \e[4;37mdev-docs/testing/deprecation_tracker.md\e[0;31m for more information.
       MESSAGE
 
-      raise UnexpectedDeprecations, message
+      raise UnexpectedDeprecations, Rainbow(message).red
     end
   end
 

data/lib/next_rails/bundle_report/ruby_version_compatibility.rb

@@ -1,8 +1,6 @@
-require "rainbow/refinement"
+require "rainbow"
 
 class NextRails::BundleReport::RubyVersionCompatibility
-  using Rainbow
-
   MINIMAL_VERSION = 1.0
   attr_reader :gems, :options
 
@@ -20,11 +18,11 @@ class NextRails::BundleReport::RubyVersionCompatibility
   private
 
   def message
-    output = "=> Incompatible gems with Ruby #{ruby_version}:".white.bold
+    output = Rainbow("=> Incompatible gems with Ruby #{ruby_version}:").white.bold
     incompatible.each do |gem|
-      output += "\n#{gem.name} - required Ruby version: #{gem.gem_specification.required_ruby_version}".magenta
+      output += Rainbow("\n#{gem.name} - required Ruby version: #{gem.gem_specification.required_ruby_version}").magenta
     end
-    output += "\n\n#{incompatible.length} incompatible #{incompatible.one? ? 'gem' : 'gems' } with Ruby #{ruby_version}".red
+    output += Rainbow("\n\n#{incompatible.length} incompatible #{incompatible.one? ? 'gem' : 'gems' } with Ruby #{ruby_version}").red
     output
   end
 
@@ -37,7 +35,7 @@ class NextRails::BundleReport::RubyVersionCompatibility
   end
 
   def invalid_message
-    "=> Invalid Ruby version: #{options[:ruby_version]}.".red.bold
+    Rainbow("=> Invalid Ruby version: #{options[:ruby_version]}.").red.bold
   end
 
   def valid?

data/lib/next_rails/bundle_report.rb

@@ -1,11 +1,9 @@
-require "rainbow/refinement"
+require "rainbow"
 require "cgi"
 require "erb"
 require "json"
 require "net/http"
 
-using Rainbow
-
 module NextRails
   module BundleReport
     extend self
@@ -27,8 +25,8 @@ module NextRails
     def erb_output(incompatible_gems_by_state, incompatible_gems, rails_version)
       template = <<-ERB
 <% if incompatible_gems_by_state[:found_compatible] -%>
-<%= "=> Incompatible with Rails #{rails_version} (with new versions that are compatible):".white.bold %>
-<%= "These gems will need to be upgraded before upgrading to Rails #{rails_version}.".italic %>
+<%= Rainbow("=> Incompatible with Rails #{rails_version} (with new versions that are compatible):").white.bold %>
+<%= Rainbow("These gems will need to be upgraded before upgrading to Rails #{rails_version}.").italic %>
 
 <% incompatible_gems_by_state[:found_compatible].each do |gem| -%>
 <%= gem_header(gem) %> - upgrade to <%= gem.latest_compatible_version.version %>
@@ -36,8 +34,8 @@ module NextRails
 
 <% end -%>
 <% if incompatible_gems_by_state[:incompatible] -%>
-<%= "=> Incompatible with Rails #{rails_version} (with no new compatible versions):".white.bold %>
-<%= "These gems will need to be removed or replaced before upgrading to Rails #{rails_version}.".italic %>
+<%= Rainbow("=> Incompatible with Rails #{rails_version} (with no new compatible versions):").white.bold %>
+<%= Rainbow("These gems will need to be removed or replaced before upgrading to Rails #{rails_version}.").italic %>
 
 <% incompatible_gems_by_state[:incompatible].each do |gem| -%>
 <%= gem_header(gem) %> - new version, <%= gem.latest_version.version %>, is not compatible with Rails #{rails_version}
@@ -45,16 +43,16 @@ module NextRails
 
 <% end -%>
 <% if incompatible_gems_by_state[:no_new_version] -%>
-<%= "=> Incompatible with Rails #{rails_version} (with no new versions):".white.bold %>
-<%= "These gems will need to be upgraded by us or removed before upgrading to Rails #{rails_version}.".italic %>
-<%= "This list is likely to contain internal gems, like Cuddlefish.".italic %>
+<%= Rainbow("=> Incompatible with Rails #{rails_version} (with no new versions):").white.bold %>
+<%= Rainbow("These gems will need to be upgraded by us or removed before upgrading to Rails #{rails_version}.").italic %>
+<%= Rainbow("This list is likely to contain internal gems, like Cuddlefish.").italic %>
 
 <% incompatible_gems_by_state[:no_new_version].each do |gem| -%>
 <%= gem_header(gem) %> - new version not found
 <% end -%>
 
 <% end -%>
-<%= incompatible_gems.length.to_s.red %> gems incompatible with Rails <%= rails_version %>
+<%= Rainbow(incompatible_gems.length.to_s).red %> gems incompatible with Rails <%= rails_version %>
       ERB
 
       erb_version = ERB.version
@@ -70,8 +68,8 @@ module NextRails
     end
 
     def gem_header(_gem)
-      header = "#{_gem.name} #{_gem.version}".bold
-      header << " (loaded from git)".magenta if _gem.sourced_from_git?
+      header = Rainbow("#{_gem.name} #{_gem.version}").bold
+      header << Rainbow(" (loaded from git)").magenta if _gem.sourced_from_git?
       header
     end
 
@@ -158,14 +156,14 @@ module NextRails
         header = "#{gem.name} #{gem.version}"
 
         puts <<-MESSAGE
-          #{header.bold.white}: released #{gem.age} (latest version, #{gem.latest_version.version}, released #{gem.latest_version.age})
+          #{Rainbow(header.bold.white)}: released #{gem.age} (latest version, #{gem.latest_version.version}, released #{gem.latest_version.age})
         MESSAGE
       end
 
       percentage_out_of_date = ((out_of_date_gems.count / total_gem_count.to_f) * 100).round
       footer = <<-MESSAGE
-        #{sourced_from_git_count.to_s.yellow} gems are sourced from git
-        #{out_of_date_gems.count.to_s.red} of the #{total_gem_count} gems are out-of-date (#{percentage_out_of_date}%)
+        #{Rainbow(sourced_from_git_count.to_s).yellow} gems are sourced from git
+        #{Rainbow(out_of_date_gems.count.to_s).red} of the #{total_gem_count} gems are out-of-date (#{percentage_out_of_date}%)
       MESSAGE
 
       puts ''

data/lib/next_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NextRails
-  VERSION = "1.4.0"
+  VERSION = "1.4.1"
 end

data/next_rails.gemspec

@@ -29,6 +29,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov", "~> 0.17.1"
   spec.add_development_dependency "timecop", "~> 0.9.1"
   spec.add_development_dependency "byebug"
-  spec.add_development_dependency "rexml", "3.1.7.3" # limited on purpose, new versions don't work with old rubies
+  spec.add_development_dependency "rexml", "3.3.8" # limited on purpose, new versions don't work with old rubies
   spec.add_development_dependency "webmock", "3.16.2" # limited on purpose, new versions don't work with old rubies
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: next_rails
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Ernesto Tagwerker
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-09-25 00:00:00.000000000 Z
+date: 2024-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -121,14 +121,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.7.3
+        version: 3.3.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.7.3
+        version: 3.3.8
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -207,7 +207,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: A toolkit to upgrade your next Rails application