next_rails 1.1.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e37620e9fa92eea06f9faa05a1ace3cd1b9ff2585da96b838e165f1b98b06129
-  data.tar.gz: 47335d3ccaf72cfb828deeeab67ae93700fe83f38a7aeb7194ddccad5ebb0f3d
+  metadata.gz: 822e7ed8bda705fc5a9ff1a0f8ccbba91901e01dd279760e7787a7ef1df3f38f
+  data.tar.gz: fd6e3bb66afd86c54fba7e5352245ada2f3ec0520cd88063d11a938d908a4d90
 SHA512:
-  metadata.gz: d449a18c9279d4bc1a2889440843c800dc5f8b1e1d50cacdb2ace1cdebb5b7eb7c14fb6247059e30f7e39412bbb97f15d5ec7b674320bf8bc8c840edf1144fa2
-  data.tar.gz: 8b22f60cdb23275ee943e68835374ea18c54d4ecb1718db2f2e9b0b701bad9a73da2dcc73c03438ed0269b610ed67bbcd7b5bd2eb9906d2c758394abbe0bf8e3
+  metadata.gz: 2da9a58d3922e7d266bc9769a5cfdfee57e1e5d21c2d31be9ff5f3b6b8c109e08b94dfb34eb894d516906921edcddafb5a26b42aab82f3c2f16344820877d133
+  data.tar.gz: e8886320ac2047e9d83d4c6fd67aaccf14b9aa735102dc4eb2755e78cb2dbe359f221ae768ab5c9e2eba44731ba91222e370ff4bea4bee5cbad966e0b5ac2678

data/.github/workflows/main.yml

@@ -1,20 +1,26 @@
 name: Run rake task
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
 
 jobs:
   test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [3.1, 2.7.5]
+        ruby-version: [3.1, 2.7.5, 2.3, 2.2, 2.1.9, 2.0.0]
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby ${{ matrix.ruby-version }}
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby-version }}
-        bundler-cache: true
-    - name: Run rake task
-      run: bundle exec rake
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Run rake task
+        run: bundle exec rake

data/CHANGELOG.md

@@ -1,38 +1,53 @@
-# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.0.4...main)
+# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.2.1...main)
 
-* [FEATURE: Try to find the latest **compatible** version of a gem if the latest version is not compatible with the desired Rails version when checking compatibility](https://github.com/fastruby/next_rails/pull/49)
+# v1.2.1 / 2022-09-26 [(commits)](https://github.com/fastruby/next_rails/compare/v1.2.0...v1.2.1)
 
-* [FEATURE: Added option --version to get the version of the gem being used](https://github.com/fastruby/next_rails/pull/38)
+- [BUGFIX: SimpleCov was not reporting accurately due to a bug in the spec helper code](https://github.com/fastruby/next_rails/pull/66)
 
-* [Added github action workflow](https://github.com/fastruby/next_rails/pull/40)
+- [FEATURE: Better documentation for contributing and releasing versions of this gem](https://github.com/fastruby/next_rails/pull/53)
 
-* [FEATURE: Add support to use DeprecationTracker with Minitest](Add support to use DeprecationTracker with Minitest)
+- [BUGFIX: bundle_report outdated was giving an exception due to missing method latest_version](https://github.com/fastruby/next_rails/pull/62)
 
-* [FEATURE: Add dependabot](https://github.com/fastruby/next_rails/pull/41)
+# v1.2.0 / 2022-08-12 [(commits)](https://github.com/fastruby/next_rails/compare/v1.1.0...v1.2.0)
 
-* [DOCUMENTATION: Update the code of conduct link in PR template](https://github.com/fastruby/next_rails/pull/46)
+- [FEATURE: Support Ruby versions as old as Ruby 2.0](https://github.com/fastruby/next_rails/pull/54)
 
-* [DOCUMENTATION: Add FEATURE REQUEST and BUG REPORT templates ](https://github.com/fastruby/next_rails/pull/48)
+- [FEATURE: Better documentation for contributing and releasing versions of this gem](https://github.com/fastruby/next_rails/pull/53)
 
-* [BUGFIX: Make behavior arguments optional](https://github.com/fastruby/next_rails/pull/44)
+# v1.1.0 / 2022-06-30 [(commits)](https://github.com/fastruby/next_rails/compare/v1.0.5...v1.1.0)
 
-* [FEATURE: Command line option to check for recommended ruby version for the desired Rails version](https://github.com/fastruby/next_rails/pull/39)
+- [FEATURE: Try to find the latest **compatible** version of a gem if the latest version is not compatible with the desired Rails version when checking compatibility](https://github.com/fastruby/next_rails/pull/49)
 
+- [FEATURE: Added option --version to get the version of the gem being used](https://github.com/fastruby/next_rails/pull/38)
+
+- [Added github action workflow](https://github.com/fastruby/next_rails/pull/40)
+
+- [FEATURE: Add support to use DeprecationTracker with Minitest](Add support to use DeprecationTracker with Minitest)
+
+- [FEATURE: Add dependabot](https://github.com/fastruby/next_rails/pull/41)
+
+- [DOCUMENTATION: Update the code of conduct link in PR template](https://github.com/fastruby/next_rails/pull/46)
+
+- [DOCUMENTATION: Add FEATURE REQUEST and BUG REPORT templates ](https://github.com/fastruby/next_rails/pull/48)
+
+- [BUGFIX: Make behavior arguments optional](https://github.com/fastruby/next_rails/pull/44)
+
+- [FEATURE: Command line option to check for recommended ruby version for the desired Rails version](https://github.com/fastruby/next_rails/pull/39)
 
 # v1.0.5 / 2022-03-29 [(commits)](https://github.com/fastruby/next_rails/compare/v1.0.4...v1.0.5)
 
-* [FEATURE: Initialize the Gemfile.next.lock to avoid major version jumps when used without an initial Gemfile.next.lock](https://github.com/fastruby/next_rails/pull/25)
-* [FEATURE: Drop `actionview` dependency because it is not really used](https://github.com/fastruby/next_rails/pull/26)
-* [BUGFIX: If shitlist path does not exist, create it for the user of the gem](https://github.com/fastruby/next_rails/pull/37)
+- [FEATURE: Initialize the Gemfile.next.lock to avoid major version jumps when used without an initial Gemfile.next.lock](https://github.com/fastruby/next_rails/pull/25)
+- [FEATURE: Drop `actionview` dependency because it is not really used](https://github.com/fastruby/next_rails/pull/26)
+- [BUGFIX: If shitlist path does not exist, create it for the user of the gem](https://github.com/fastruby/next_rails/pull/37)
 
 # v1.0.4 / 2021-04-09 [(commits)](https://github.com/fastruby/next_rails/compare/v1.0.3...v1.0.4)
 
-* [BUGFIX: Fixes issue with `bundle_report` and `actionview`](https://github.com/fastruby/next_rails/pull/22)
+- [BUGFIX: Fixes issue with `bundle_report` and `actionview`](https://github.com/fastruby/next_rails/pull/22)
 
 # v1.0.3 / 2021-04-05 [(commits)](https://github.com/fastruby/next_rails/compare/v1.0.2...v1.0.3)
 
-* [BUGFIX: Update README.md to better document this `ten_years_rails` fork](https://github.com/fastruby/next_rails/pull/11)
-* [BUGFIX: Make ActionView an optional dependency](https://github.com/fastruby/next_rails/pull/6)
+- [BUGFIX: Update README.md to better document this `ten_years_rails` fork](https://github.com/fastruby/next_rails/pull/11)
+- [BUGFIX: Make ActionView an optional dependency](https://github.com/fastruby/next_rails/pull/6)
 
 # v1.0.2 / 2020-01-20
 
@@ -40,4 +55,4 @@
 
 # v1.0.0 / 2019-07-24
 
-* Official Release
+- Official Release

data/CONTRIBUTING.md

@@ -0,0 +1,60 @@
+# Contributing to next_rails
+
+Have a fix for a problem you've been running into or an idea for a new feature you think would be useful? Bug reports and pull requests are welcome on GitHub at [https://github.com/fastruby/next_rails](https://github.com/fastruby/next_rails).
+
+Here's what you need to do:
+
+- Read and understand the [Code of Conduct](https://github.com/fastruby/next_rails/blob/main/CODE_OF_CONDUCT.md).
+- Fork this repo and clone your fork to somewhere on your machine.
+- [Ensure that you have a working environment](#setting-up-your-environment)
+- Read up on [run the tests](#running-all-tests).
+- Open a new branch and write a failing test for the feature or bug fix you plan on implementing.
+- [Update the changelog when applicable](#a-word-on-the-changelog).
+- Push to your fork and submit a pull request.
+- [Make sure the test suite passes on GitHub Actions and make any necessary changes to your branch to bring it to green.](#continuous-integration).
+
+## Setting up your environment
+To install the dependencies, run:
+
+```bash
+bin/setup
+```
+
+You can also run `bin/console` for an interactive prompt that will allow you to experiment with the gem.
+
+To install this gem onto your local machine, run:
+
+`bundle exec rake install`.
+
+### Running all tests
+
+To run all of the tests, simply run:
+
+```bash
+bundle exec rake
+```
+
+## A word on the changelog
+
+You may also notice that we have a changelog in the form of [CHANGELOG.md](CHANGELOG.md). We use a format based on [Keep A Changelog](https://keepachangelog.com/en/1.0.0/).
+
+The important things to keep in mind are:
+
+- If your PR closes any open GitHub issue, make sure you include `Closes #XXXX` in your comment.
+- New additions get added under the main (unreleased) heading;
+- Attach a link to the PR with the following format:
+
+* [<FEATURE | BUGFIX | CHORE>: Description of changes](github.com/link/to/pr).
+
+## When Submitting a Pull Request:
+
+* If your PR closes any open GitHub issues, please include `Closes #XXXX` in your comment.
+* Please include a summary of the change and which issue is fixed or which feature is introduced.
+* If changes to the behavior are made, clearly describe what are the changes and why.
+* If changes to the UI are made, please include screenshots of the before and after.
+
+## Continuous integration
+
+After opening your Pull Request, please make sure that all tests pass on the CI, to make sure your changes work in all possible environments. GitHub Actions will kick in after you push up a branch or open a PR.
+
+If the build fails, click on a failed job and scroll through its output to verify what is the problem. Push your changes to your branch until the build is green.

data/README.md

@@ -140,6 +140,33 @@ The Gemfile.next.lock is initialized with the contents of your existing
 Gemfile.lock lock file. We initialize the Gemfile.next.lock to prevent
 major version jumps when running the next version of Rails.
 
+## Contributing
+
+Have a fix for a problem you've been running into or an idea for a new feature you think would be useful? Want to see how you can support `next_rails`?
+
+Take a look at the [Contributing document](CONTRIBUTING.md) for instructions to set up the repo on your machine!
+
+## Releases
+
+`next_rails` adheres to [semver](https://semver.org). So given a version number MAJOR.MINOR.PATCH, we will increment the:
+
+1. MAJOR version when you make incompatible API changes,
+2. MINOR version when you add functionality in a backwards compatible manner, and
+3. PATCH version when you make backwards compatible bug fixes.
+
+Here are the steps to release a new version:
+
+1. Update the `version.rb` file with the proper version number
+2. Update `CHANGELOG.md` to have the right headers
+3. Commit your changes to a `release/v-1-1-0` branch
+4. Push your changes and submit a pull request
+5. Merge your pull request to the `main` branch
+6. Git tag the latest version of the `main` branch (`git tag v1.1.0`)
+7. Push tags to GitHub (`git push --tags`)
+8. Build the gem (`gem build next_rails.gemspec`)
+9. Push the .gem package to Rubygems.org (`gem push next_rails-1.1.0.gem`)
+10. You are all done!
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/deprecation_tracker.rb

@@ -47,7 +47,11 @@ class DeprecationTracker
   end
 
   # There are two forms of the `warn` method: one for class Kernel and one for instances of Kernel (i.e., every Object)
-  Object.prepend(KernelWarnTracker)
+  if Object.respond_to?(:prepend)
+    Object.prepend(KernelWarnTracker)
+  else
+    Object.extend(KernelWarnTracker)
+  end
 
   # Ruby 2.2 and lower doesn't appear to allow overriding of Kernel.warn using `singleton_class.prepend`.
   if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.3.0")
@@ -198,7 +202,12 @@ class DeprecationTracker
       hash[bucket] = messages.sort
     end
 
-    normalized.reject {|_key, value| value.empty? }.sort_by {|key, _value| key }.to_h
+    # not using `to_h` here to support older ruby versions
+    {}.tap do |h|
+      normalized.reject {|_key, value| value.empty? }.sort_by {|key, _value| key }.each do |k ,v|
+        h[k] = v
+      end
+    end
   end
 
   def read_shitlist

data/lib/next_rails/bundle_report.rb

@@ -6,7 +6,7 @@ require "net/http"
 
 module NextRails
   class BundleReport
-    def self.compatibility(rails_version:, include_rails_gems:)
+    def self.compatibility(rails_version: nil, include_rails_gems: nil)
       incompatible_gems = NextRails::GemInfo.all.reject do |gem|
         gem.compatible_with_rails?(rails_version: rails_version) || (!include_rails_gems && gem.from_rails?)
       end.sort_by { |gem| gem.name }
@@ -15,36 +15,36 @@ module NextRails
 
       incompatible_gems_by_state = incompatible_gems.group_by { |gem| gem.state(rails_version) }
 
-      template = <<~ERB
-        <% if incompatible_gems_by_state[:found_compatible] -%>
-        <%= "=> Incompatible with Rails #{rails_version} (with new versions that are compatible):".white.bold %>
-        <%= "These gems will need to be upgraded before upgrading to Rails #{rails_version}.".italic %>
+      template = <<-ERB
+<% if incompatible_gems_by_state[:found_compatible] -%>
+<%= "=> Incompatible with Rails #{rails_version} (with new versions that are compatible):".white.bold %>
+<%= "These gems will need to be upgraded before upgrading to Rails #{rails_version}.".italic %>
 
-        <% incompatible_gems_by_state[:found_compatible].each do |gem| -%>
-        <%= gem_header(gem) %> - upgrade to <%= gem.latest_compatible_version.version %>
-        <% end -%>
+<% incompatible_gems_by_state[:found_compatible].each do |gem| -%>
+<%= gem_header(gem) %> - upgrade to <%= gem.latest_compatible_version.version %>
+<% end -%>
 
-        <% end -%>
-        <% if incompatible_gems_by_state[:incompatible] -%>
-        <%= "=> Incompatible with Rails #{rails_version} (with no new compatible versions):".white.bold %>
-        <%= "These gems will need to be removed or replaced before upgrading to Rails #{rails_version}.".italic %>
+<% end -%>
+<% if incompatible_gems_by_state[:incompatible] -%>
+<%= "=> Incompatible with Rails #{rails_version} (with no new compatible versions):".white.bold %>
+<%= "These gems will need to be removed or replaced before upgrading to Rails #{rails_version}.".italic %>
 
-        <% incompatible_gems_by_state[:incompatible].each do |gem| -%>
-        <%= gem_header(gem) %> - new version, <%= gem.latest_version.version %>, is not compatible with Rails #{rails_version}
-        <% end -%>
+<% incompatible_gems_by_state[:incompatible].each do |gem| -%>
+<%= gem_header(gem) %> - new version, <%= gem.latest_version.version %>, is not compatible with Rails #{rails_version}
+<% end -%>
 
-        <% end -%>
-        <% if incompatible_gems_by_state[:no_new_version] -%>
-        <%= "=> Incompatible with Rails #{rails_version} (with no new versions):".white.bold %>
-        <%= "These gems will need to be upgraded by us or removed before upgrading to Rails #{rails_version}.".italic %>
-        <%= "This list is likely to contain internal gems, like Cuddlefish.".italic %>
+<% end -%>
+<% if incompatible_gems_by_state[:no_new_version] -%>
+<%= "=> Incompatible with Rails #{rails_version} (with no new versions):".white.bold %>
+<%= "These gems will need to be upgraded by us or removed before upgrading to Rails #{rails_version}.".italic %>
+<%= "This list is likely to contain internal gems, like Cuddlefish.".italic %>
 
-        <% incompatible_gems_by_state[:no_new_version].each do |gem| -%>
-        <%= gem_header(gem) %> - new version not found
-        <% end -%>
+<% incompatible_gems_by_state[:no_new_version].each do |gem| -%>
+<%= gem_header(gem) %> - new version not found
+<% end -%>
 
-        <% end -%>
-        <%= incompatible_gems.length.to_s.red %> gems incompatible with Rails <%= rails_version %>
+<% end -%>
+<%= incompatible_gems.length.to_s.red %> gems incompatible with Rails <%= rails_version %>
       ERB
 
       puts ERB.new(template, nil, "-").result(binding)
@@ -104,15 +104,15 @@ module NextRails
       out_of_date_gems.each do |_gem|
         header = "#{_gem.name} #{_gem.version}"
 
-        puts <<~MESSAGE
-          #{header.bold.white}: released #{_gem.age} (latest version, #{_gem.latest_version.version}, released #{_gem.latest_version.age})
+        puts <<-MESSAGE
+#{header.bold.white}: released #{_gem.age} (latest version, #{_gem.latest_version.version}, released #{_gem.latest_version.age})
         MESSAGE
       end
 
       puts ""
-      puts <<~MESSAGE
-        #{"#{sourced_from_git.count}".yellow} gems are sourced from git
-        #{"#{out_of_date_gems.length}".red} of the #{gems.count} gems are out-of-date (#{percentage_out_of_date}%)
+      puts <<-MESSAGE
+#{"#{sourced_from_git.count}".yellow} gems are sourced from git
+#{"#{out_of_date_gems.length}".red} of the #{gems.count} gems are out-of-date (#{percentage_out_of_date}%)
       MESSAGE
     end
   end

data/lib/next_rails/gem_info.rb

@@ -88,15 +88,24 @@ module NextRails
       end
     end
 
-    def compatible_with_rails?(rails_version:)
+    def latest_version
+      latest_gem_specification = Gem.latest_spec_for(name)
+      return NullGemInfo.new unless latest_gem_specification
+
+      GemInfo.new(latest_gem_specification)
+    rescue
+      NullGemInfo.new
+    end
+
+    def compatible_with_rails?(rails_version: nil)
       unsatisfied_rails_dependencies(rails_version: rails_version).empty?
     end
 
-    def unsatisfied_rails_dependencies(rails_version:)
+    def unsatisfied_rails_dependencies(rails_version: nil)
       spec_compatible_with_rails?(specification: gem_specification, rails_version: rails_version)
     end
 
-    def find_latest_compatible(rails_version:)
+    def find_latest_compatible(rails_version: nil)
       dependency = Gem::Dependency.new(@name)
       fetcher = Gem::SpecFetcher.new
 
@@ -129,7 +138,7 @@ module NextRails
       end
     end
 
-    def spec_compatible_with_rails?(specification:, rails_version:)
+    def spec_compatible_with_rails?(specification: nil, rails_version: nil)
       rails_dependencies = specification.runtime_dependencies.select {|dependency| RAILS_GEMS.include?(dependency.name) }
 
       rails_dependencies.reject do |rails_dependency|

data/lib/next_rails/version.rb

@@ -1,3 +1,3 @@
 module NextRails
-  VERSION = "1.1.0"
+  VERSION = "1.2.1"
 end

data/next_rails.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.homepage     = "https://github.com/fastruby/next_rails"
   spec.license       = "MIT"
 
-  spec.required_ruby_version = ">= 2.3.0"
+  spec.required_ruby_version = ">= 2.0"
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
@@ -25,9 +25,10 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "colorize", ">= 0.8.1"
   spec.add_development_dependency "bundler", ">= 1.16", "< 3.0"
-  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "simplecov", "~> 0.17.1"
   spec.add_development_dependency "timecop", "~> 0.9.1"
-  spec.add_development_dependency "webmock"
+  spec.add_development_dependency "rexml", "3.1.7.3" # limited on purpose, new versions don't work with old rubies
+  spec.add_development_dependency "webmock", "3.16.2" # limited on purpose, new versions don't work with old rubies
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: next_rails
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Ernesto Tagwerker
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-06-30 00:00:00.000000000 Z
+date: 2022-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -49,16 +49,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,20 +101,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.1
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.1.7.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.1.7.3
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.16.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.16.2
 description: A set of handy tools to upgrade your Rails application and keep it up
   to date
 email:
@@ -140,6 +154,7 @@ files:
 - CHANGELOG.md
 - CODEOWNERS
 - CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -172,7 +187,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="