nexmo 0.1.1 → 0.2.0

data/lib/nexmo.rb

@@ -1,22 +1,24 @@
 require 'net/http'
 require 'net/https'
 require 'json'
-require 'cgi'
+require 'uri'
 
 module Nexmo
   class Client
     def initialize(key, secret)
       @key, @secret = key, secret
 
+      @headers = {'Content-Type' => 'application/x-www-form-urlencoded'}
+
       @http = Net::HTTP.new('rest.nexmo.com', 443)
 
       @http.use_ssl = true
     end
 
-    attr_accessor :key, :secret, :http
+    attr_accessor :key, :secret, :http, :headers
 
     def send_message(data)
-      response = post('/sms/json', data.merge(:username => @key, :password => @secret))
+      response = @http.post('/sms/json', encode(data), headers)
 
       object = JSON.parse(response.body)['messages'].first
 
@@ -31,16 +33,8 @@ module Nexmo
 
     private
 
-    def post(path, data)
-      @http.post(path, urlencode(data), {'Content-Type' => 'application/x-www-form-urlencoded'})
-    end
-
-    def urlencode(data)
-      data.map { |k, v| "#{urlescape(k)}=#{urlescape(v)}" }.join('&')
-    end
-
-    def urlescape(value)
-      CGI.escape(value.to_s)
+    def encode(data)
+      URI.encode_www_form data.merge(:username => @key, :password => @secret)
     end
   end
 

data/nexmo.gemspec

@@ -1,13 +1,14 @@
 Gem::Specification.new do |s|
   s.name = 'nexmo'
-  s.version = '0.1.1'
+  s.version = '0.2.0'
   s.platform = Gem::Platform::RUBY
   s.authors = ['Tim Craft']
   s.email = ['mail@timcraft.com']
   s.homepage = 'http://github.com/timcraft/nexmo'
   s.description = 'A simple wrapper for the Nexmo API'
   s.summary = 'See description'
-  s.files = Dir.glob('{lib,test}/**/*') + %w(README.txt nexmo.gemspec)
+  s.files = Dir.glob('{lib,spec}/**/*') + %w(README.txt nexmo.gemspec)
   s.add_dependency('json', ['~> 1.5.1'])
+  s.add_development_dependency('mocha')
   s.require_path = 'lib'
 end

data/spec/nexmo_spec.rb

@@ -0,0 +1,34 @@
+require 'minitest/autorun'
+require 'mocha'
+
+require_relative '../lib/nexmo'
+
+describe Nexmo::Client do
+  before do
+    @client = Nexmo::Client.new('key', 'secret')
+  end
+
+  it 'uses ssl by default' do
+    assert @client.http.use_ssl?
+  end
+
+  it 'allows access to headers' do
+    @client.headers.must_be_kind_of(Hash)
+  end
+
+  describe '#send_message' do
+    it 'makes the correct http call' do
+      http_response = stub(:body => '{"messages":[{"status":0,"message-id":"id"}]}')
+
+      data = 'from=ruby&to=number&text=Hey%21&username=key&password=secret'
+
+      headers = {'Content-Type' => 'application/x-www-form-urlencoded'}
+
+      @client.http.expects(:post).with('/sms/json', data, headers).returns(http_response)
+
+      response = @client.send_message({from: 'ruby', to: 'number', text: 'Hey!'})
+
+      assert response.success?
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nexmo
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-30 00:00:00.000000000 +01:00
-default_executable: 
+date: 2011-11-16 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &1011080 !ruby/object:Gem::Requirement
+  requirement: &2946070 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,7 +21,18 @@ dependencies:
         version: 1.5.1
   type: :runtime
   prerelease: false
-  version_requirements: *1011080
+  version_requirements: *2946070
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: &2945010 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2945010
 description: A simple wrapper for the Nexmo API
 email:
 - mail@timcraft.com
@@ -31,9 +41,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/nexmo.rb
+- spec/nexmo_spec.rb
 - README.txt
 - nexmo.gemspec
-has_rdoc: true
 homepage: http://github.com/timcraft/nexmo
 licenses: []
 post_install_message: 
@@ -54,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: See description